Commit graph

2626 commits

Author SHA1 Message Date
Sam Wilson 6175e2c519 Add nicer realtime preview error messages
Add a new ErrorLayout to display error messages along with an
image.

Bug: T303383
Change-Id: I1ec27a212b5ab67d3e805c0d7756432850de89ea
2022-03-24 14:56:19 +08:00
jenkins-bot 7f5f5aa658 Merge "Realtime Preview: wait for a response before making new requests" 2022-03-22 16:22:10 +00:00
Translation updater bot 6642fe9925 Localisation updates from https://translatewiki.net.
Change-Id: Id1074814fa4568dbe26969ff5036563b9e55d8e4
2022-03-22 08:30:29 +01:00
MusikAnimal 2cbf638f54 Realtime Preview: wait for a response before making new requests
If a preview is requested before one finishes, one final request is
fired off to ensure the preview is up-to-date.

Bug: T302282
Change-Id: I2399fc7cc08cd0987d2d689ca9f297db1ec5edf0
2022-03-21 21:17:26 -04:00
Translation updater bot 4b813cafa3 Localisation updates from https://translatewiki.net.
Change-Id: I99e729ef77c0e586ad56bd598ab3a303c2e43ff4
2022-03-21 08:15:42 +01:00
jenkins-bot f3a9dea20a Merge "Do not add toolbar when textbox is hidden" 2022-03-21 06:41:04 +00:00
Translation updater bot 48d9696e7d Localisation updates from https://translatewiki.net.
Change-Id: I48957edc9da4e05149e9e6edc50c624fcafe7267
2022-03-18 08:45:34 +01:00
Translation updater bot 458b17dec6 Localisation updates from https://translatewiki.net.
Change-Id: I7dde62e9ee5db7aded9afeecacfab32062de552c
2022-03-17 08:37:47 +01:00
jenkins-bot a65aaa0c6d Merge "Streamline smaller pieces of JavaScript code" 2022-03-16 20:52:38 +00:00
Translation updater bot d36f05a9ed Localisation updates from https://translatewiki.net.
Change-Id: I864345e8072818e4b525bcfce2a3d28e8dbda1cf
2022-03-16 08:08:23 +01:00
jenkins-bot b6ae231fd2 Merge "build: Update devDependencies" 2022-03-15 20:43:39 +00:00
Translation updater bot 4eb8589112 Localisation updates from https://translatewiki.net.
Change-Id: I4680f9e44776042d1e6a205d963d23c32ca293ed
2022-03-15 08:25:59 +01:00
jenkins-bot c0b0b33609 Merge "dialogInsertTable: empty preview-hidden row to hide header row when needed" 2022-03-15 06:57:15 +00:00
Pols12 eeaa229523 dialogInsertTable: empty preview-hidden row to hide header row when needed
In “Insert table” dialog, when checking/unchecking “Add header row”,
Example preview first row switches between preview-hidden and
preview-header. Previously, preview-hidden contained 3 TD cells
(while preview-header contains 3 TH cells).

This commit removes the 3 TD to hide the TH instead of replacing with
TD, since, in the generated wikitext, the header row is not included in
row count.

Bug: T303690
Change-Id: I38c1bb081a30e25875de8beaadccc075189ad397
2022-03-14 07:31:41 +00:00
Ed Sanders 930335fc0d build: Update devDependencies
Change-Id: Ibe0e5fb26ecbdf6dbf3792bbb5b53d92c88eaf20
2022-03-13 22:46:07 +00:00
Sam Wilson 411be83bc3 Add toggle button and two-pane layout for realtime preview
* Toolbar button to toggle a two-pane layout on and off.
* Resizable bar for the width of the two panes.
* Resizable bar for the edit box height, even when realtime preview is off.
* Only enabled when $wgWikiEditorRealtimePreview = true.
* Fires JS hooks when enabled, resized, and disabled.

Bug: T293347
Change-Id: Id09d44519249c0b7f5c33d48d524b7c92a5a9106
2022-03-13 07:28:01 +08:00
Translation updater bot 27020ae196 Localisation updates from https://translatewiki.net.
Change-Id: Ib8f60f24b9f6cc0ce850594a8622ea46b7e5687d
2022-03-09 08:10:21 +01:00
Ammarpad 6c90478689 Do not add toolbar when textbox is hidden
If the textbox is not visible, the toolbar cannot be used.

Bug: T303122
Change-Id: Ie676f3e588ba74b59c9586b05e7348ef57059b01
2022-03-08 06:10:23 +01:00
Translation updater bot ee950bc20f Localisation updates from https://translatewiki.net.
Change-Id: Ic14dd7937957b45be15d25f0babcc559bf4c04df
2022-03-07 08:12:00 +01:00
Reedy 07c823679c Use namespaced EventLogging class
Change-Id: Ia5a0ba6846ee1bd6a5436e003d65be955a06d565
2022-03-06 16:15:32 +00:00
jenkins-bot 5f13929858 Merge "Remove unused jquery.wikiEditor.html file" 2022-03-04 20:42:09 +00:00
jenkins-bot 03e541cb48 Merge "Remove unused messages and commented-out code" 2022-03-04 20:32:34 +00:00
Thiemo Kreuz dbb6583bbb Streamline smaller pieces of JavaScript code
The main idea is to make the code shorter and easier to read.

One notable change is to use .test() for boolean tests instead of the
actual .match() function.

Change-Id: Ic43442b75f839906b644d4586c907601f4d5d521
2022-03-04 09:22:07 +00:00
Translation updater bot 2982ffcaeb Localisation updates from https://translatewiki.net.
Change-Id: I23fed73d0f651133fe15e9bfc4c44bc0b7bd9c4b
2022-03-04 08:30:46 +01:00
Timo Tijhof 90e6ccaced Remove unused jquery.wikiEditor.html file
Has sat there since the first commit in 2010 (r73055), but not used.
I imagine it was was a design prototype at some point.

Also fix a few minor eslint warnings about line length, and remove the
one-off "ext-" prefix and capitilised "WikiEditor" CSS class name that
the rest of the repo doesn't use.

Change-Id: Id0eeb456fffdb490a6a86974288e57099e53ce71
2022-03-03 15:27:18 +00:00
Translation updater bot 06ceb65228 Localisation updates from https://translatewiki.net.
Change-Id: I312aacac818edb605b963388aed361f182edab86
2022-03-03 08:23:21 +01:00
Sam Wilson 2aa9e1d298 Remove unused messages and commented-out code
It looks like `wikieditor-loading` was already commented out in 2010:
9d278e8dee%5E!/#F114
and I couldn't find any usage of `wikieditor-toolbar-loading`.

Change-Id: I07988643ca502dcbd7c3208fb803a84003947d5e
2022-03-02 02:40:05 +00:00
Sam Wilson fff7cd6ba1 Allow tool.element to be a function
This adds support for the new 'element' tool type to be a function
which returns the HTML for the toolbar widget. It means that it's
possible for the element to access the WikiEditor context object.

Bug: T286759
Change-Id: I6af12075b96d480639f2fc0d97333a6142480c02
2022-03-02 10:08:54 +08:00
Translation updater bot fc768ba3c4 Localisation updates from https://translatewiki.net.
Change-Id: I3145cdbdd27282d98b48cac6d2d2519b70bbff1d
2022-02-28 14:29:46 +01:00
Translation updater bot 7f04dde774 Localisation updates from https://translatewiki.net.
Change-Id: I0a110ec3f01759acf8af96553fceb34f7900d87c
2022-02-25 09:46:27 +01:00
jenkins-bot 833a5f2c46 Merge "insertlink: Set url mode of title field when switching between modes automatically" 2022-02-25 05:35:22 +00:00
Translation updater bot d47fe43d16 Localisation updates from https://translatewiki.net.
Change-Id: I68902cd40cb95a9d363b47d81c34ab01b56d0b7b
2022-02-23 08:19:42 +01:00
Func fbecf46511 insertlink: Set url mode of title field when switching between modes automatically
Logic under LinkTypeField.setIsExternal() wouldn't emit events about
selection changes, at the mean time TitleInputField.setUrlMode() would
call setIsExternal() and handle everything correctly.
setTouched() is moved forward to actually prevent value being overwritten.

Bug: T302196
Bug: T302201
Change-Id: I5662556394a539073ebf0a17743a260a9d8b0c8c
2022-02-22 15:33:04 +00:00
Ed Sanders d1dc65cfd5 Remove unused deprecated module "jquery.throttle-debounce"
Change-Id: I76a43af8d67768622e6cc0e0d3a059027a5a232f
2022-02-22 01:08:45 +00:00
Translation updater bot b437863971 Localisation updates from https://translatewiki.net.
Change-Id: I8b249db50ae71ba2a6b2023727273d0e875a5091
2022-02-21 08:17:17 +01:00
Translation updater bot 3fa6f08409 Localisation updates from https://translatewiki.net.
Change-Id: If9fe790be7f6f5735fd85d5af9d07a59391a5103
2022-02-16 08:13:45 +01:00
jenkins-bot 90ac830640 Merge "Misnamed field on a/b test logging" 2022-02-12 20:36:53 +00:00
David Lynch 9c6dee2372 Misnamed field on a/b test logging
Bug: T301497
Change-Id: I9469ec8b6e745ae9181e5ffe21036f2de417680a
2022-02-11 19:58:16 -06:00
jenkins-bot 1418002309 Merge "Improve DiscussionTools a/b test bucket logging" 2022-02-12 01:38:32 +00:00
jenkins-bot 802dd69c50 Merge "Check for disabled button in click handler" 2022-02-11 22:26:43 +00:00
Sam Wilson 64d5613172 Check for disabled button in click handler
For some reason, even though jQuery UI dialogs know about their
own buttons, they don't know if the buttons are disabled. This
means that it's still possible to submit the dialog when a button
is disabled.

This change (which is mostly whitespace) adds a check in the click
handler to return early if the 'insert link' button is disabled.
It also gives this button a class name, and so simplifies the other
place that refers to the button.

Bug: T298596
Change-Id: I39fea13b1874f851a68cf08243b3e7ccd355d775
2022-02-11 22:53:13 +01:00
David Lynch 9c478c9290 Improve DiscussionTools a/b test bucket logging
Make sure it works on pages which don't trigger DT, such as full-page
wikitext editing.

Bug: T301497
Change-Id: I244381ee9e47bd3119e341cddb42e2ab38add4a8
2022-02-11 15:41:53 -06:00
jenkins-bot 4a1caf3390 Merge "Add 'element' type for toolbar tools" 2022-02-11 21:23:49 +00:00
Sam Wilson 5c9d867847 Remove out of date invalid link alert
The alert text is now added as a red message under the form field
for the link target text, and there's no need to have an additional
alert because the dialog's insert-link button can't be clicked
while there's an invalid internal link anyway.

Bug: T298596
Change-Id: Ib536b51baae24a6cfe7a7426d039fdf11c4cb150
2022-02-11 15:49:12 +08:00
Translation updater bot 8e05e5d8d0 Localisation updates from https://translatewiki.net.
Change-Id: I8d0af9dbc6d5f230e77c125afaeb9594370f1555
2022-02-09 08:13:21 +01:00
Translation updater bot 05eabda0f7 Localisation updates from https://translatewiki.net.
Change-Id: I4ab02239aec3dd1ee6dd4149aa79e22f2e5629a8
2022-02-08 08:29:11 +01:00
jenkins-bot 84f26ccfd2 Merge "Properly disable insert-link button" 2022-02-08 04:21:55 +00:00
Sam Wilson 2d58366710 Add 'element' type for toolbar tools
In addition to button, toggle, and select, add an element type of
tool which can be used to insert any HTML content.

Bug: T286759
Change-Id: Ia193308a076a7eaa010269ea0dd7b707c774561d
2022-02-08 10:33:54 +08:00
Ed Sanders 7fea791042 build: Update eslint-config-wikimedia to 0.21.0
Change-Id: I87bca80d107c965296af74e16961cd855d72b806
2022-02-07 17:27:27 +00:00
Translation updater bot 07f1703a5d Localisation updates from https://translatewiki.net.
Change-Id: Ibc3fbad894f18d0ea73a220951ff43374b38f10d
2022-02-07 08:23:12 +01:00