wikimedia/mediawiki-extensions-WikiEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/WikiEditor synced 2024-11-24 00:06:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Realtime Preview: wait for a response before making new requests"

Browse source
This commit is contained in:
jenkins-bot 2022-03-22 16:22:10 +00:00 committed by Gerrit Code Review
parent 6642fe9925 2cbf638f54
commit 7f5f5aa658
1 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
modules/realtimepreview/RealtimePreview.js
View file

@ -19,6 +19,9 @@ function RealtimePreview() {
.addClass( 'error' );
this.twoPaneLayout.getPane2().append( this.$previewNode, this.$errorNode );
this.eventNames = 'change.realtimepreview input.realtimepreview cut.realtimepreview paste.realtimepreview';
// Used to ensure we wait for a response before making new requests.
this.isPreviewing = false;
this.previewPending = false;
}
/**
@ -54,7 +57,6 @@ RealtimePreview.prototype.getToolbarButton = function ( context ) {
* Toggle the two-pane preview display.
*
* @private
* @param {Object} context The WikiEditor context object.
*/
RealtimePreview.prototype.toggle = function () {
var $uiText = this.context.$ui.find( '.wikiEditor-ui-text' );
@ -114,10 +116,19 @@ RealtimePreview.prototype.addPreviewListener = function ( $editor ) {
* @private
*/
RealtimePreview.prototype.doRealtimePreview = function () {
// Wait for a response before making any new requests.
if ( this.isPreviewing ) {
// Queue up one final preview once this one finishes.
this.previewPending = true;
return;
}
this.isPreviewing = true;
this.twoPaneLayout.getPane2().addClass( 'ext-WikiEditor-twopanes-loading' );
var loadingSelectors = this.pagePreview.getLoadingSelectors();
loadingSelectors.push( '.ext-WikiEditor-realtimepreview-preview' );
this.$errorNode.empty();
this.pagePreview.doPreview( {
$previewNode: this.$previewNode,
$spinnerNode: false,
@ -128,6 +139,12 @@ RealtimePreview.prototype.doRealtimePreview = function () {
this.$errorNode.append( $errorMsg );
}.bind( this ) ).always( function () {
this.twoPaneLayout.getPane2().removeClass( 'ext-WikiEditor-twopanes-loading' );
this.isPreviewing = false;
if ( this.previewPending ) {
this.previewPending = false;
this.doRealtimePreview();
}
}.bind( this ) );
};