Commit graph

7579 commits

Author SHA1 Message Date
Moriel Schottlender 963e133851 Remove media item styling moved to MW-core in I400336c12d.
Change-Id: I348e55ddea94f3b67f647c66ba53f7384d683584
2014-05-22 12:34:00 -07:00
Ed Sanders d10f27e80a Make MWGalleryInspector wider
Galleries usually have very long lines of text so make the
inspector big.

Change-Id: I69f294af9603a271b73ac1d39166fe4b492290f0
2014-05-22 18:52:27 +01:00
Ed Sanders bafad7ea1e Remove DesktopContext.css/js from core, leave in desktop
Change-Id: I6f5e5a01a9feba593567288f5237a773fa02453e
2014-05-22 18:23:52 +01:00
Matthew Flaschen a50e5c6fd6 Preserve veaction, vesection on special redirects to wiki pages
Bug: 50877
Change-Id: I61fcc9109105ea25f30f89ec18d8fa0d13dcde82
2014-05-22 13:05:23 -04:00
Krenair 060fcabe3b Detect that a category is hidden when following a redirect
At the moment, if you have a category on a page, and the category redirects
to another category which is hidden, VE does not mark it as hidden when
loading the page.

Change-Id: I9303838d36fbc1e2c0ed16b8bb0020bf52a6c211
2014-05-22 17:44:05 +01:00
jenkins-bot e288385569 Merge "Don't add |link= when converting block images to inline" 2014-05-22 00:44:23 +00:00
Juliusz Gonera 44db741a4b Hide unsupported UI elements in references on mobile
Also tweak styles for the supported ones slightly.

Change-Id: Ia4f0f3627d062698c085cd60f72928ef16532d20
2014-05-21 16:18:08 -07:00
James D. Forrester 1294791b40 Re-sync .docs/eg-iframe.html
Change-Id: I50d2bee652d2a1c2b61d34eefaf61817e4c60bce
2014-05-21 16:17:15 -07:00
Roan Kattouw c6fa82f0fb Don't add |link= when converting block images to inline
Change-Id: I71d996df4839bb507b970c55f97d5543665f4f81
2014-05-21 16:05:27 -07:00
Roan Kattouw 6c1c01c657 Update VE core submodule to master (b0a1e1a)
New changes:
36762de Localisation updates from https://translatewiki.net.
d040f9e Add SVG to image demo
c4523fb Always cover inserted content in SurfaceFragment#insertContent

Change-Id: Icef709a904255b2453d6a2f3ed081b1b12bdb042
2014-05-21 15:52:58 -07:00
jenkins-bot 1606452037 Merge "Update VE core submodule to master (fa14d31)" 2014-05-21 22:04:56 +00:00
Translation updater bot 2cbdf0df3b Localisation updates from https://translatewiki.net.
Change-Id: Ide809ebd18382b9459065ece4031c47ab5584c8d
2014-05-21 20:26:17 +00:00
James D. Forrester 7f0d6646dc Update VE core submodule to master (fa14d31)
New changes:
1bc3c99 Remove Firefox cursoring hack
5ebd89a Separate demo into mobile demo and desktop demo
3714877 Add test files to dependency tree
2aecf95 Localisation updates from https://translatewiki.net.
e750fb7 Update OOjs UI to v0.1.0-pre (d4086ff6e6)
363f2a1 Phantom optimisations
edfd5cb Localisation updates from https://translatewiki.net.
6fed173 Localisation updates from https://translatewiki.net.
0dd3402 Update OOjs UI to v0.1.0-pre (521a9e242b)
50ad883 Localisation updates from https://translatewiki.net.
501afaf Update OOjs UI to v0.1.0-pre (0fbf6bd14e)
cdaf6c1 Localisation updates from https://translatewiki.net.
682b4d0 Phantom optimisations, episode II
e1721a2 Move DesktopSurface and DesktopContext to visualEditor.desktop
857d463 Make $window a property of ce.Surface
fa14d31 Update OOjs UI to v0.1.0-pre (0436296667)

Change-Id: I13d7dd9289f273b938fdb070cec12ff998351265
2014-05-21 13:26:02 -07:00
jenkins-bot a66c3147cb Merge "Don't update image model twice" 2014-05-21 19:23:55 +00:00
James D. Forrester a8501778dd Switch from Parsoid extension's styles to MediaWiki core's
Using the new mediawiki.skinning.content.parsoid module instead of the clunky
ext.parsoid.styles (which added an unhelpful dependency).

Change-Id: I87e93777ece75ebf035df29490a80daf9fa7c45a
2014-05-21 12:19:07 -07:00
Moriel Schottlender d8040dbffc Don't update image model twice
The image model is updated through events from the edit dialog.
There is no need to update the states of the select/checkboxes
at the end in 'apply'. The only inputs that are not updated
on change are caption and alternate text.

Bug: 65564
Change-Id: I18c009546120e270467418cff677ec491fd109ca
2014-05-21 14:41:33 -04:00
cmcmahon 82dc0cbb99 [browser test] Dismiss new confirm dialog
Note: this is not a real confirm, it is an iframe with some
buttons that look like a standard confirmation but are not

Change-Id: I7854815542f05bec03ce950495dd675605916deb
2014-05-21 09:35:28 -07:00
Krenair 12d14b9e26 Allow extensions to add extra meta item checkboxes to the page settings dialog
Like this:

ve.ui.MWSettingsPage.static.addMetaCheckbox(
    'metaItemName', // e.g. 'mwDisambiguation'
    'checkboxLabel' // e.g. 'Disambiguation page'
);

Depending on 'ext.visualEditor.mwmeta'

Bug: 61073
Change-Id: I78dd68ff5aad20c7e66c4ce1528b6f1bbc74892d
2014-05-21 16:07:00 +00:00
jenkins-bot 8094a2f64c Merge "Unbind confirm dialog handlers after either of the events fires once" 2014-05-21 13:55:15 +00:00
Moriel Schottlender fad534ee4b Adjust newNode range and fallback in MWImageModel
When inserting a new node, get the proper fragment range and ask
for the node from within the search loop. Also added a fallback
for the case that the node wasn't found, and a caption cannot
be added.

Change-Id: Ic19d9b1cd2739435137f633de09a13b25a11a0cb
2014-05-21 05:56:37 +00:00
Moriel Schottlender 7d228673bb Fix MWImageModel's getImageNodeType()
* Fixing a typo in the getImageNodeType() method ('frame' was supposed
  to be 'frameless').
* Adding a check for type 'mwBlockImage' before editing/adding captions
* Using the node's getType() method instead of the model's where possible.
* Adjusting default alignment, so that when we check if it is set, it gives
  us the actual answer, which is always useful.

Bug: 65568
Change-Id: I1687d8c7430c723b52448a9e24641e2c30d85d6a
2014-05-21 00:01:02 -04:00
Roan Kattouw 293609e5d8 Unbind confirm dialog handlers after either of the events fires once
We weren't unbinding these handlers at all, and so the 'ok' or 'cancel'
handlers could run multiple times for one button click, and even worse,
you could get in a situation where clicking 'ok' in one confirm dialog
would also run the 'ok' handler for the other one. This happens because
the ConfirmDialog instance is recycled by the WindowSet.

The way the unbinding is done is ugly; we should either consolidate the
'ok' and 'cancel' events so we can use .once(), or come up with some other
way to automatically unbind the handlers.

Bug: 65557
Change-Id: Iabf0c0d0229add09cc775358fc5a4e5ae783db04
2014-05-20 19:11:45 -07:00
Translation updater bot 3871ba5a06 Localisation updates from https://translatewiki.net.
Change-Id: Ie610d0f236c9caf5863be9a8ef99b8848f6ac0b0
2014-05-20 19:05:32 +00:00
jenkins-bot 5798569c73 Merge "Image model and the media edit dialog" 2014-05-20 01:15:31 +00:00
Moriel Schottlender 37b3c07b26 Image model and the media edit dialog
Creating an MWImageModel that handles all image edit operations.
If the new attributes mean a change of image types from inline
to block or vice versa, the model will handle the creation and
insertion of the new node.

Change-Id: Ibe71bc8bd74e4ba5a024ac722432ccf0b8f65e71
2014-05-19 21:11:06 -04:00
jenkins-bot 8c95826338 Merge "Set flags for confirm dialog buttons for switching to source mode" 2014-05-19 21:56:38 +00:00
jenkins-bot 1d0e42a6ce Merge "Set flags for confirm dialog buttons" 2014-05-19 21:14:31 +00:00
jenkins-bot cd3264889c Merge "Use OOUI confirmation dialog rather than native confirm() for switching to source editing" 2014-05-19 20:50:31 +00:00
Roan Kattouw 96809998f2 Set flags for confirm dialog buttons for switching to source mode
"Yes, switch" isn't constructive; make it primary instead.
"No, cancel" isn't destructive; make it neutral (no flags) instead.

Change-Id: I841cbed4a81eaed679a8c7da89942c6b030a1217
2014-05-19 13:49:52 -07:00
Roan Kattouw 5b93980b68 Set flags for confirm dialog buttons
"Discard edits" isn't constructive, and "Continue editing" isn't destructive.
Instead, mark "Discard edits" as destructive, and make the continue
button neutral (no flags).

Change-Id: I7648555ad47be698e75b5019d7738b0afb8611aa
2014-05-19 13:46:36 -07:00
Translation updater bot c961ef503f Merge "Localisation updates from https://translatewiki.net." 2014-05-19 19:48:07 +00:00
Translation updater bot 91c62924e7 Localisation updates from https://translatewiki.net.
Change-Id: If053b4b94ad4a2e31fe6043c9d3df961ae762ecd
2014-05-19 19:47:31 +00:00
jenkins-bot fefd3a5d72 Merge "Whitelist Opera 15+" 2014-05-19 19:42:59 +00:00
Timo Tijhof 37087f1f5f MWTransclusionDialog: Remove setMode() call from teardown()
teardown() runs after the dialog has been hidden (if you need it
to be visible, use close() instead).

However removing it instead of moving because it is obsolete,
this is something that should be done from setup() instead, and
already is.

Bug: 65373
Change-Id: Ib6b4ab49f191d1d339e69934453786a82d97380f
2014-05-19 20:44:38 +02:00
jenkins-bot 7f7619a9e5 Merge "[browser test] use css for Template selector" 2014-05-19 18:25:09 +00:00
jenkins-bot 3689512e7d Merge "Update wikitext-warning to refer to 'Switch to source editing'" 2014-05-19 18:24:52 +00:00
jenkins-bot bec824f1dd Merge "Update beta warning to refer to 'Switch to source editing'" 2014-05-19 18:24:21 +00:00
cmcmahon 37e01c67b2 [browser test] use css for Template selector
Change-Id: I288c8bb8a27a6eebbd550c533837787759ef2674
2014-05-19 11:21:32 -07:00
jenkins-bot d0ea265784 Merge "Fix styling on save dialog" 2014-05-19 17:53:33 +00:00
jenkins-bot a8910ca542 Merge "Remove edit tab from the DOM if it's hidden" 2014-05-19 17:51:12 +00:00
jenkins-bot 76a379b6cd Merge "On file pages, only replace the (local) image description when saving" 2014-05-19 17:51:08 +00:00
Ed Sanders ddf88a5633 Fix styling on save dialog
Apply styles directly to textarea instead of wrapper div

Change-Id: Id2340cb81dd343266b8a57ae91057fa3015a47e0
2014-05-19 18:41:06 +01:00
Ed Sanders bd3b5ffc4f Initialise save panel on 'ready' so focus works
Bug: 65222
Change-Id: I18a0191a3013332621e44455ea59d5f8d683117e
2014-05-19 17:23:38 +01:00
Translation updater bot d36f22e620 Localisation updates from https://translatewiki.net.
Change-Id: Id0ff995087d24b865ba7a888aeb3e4cb2b696852
2014-05-18 20:08:44 +00:00
Translation updater bot 825749a52f Localisation updates from https://translatewiki.net.
Change-Id: Ia2f6952cd6b1c97f6aa9846bd993433031f2b49b
2014-05-17 19:57:15 +00:00
Krenair a5dd438725 Use OOUI confirmation dialog rather than native confirm() for switching to source editing
Per TTO on bug 51655, the implementation of confirm() in most browsers is crappy and we
shouldn't use it.

Change-Id: I755085a253c05958e4b50af57b19dab90f2f0fb6
2014-05-17 18:24:04 +01:00
Krenair eb7b727a53 On file pages, only replace the (local) image description when saving
Instead of overwriting everything else on the page (including the thumbnail!)

Bug: 65349
Change-Id: Ib6c4928646d6d278e29fbe31ae1902b0dc3b146a
2014-05-17 17:53:15 +01:00
Krenair e7787db92d Remove edit tab from the DOM if it's hidden
Fixed bug 64142, works around bug 65292

Bug: 64142
Bug: 65292
Change-Id: I31d8f7b149d657a678ed6ebc56b92305934f34bc
2014-05-17 00:56:38 +01:00
jenkins-bot 191fb5e1f1 Merge "Hide 'no results found' once there's at least one result" 2014-05-16 23:16:19 +00:00
Moriel Schottlender 3a9faa44fc Hide 'no results found' once there's at least one result
Naturally, the 'no results found' should only appear as long as there
are actually no results found.

Bug: 52463
Change-Id: I0116b769b9e4995678975d43a74c54c4d426f672
2014-05-16 18:35:41 -04:00