wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-29 00:30:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
11424 commits 13 branches 17 tags 198 MiB
Commit graph

4633 commits

Author SHA1 Message Date
Translation updater bot d036f04573 Localisation updates from https://translatewiki.net. 
Change-Id: I30e95352b17b75c8eb8dba54a4007238c28b1c63
 2016-03-17 23:23:48 +01:00
Ed Sanders b7d25d92bc Detect the type of plain pasted links 
Using the same logic we used for converting pasted URLs, detect
internal links by matching their base.

Currently link pasting is still disabled in the VE target, but
has been enabled elsewhere (Flow).

Change-Id: Iebd61abbe1fe82fd18d129e1dbc815ca75f44e87
 2016-03-17 19:30:13 +00:00
jenkins-bot d5ef085b3e Merge "Link pasting: Match RDFa-less links as external" 2016-03-17 17:45:52 +00:00
Ed Sanders 5e6cbc187c Link pasting: Match RDFa-less links as external 
Now that some targets support link pasting (Flow) we need to
make sure that pasted links match to an allowed type ('link/mwExternal')
instead of plain 'link' annotations which should never exist
in an MW document.

In a later commit we should auto-detect internal links.

Change-Id: I7faae834aa6e730c3cf93a691331a05fd0fe3d5c
 2016-03-17 17:18:41 +00:00
jenkins-bot 1c27e5d51a Merge "In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId" 2016-03-17 15:39:12 +00:00
jenkins-bot 33c9055fdc Merge "Reload page after user selects multi-tab option of SET dialog" 2016-03-17 15:39:09 +00:00
Alex Monk 3288d4e3f9 Show redirect target inside target 
Bug: T63861
Depends-On: I71d3d415fe918e8b0a090860cad9271092b1bd7e
Change-Id: I5a138b95e04773885ca9ee548026729805eb11f0
 2016-03-17 15:21:06 +00:00
Translation updater bot 445a830d52 Localisation updates from https://translatewiki.net. 
Change-Id: I2764438c78e674d492157f55fb15ae82ed114b36
 2016-03-15 23:06:07 +01:00
Ed Sanders dec9aa09e4 Use keyboard icon for keyboard help tool 
Change-Id: Id5e5097dfcdb5e3be2b21c89886857cb379997e6
 2016-03-15 17:28:48 +00:00
Alex Monk 02953f5d64 Suppress meta dialog on refresh pages if we want to show SET dialog 
Bug: T129819
Change-Id: I1176d06e5a5f56f01528acd7d099c8be9d317e51
 2016-03-15 08:10:46 +00:00
Translation updater bot af64cf7b12 Localisation updates from https://translatewiki.net. 
Change-Id: I85827c3e9262adf7bb6191ff68de688f744b613a
 2016-03-14 22:55:30 +01:00
jenkins-bot 53d3c62d46 Merge "CommandHelpDialog: Inherit non-corruptively" 2016-03-14 20:28:56 +00:00
Ed Sanders f5873ac1db CommandHelpDialog: Inherit non-corruptively 
Change-Id: Ieb497eebe930e58a02552eb9d4305280c91c92c2
 2016-03-14 20:03:52 +00:00
Ed Sanders 5d5d5419c6 AceEditorWidget: Use namespaced 'require' 
The un-namespaced version will soon be removed to fix RL issues.

Bug: T127643
Change-Id: Iaf4ed23d88cb955b8f8f61725f9effa6180de5bf
 2016-03-14 16:56:16 +00:00
Željko Filipin 63eb2a2f46 [BrowserTest] Increase the time Selenium waits for VisualEditor to load 
I have noticed that Jenkins job that runs daily fails sometimes because
looking up the element failed after 5 seconds. The time is increased
from 5 to 10 seconds.

Bug: T94150
Change-Id: Ib23f4ac72aa6c734f297e8f9fb5ad4645ac8891e
 2016-03-14 13:00:17 +01:00
jenkins-bot 110c6eb057 Merge "[BrowserTest] Disable failing language screenshot scenario" 2016-03-14 11:33:53 +00:00
jenkins-bot 0cdf4393ed Merge "Prefer error *code* when logging unknown errors" 2016-03-14 01:01:48 +00:00
jenkins-bot 3a1f6a34c8 Merge "Log readonly code for readonly errors" 2016-03-14 01:00:47 +00:00
Alex Monk 612e43dc08 Prefer error *code* when logging unknown errors 
See also I4a5bac24

Change-Id: I62fda9dadd24704f5930b30a2f8ad4d4a9e729cb
 2016-03-14 00:27:42 +00:00
Translation updater bot 004247822d Localisation updates from https://translatewiki.net. 
Change-Id: I18e35f520e9b8dde3c96e6b2c3b740d1fb48c294
 2016-03-13 22:57:53 +01:00
jenkins-bot 1a0733c4f2 Merge "MWSaveDialog: Fix vertical alignment" 2016-03-13 11:43:17 +00:00
Translation updater bot 368953b808 Localisation updates from https://translatewiki.net. 
Change-Id: I1c34348e0ce6227d6a3e84a969271563b0e8a6d5
 2016-03-12 21:14:25 +01:00
Alex Monk 22bf016a84 In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId 
There's probably more to this bug but I think we should still correct this

Bug: T125437
Change-Id: Ib32d1e69b2500578b5dc160c0c2d7481f5577ebb
 2016-03-12 04:46:54 +00:00
Translation updater bot 7c8a2207d3 Localisation updates from https://translatewiki.net. 
Change-Id: Ifefb57f56a762c7fcb5cab0258d018be0e7c10eb
 2016-03-11 22:18:35 +01:00
Ed Sanders da9aff2421 MWSaveDialog: Fix vertical alignment 
Change-Id: Ifb62375da6c872a3a4ef783e479a5476ca318b32
 2016-03-11 17:37:01 +00:00
Alex Monk d1d4839f8f Log readonly code for readonly errors 
I thought I did this yesterday

Change-Id: Icd2cf8fdf4263cab335a2ddfa53ab0585153dfb4
 2016-03-11 17:33:57 +00:00
Alex Monk 3807a918f9 Reload page after user selects multi-tab option of SET dialog 
Bug: T129510
Change-Id: I3fcac175f18d8159e6a5c4084668264d4705970c
 2016-03-11 05:39:29 +00:00
Translation updater bot 55a6cd08b2 Merge "Localisation updates from https://translatewiki.net." 2016-03-10 21:33:52 +00:00
Translation updater bot 3aac2043a4 Localisation updates from https://translatewiki.net. 
Change-Id: Ia3db1d0b33d4bdbde66452bcf33a7b0b0e4da5bb
 2016-03-10 22:31:26 +01:00
jenkins-bot d6ec1ed86f Merge "Fix logging of event_action.saveFailure.message for responseUnknown" 2016-03-10 21:22:37 +00:00
jenkins-bot ad7c364725 Merge "Better handling of read-only mode" 2016-03-10 21:22:34 +00:00
Alex Monk 0a6f6e1bbd Fix logging of event_action.saveFailure.message for responseUnknown 
Change-Id: Ic8d3066d8f6ccf8bc4a1001fd4d406b313915e82
 2016-03-10 21:03:25 +00:00
Alex Monk d2a9aefba7 Better handling of read-only mode 
* Don't just fail to load, action=visualeditor itself should not write to the DB
  (we have action=visualeditoredit for that)
* Send notice to the client in the usual way
* Handle read only errors on save, log as unknown

This won't let you review changes because that uses visualeditoredit

Bug: T129501
Change-Id: Id78c06b031423e47a7ddf94ec615b6d6975309d3
 2016-03-10 21:02:52 +00:00
jenkins-bot 3eaaf57847 Merge "Suppress welcome dialog this time if we're showing the SET pref dialog" 2016-03-10 20:38:39 +00:00
Alex Monk 4462f2539a Suppress welcome dialog this time if we're showing the SET pref dialog 
Bug: T129200
Change-Id: Iaa6d80df930cfcbd243efd31437cb8707da35c06
 2016-03-10 17:54:15 +00:00
Željko Filipin 43e9c8714f [BrowserTest] Disable failing language screenshot scenario 
VisualEditor_Insert_Menu scenario fails with `Original image height is
too small! (ChunkyPNG::OutOfBounds)`.

Bug: T119482
Change-Id: I30c3a9757c5754a40921fce5225b73897eed865b
 2016-03-10 15:06:56 +01:00
Translation updater bot d36a099939 Localisation updates from https://translatewiki.net. 
Change-Id: I32293b4f2532d15e65b71f09e53ac9c2e8817356
 2016-03-09 22:48:24 +01:00
jenkins-bot 2e89f4f658 Merge "[BrowserTest] Disable failing language screenshots" 2016-03-09 17:32:57 +00:00
jenkins-bot 67fb8dd07f Merge "[BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError" 2016-03-09 17:31:27 +00:00
Timo Tijhof cf1d7c0dab mw.DesktopArticleTarget: Fix "Uncaught: Cannot read done of undefined" 
Regression from 863a2c2974.

Sometimes when clicking "Switch to source mode" in the toolbar this
error is thrown and the interface freezes because setEditorPreference()
only returns a promise if the value is different.

> Uncaught TypeError: Cannot read property 'done' of undefined
> - ve.init.mw.DesktopArticleTarget.switchToWikitextEditor

Change-Id: Ie59f06a8ed9af9c4fb8199b013c06992d0c4f700
 2016-03-08 23:13:11 +00:00
Translation updater bot d8a9a11ca7 Localisation updates from https://translatewiki.net. 
Change-Id: Ia668efdeff27d984848c2bca823bf41d370706f9
 2016-03-08 22:46:51 +01:00
Ed Sanders d5e594b9f6 Link inspector: Remove premature call to onLinkTypeIndexSet 
This causes the inspector to take focus early (line 291) on
first load, and is not necessary as this method fires when
needed anyway.

Bug: T129228
Change-Id: Ia69f76b68e89daf5cb01449c40e71de4ec32d400
 2016-03-08 16:54:09 +00:00
jenkins-bot 7261cf5364 Merge "Link inspector: make height consistent" 2016-03-08 16:50:02 +00:00
Ed Sanders 7f31507e12 Link inspector: make height consistent 
Make the DOM order sensible so we don't have to
use SearchWidget's position:absolute hacks.

Bug: T129173
Change-Id: I3517e0e0cfe2ab0eee4bed7390e41710d3140eb0
 2016-03-08 10:26:31 +00:00
James D. Forrester 80139533ab i18n: Don't refer to the name of the tab in the beta notice given it changes 
Change-Id: I9beb322aeabece0df483271b33dbaa41f5da732a
 2016-03-07 16:58:32 -08:00
James D. Forrester b247ffd7bd i18n: Explain to returning users that their preferences are mutable 
Change-Id: I8a47725d7271af54b30f2130e97b08edec0f0b59
 2016-03-07 16:56:13 -08:00
James D. Forrester 9a6650ae1f i18n: Relabel the SET preference and dialog to 'mode' 
Change-Id: Id876f4ba102800237cbc4a671d4db9a26f7f116d
 2016-03-07 15:51:19 -08:00
jenkins-bot 8d7baccd5f Merge "DesktopArticleTarget: Add Edge and MSIE to whitelist" 2016-03-07 23:28:58 +00:00
jenkins-bot 7a5f34fac3 Merge "Education popup: Also handle clicks on dots" 2016-03-07 23:28:55 +00:00
jenkins-bot 39f3cfa4a7 Merge "Keep summary and checkbox selections when swtiching WTE->VE" 2016-03-07 23:17:08 +00:00
jenkins-bot 075f569e51 Merge "Update ArticleTarget for new API token handling" 2016-03-07 23:14:32 +00:00
jenkins-bot 6ed2d23b13 Merge "Don't give the user the option to discard changes when changing editor" 2016-03-07 23:14:29 +00:00
jenkins-bot 15f8efed70 Merge "DesktopArticleTarget.init#getLastEditor: Check values for validity" 2016-03-07 23:14:26 +00:00
James D. Forrester 79d1f92b42 DesktopArticleTarget: Add Edge and MSIE to whitelist 
Bug: T128447
Change-Id: Ia7afe4ddd5abd4fd1de85ba2d2df1fefa6735d79
 2016-03-07 14:58:10 -08:00
jenkins-bot 4d34f9ad75 Merge "Follow-up I65d96627: Remember the user's preference in WikiEditor too" 2016-03-07 22:31:54 +00:00
James D. Forrester d8eb68d7b6 Don't give the user the option to discard changes when changing editor 
Bug: T128585
Change-Id: I02f31e46ae7b2dc7505ed55fc56cd00f538a90e3
 2016-03-07 13:39:32 -08:00
Translation updater bot 98052e165d Localisation updates from https://translatewiki.net. 
Change-Id: I1e160b1149c6f0a5abb31ad51ba0a099de151a1f
 2016-03-07 22:27:34 +01:00
James D. Forrester b0407d840d Follow-up I65d96627: Remember the user's preference in WikiEditor too 
Oh dear.

Bug: T129130
Change-Id: I12481ded12f99ab1ba59dbd403c1eed038235fd9
 2016-03-07 13:03:35 -08:00
jenkins-bot 789979f223 Merge "Try to fix handling of empty document on WTE->VE switch" 2016-03-07 19:48:22 +00:00
James D. Forrester 302aeefd85 DesktopArticleTarget.init#getLastEditor: Check values for validity 
Change-Id: I23e0884a97b3689dd42c3df11a6311cd0601c348
 2016-03-07 11:27:23 -08:00
jenkins-bot fe19bfb0af Merge "Use iconWhenInvisible for alien extension nodes" 2016-03-07 18:34:38 +00:00
Ed Sanders bbf86a6768 Use iconWhenInvisible for alien extension nodes 
Change-Id: I0bc9bfd040685855402f705f46973e36c42dc0db
 2016-03-07 18:15:45 +00:00
jenkins-bot c930ac2779 Merge "Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry" 2016-03-07 16:32:13 +00:00
Translation updater bot 4dd9110c18 Localisation updates from https://translatewiki.net. 
Change-Id: I894adeef0ad09824fad0d3fff544ced1f7f3b1ae
 2016-03-06 22:18:45 +01:00
Ed Sanders 5cc10a810a Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry 
This allows extensions to register their own rules for detecting wikitext,
e.g. matching '<ref>'.

Bonus: Strip the autogenerated <references/> tag which
gets inserted when converting a <ref>.

Bug: T128805
Change-Id: I7a38db45d25e86ff3f3f6199aa04425ec98f7cc4
 2016-03-05 22:47:00 +00:00
Translation updater bot bcb8aed482 Localisation updates from https://translatewiki.net. 
Change-Id: Icffb9dc8b7f78d2debad38046ba42ea678b969ae
 2016-03-05 23:01:12 +01:00
Ricordisamoa 993015e03b Update ArticleTarget for new API token handling 
action=query&prop=info was being used because it can be combined
with action=query&meta=userinfo, while action=tokens cannot.

However, since MediaWiki 1.24 the 'intoken' parameter of
action=query&prop=info is deprecated, while the preferred way of
retrieving tokens is action=query&meta=tokens which not only can
be combined with action=query&meta=userinfo but also spares the
need of dealing with page ids.

Change-Id: I5ded3c303ede20514eeb2840715fe240b3b2c7e1
 2016-03-05 14:44:07 +01:00
jenkins-bot ea11c33e6d Merge "Handle API errors when refetching the edit token" 2016-03-05 02:16:32 +00:00
Roan Kattouw 6322be2e07 Handle API errors when refetching the edit token 
This can happen when the user gets logged out on a private wiki.
We get a badtoken error, so we try to refetch the token, which
itself returns an error. Token refetches didn't have error handling
at all and got the save dialog stuck in the pending state.

We can't offer the user to proceed with a different identity here,
because we encountered an error while trying to figure out what their
current identity is. The best we can do is encourage them to
log back in in a different tab.

Bug: T128934
Change-Id: I17d4452f688ec22631dbd12af223731635004d66
 2016-03-04 18:06:33 -08:00
jenkins-bot 074885d7cf Merge "Follow-up 2c24efae: fix typo in event name for unknown save errors" 2016-03-05 02:01:57 +00:00
Roan Kattouw 84d534997e Follow-up 2c24efae: fix typo in event name for unknown save errors 
This probably means we stopped logging unknown save errors
back in August.

Change-Id: I4a5bac244a469e73643e8a7d978d9212dd838fb0
 2016-03-04 17:31:40 -08:00
Translation updater bot 0d94d8312d Localisation updates from https://translatewiki.net. 
Change-Id: I92baebf577ce098877cff730f2ff8de4974f79b2
 2016-03-04 22:56:47 +01:00
Željko Filipin dc3944726a [BrowserTest] Disable failing language screenshots 
Bug: T119482
Change-Id: I165fcb2ee94430d29e287b80e13a48e05a021f77
 2016-03-04 15:54:13 +01:00
Alex Monk dde45949a3 Try to fix handling of empty document on WTE->VE switch 
Bug: T128635
Change-Id: Iff83e1d71e7186b8da875aa507f9e19e8d9c23ce
 2016-03-04 02:05:41 +00:00
Ed Sanders 67c207a6f5 Use abstract target widget creation 
Change-Id: Ic7e43e80f4f48df99842cee702963d54205e5055
Depends-On: I6a667a641540b347052ea0c645af4e1e59cf333a
 2016-03-03 11:49:44 -08:00
Ed Sanders d64436cc0c Use new surface executeCommand method 
Change-Id: I84c718d9da4b7dd0627ba37d9c29c3a25cc5d73e
Depends-On: Id975ea9da43654cd9991a302b49a9fb32782078e
 2016-03-03 11:49:44 -08:00
Ed Sanders 62d16e5a8a Update VE core submodule to master (ac24b50) 
New changes:
0b7e689 FindAndReplaceDialog: don't use tabindex
17b10a5 Localisation updates from https://translatewiki.net.
a4133e4 [BREAKING CHANGE] Make whitespaceHtmlCharacters a real static property

Local changes:
* MWEntityNode: Fix lookup of whitespaceHtmlCharacters

  Property is now in 'static', and use registry to look up
  TextNode by symbolic name.

Change-Id: Ied8c0c6feb69141c7c53fc4cc790774dee2cb63c
Depends-On: I7537b46a9fd58dfb2bd18dc4ed469aa221b96e86
 2016-03-03 08:13:33 -08:00
Ed Sanders 115bf4b3d2 CategoryWidget: Remove reorder event fix after upstream fix 
Change-Id: I9088c931433b0824f72b4c77d0fd05cb062068f7
Depends-On: I67945db3652b0edb24b490089b8ea5a43f0b29d0
 2016-03-03 15:53:49 +00:00
Željko Filipin 8e0e40d5cc [BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError 
Sauce Labs browsers raise
Selenium::WebDriver::Error::StaleElementReferenceError
if a test tries to use an element but VisualEditor is not loaded.

Bug: T128731
Change-Id: Icb01b4dee256a0270d722492d11dabf0cfc4f8c4
 2016-03-03 14:58:14 +00:00
jenkins-bot 659b9c3576 Merge "[BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages" 2016-03-02 23:33:32 +00:00
Translation updater bot 61cda9824f Localisation updates from https://translatewiki.net. 
Change-Id: Ife76752d154e4b595a570e8c8fefed114362dc9f
 2016-03-02 23:40:57 +01:00
Alex Monk a3f77d9479 Education popup: Also handle clicks on dots 
Bug: T128440
Change-Id: I25728cf3dd3462cb1a13476fe45d7fc3755429dd
 2016-03-02 21:48:05 +00:00
Alex Monk 4ed6fd4010 Change Accept header a bit 
Per post-merge commit on I77af4b58 by Subbu

Bug: T128233
Change-Id: I30c4c1ad5b68e5b8a006d7a6c7bcbaac7e2eb164
 2016-03-02 15:37:37 +00:00
Željko Filipin 301b152ec8 [BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages 
Looks like local browsers raise
Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs)
browsers raise Selenium::WebDriver::Error::UnknownError if a test tries
to use an element but VisualEditor is not loaded.

Bug: T126966
Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
 2016-03-02 13:50:44 +01:00
Alex Monk 21334a0fa8 Keep summary and checkbox selections when swtiching WTE->VE 
Bug: T128529
Change-Id: I8a7deac1c4d9390c1db7d78c3e0a11d927ef127b
 2016-03-02 11:55:50 +00:00
Ed Sanders d94d98ebfe ArticleTarget: Update documentation 
'onReady' no longer exists

Change-Id: I6fbcf619ba471f69380a64ba02994bd6ef0ca246
 2016-03-01 22:03:07 +00:00
jenkins-bot 7d1ddae652 Merge "MWTemplateSpecModel: Use namespace constant" 2016-03-01 21:56:51 +00:00
jenkins-bot 1619ca17aa Merge "MWTemplatePage: Don't assume template is the template namespace" 2016-03-01 21:51:19 +00:00
Ed Sanders 1e800f2fdf MWTemplateSpecModel: Use namespace constant 
Change-Id: I4404ee726550ca9aa9322720736f6f3778278df7
 2016-03-01 21:41:10 +00:00
Ed Sanders 5b17cbca67 MWTemplatePage: Don't assume template is the template namespace 
Content can be transcluded from any namespace using '{{:'.

Bug: T128333
Change-Id: Ifa076960958d1e72f302c5bfd5d896427a0e721f
 2016-03-01 13:40:38 -08:00
Translation updater bot eceb548e6c Localisation updates from https://translatewiki.net. 
Change-Id: Id1453f111870ee703f552fa407dab76b19d786f5
 2016-03-01 22:04:45 +01:00
jenkins-bot a0caedc6d9 Merge "API: Send Accept: header to RESTbase" 2016-03-01 03:24:45 +00:00
Alex Monk 2f135e9590 API: Send Accept: header to RESTbase 
Bug: T128233
Change-Id: I77af4b58e5469a898063a3f838802e4f5769514b
 2016-03-01 01:14:02 +00:00
Alex Monk d46c5e9f91 Fix WTE->VE switching in prefer-wt SET mode 
Bug: T128402
Change-Id: I56af672f2334214f048a4bbfe2f9fab891832792
 2016-02-29 23:46:11 +00:00
David Lynch 7486f74c6f MWMediaDialog: Only cache relevant information 
Trim the cached image data from the media dialog down so that it only caches
the same information that would have been fetched for a non-uploaded image.
Consistency!

Bug: T126081
Change-Id: I0f057c111b66f29c6360e27f97256384f5320b75
 2016-02-29 10:16:34 -06:00
jenkins-bot e39d8a744b Merge "Show welcome dialog on mobile too" 2016-02-29 03:02:03 +00:00
jenkins-bot 517bb92a79 Merge "Give a useful message in the temporary blank edit screen" 2016-02-29 02:56:12 +00:00
Translation updater bot 7546362fa9 Localisation updates from https://translatewiki.net. 
Change-Id: I7bade8021975fc1c3e2426211e6805a913f07891
 2016-02-28 22:00:32 +01:00
jenkins-bot 70a9cee5f3 Merge "Update VE core submodule to master (0371bbe)" 2016-02-28 01:12:55 +00:00
jenkins-bot 03448253b3 Merge "Revert "Compress PNGs with zopflipng"" 2016-02-28 00:29:30 +00:00