The bug is easiest to reproduce with `[[File:Example.jpg|link=]]`,
but it also affected video embeds.
jQuery appendTo() method returns the set of inserted elements.
Because `this.$element` is undefined at this point, the `<img>`
was not actually being inserted anywhere, and an empty set was
returned, causing MWInlineImageNode to have no CE rendering.
This was not an issue prior to c4f93b14, because `this.$element`
was being defined by the parent constructor (OO.ui.Element)
We don't actually want to insert it anywhere, this appendTo()
call was a remnant of wrapping code removed in a22aeafc.
Bug: T191406
Change-Id: If1dbf9fef0e0ac9debfdb3049ebcccac70948515
Wikis with a local link over-ride configured will need to do so here
for the new message `visualeditor-sourcefeedback-link`; wikis with a
remote link configured will need to update their configuration ahead
of this being deployed, setting $wgVisualEditorSourceFeedbackTitle.
Bug: T157953
Change-Id: Iea7ad8328b03f69e01d7c67ca1ddbb7ae7906288
New changes:
7892c2f7c Toggle table cell tooltip when editing
1e97ab57a Define parentNodeTypes for internal item node
9dbeb9d6e Update OOjs to v2.2.0
45e07f40c build: Provide oojs.noJQuery for server side users
a1efeddf7 ve.ce.Surface: Refuse to focus when disabled
Bug: T184636
Bug: T191115
Change-Id: I5ab158adb3d9aa43a0ed8b5c54ee3d5eebc252fc
New changes:
62e47b56c Remove icon padding from format tools in WMUI
22a79c1d5 Localisation updates from https://translatewiki.net.
81bbd2732 Follow-up I2be081c76: Fix drop bugs
Bug: T191103
Change-Id: Ia6d8a63c6aeb79c350cdb98b8f6a7836aff62609
These are not specific to desktop.
Also make the static builders static, and move VE target specific
code to caller, such as the click handler.
Change-Id: Ib7e769e3d6d339b9e66e1bc924480b0b0d5db17d
Also move the maintenane script to a name that makes
MediaWiki.Files.ClassMatchesFilename.NotMatch not error,
and use the more restrictive licence tag usage for
MediaWiki.Commenting.LicenseComment.InvalidLicenseTag.
Change-Id: Ifa5518cd590ae83c6fd76f1dbb5a2ce40de4b119
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.LicenseComment.InvalidLicenseTag
Change-Id: I9e8470d0a967fdab4b410aa999cc98d52fb780e8
New changes:
4922429f7 Merge all theme overrides into single files
Local changes:
* Update extension.json module definitions for 4922429f7
* Merge all VE-MW theme overrides into single files
Change-Id: Ie8bb4a78c3c50dd4e930f25f6f72bc2f395bd10c
It doesn't make sense to have a default action here, per Esanders.
Blocks I4a2505cfc8e86e73e46d40acffbf3cd8803458e2.
Change-Id: I02259a5117f3539593ccd09cfd4c8271e8464388
