Commit graph

19548 commits

Author SHA1 Message Date
Esther Akinloose 9de7c6743d selenium: Improve debugging
Looks like Selenium tests are flaky. To improve debugging:

- Move code from beforeEach hook to specs.
  (Video recording happens only in specs, not in hooks.)

- Increase logLevel from error to info.

Bug: T296187
Change-Id: Iffcfae9a76085670eb8858fbcf622e596a4ff2f0
2022-05-20 16:44:23 +02:00
Ed Sanders 726bbbdb05 Update VE core submodule to master (776219f4b)
New changes:
8030b7e93 Localisation updates from https://translatewiki.net.
fdf1a9201 ve.ce.Surface: Fix typos in documentation
776219f4b Follow-up Ic15dd21f: Fix typo width->height

Bug: T307527
Change-Id: I91149b7806124a3541550eaa7437ffdd9583fd7a
2022-05-20 12:02:28 +01:00
libraryupgrader 0166b79ecd build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 38.0.0 → 39.0.0
* php-parallel-lint/php-console-highlighter: 0.5.0 → 1.0.0
* php-parallel-lint/php-parallel-lint: 1.3.1 → 1.3.2

npm:
* grunt-eslint: 23.0.0 → 24.0.0
* meow: 3.7.0 → 3.7.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v
* trim-newlines: 1.0.0 → 1.0.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v

Change-Id: Id518b0dcafa3a6ce480c951c5ea7d0512aaa94a2
2022-05-20 10:06:25 +00:00
Translation updater bot 0d94b62daf Localisation updates from https://translatewiki.net.
Change-Id: If07d11654fd860de91f76b20fd1a33121713c320
2022-05-20 08:37:41 +02:00
Željko Filipin 098e217055 selenium: Use @wdio/spec-reporter
Bug: T280331
Change-Id: Iaa9f8be21c208963ebe3da2062075dc938404172
2022-05-19 15:29:41 +02:00
Ed Sanders 3e1c562898 Remove duplicate dependency on mwsave from mobileArticleTarget
The dependency on mwsave is in articletarget.

Change-Id: Ifb454978aa15974855b60095aeb76263bcb8c190
2022-05-19 14:18:14 +01:00
Andrew Kostka 46846d1b01 Improve collapsible descriptions for smaller screens
Bug: T307986
Change-Id: Iac6205fc90a884965c2e37cf6ed4b403874256d8
2022-05-19 12:39:20 +02:00
Andrew Kostka 0c176752eb Fix non-collapsible parameter descriptions on smaller screens
This patch fixes a bug which causes long parameter descriptions to
be to non-collapsible when adding them from the sidebar-only view on
smaller screens.

Change-Id: If373587a9b2c3841ad6814f74bfcbf0c0f013488
2022-05-19 12:26:30 +02:00
David Lynch b59625158d Update schema logging of bucket for new DiscussionTools A/B test
Bug: T304030
Depends-On: I5e57bb9b7958576f3a04373748331a86f4626fb5
Change-Id: I2ef4c64a55eebc0d2eeca7a57b84b8ba0ded1499
2022-05-19 01:20:33 -05:00
jenkins-bot 86136db386 Merge "Stop passing scrub_wikitext" 2022-05-18 23:41:41 +00:00
Translation updater bot ad76b58b8c Localisation updates from https://translatewiki.net.
Change-Id: Ia59a3041c5c0dfd092b0f6865d45174d59076fdf
2022-05-18 08:20:17 +02:00
Ed Sanders e9b29e7714 Messages: Remove 'visualeditor-donebutton-tooltip'
This was removed from the code a while ago when we switched
to a single toolbar on mobile.

Change-Id: Ic2a807bd8e17a692ad3a6974bbb3028fa1d2d434
2022-05-18 01:06:45 +01:00
Ed Sanders ffa2d2d9d2 Messages: Remove unused 'subject'
Introduced in I1002b9706, but in that same commit we created a
custom message that didn't include the ':' after 'Subject:'.

Change-Id: I28fa059821f740820875c084758d4aa7d1d23b03
2022-05-18 01:04:21 +01:00
Ed Sanders d8c4c54dc8 Messages: Upstream various messages to ArticleTarget module
This messages are used in ve.init.mw.ArticleTarget.js.

Change-Id: I7f694f5b15e86b3d91cce5b7e4534b2e8293361d
2022-05-18 01:03:37 +01:00
Arlo Breault d8aa99e35c Stop passing scrub_wikitext
It's no longer optional in Parsoid.

Bug: T297298
Change-Id: Ice36f4f4b82b0286799e9eedd164ca8d2dfc2b2e
2022-05-17 19:51:17 -04:00
James D. Forrester 377a6523ae Update VE core submodule to master (849c2e8de)
New changes:
152633e2c Localisation updates from https://translatewiki.net.
849c2e8de Update OOUI to v0.44.0

Change-Id: I790613101b2c13a1c04ebcf87a776df834d26b4a
2022-05-17 17:45:02 -04:00
jenkins-bot 37a5099471 Merge "Implement replacePageContent in MobileArticleTarget" 2022-05-17 21:22:50 +00:00
jenkins-bot fc8b909fb7 Merge "ArticleTarget: Always reload the page after save on non-view page" 2022-05-17 21:22:33 +00:00
jenkins-bot c6f45c5f73 Merge "selenium: Content Editable should save an edit" 2022-05-17 16:29:34 +00:00
Translation updater bot 5de8de3b37 Localisation updates from https://translatewiki.net.
Change-Id: I83b84edca3640a3116faed56482ef8bddeb4e89a
2022-05-17 08:29:17 +02:00
Željko Filipin e9ee23aace selenium: Content Editable should save an edit
Bug: T296187
Change-Id: I5a48662bb271fd49b6cfa0365e4775c8865dc5c7
2022-05-16 15:11:56 +01:00
Thiemo Kreuz aa989c00dd Extract MWExpandableContentElement.onButtonClick method
This is done in preparation for Iac6205f to make it easier to review.
This patch here is meant to be a no-op that doesn't change anything,
just moves existing code around.

Bug: T307986
Change-Id: Ie6ccd9528e5799ba340fed344e1f47a443c2c51f
2022-05-16 12:43:10 +02:00
Translation updater bot 7094857fab Localisation updates from https://translatewiki.net.
Change-Id: I921f0bf0cc5cfeb380459482ebda9de1c6631ebd
2022-05-16 08:25:38 +02:00
jenkins-bot fb7beaaa3a Merge "ApiParsoidTrait: Log trace as 'exception.trace' instead of 'trace'" 2022-05-15 22:28:59 +00:00
jenkins-bot 291d4d1374 Merge "Upstream teardown of saveDialog from DesktopArticleTarget to ArticleTarget" 2022-05-15 20:41:46 +00:00
jenkins-bot ace451bede Merge "Upstream isViewPage from DesktopArticleTarget to ArticleTarget" 2022-05-15 20:39:35 +00:00
Timo Tijhof 54d44ccb6c ApiParsoidTrait: Log trace as 'exception.trace' instead of 'trace'
This ensures proper redacting, and consistent discovery and formatting
for Logstash queries.

Bug: T233342
Change-Id: I9a2a96793a5b7669648d222a0d472c15c09b84d3
2022-05-15 20:21:34 +00:00
Bartosz Dziewoński aaef4584cc Update VE core submodule to master (f07b7e2cf)
New changes:
46eedcade Localisation updates from https://translatewiki.net.
86add3cf8 WindowManager: Simplify teardown
7f4bc9340 Ensure mobile context appears above toolbar on mobile

Bug: T308201
Bug: T308295
Change-Id: Ib3af733873f836db54c8eece864ae3bd04e8e657
2022-05-14 00:03:19 +02:00
Ed Sanders c877dc47fc Implement replacePageContent in MobileArticleTarget
Change-Id: I5b31bb9406bea15c5473363ba8fcda4c14f90994
Depends-On: Ifeb7c71e053501bc2c9448459c68895cb11368bd
Bug: T219420
2022-05-13 22:53:02 +01:00
Ed Sanders 37b81b5ba4 ArticleTarget: Always reload the page after save on non-view page
This is currently only handled in DesktopArticleTarget in teardown,
which happens after we've wasted time trying to update the page.

Also ensure we always reload on non-view pages on MobileArticleTarget
for other types of teardown (e.g. quitting the editor).

Change-Id: I7fb352fcacc8727bb113115e98af38a3940a8f9c
2022-05-13 22:53:02 +01:00
Ed Sanders ae58439c41 Upstream teardown of saveDialog from DesktopArticleTarget to ArticleTarget
Change-Id: I2e28f604d7e34fed15d9b74b6723347e3a17ce9e
2022-05-13 22:52:40 +01:00
Ed Sanders be2fc6c814 Upstream isViewPage from DesktopArticleTarget to ArticleTarget
Change-Id: Ic3839d9d70d6d4127fe2cd9bc01da799027fed3c
2022-05-13 22:47:06 +01:00
jenkins-bot e449d24344 Merge "Rephrase messages about changes that will be lost" 2022-05-13 16:16:11 +00:00
Translation updater bot 176634ba60 Localisation updates from https://translatewiki.net.
Change-Id: I68ffd16dd2380373dde7642cc363c178e416bd89
2022-05-13 08:27:06 +02:00
jenkins-bot c38ff0bcfc Merge "Hide the floating help button on small screens" 2022-05-12 10:26:07 +00:00
Translation updater bot 6b6b065e07 Localisation updates from https://translatewiki.net.
Change-Id: I19bf42f80434a71504b0401bfdda644efefc6fe5
2022-05-12 08:14:03 +02:00
Andrew Kostka dda7d8e9c1 Hide the floating help button on small screens
Bug: T307981
Change-Id: I7c1776f95f22e9c81b559f25ad97616d2f1a8dc2
2022-05-12 06:32:16 +02:00
jenkins-bot 5f311d3c83 Merge "Follow-up I420bfcac8: Fix typo in loop" 2022-05-11 23:38:50 +00:00
jenkins-bot 26f79fba9c Merge "Update VE core submodule to master (af608e441)" 2022-05-11 23:26:51 +00:00
Ed Sanders 6e647b4858 Follow-up I420bfcac8: Fix typo in loop
Bug: T298147
Change-Id: Ia725709e221994737f393791de914994dbf415dd
2022-05-12 00:20:54 +01:00
jenkins-bot 1ed40a266e Merge "Filter <script> tags during parse, instead of save" 2022-05-11 21:52:47 +00:00
Bartosz Dziewoński 4c90b310ea Update VE core submodule to master (af608e441)
New changes:
30aceee47 Use equivalent colours at 50% opacity for block level backgrounds

Bug: T307466
Change-Id: I262cfc1cb914f3e36b5d5723ce53f83f2b884b87
2022-05-11 23:28:16 +02:00
jenkins-bot 2861442874 Merge "[doc only] Update comment in ApiParsoidTrait which mentions renamed file" 2022-05-11 13:22:47 +00:00
jenkins-bot 2068c1b0fe Merge "Restore global context fiddling to fix FlaggedRevs edit notices and checkboxes" 2022-05-11 09:20:54 +00:00
Translation updater bot f8f72a5035 Localisation updates from https://translatewiki.net.
Change-Id: Ibfed79ef0d511a0edeecaf0885b5cd80805d16d3
2022-05-11 08:12:22 +02:00
C. Scott Ananian 26df6d45c2 [doc only] Update comment in ApiParsoidTrait which mentions renamed file
This file was moved in 3f0f302577
(July 2019).

Change-Id: I310f8ad171cb927b93f61d4a7677741c3cb8faf1
2022-05-10 20:31:24 -04:00
Bartosz Dziewoński 4ebf2ae8bf Restore global context fiddling to fix FlaggedRevs edit notices and checkboxes
Partially reverts aed5bcf7d0.

Bug: T307852
Change-Id: I6aee2266c6b4dce560196c87b518ac25a493623a
2022-05-11 00:08:41 +02:00
Ed Sanders 4dd590432e Filter <script> tags during parse, instead of save
This is a test to identify the soruce of stray <script> tags.

Bug: T298147
Change-Id: I420bfcac89528f3a11742214dd51fadd6281fd91
2022-05-10 17:31:22 +01:00
Amir E. Aharoni 66cfaa8ba4 Rephrase messages about changes that will be lost
Make the two related messages the same, and more
grammatically logical and clear.

Change-Id: I30752a28626945e6ca974a726cb10a1022a8c820
2022-05-10 15:56:40 +03:00
Thiemo Kreuz 53b169ab43 Update CSS to force word wrap in unused parameters button
Follow-up for what was done in I37505af. I don't fully understand why
these two extras are sometimes needed and sometimes not. But this exact
combination of 3 properties is used in multiple places already, so
let's just do the same here.

Bug: T300008
Change-Id: I1eba5fc378475d365111add58a141c3114dc0118
2022-05-10 10:20:44 +02:00