Commit graph

7820 commits

Author SHA1 Message Date
Trevor Parscal f30336bc2e Always initialize data before use
LinkNodeInspector was broken when you clicked away/pressed escape, because data was not set.

Normalizing on data being initialized at the top of get*Process methods if used.

Change-Id: I89728ac558545a6f2c325014b6f457ec6bef17b8
2014-07-15 15:49:51 -07:00
Translation updater bot b37a947f78 Localisation updates from https://translatewiki.net.
Change-Id: Ie46b8801476574031135d86cfda2d75e811111be
2014-07-15 22:08:39 +02:00
jenkins-bot 5a367aec52 Merge "Simplify visualeditor-help-title and visualeditor-timeout" 2014-07-15 18:31:31 +00:00
jenkins-bot 74786a31cb Merge "[BrowserTest] Added support for page elements in iframe" 2014-07-15 13:30:43 +00:00
vikassy e3ecff4dcb [BrowserTest] Added support for page elements in iframe
Bug: 62737
Change-Id: Id60c7268dd6e3e4e755bdc53fef7e7d714d4ab0b
2014-07-15 13:26:09 +00:00
Trevor Parscal 8ebea5a75b Close the citation dialog after the apply changes button is clicked
Change-Id: If3976389f0a1574fce993f5b79b9b18067a88878
2014-07-14 17:09:24 -07:00
Federico Leva 760fc0e6ca Simplify visualeditor-help-title and visualeditor-timeout
The less repetition and the less undefined concepts where possible,
the more clarity. Suggestions thanks to James' explanations at
* https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Visualeditor-timeout/en
* https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Visualeditor-help-title/en

Change-Id: I05857e5287f5f15f0206a8faa46922e7aa7c3c1b
2014-07-15 00:00:59 +00:00
James D. Forrester fbdff76263 Update VE core submodule to master (f2277ea)
New changes:
56de6f5 Localisation updates from https://translatewiki.net.
f8bda64 Widgetise demo menu
6ac48d8 Localisation updates from https://translatewiki.net.
365e131 builderloader: Omit value for boolean "disabled" attribute per HTML5
706e4b3 Prevent double counting of DM nodes in getNodeAndOffset
b141a7d Update OOjs UI to v0.1.0-pre (d2451ac748)
c5b3921 Localisation updates from https://translatewiki.net.
1606983 Update reference to ConfirmationDialog to use MessageDialog

Deletions:
* Styles for ve.ui.MWBetaWelcomeDialog - not needed anymore because
  OO.ui.MessageDialog provides them
* Styles for ve.ui.MWGalleryInspector - not needed anymore because
  ve.ui.MWExtensionInspector provides part of them and the rest are being
  replaced by programatic sizing

Modifications:
* ve.ui.MWLinkTargetInputWidget - Added support for validation and href
  getter
* Split message between tool and dialog title for ve.ui.MWEditModeTool
  and ve.ui.MWWikitextSwitchConfirmDialog

General changes:
* Updated inheritance.
* Added manager param to constructors of dialogs and inspectors.
* Updated use of show/hide with toggle.
* Added meaningful descriptions of dialog and inspector classes.
* Configured dialog and inspector sizes statically.
* Configured dialog action buttons statically.
* Interfaced with OO.ui.ActionSet to control action buttons.
* Moved applyChanges code into getActionProcess methods.
* Always using .next in setup/ready process getters and .first in
  hold/teardown process getters.

Change-Id: Ia74732e6e32c0808eee021f0a26225b9e6c3f971
2014-07-14 23:24:45 +00:00
Translation updater bot 73beda2c10 Localisation updates from https://translatewiki.net.
Change-Id: I1f6a557082525ae68b261079a3b7a890be0e26b2
2014-07-14 22:03:53 +02:00
jenkins-bot 5e5e3680df Merge "[BrowserTest] Fixed language screenshot upload script" 2014-07-14 10:00:32 +00:00
vikassy 7ca18bacb2 [BrowserTest] Fixed language screenshot upload script
Bug: 62737
Change-Id: I7be433f711b422c156da863dbcbd30e089cc67c7
2014-07-14 11:58:07 +02:00
jenkins-bot 1ea89677ef Merge "Remove ext.visualEditor.editPageInit alias" 2014-07-13 21:06:27 +00:00
Translation updater bot 1ed589eccd Localisation updates from https://translatewiki.net.
Change-Id: I106d07e16120881cafcd59a0c3cbcd30d44a0e96
2014-07-13 22:25:27 +02:00
Bartosz Dziewoński 7656398e79 Remove ext.visualEditor.editPageInit alias
Created in 2012… (9a0380c6)

Change-Id: Ie302e9e0c22aea37de62e3037738320c6b82e36b
2014-07-13 14:37:16 +02:00
Translation updater bot ba3ccd46f8 Localisation updates from https://translatewiki.net.
Change-Id: Ia0436f75950d914826f2bb14b82b4a2e6a8a2d6d
2014-07-12 23:25:05 +02:00
Translation updater bot 9524a58bea Localisation updates from https://translatewiki.net.
Change-Id: I33438e5fb2f431d5d48f2ee78efdb55819db57da
2014-07-11 21:58:18 +02:00
jenkins-bot 8b25cb9717 Merge "generateContents -> generatedContents" 2014-07-10 21:58:42 +00:00
Ed Sanders b1fb9c1b82 generateContents -> generatedContents
Change-Id: Idfe609d0830ba2b29901211f56dd355ddf8ab96e
2014-07-10 22:47:48 +01:00
Alex Monk 3acca7cdf5 Fix cite/template dialogs
I1a7fc7f2 broke cite/template dialog - onDescriptionClick is not defined.
I can't find it anywhere in the VE-MW or OOUI source.
Before my change, it was simply a no-op. But now we try to bind it in a way
that breaks everything. This commit just removes that line since it was
apparently not doing anything.

Bug: 67814
Change-Id: I0b9c3318b3de8530e0ba9e355cd73eb7f70a6b5a
2014-07-10 21:37:07 +01:00
Amir E. Aharoni 8e3b544479 [BrowserTest] Rename *langauge* to *language*
Change-Id: I29886571ae9a0a81f977e75a4c1ae4f4ec69dc7b
2014-07-10 15:15:41 +00:00
jenkins-bot 6d8e900d57 Merge "Replace ve.bind( fn, ... ) calls with fn.bind( ... )" 2014-07-10 14:11:43 +00:00
Alex Monk 5054ee94f8 mw.ViewPageTarget: Remove vesection from URL on save/cancel
Bug: 66237
Change-Id: I1cc34176322cb768d1cb9711407ecdf91b3ca767
2014-07-10 14:02:44 +00:00
jenkins-bot f3d183ddfa Merge "MWTemplatePage: Account for template.title being null" 2014-07-10 13:59:01 +00:00
Alex Monk 51142e8b11 Replace ve.bind( fn, ... ) calls with fn.bind( ... )
Bug: 62762
Change-Id: I1a7fc7f27fa737d17f5c6b3d084ef4a35e4bebc0
2014-07-10 13:54:07 +00:00
Timo Tijhof fd83cafa4b MWTemplatePage: Account for template.title being null
Example:
* Transclusion with html comment in target
  {{ Unsigned <!-- ignored -->  |Example}}.
* Transclusion with wikitext expression as target
  {{ {{echo|Unsigned}} <!-- ignored -->  |Example}}.

The first case was handled already (Parsoid strips the comment
when it normalises the target title). The second case, however,
is not handled and ends in template.title being null.

This was already documented (MWTemplateModel#getTitle returns
{string|null}), but not used correctly.

The title of the dialog is unaffected as it fallsback to
displaying target.wt instead of target.title.

Bug: 66724
Change-Id: Ib6696ac3538f6cb9e93da2f6f8666f373247eeb4
2014-07-10 13:49:41 +00:00
Amir E. Aharoni c970f03b1a [BrowserTest] Add screenshots to .gitignore
It's a directory that is created by the language screenshots scenarios.

Change-Id: Iae7dad5836f0abf22bf7f5f947268295aadddfbd
2014-07-10 13:45:50 +00:00
Translation updater bot 9e26fdf0f7 Localisation updates from https://translatewiki.net.
Change-Id: I06a869c905e84dcd41877a370dd98b0f7ca7843c
2014-07-09 20:37:22 +00:00
jenkins-bot 70d0e1487d Merge "Rephrase visualeditor-parameter-search-more" 2014-07-09 16:58:53 +00:00
Amir E. Aharoni 566a5deddf Rephrase visualeditor-parameter-search-more
"More" is usually used in such context and not "other".

Change-Id: I21f70961761e22bef8dce9f58a2f3b0f88c84b28
2014-07-09 09:49:48 -07:00
jenkins-bot b15f090675 Merge "[BrowserTest] Added support for uploading the language screenshots" 2014-07-09 08:58:03 +00:00
vikassy c41b631348 [BrowserTest] Added support for uploading the language screenshots
To use this script:

*Create an environment variable MEDIAWIKI_API_UPLOAD_URL having API URL
of the site where the images are to be uploaded. (Eg: http://commons.wikimedia.beta.wmflabs.org/wiki/api.php)

*LANGUAGE_SCREENSHOT_CODE environment variable should be set.

Run the upload script by: bundle exec ruby upload.rb

Bug: 62737
Change-Id: I1937aa5f02e3bf587ac65d8d11c3ebbb8b1d0528
2014-07-09 14:22:11 +05:30
Translation updater bot 95fe019286 Localisation updates from https://translatewiki.net.
Change-Id: I816d64f9f3d8aee0beb65387c12381f246744c17
2014-07-08 21:03:07 +00:00
James D. Forrester 9b275ae066 Update VE core submodule to master (7af9774)
New changes:
b3e4c35 Localisation updates from https://translatewiki.net.
e0708f2 Show from/to of range in debug bar
a132724 Localisation updates from https://translatewiki.net.
d80b127 Localisation updates from https://translatewiki.net.
c81a3f3 Localisation updates from https://translatewiki.net.
7f90e0b Apply 'original size' to images

Change-Id: I14b7fc9c1b61b8a30e57eb366b06d1032b12d00a
2014-07-08 10:59:08 -07:00
Moriel Schottlender c2c046620b Apply 'original size' to images and enable apply button in ve-MW
Depends on core change I243cff5a2d56db48882c343a8bb91153edd96a43

Bug: 66863
Change-Id: If7914c254b70f4b2b9e2788f5755550eb020b21c
2014-07-08 13:11:07 -04:00
Translation updater bot f30c4d6e8d Localisation updates from https://translatewiki.net.
Change-Id: I3e9a17ff64db4c67ce7de914aedb7933c7a04bf6
2014-07-07 20:22:35 +00:00
jenkins-bot b65d6f5e85 Merge "Clearer test message, as used in core" 2014-07-07 16:48:06 +00:00
Željko Filipin cc6176e57d [BrowserTest] Change interface language with environment variable
Paired with: Vikas Yaligar
Bug: 62737

Change-Id: I3ba97a8b4ab5c881b9fb9bbc24411b6c371320e5
2014-07-07 11:04:37 +02:00
Translation updater bot 1aa6ca1dc2 Localisation updates from https://translatewiki.net.
Change-Id: Ia9ec82e0eb5d0d6fe29fa3e90a7696512286782c
2014-07-06 19:56:16 +00:00
Ed Sanders 33406b663c Clearer test message, as used in core
Change-Id: I9cae998c3a492a5ba4ae8e70d65b2f6ed0438f13
2014-07-05 21:56:21 +01:00
Translation updater bot baa6361984 Localisation updates from https://translatewiki.net.
Change-Id: I4f8ffeb4c5ee49a3f1687ad84401d7ddc2aac7cc
2014-07-05 19:57:38 +00:00
Translation updater bot 1384bf592f Localisation updates from https://translatewiki.net.
Change-Id: Ia0fb273d0ae1b4ae8d22abd72a77e9b5544c80bc
2014-07-04 21:34:36 +00:00
Željko Filipin 6953938b0f [BrowserTest] Language Screenshot feature needs site specific tag
Fixing failed Jenkins job

bundle exec cucumber … --tags @en.wikipedia.beta.wmflabs.org --tags
@firefox --tags @language_screenshot
…
0 scenarios
0 steps
0m0.000s
…

https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-langu
age-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=en,label=con
tintLabsSlave/1/console

Bug: 62737
Change-Id: I2da00dfae29fa6d51c45864caea42d39ec60983d
2014-07-04 16:59:32 +02:00
Roan Kattouw a0989d15d4 Add stylesheet with IE hacks and only load it with IE
The stylesheet contains workarounds for highlights on references
being drawn in the wrong place, resize handles appearing on headings,
and highlights being opaque.

Change-Id: I78da4d6a751429cd160b693b4a524fc7ea1ef76f
2014-07-03 18:20:30 -07:00
Roan Kattouw b86d481871 Update VE core submodule to master (a887989)
Also implement isInternetExplorer() in mw.Platform using jquery.client.

New changes:
9b2102f Skip over nested handlesOwnChildren nodes in getRelativeOffset
30a9835 Localisation updates from https://translatewiki.net.
5d142a0 Restrict get relative offset to movements of +/-1
7a2c984 Check that the surface has a selection after focus
851a63d Remove jquery.client
8786e53 Add evil detection functionality for IE
96f19ad Disable triple-click handling in IE
d746d42 Revert "Restrict get relative offset to movements of +/-1"
859d578 Revert "Skip over nested handlesOwnChildren nodes in getRelativeOffset"

Change-Id: Ib2e6568a862336e2516e4c519468218ec2a84834
2014-07-03 17:59:37 -07:00
Timo Tijhof f3cd6899a5 ve.ce.MWReferenceListNode: Add class 'references'
The code previously appeared to add 'reference' (no "s"), but was
failing to do so due to passing variadic arguments to a method
that only takes one arguments (jQuery#addClass).

See also Ifae04e48.

Change-Id: Id59673c8033c82e51577f681221dbfd312da7b8d
2014-07-04 01:29:39 +02:00
jenkins-bot ff7f4e8244 Merge "Use addClass() correctly, otherwise references don't get the 'reference' class" 2014-07-03 22:32:31 +00:00
Roan Kattouw 90162a343d Use addClass() correctly, otherwise references don't get the 'reference' class
Change-Id: Ifae04e480f3e92725e15cae53119b0935e83b72a
2014-07-03 15:29:08 -07:00
jenkins-bot 14d2857a3a Merge "Revert "[BrowserTest] change search criteria for beta labs issue"" 2014-07-03 20:55:44 +00:00
Cmcmahon deae821543 Revert "[BrowserTest] change search criteria for beta labs issue"
This reverts commit 4f7b4170e2.

Search problem was fixed

Change-Id: I2d52aa73ddfb9315acf4d5529f5f276bac46264e
2014-07-03 20:53:36 +00:00
Translation updater bot 19f6155bbc Localisation updates from https://translatewiki.net.
Change-Id: I176cde069df648d92741720ac0ae07eef8ed135d
2014-07-03 19:23:54 +00:00