Commit graph

123 commits

Author SHA1 Message Date
David Lynch 709e791acd Edit check: let ecenable bypass the account age requirement
Clean up accountShouldSeeEditCheck since nothing is calling it but the
new method inside BaseEditCheck

Follow-up to e947e53f98

Change-Id: Ic55187bb77f5ef003369313b76a65897fb3be392
2024-09-09 10:52:50 -05:00
jenkins-bot b19679e381 Merge "Edit check: stop from appearing outside the main namespace" 2024-09-09 13:29:48 +00:00
David Lynch e947e53f98 Edit check: stop from appearing outside the main namespace
This was accidentally removed in d69d366469 during its refactor.

Because of the change to how checks are decided to be shown, I've made
AddReferenceEditCheck always be required -- later code in
hasAddedContentNeedingReference assumes that it's loaded anyway, so a
wiki deciding to configure it to not load at all for some account types
would have broken saving.

Bug: T373692
Change-Id: I007cd705451581ebacfa12e8ac5502bd1bc56a38
2024-09-04 10:33:22 -05:00
Translation updater bot d29293e043
Localisation updates from https://translatewiki.net.
Change-Id: I2417fa6f554a48aeadc0164ea856a15257d1c8e6
2024-09-02 09:21:51 +02:00
Translation updater bot dedd30bfef
Localisation updates from https://translatewiki.net.
Change-Id: I103ce5ad2adc11b48a2d7ed8ea72e4e892dc6b9f
2024-08-30 09:20:39 +02:00
Translation updater bot 471e84a0d9
Localisation updates from https://translatewiki.net.
Change-Id: Ic7ad4140ac4eeded1de5331ad1d57f17b2cd11ca
2024-08-28 09:41:04 +02:00
Translation updater bot d9c7c05e32
Localisation updates from https://translatewiki.net.
Change-Id: I5eeb703911cd5914a71d9241be0eb97ebbd4df5c
2024-08-26 09:23:43 +02:00
David Lynch 16c2dd919b Edit check: center the text in the proofreading toolbar
Bug: T341308
Change-Id: I5e12cefe690c2b9fba7cd7998a11723931575465
2024-08-22 01:23:27 -05:00
Translation updater bot 762a5c0ff9
Localisation updates from https://translatewiki.net.
Change-Id: I71885816cfe342b8cba5b6e5d443dbee1f12a859
2024-08-19 09:25:55 +02:00
Translation updater bot fd15b8b6de
Localisation updates from https://translatewiki.net.
Change-Id: I7c303550e44dd07c1cca634d5f1f8d7f252bff77
2024-08-15 09:21:17 +02:00
Translation updater bot ca1586a6ed
Localisation updates from https://translatewiki.net.
Change-Id: Ic93b15e04deb2e2795d6163d62be4fca9d721522
2024-08-12 09:23:31 +02:00
Translation updater bot 459a6e2605
Localisation updates from https://translatewiki.net.
Change-Id: Ie74c95168186a14433fd1c38f5eabe1dbce6366e
2024-08-09 09:37:31 +02:00
David Lynch 65b695ea2f Edit check: another counter for the save process
preSaveChecksShown + preSaveChecksNotShown = preSaveChecksAvailable
allowing us to use simple stat counters to detect errors in check
generation.

Follow-up to 57daf35bd6

Change-Id: I0586b766b5beec3bd059c90875ad0e2d1f092fab
2024-08-07 21:01:17 -05:00
Translation updater bot f0f1623051
Localisation updates from https://translatewiki.net.
Change-Id: I651b9daca7ca198b3cf4606692438787ab357ad3
2024-08-05 09:26:07 +02:00
David Lynch 57daf35bd6 Edit check: some simple counters for steps in the process
Change-Id: Iac0faea1f06eb30ac075a702cdcaaec29e0fbaf0
2024-08-01 11:21:46 -05:00
Translation updater bot 83e951d33a
Localisation updates from https://translatewiki.net.
Change-Id: Ia6dc068e460bb43a200a7b8f28affde76788637e
2024-07-15 09:25:24 +02:00
Translation updater bot c4828126e6
Localisation updates from https://translatewiki.net.
Change-Id: I12d6f99bfa9111dd73dcb4019abd5b392fef0196
2024-07-03 09:27:43 +02:00
jenkins-bot fd7194be26 Merge "EditCheckInspector: initially disable the continue action on mobile" 2024-07-01 18:17:45 +00:00
Translation updater bot b34e7949f9
Localisation updates from https://translatewiki.net.
Change-Id: I93077216310f9a99b4a9c31bb6189a6bcc62b37b
2024-07-01 09:26:47 +02:00
Translation updater bot 265eede395
Localisation updates from https://translatewiki.net.
Change-Id: I8e9f5b429f152847eb28bf268504d54582fd0268
2024-06-28 09:43:42 +02:00
David Lynch 58e82f36aa EditCheckInspector: initially disable the continue action on mobile
This would cause an error if the continue action was chosen before
selecting an item in the list.

Change-Id: Ic1eb66caff112c09bb60b31a7221c48e2962b3d8
2024-06-27 23:24:10 -05:00
Translation updater bot 59e1a2fedb
Localisation updates from https://translatewiki.net.
Change-Id: Icc3f3ae8161cb6c8a2c4af353bc6a165b1618c8b
2024-06-27 09:22:18 +02:00
Translation updater bot f1601effc2
Localisation updates from https://translatewiki.net.
Change-Id: I5e96c5e8fc3aa96e39bf2f73303c2e8125eec690
2024-06-26 09:22:34 +02:00
Translation updater bot 87af9c72e0
Localisation updates from https://translatewiki.net.
Change-Id: I459fcd6b2b525b87b74af1d3ba534262a580b8dc
2024-06-24 09:26:21 +02:00
Translation updater bot 22fedfb771
Localisation updates from https://translatewiki.net.
Change-Id: I7c423e6468289083f7580540130ccebb13dff5fe
2024-06-21 09:43:29 +02:00
Translation updater bot 31c8b3a722
Localisation updates from https://translatewiki.net.
Change-Id: I7230bb88bda762241e34a33ec24ae4b0dacbf3fa
2024-06-20 09:25:17 +02:00
Translation updater bot 233845cc1c
Localisation updates from https://translatewiki.net.
Change-Id: Ibdbad3d5d8dadbba7207884317a0131999c8053f
2024-06-19 09:23:19 +02:00
David Lynch 955bfc4b68 findAddedContentNeedingReference was removed accidentally
Replace it with a hasAddedContentNeedingReference that'll need to be
kept in-sync with the internal logic in AddReferenceEditCheck while
we're tagging this.

Follow-up to d69d366469.

Bug: T367920
Change-Id: I9f4f96bf5c6c4b7b3131b1435426b2e283c9833a
2024-06-18 16:12:30 -05:00
jenkins-bot b97d66d149 Merge "EditCheck: Use sourceType:commonjs in ESLint" 2024-06-17 17:53:50 +00:00
jenkins-bot 66694cc5f8 Merge "Edit check API" 2024-06-17 15:16:00 +00:00
Translation updater bot a054bf8fff
Localisation updates from https://translatewiki.net.
Change-Id: I7721a4e934d953242709d3d33e10a9ec15f43624
2024-06-17 09:33:29 +02:00
jenkins-bot dc3128fe4e Merge "Add code to support showing multiple checks in pre-save workflow" 2024-06-16 15:30:27 +00:00
Ed Sanders 9a87e1157f EditCheck: Use sourceType:commonjs in ESLint
Change-Id: I0dd72a0129d6f991966a34a502f5a41aab5a154d
2024-06-14 16:25:51 +01:00
Translation updater bot 16f287aed7
Localisation updates from https://translatewiki.net.
Change-Id: Id5fba2c370adaf5dacd478d130c45ded70486b02
2024-06-14 09:50:13 +02:00
David Lynch d69d366469 Edit check API
Change-Id: Ic5504eb2fe8d1d3f22e88abe1dd88790bdfd8b9c
2024-06-12 11:01:04 +01:00
David Lynch d0a57f5197 Add code to support showing multiple checks in pre-save workflow
Leave the feature disabled for now.

Change-Id: Id70762a887c57d9255df22d50bf7badad89040de
2024-06-12 11:01:04 +01:00
David Lynch e6e104dda5 Use reliability API to detect blocked external links
Bug: T366751
Change-Id: If3813cb662155f674688d0ca0733fabdbb338a50
2024-06-08 13:55:43 -05:00
David Lynch d2899153ea Phan wasn't checking the editcheck includes
Have to ignore some calls to AbuseFilter/SpamBlacklist rather than
adding those extensions to directory_list because those extensions don't
pass checks themselves.

Change-Id: If3db9df8a49d8319b08695410a056e1d8e068c15
2024-06-08 13:55:43 -05:00
Ed Sanders 291844dbee build: Update stylelint-config-wikimedia to 0.17.1
Change-Id: I8e0f087ae3d2644df85a85791b9c49c09567c0f4
2024-06-05 18:47:49 +01:00
jenkins-bot 9a73262215 Merge "Turn property into const in ResourceLoaderData class" 2024-06-04 18:48:04 +00:00
jenkins-bot 932df6759e Merge "Add type declarations and remove redundant PHPDoc tags" 2024-06-04 18:24:54 +00:00
thiemowmde 1d449787ef Add type declarations and remove redundant PHPDoc tags
Most of this code was already typed, but not everything. Using
language-level type declarations allows us to remove extra PHPDoc
blocks that just repeat the same information.

I'm also using the more narrow UserIdentity instead of User in a
few places where this is possible.

Change-Id: I7661824fcb34180af1a4fd3030fcd6c0b7d34089
2024-06-04 16:55:00 +00:00
Ed Sanders dbc696124f ESLint: Enforce no-var and autofix
Temporarily disable prefer-const as this requires
manual fixing.

Change-Id: I477b69a57e8d33535c6fc71dba196a8605780725
2024-05-21 17:40:52 +01:00
Translation updater bot b3b30bb4a5 Localisation updates from https://translatewiki.net.
Change-Id: I464cad219aa2f71ec6b2688a2cc2a91ea950c90f
2024-05-20 09:26:33 +02:00
jenkins-bot f95f6768fc Merge "Disable eslint security regexp warnings" 2024-05-09 16:33:35 +00:00
Ed Sanders 1980827aec Use arrow callbacks in other modules
Change-Id: Ib07720923de6657ae55ac29a07c5cc85b088a70d
2024-05-09 10:33:44 +01:00
Bartosz Dziewoński 12613a6ad0 Disable eslint security regexp warnings
They generate a lot of false positives in this extension.

Since this is client-side code, the worst that could happen is a
browser tab hanging, not any real security issues.

Change-Id: I177cfa7e57a6b7b528d558d2cba076e85fd0271f
2024-05-07 20:54:42 +02:00
Translation updater bot c05851aa4f Localisation updates from https://translatewiki.net.
Change-Id: I883d7f93aee32b044635d3072952284d7dbc1491
2024-05-02 09:20:26 +02:00
Ed Sanders e3659d4846 Prefer arrow callbacks
Change-Id: Ia05b27f7c71c33580ffd0718e3bbc673dd8b3d63
2024-05-01 14:11:54 +01:00
Translation updater bot 866b04c1ad Localisation updates from https://translatewiki.net.
Change-Id: I8575e232bca0204888a984ed296da869ec6a5a6b
2024-04-23 09:29:14 +02:00
Translation updater bot 1210543fca Localisation updates from https://translatewiki.net.
Change-Id: I9c7d830c1ec3284d9c3e26c8b544f5cab5380df4
2024-04-22 09:30:14 +02:00
Translation updater bot 8e3dcce2d6 Localisation updates from https://translatewiki.net.
Change-Id: Iddacc58eb8702efe6a72d981f73525af44942d8c
2024-03-22 08:45:48 +01:00
Translation updater bot 545098a7ef Localisation updates from https://translatewiki.net.
Change-Id: I1dc48916ab44c31217fbf47c2d559b7cf2e7fc09
2024-03-18 08:32:05 +01:00
Ed Sanders 45ff962bcd EditCheck: Fix the colour of the popup widget anchor
When EditCheck is the first item in the menu, make the
anchor pink as well.

Relies on the :has selector in modern browsers.

Change-Id: I66e760742da25b3797529b0c65a8d90871a0a1da
2024-03-12 17:25:49 -07:00
Translation updater bot 635761fefe Localisation updates from https://translatewiki.net.
Change-Id: Id4478577912c4eeb0d63fbc345709a5744c256c7
2024-03-01 08:34:20 +01:00
Translation updater bot 77e3ac92f8 Localisation updates from https://translatewiki.net.
Change-Id: I277685ccbf144b215549ead9b4bcbac3f5b2abed
2024-02-26 08:37:24 +01:00
Ed Sanders 80e8d65cff Introduce ApiEditCheckReferenceUrl
Checks the URL against SpamBlacklist, and the new
BlockedExternalDomains list in AbuseFilter.

Bug: T349261
Change-Id: I39896ae0d59db4aa918b08b3b2eaacb52bfe4a03
2024-02-22 15:39:43 -06:00
thiemowmde ea58831d5a Turn property into const in ResourceLoaderData class
We can use this language feature for a while now.

Change-Id: I523d31f0fbe58d51f23ee47372e0f6d1d72df722
2024-02-20 10:50:25 +01:00
jenkins-bot 8f058ffe86 Merge "Only activate edit check in visual mode" 2024-02-15 22:27:01 +00:00
David Lynch 9c7f772d4f Only activate edit check in visual mode
Change-Id: I9b2dac998cd33a855f56e91c77332ef6ae156f7d
2024-02-15 12:20:03 -06:00
Translation updater bot b224d16b64 Localisation updates from https://translatewiki.net.
Change-Id: Id6c3c7d9d5ea86b114ca0c7ca4e7ba5b6152b727
2024-02-14 08:19:38 +01:00
Translation updater bot d3d25a13c1 Localisation updates from https://translatewiki.net.
Change-Id: I8d467e3af64c396055a3c3bb22cd455c1e66a59e
2024-01-15 08:25:47 +01:00
Translation updater bot b11be1970e Localisation updates from https://translatewiki.net.
Change-Id: I226fabe6fcf68d98798dee81f0ece610e8968691
2024-01-11 10:06:31 +01:00
Translation updater bot b4c6326095 Localisation updates from https://translatewiki.net.
Change-Id: I5ff26bd380f5d5b9d25ea8ad0bdb539ba12fd15c
2024-01-10 08:33:36 +01:00
Translation updater bot fff8e94ac4 Localisation updates from https://translatewiki.net.
Change-Id: I4d53131b771abccd5e0758cf8e87ac36bf3eb220
2023-12-11 10:44:19 +01:00
Translation updater bot 08fa969984 Localisation updates from https://translatewiki.net.
Change-Id: I5f24f4f4ec99ee08ecd29250ece23788a6409637
2023-12-08 14:46:53 +01:00
David Lynch 5d6463ebba Edit check config for whether to ignore references in certain sections
Adds two new configs:
* ignoreSections, array of section names that'll be compared
* ignoreLeadSection, bool for whether to ignore the lead section

Bug: T346949
Depends-On: I7ded925b91b1d86b3c76c4135c85a3f0be1dee5e
Change-Id: I44f18fadcafbe011008d8abff566e2ccd7682f4f
2023-12-05 15:47:17 +00:00
Translation updater bot af8fab06a1 Localisation updates from https://translatewiki.net.
Change-Id: I6138e5e924b37d057bd750d489ae3e7c621aa155
2023-12-05 09:16:08 +01:00
Translation updater bot bbfbba3e83 Localisation updates from https://translatewiki.net.
Change-Id: Ie6b17d53bfbc8b64f7be4c0bdbfcd0cf51e3bcea
2023-12-04 09:06:33 +01:00
Ed Sanders d42a0772bb Move verbose copyright message to AUTHORS.txt
Avoids having to update the date in every file every year,
which we stopped doing.

Change-Id: I7bf7aa0937eef911e00772470091753a7b06fd3d
2023-12-01 16:07:39 +00:00
David Lynch 094c007df0 Allow a global variable to forcible enable edit check
The URL parameter turns out to be a bit painful for people to use in
some situations.

Bug: T350749
Change-Id: I7c88dc604dd321a7c78810b21f7ad8306ff9dab6
2023-11-30 10:27:50 +00:00
Translation updater bot 6791f0c47e Localisation updates from https://translatewiki.net.
Change-Id: I47a8c1cb0ec8089ab417d04f9a0e0a221e7a510b
2023-11-29 08:32:05 +01:00
Ed Sanders 876a947a7b Move EditCheck files to ./editcheck and structure as a sub-extension
Change-Id: I4085223a93b37e601b3627fc2d6db7978cac820e
2023-11-28 15:56:43 +00:00