Commit graph

15884 commits

Author SHA1 Message Date
James D. Forrester e0272fef60 Update VE core submodule to master (fe0f165df)
New changes:
2e14259db ve.ui.FragmentInspector: Fix positioning of additional actions

Change-Id: I1702552df1eba492251c8388710c8b2f194a0991
2019-07-25 13:52:43 -07:00
jenkins-bot 138c3eb53a Merge "ve.ui.MWLinkAnnotationInspector: Update size after showing/hiding errors" 2019-07-25 20:51:33 +00:00
Ed Sanders 32042d76e8 Update VE core submodule to master (fbbb9c4cb)
New changes:
854a1fa2c Distinguish active link styling

Local changes:
* Pull through active link styling

Bug: T228220
Change-Id: I925f88d32a514a749b96f501a211003bc4c924f0
2019-07-25 20:25:54 +00:00
Ed Sanders 9a1994e47c Update VE core submodule to master (7cb9caca1)
New changes:
28aea2e4d Edit cards v2 design
739017973 Track usage of the new "close context" button

Local changes:
* Edit cards v2 pull through

Bug: T222396
Change-Id: I1ca885e8d8127e7827a059755315ed789a7b9210
2019-07-25 22:24:48 +02:00
Bartosz Dziewoński 473bf1bf94 Update VE core submodule to master (e63fe33b1)
New changes:
e6531ada8 Follow-up 06f1ebb8: Drop deprecated ve.init.Platform methods
65a6870b3 Localisation updates from https://translatewiki.net.
e63fe33b1 Instrument ActionProcess for FragmentDialogs as well

Bug: T221305
Change-Id: I9e4d4249167dae7b8593c0fa88e6227c9714957d
2019-07-25 22:05:45 +02:00
Bartosz Dziewoński bfc549e720 ve.ui.MWLinkAnnotationInspector: Update size after showing/hiding errors
Change-Id: I84af3fbfea4aa89d76de95cfcdbfd3bc9e69ee83
2019-07-25 00:06:02 +02:00
David Lynch 5424a5e6bb Update VE core submodule to master (788d449ae)
New changes:
2d326b1fe Re-enable karma Firefox testing
4d95bdf2c ve.ui.Surface: Update iOS padding on focus/blur/activation
5cf567d34 Generalize the tracking of window opening

Bug: T200347
Bug: T221305
Change-Id: I3da0e81ac906f2426060fcaea4d268aa8b82e82c
2019-07-24 15:04:45 -05:00
Ed Sanders b35241497a Use type=url for external link input
Change-Id: I13cfdaaf5e94f07d16270df2933d1b23cf9f0ff7
2019-07-24 13:50:11 +01:00
jenkins-bot ef25e831b9 Merge "MobileArticleTarget: Compat for OOUI scrolling fix on iOS Safari" 2019-07-24 11:34:23 +00:00
Bartosz Dziewoński cc1cb63aca targets: Fix silly indirection via a global variable
Since we're inside the Target instance, `ve.init.target` refers to
this object. Some of the code I'm changing even uses `this` instead
of `ve.init.target` on the next or previous line.

Most of the mistakes are a result of mass search-and-replace changes
(478b0bcb, e1a887cc), or moving the code from other classes (d294006d).
But I can't explain the "ve.init.target.getSurface().getDom()" line,
it would be good to figure out why it was this way before we change it.

Change-Id: I0d7c6a48369242d4c99620fcd775ab537420d84a
2019-07-23 22:39:47 +00:00
Bartosz Dziewoński 2b6857d89a Update VE core submodule to master (6045a533f)
New changes:
5e8865931 Don't hide the context when opening an inspector on mobile

Bug: T228229
Change-Id: I32ff3962cdff332d51f32c5c3fd36e8062c3ac6f
2019-07-23 22:13:39 +00:00
Bartosz Dziewoński 0fb7d5efda Update VE core submodule to 962335a40293cf4b1314c0236788f35f080ae877
New changes:
a06204317 Fix TableNode unit test getOffsetFromCoords failure on Firefox
dfe0eb025 Refactor mobile context logic into ve.ui.MobileContext

Local changes:
* Pull through for edit cards refactor

Bug: T227532
Bug: T228767
Change-Id: I6c043e039fbef62a56f475b0dc365e171ab7bf59
2019-07-23 22:13:27 +00:00
Ed Sanders 393de5985f Update VE core submodule to abf2bfa85e64e67cdf963601fe1da2a11fd9e89a
New changes:
1a7460058 Remove ve.newMobileContext feature flag

Local changes:
* Remove ve.newMobileContext feature flag

Change-Id: Ia8def997b7cba4623866080752b06068d2118cc3
2019-07-23 22:12:48 +00:00
jenkins-bot 3597db04e5 Merge "MWEditingTabDialog: Don't use ve.init.target because it may not be loaded" 2019-07-23 20:49:17 +00:00
daniel b898c417b4 Removes forward-compat code needed for method rename in core.
Depends-On: If47a93878f87d69800e5f305404c22528dac5e94
Change-Id: I2181f1a39b47078a32a8de68ac63d3144fc5b807
2019-07-23 21:38:52 +02:00
Bartosz Dziewoński a5867818ff MWEditingTabDialog: Don't use ve.init.target because it may not be loaded
We also show this dialog on the old wikitext editor, where
ve.init.target is not set, because the relevant code is not loaded.

Follow-up to 478b0bcbb9.

Similar to e88cd81f94, which fixed the
same issue in a different file.

I checked all uses of ve.init.target in files under ve-mw/init/ and I
think this was the only remaining mistake.

Bug: T228684
Change-Id: I15551870cdb01d570e24ba9668e67330b8072e01
2019-07-23 19:09:37 +00:00
James D. Forrester df0e56a8fc Update VE core submodule to master (d33f296d1)
New changes:
da6d39555 Use collapsed selection for "set label" button on mobile
03d6ccf50 Localisation updates from https://translatewiki.net.
d33f296d1 Update OOUI to v0.33.4

Bug: T228227
Change-Id: I20e39928fb6ca6e0d72c399987d76cc579b4f842
2019-07-23 07:34:03 -07:00
jenkins-bot 81fda630e7 Merge "SaveDialog: Hide options bar when empty" 2019-07-19 18:44:46 +00:00
Bartosz Dziewoński c354e17388 Update VE core submodule to master (e2f4b0e96)
New changes:
1f9b02179 ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations
570acddfb Revert "Call handleInsertion on beforeinput"
e2f4b0e96 Localisation updates from https://translatewiki.net.

Bug: T217223
Bug: T227241
Bug: T227852
Change-Id: I439872773aee5a78928cf8af1a44c8eb080a8bf0
2019-07-19 18:09:51 +02:00
Bartosz Dziewoński b00190a398 MobileArticleTarget: Compat for OOUI scrolling fix on iOS Safari
Our overlay could be higher than the viewport, allowing the viewport
to scroll again.

Bug: T212159
Change-Id: I1e97d1963b214fc7673c33ae6c14ab7b0b80f31d
2019-07-18 02:11:53 +02:00
James D. Forrester c82238b0b6 Update VE core submodule to master (3d0cc9eac)
New changes:
9171b9afd Update OOUI to v0.33.3
d22e876e0 SurfaceFragment: Fix typo in docs
11b04e1b6 HashValueStore: Shortcut merge if other === this

Change-Id: Ibfe03293675f6484d0758ebc239246713bfa7d95
2019-07-17 14:38:09 -07:00
Ed Sanders 5aea61add7 Update OOUI icons names for article icons in link cache
Bug: T222079
Change-Id: I8ac2d02dfeaec3a197432d1718792a458d626917
2019-07-17 13:08:50 +01:00
jenkins-bot aca81dbca8 Merge "ve.dm.MWTransclusionNode: Protect <style> nodes too when copying" 2019-07-16 22:21:51 +00:00
Bartosz Dziewoński 59bc6f6a76 Add dependency on 'mediawiki.interface.helpers.styles'
This module is now needed to correctly display log excerpts,
like in our edit notices popup for protected pages.

Bug: T227190
Change-Id: I19dec69a33a2b3246ff1abe6bec90b2359ac36a4
2019-07-16 20:58:38 +00:00
Bartosz Dziewoński 3ca8319dfc ve.dm.MWTransclusionNode: Protect <style> nodes too when copying
Bug: T226374
Change-Id: Ie7853382642336638e0a1de9ca506d750ce054ce
2019-07-16 22:51:28 +02:00
jenkins-bot f0acb0d427 Merge "Update VE core submodule to master (311a3dff1)" 2019-07-16 15:41:49 +00:00
Ed Sanders 085764ddd6 SaveDialog: Hide options bar when empty
Since I7f6fd7ee9 it is now possible for the options bar to be
completely empty if the user is logged out. In this case hide
it and only show it again when the character limit needs to be
show.

Ideally we wouldn't have the height change, but it is quite rare
that a user gets to 400 chars and is logged out.

Bug: T228165
Change-Id: Ifbdf352afcbf4e549889e04fdb70fd30ce233aad
2019-07-16 14:28:25 +01:00
libraryupgrader ef3906b82b build: Updating dependencies
composer:
* mediawiki/minus-x: 0.3.1 → 0.3.2

npm:
* lodash: 4.17.11 → 4.17.14
  * https://npmjs.com/advisories/1065
  * CVE-2019-10744
* grunt-banana-checker: 0.7.0 → 0.7.1

Change-Id: Idaf7723adc2136f1fc39573897604c056f814e49
2019-07-16 04:47:13 +00:00
jenkins-bot 2d25d15a39 Merge "Add number of images to gallery context" 2019-07-15 23:26:30 +00:00
Bartosz Dziewoński 8aac97cc30 Update VE core submodule to master (311a3dff1)
New changes:
bb8471c98 Edit cards: Don't show keyboard when going from focusable to link
80feb00ae BranchNode: Add comment to internalItem hack
9c2f1241b FocusableNode: Avoid DOM manipulation in setup

Change-Id: Iad906dc3aeff1b777ad11f276a277381a99b4113
2019-07-16 01:06:27 +02:00
Ed Sanders c958ea383d Add number of images to gallery context
Change-Id: I3e54c6cb2b29ecb1153afd5f2f61adaabceb095b
2019-07-16 01:04:08 +02:00
Ed Sanders 377ed366cd Add validation to feedback to internal links
Turns out we had this message lying around unused,
so use it (even though an invalid title is quite
hard to come up with).

Change-Id: I0200678820fe88a59869f7fad8f491b4c5b77482
2019-07-15 22:35:59 +00:00
Ed Sanders fba9585dbf Add validation feedback to external link
Bug: T227899
Change-Id: I165ed59402bdffb63b0c79b68a41d509c4574837
2019-07-15 22:35:46 +00:00
James D. Forrester d8b6509d78 Update VE core submodule to master (e16b98e25)
New changes:
616f2c40d Fix some typos in code comments
22c03cc02 Render internal item nodes when requested individually

Bug: T228070
Change-Id: I99ee90f0b88c00455995d165745509121df1b2b0
2019-07-15 14:11:20 -07:00
jenkins-bot 14539bfe22 Merge "Make page title the target title" 2019-07-15 19:08:11 +00:00
tcreusc 57317a20e4 Make page title the target title
There are cases where the page title and the real/desired page name
are not the same. Fixing that also fixes the suggestions that appear
in dialogs (see related bug).

Bug: T193132
Change-Id: Iafa84c05bea08ebb061ee6d1323eb50945b39815
2019-07-15 17:22:17 +00:00
jenkins-bot 5f85137285 Merge "MWSaveDialog: Use close flag for close actions, move 'back' button" 2019-07-15 15:34:22 +00:00
Translation updater bot abda55d5dd Localisation updates from https://translatewiki.net.
Change-Id: I5b11126d64c28b18e1b272062a7ffe8bf0c95511
2019-07-15 08:35:39 +02:00
Ed Sanders b64cd4ced1 Update VE core submodule to master (213b79783)
New changes:
6cd9ba63f Localisation updates from https://translatewiki.net.
c9cebed32 Update OOUI to v0.33.2
65c66b8a6 Localisation updates from https://translatewiki.net.
8d94ad13f Replace unrendered parts of the view tree with a stub node
213b79783 Basic unit tests for attachedRoot functionality

Bug: T215717
Change-Id: I7bd8106a82e4fa7c912ce9f8d4fab86bfb546702
2019-07-14 15:26:28 +01:00
Bartosz Dziewoński f259bb9c02 MWSaveDialog: Use close flag for close actions, move 'back' button
When previewing/reviewing changes, the "Return to save form" button
now replaces the "Resume editing" button in the top-left corner (and
receives the 'back' flag). Effectively, you tap 'back' once to go back
to the edit summary, and twice to go back to editing. This seems to me
like a much more natural interaction than two separate buttons.

Bug: T225021
Bug: T227049
Bug: T227857
Change-Id: Id27ccf06923c8aa86b1c1a9292bc43bb825ce6c8
2019-07-12 20:33:02 +00:00
Translation updater bot 7ed1a9ba95 Localisation updates from https://translatewiki.net.
Change-Id: If146cd0932f83bb8b1e2f9324f1c9555e050953f
2019-07-12 08:45:01 +02:00
James D. Forrester 18472d84a2 Follow-up Id330efac: Only hide the welcome dialog on mobile
Change-Id: I8fa3c6100652d2f29a60bc22c8e08a4d9e79d37a
2019-07-10 13:10:27 -07:00
jenkins-bot 5358d67342 Merge "Remove non-existing showRedlink from ve.ui.MWInternalLinkAnnotationWidget" 2019-07-10 19:06:16 +00:00
Bartosz Dziewoński cde7946bdc MobileArticleTarget: Don't show the welcome dialog
Bug: T227670
Change-Id: Id330eface30d5fad8c7264a2be1ceeb4df3a4952
2019-07-10 18:28:02 +00:00
Niklas Laxström ea66017b4b Remove non-existing showRedlink from ve.ui.MWInternalLinkAnnotationWidget
It was removed in 3e31a31 in 2016.

Change-Id: Ib7383a4ff585258a98d6795487e912597b41900e
2019-07-10 12:18:48 +02:00
James D. Forrester 9aca5ab86c build: Upgrade phan-taint-check-plugin from 1.5.0 to 2.0.1
Change-Id: Ie2bd989a52ec61ad881fd4f12d0598b42f4ca2e0
2019-07-09 13:00:47 -07:00
jenkins-bot 2ec5bd5447 Merge "MWLinkAnnotationInspector: Work around annoying syntax highlighting bug in Gerrit" 2019-07-09 17:09:40 +00:00
David Lynch e32f460a5c Extra logging for link inspectors
Bug: T221249
Change-Id: I4e5991f7aa90d08598d5ba7ac14839956bee9b94
2019-07-09 10:12:33 +00:00
Bartosz Dziewoński 9ba3255c26 MWLinkAnnotationInspector: Work around annoying syntax highlighting bug in Gerrit
Wrap a regexp in parentheses to avoid confusing Gerrit's New UI syntax
highlighter, which goes crazy if a line starts with a regexp.
https://github.com/highlightjs/highlight.js/issues/1962

Change-Id: I7e4ca4d5c4d449925af7168147016ed2fb8a6e33
2019-07-09 10:08:23 +02:00
James D. Forrester a0aacd89e1 Update VE core submodule to master (d49575d46)
New changes:
3bc3dfd87 build: Upgrade various devDependencies to latest and make pass
a0165b985 Fix visible whitespace rendering in source mode
261535e2d Avoid jQuery.map
bf1398cc3 Remove unused :visible check

Bug: T226478
Change-Id: I9b6a79ea0fdb1679036372b46b8df3b885ffb135
2019-07-08 11:17:16 -07:00