wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-11 05:56:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

MWSaveDialog: Use close flag for close actions, move 'back' button

Browse source 
When previewing/reviewing changes, the "Return to save form" button
now replaces the "Resume editing" button in the top-left corner (and
receives the 'back' flag). Effectively, you tap 'back' once to go back
to the edit summary, and twice to go back to editing. This seems to me
like a much more natural interaction than two separate buttons.

Bug: T225021
Bug: T227049
Bug: T227857
Change-Id: Id27ccf06923c8aa86b1c1a9292bc43bb825ce6c8
This commit is contained in:
Bartosz Dziewoński 2019-07-01 15:11:57 +02:00
parent 7ed1a9ba95
commit f259bb9c02
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
View file

@ -63,8 +63,8 @@ ve.ui.MWSaveDialog.static.actions = [
},
{
label: OO.ui.deferMsg( 'visualeditor-savedialog-label-resume-editing' ),
flags: [ 'safe', 'back' ],
modes: [ 'save', 'review', 'preview', 'conflict' ]
flags: [ 'safe', 'close' ],
modes: [ 'save', 'conflict' ]
},
{
action: 'review',
@ -79,6 +79,7 @@ ve.ui.MWSaveDialog.static.actions = [
{
action: 'approve',
label: OO.ui.deferMsg( 'visualeditor-savedialog-label-review-good' ),
flags: [ 'safe', 'back' ],
modes: [ 'review', 'preview' ]
},
{