Commit graph

7120 commits

Author SHA1 Message Date
jenkins-bot da475dd4b1 Merge "[browser test] increase wait for save to complete" 2014-04-18 16:41:02 +00:00
cmcmahon c4707a05fb [browser test] increase wait for save to complete
sleep() is evil, but let this stay at least for now

Change-Id: If3c98b2a05ea37dee0365afd5f17cf8b282ab29a
2014-04-18 09:38:27 -07:00
Željko Filipin 1236387abd [browser test] Run all Selenium tests in Firefox
Paired with: Chris McMahon
Bug: 58040

Change-Id: I83d4c391fc101bda8c18a6d0c533ca75795569ff
2014-04-18 17:33:12 +02:00
jenkins-bot 12e780c67a Merge "Remove getVersion from api module" 2014-04-18 04:23:23 +00:00
jenkins-bot caecb84b9b Merge "Remove Function.prototype.bind from compatibility check" 2014-04-18 04:16:49 +00:00
jenkins-bot 52e103f454 Merge "Add whitespace" 2014-04-18 00:23:43 +00:00
Ed Sanders 29476afe83 Use forced directionality for HieroInspector
Change-Id: I2f4b15fb7bc1b3d028106e09fb5039ee5cb2987a
2014-04-17 17:03:51 -07:00
Ed Sanders 8070f48d27 Extension inspector directionality
Use a dir string instead of isLtr boolean like we do everywhere
else. Also use this.constructor.static, not this.static inside
methods.

Fixes Ie0525628.

Bug: 64072
Change-Id: I5321b71a446802d89ca86d55a0bff855b69825eb
2014-04-17 22:00:36 +00:00
Translation updater bot 25d1ca0659 Localisation updates from https://translatewiki.net.
Change-Id: Id4f98d4bd9e6cbfb0ff845eedf7a3e68c2eaedb9
2014-04-17 19:02:52 +00:00
Niklas Laxström dc4015455b Remove getVersion from api module
This method is deprecated since 1.21, VE is marked to require 1.22.

Change-Id: I67d30777fe0b2ebdacffcb2d6ca92275321c4e68
2014-04-17 14:04:21 +00:00
Niklas Laxström 32446f3cb3 Add whitespace
Change-Id: Id4448bcd952b1b9664cf74a99be80b8129fafa4d
2014-04-17 14:03:46 +00:00
Niklas Laxström 4c0221c09c Remove useless isset
The exact same thing is access two lines above without isset

Change-Id: I242b9f402908c7d40c0dc026c6c5d99ac1e2bf4a
2014-04-17 08:17:16 +00:00
James D. Forrester df31082085 Remove Function.prototype.bind from compatibility check
We aren't using it anyway, and it blocks some browsers unnecessarily
(PhantomJS in particular).

Change-Id: I90b1124704bfaf571212fdf9e187a450104176dc
2014-04-17 03:49:03 +00:00
James D. Forrester 287efeef6f Update VE core submodule to master (83be91a)
New changes:
d375dc1 Restore call to dm.Surface#startHistoryTracking removed in I9f8b840c
576a4c1 Call stopHistoryTracking() when destroying ui.Surface
83be91a Update OOjs UI to v0.1.0-pre (9d291a9222)

Change-Id: I2b9f272fc9e9d8784d435a40641d655014d9cff7
2014-04-16 20:48:38 -07:00
jenkins-bot a1fd95e522 Merge "Don't change tabs on Education Program pages" 2014-04-17 03:38:50 +00:00
Krenair e3be4a6588 Don't change tabs on Education Program pages
Unfortunately the best way I've come up with to do this so far is
checking the namespace.

Bug: 53477
Change-Id: Ib2dbe91aff516f2d2408e07ff3f73ea861bfcbe2
2014-04-16 20:33:24 -07:00
jenkins-bot 564e77bc43 Merge "Allow MWExtensionInspector to be set to forced LTR status" 2014-04-17 03:21:17 +00:00
jenkins-bot 07a7708da1 Merge "Follow redirects in the category widgets" 2014-04-17 02:44:41 +00:00
Trevor Parscal 926700fbca Re-split the transclusion dialog
We used to have two dialogs; a complex one, and a subclass that dumbed it
down - this was rubbish.

Then we merged them together - this was a'ight.

Now we have two dialogs again; a simple one, and a subclass that fancies
it up a bit - this is wicked keen broham.

Change-Id: I4b2ba31bed5c4f80940623702d635cacd19e0a66
2014-04-17 01:39:18 +00:00
James D. Forrester 0e4676e6a9 Allow MWExtensionInspector to be set to forced LTR status
This is used in e.g. the formula editor and it's potentially useful.

Change-Id: Ie05256285e517c2d0d464822befbf81f2d9209e3
2014-04-16 18:34:26 -07:00
jenkins-bot 537fbc95f9 Merge "Use the correct classname in MobileViewTarget" 2014-04-17 00:45:08 +00:00
Roan Kattouw 5b0d4b5286 Use the correct classname in MobileViewTarget
Change-Id: I7e0a5aa56116dd7f44cbac29e0b6bc5d760e157e
2014-04-16 17:41:18 -07:00
Roan Kattouw 4fc08d24c5 Make the Add template button not wrap to the next line
By default, MWTitleInputWidgets are now 30em wide, but this doesn't
work in the transclusion dialog where we want to put the "Add template"
button after an MWTitleInputWidget and have it not wrap to the next line.
So make the MWTitleInputWidget on the add template page 20em wide instead
(this is what they all were before the default was changed to 30em).

Change-Id: I2f33a87427657f4e27939c401436c4ce6441208c
2014-04-16 16:24:45 -07:00
Roan Kattouw 9312501824 Update VE core submodule to master (2d96306)
Add reference to DimensionsWidget.css

New changes:
2d96306 [BREAKING CHANGE] Separate Widget styles properly

Change-Id: I84c1a3576b8eca74d483e26a4affd21f790040ad
2014-04-16 16:02:51 -07:00
Roan Kattouw 2262073c9c Update VE core submodule to master (4366f20)
Use new dm.Surface method for checking undo history state
(hasPastState -> hasBeenModified).

New changes:
38776df [BREAKING CHANGE] Refactor history state methods to better suit uses
3412b41 Localisation updates from https://translatewiki.net.
0c5238c Add system to dm.Surface for staging changes
8f0077c Only hide popups on selection change
4575f82 Fix initial selection when focusing in Firefox
debfd4e Document focus/blur cleanup

Change-Id: Ic66c96a4f64ad82a01a84535ca8cd19332065b37
2014-04-16 15:57:28 -07:00
Roan Kattouw 9d1b7432fd Also focus surface in media edit dialog
16ec8ffdcf did this for the reference dialog, but the media edit
dialog needs it too. Additionally, we need to focus it when the
user switches to a different page then comes back.

Bug: 63909
Change-Id: If1b9587f4d10dbe6374e987b35c781954bcc566d
2014-04-16 15:12:39 -07:00
jenkins-bot 4d6a59b16b Merge "Focus the surface in the reference dialog after it opens" 2014-04-16 19:00:51 +00:00
jenkins-bot 266bc709f6 Merge "Always replace state with VE tag when loading" 2014-04-16 18:50:09 +00:00
Roan Kattouw d335e59330 Fix another surfaceModel.getFragment() in MWCitationDialog
Change-Id: Ic12652bf3d53396f84d558595ce1e4a2d0a22796
2014-04-16 11:42:15 -07:00
Roan Kattouw 16ec8ffdcf Make inserting reference lists work again
surfaceModel.getFragment() is a null fragment, use this.getFragment()

Bug: 64012
Change-Id: I995929ff0dda60220e17e579994b51ffb406f149
2014-04-16 11:40:26 -07:00
jenkins-bot e708595f14 Merge "Make fieldsets render properly" 2014-04-16 18:27:16 +00:00
jenkins-bot fb366c47f1 Merge "Hide inspectors using new method when saving" 2014-04-16 18:27:05 +00:00
jenkins-bot 544531d092 Merge "Update VE core submodule to master (69db959)" 2014-04-16 18:19:23 +00:00
Translation updater bot c83a165b3c Merge "Localisation updates from https://translatewiki.net." 2014-04-16 18:16:16 +00:00
Translation updater bot 7eeeccc841 Localisation updates from https://translatewiki.net.
Change-Id: I7b42029a5301cd0a3a3a4d2a095261aa036935b7
2014-04-16 18:15:39 +00:00
James D. Forrester 34d1e8356f Update VE core submodule to master (69db959)
New changes:
51bd18e Allow the context to close any open inspector
69db959 Update OOjs UI to v0.1.0-pre (c58b498573)

Change-Id: I62d8b4c2ec13022f33667e1050782b76f6d93a76
2014-04-16 11:09:42 -07:00
Moriel Schottlender fa72f5fdc2 Border checkbox disabling/enabling fix
Due to a lack of clarity in the wikitext documentation the border
checkbox wasn't set up right. This is the proper behavior: border is
allowed for all unframed images (frameless and basic) while the
framed images (frame and thumb) have it anyways. Wikitext
documentation was also clarified for prosperity.

Change-Id: I4dd4775da473d669781553796be99646240c13fe
2014-04-16 13:14:58 -04:00
Krenair e9153fdccf Always replace state with VE tag when loading
Instead of just when venotify is used. To stop the back button breaking.

Bug: 63739
Change-Id: I637818f34a9015076c85c6daccb337503ad2499d
2014-04-16 18:02:10 +01:00
cmcmahon d62a9e939a [browser test] Save page is slow.
Change-Id: I550c462795f3e51555a21e0877985052610ad8cc
2014-04-16 08:52:21 -07:00
Krenair 9c2e1d8048 Follow redirects in the category widgets
Display the redirects nicely in the UI, etc.

Bug: 52414
Change-Id: Ib62144cb90899d0c525d6f08f6b5f1159b7d2a86
2014-04-16 15:30:14 +00:00
Moriel Schottlender 8d99aa88c8 Fix border checkbox
Make sure border is enabled for unframed types and disabled for
framed images.

Change-Id: I716e9bc4140fbc09aac52930d1dd8213f31617a3
2014-04-16 00:03:35 -04:00
jenkins-bot 24071290a8 Merge "Fix name of advanced settings page in open command" 2014-04-16 02:57:30 +00:00
Krenair 96cdfe28ce Fix name of advanced settings page in open command
Bug: 63984
Change-Id: I924520be81a183a1de3f8f81c60d9ed26fb3a80e
2014-04-16 02:08:30 +01:00
James D. Forrester 957a2cb82a Update VE core submodule to master (f1dd298)
New changes:
f1dd298 Clear the surface observer when blurring

Change-Id: Ibb5a1020f4d4d9de68188cabde7615f9e181a37a
2014-04-15 16:45:52 -07:00
James D. Forrester aa3c520c1c Update VE core submodule to master (bb7124b)
New changes:
a997cc1 Debounce ce.Surface#onFocusChange
ef24608 Use document direction when a fragment has a null range
644243a Don't call select on a fragment if it's null

Change-Id: I22d00fd360539f286d815e747dd904bed87276c4
2014-04-15 15:42:37 -07:00
jenkins-bot c1f29636e8 Merge "Update VE core submodule to master (d1f5386)" 2014-04-15 22:41:49 +00:00
Roan Kattouw b764ecc7f4 Focus the surface in the reference dialog after it opens
Otherwise the surface ends up in a weird half-focused state which
causes it to behave strangely.

Bug: 63909
Change-Id: I3ebc30fde0202116b383a5b497aca65b66732922
2014-04-15 22:25:41 +00:00
James D. Forrester 42f9d3e45b Update VE core submodule to master (d1f5386)
New changes:
2909ff9 Update OOjs UI to v0.1.0-pre (eba79af989)
1737a76 Add .focus() to SurfaceWidget
6fc4026 Code style typos
d1f5386 Update OOjs UI to v0.1.0-pre (8197f2cd2e)

Change-Id: Ia8edc2319ed0a4578652fb7e5b257061edd0a7c0
2014-04-15 15:23:30 -07:00
James D. Forrester 37030882d1 Fix fencepost error with MWMoreParametersSearchWidget overflow
The logic was checking that there were at least three items to show, then triggering
the MWMoreParametersResultWidget widget with the number of items left in the overflow
if the limit was two. Whoops. :-)

Change-Id: Icec16a2d26bef8bf8d74ed619341afd494ca0479
2014-04-15 12:30:40 -07:00
Trevor Parscal 9cd05d05a0 Make fieldsets render properly
Depends on I797ec22 in OOJS-UI

Change-Id: I3841bc50346e67dfe92814ebe337fd92365ae1d4
2014-04-15 11:47:15 -07:00