Commit graph

5648 commits

Author SHA1 Message Date
David Lynch d6c71632ef Switching modes created an infinite loop onBeforeUnload
Switching from visual to source reruns setupUnloadHandlers, which caused an
infinite loop where it thought it was its own fallback pre-existing handler.

Bug: T153346
Change-Id: I8df55a5395ede02fc34ec47a94f2c780dc08595f
2017-03-08 11:32:03 -06:00
Translation updater bot b27fe68833 Localisation updates from https://translatewiki.net.
Change-Id: I71344493334c65b08754134fe3bd3202fb72f04c
2017-03-07 23:00:20 +01:00
jenkins-bot f9af257b7e Merge "ve.init.mw.DesktopTarget: Use mw-body-content instead of mw-body to match Vector changes" 2017-03-07 18:32:22 +00:00
Ed Sanders 387f9a5514 ve.init.mw.DesktopTarget: Use mw-body-content instead of mw-body to match Vector changes
This ensures the styles are still applied to surfaces in dialogs.

Change-Id: I30e0cc7dc87dc8c8b6b3be84f821aa22baab457f
2017-03-07 18:17:35 +00:00
jenkins-bot 9a90148d05 Merge "Add external classes to mw:ExtLinks in NWE preview" 2017-03-07 18:17:11 +00:00
Translation updater bot 53cff258cf Localisation updates from https://translatewiki.net.
Change-Id: Id6df97f02c3d04ff546d52afaa98efaa67d5906f
2017-03-06 22:54:27 +01:00
jenkins-bot 81c9b5b032 Merge "Apex: Fix target margins" 2017-03-06 19:22:00 +00:00
Translation updater bot 9062ab75ab Localisation updates from https://translatewiki.net.
Change-Id: Ia42483cea0eaf12517b602850dc2ae362c46b005
2017-03-05 22:54:46 +01:00
Ed Sanders aa8f477dab Apex: Fix target margins
Apex is basically abandonware, so we should consider deleting
this code.

Change-Id: Ie0c21fc21d4c37ab0344978bbd0d071415866397
2017-03-05 18:07:04 +00:00
Translation updater bot a2ef681fd9 Localisation updates from https://translatewiki.net.
Change-Id: I9a379fbf4bf30911eb8f7d796a4f8a94c1622c2b
2017-03-04 23:06:24 +01:00
jenkins-bot 82355461fe Merge "Comment Parsoid hacks as such" 2017-03-03 22:58:25 +00:00
Ed Sanders 8802aa331b Add external classes to mw:ExtLinks in NWE preview
Bug: T153413
Change-Id: I118d3b1794b99ed2d120dd5c5201c1fd18b6245b
2017-03-03 22:46:21 +00:00
Ed Sanders 91822ddbd5 Comment Parsoid hacks as such
Change-Id: I23fcc49031e3b34e5b83d7acea56845b325f3026
2017-03-03 22:41:36 +00:00
Translation updater bot 8a76e9fe81 Localisation updates from https://translatewiki.net.
Change-Id: I538b21eb94aacba63d2ff173e67c18146923ba04
2017-03-03 22:50:06 +01:00
jenkins-bot 5aba0ee22b Merge "Improve NWE new section styles" 2017-03-03 18:06:04 +00:00
jenkins-bot 8d29d962c5 Merge "Cleanup DesktopTarget styles" 2017-03-03 17:54:43 +00:00
Ed Sanders 06fa5166c7 Improve NWE new section styles
* Use <h2> for TextInputWidget to avoid duplicating skin styles
* Fix placeholder colour and font

Change-Id: I36c0b79ec9cbf3fa2ead0541ef5bac4a14a8781b
2017-03-03 11:59:06 +00:00
Translation updater bot d53d15ec41 Localisation updates from https://translatewiki.net.
Change-Id: I3865ee179a56f5eddf123afa31e98ee6d13c4ed8
2017-03-02 23:26:47 +01:00
David Lynch 6cb6933e67 DesktopArticleTarget: Correctly bind section link handler
Since December, the handler now expects to be passed the mode we're switching
to. Since we're filtering for just the edit link and not edit source, we can
hardcode 'visual' here.

Bug: T159374
Change-Id: I160045dd59ff1b4c2d180dbbe37280a1839886df
2017-03-02 11:43:11 -06:00
jenkins-bot 59d52158a9 Merge "MWWikitextStringTransferHandler.test: Don't pass around an invalid doc" 2017-03-02 05:56:23 +00:00
jenkins-bot e55e6d7c99 Merge "MWWikitextSurfaceFragment#convertFromSource: Don't make an invalid doc" 2017-03-02 05:56:22 +00:00
jenkins-bot c537a8f0a2 Merge "ArticleTarget#getWikitextFragment: Optimise no-op" 2017-03-02 05:45:58 +00:00
James D. Forrester 9b4e27a91c MWWikitextStringTransferHandler.test: Don't pass around an invalid doc
Even if it sounds cool, it isn't.

Change-Id: Ib6612bc0ea8d66fc1964b3a782ad56356da65952
2017-03-02 05:43:10 +00:00
James D. Forrester 6fd475e8ec MWWikitextSurfaceFragment#convertFromSource: Don't make an invalid doc
Though neat, this hack to get the internal list doesn't seem to be used
and creates an invalid document (just an internal list with no content,
so the internal list is at the start and the default selection position
is inside it). Instead, use the ve.dm.Document.static.newBlankDocument()
utility function that was made for this use case.

Bug: T153509
Change-Id: Iba5931cb5e3f939a803c1d59fa0d8f30a0513f84
2017-03-02 05:43:03 +00:00
James D. Forrester e0814210e9 ArticleTarget#getWikitextFragment: Optimise no-op
Change-Id: I6b54ae26e26c5ca697848d2534c128fc9c4bc4aa
2017-03-01 19:17:26 -08:00
Bartosz Dziewoński 461f99e9da Document usages of ve.dm.Node.static.suggestedParentNodeTypes
Ed told me this.

Change-Id: I5e3160d3e5c38f9babc133db8977a6e6b8bbd610
2017-03-02 00:11:54 +01:00
Translation updater bot 603a5a6bd9 Localisation updates from https://translatewiki.net.
Change-Id: I99dbcc74f0ff9a76c6463de302ea9fc90045f83e
2017-03-01 22:47:27 +01:00
Ed Sanders 3c0ddc9c69 Cleanup DesktopTarget styles
* Ensure DAT styles are fully scoped to DAT instances
* Ensure that generic desktop target rules are in the correct file
* Remove old unused rules

Change-Id: I466a0547ff9a0fa1102aac0b1e501a6ba6863ca3
2017-03-01 12:38:51 +00:00
jenkins-bot ec897c120b Merge "Pass $overlay to FieldsetLayout and FieldLayout in various places" 2017-03-01 00:35:06 +00:00
Ed Sanders e163a09105 Use more specific event name for switching editor from the toolbar
As we are in the global toolbar event namespace, 'switch' could
mean anything.

Change-Id: I66751faa249710af634ed0fd0c2f2a0bcd872db3
2017-02-28 23:07:54 +00:00
Ed Sanders 109a136bd6 Use pencil icon for editor switcher dropdown
Pencil is the icon we use for 'edit' elsewhere in the UI.
Use the eye icon for the VE tool to specify 'visual'.

Bug: T116417
Change-Id: I12b6bab2a52758685abde04579b274a32d651174
2017-02-28 22:59:51 +00:00
jenkins-bot a61bbb18e3 Merge "Transclusion dialog: Add VE specific rules from OOjs UI" 2017-02-28 21:49:15 +00:00
Volker E 4e4d1da7a3 Transclusion dialog: Add VE specific rules from OOjs UI
Adding VE specific rules from OOjs UI in preparation of removing them
from the library.

Change-Id: I798717b60badb521d28f8f7a7036a99e5a26d61a
2017-02-28 12:24:22 -08:00
Ed Sanders b3989e4f07 Move switching methods to ArticleTarget and fix in mobile
Change-Id: I7796dab5d2a24f9719870abf383925442b787612
2017-02-28 11:47:35 -08:00
Ed Sanders b3cfca5401 MobileArticleTarget: Don't explicitly set menu indicator
It is now inferred from toolbar position.

Change-Id: I9e3ac28aee74599b4b35ac2f870dca2556efb027
2017-02-28 10:37:30 -08:00
jenkins-bot 2e2a5e452c Merge "Use list tool group for editor switching" 2017-02-28 18:33:44 +00:00
jenkins-bot 0070838981 Merge "Use ems for mobile surface font sizes, and add top/bottom spacing" 2017-02-28 18:30:23 +00:00
jenkins-bot 8a12dfd2ee Merge "Update tests to Selenium 3" 2017-02-28 16:04:27 +00:00
Ed Sanders 5ca02bae09 Use ems for mobile surface font sizes, and add top/bottom spacing
Change-Id: Ida827b54a49c427f2fad2de1f634d8c4e4d28154
2017-02-28 15:07:39 +00:00
Ed Sanders cb60db4c7f Use list tool group for editor switching
Bug: T116417
Change-Id: Iadf5a81e2733ab81fe25c686dcd6dad8eac3885c
2017-02-28 15:06:48 +00:00
Željko Filipin f776983204 Update tests to Selenium 3
Bug: T158074
Change-Id: I784fc7bb85f32d5e50b5abb500c51493839ccebe
2017-02-28 14:39:00 +01:00
Translation updater bot df7307c1b8 Localisation updates from https://translatewiki.net.
Change-Id: Iaead1637d6460165edf1282450ba148e48d468a9
2017-02-27 22:40:16 +01:00
Ed Sanders a3433e67fd Move modules loaded from DAT.init/TargetLoader to ResourceLoader
This will make it easier for third parties to load the required
modules for an article-like target.

Also cleanup mobileArticleTarget to better match desktopArticleTarget.

Change-Id: Idb75e2bd99d8cf2c298e101cf92e8af4f85f5ad5
2017-02-27 16:48:56 +00:00
Translation updater bot 4c9bc6ce53 Localisation updates from https://translatewiki.net.
Change-Id: Ia9c63305453091afe7ebd5b5c5361dd2474ab11c
2017-02-26 22:55:11 +01:00
Translation updater bot 49d2dade48 Localisation updates from https://translatewiki.net.
Change-Id: Ie31ed3d14e14a362b890588db76946c2f6567755
2017-02-25 22:44:27 +01:00
Translation updater bot 0f769f9a4c Localisation updates from https://translatewiki.net.
Change-Id: Iea0b0881d660a604f83716425c1d2d38bb474dd1
2017-02-24 22:49:39 +01:00
jenkins-bot a629b62b43 Merge "For the mode switch tool, show a different tooltip when disabled" 2017-02-24 19:23:53 +00:00
James D. Forrester 440a73206d For the mode switch tool, show a different tooltip when disabled
Bug: T158723
Change-Id: I8c397e9b10c51d78c0b0f18c494ca9f36400d23e
2017-02-24 08:49:47 -08:00
Translation updater bot a520037a38 Localisation updates from https://translatewiki.net.
Change-Id: I7f5ea4a13665e807fe98c1f8d68d88536217d439
2017-02-23 23:11:42 +01:00
L10n-bot ce86129067 Merge "Localisation updates from https://translatewiki.net." 2017-02-22 21:53:36 +00:00