Commit graph

5895 commits

Author SHA1 Message Date
Bartosz Dziewoński d687e01208 Do not check for visual editor availability when loading source editor
Follow-up to fefb76eebc. Prior to that
change, the condition for this looked like this:

  // … if on a ?veaction=edit/editsource page
  (
    isViewPage &&
    uri.query.veaction in editModes &&
    (
      uri.query.veaction === 'editsource' ||
      init.isVisualAvailable
    )
  )

In the refactor, the `uri.query.veaction === 'editsource'` check was
lost.

Since that code is pretty messy (probably predating the source editor
and hastily adjusted), instead change the check for `isVisualAvailable`
to just `isAvailable`. If the requested mode turns out to not be
available later, the editor will not load.

Bug: T165146
Change-Id: Idfaf9115dd20cec8f8e044a704b93b07984cdcee
2017-05-16 18:57:56 +02:00
jenkins-bot 4249e7898e Merge "Rename deprecated Card to current TabPanel" 2017-05-16 09:50:42 +00:00
jenkins-bot cfa8de994e Merge "MWTransclusionNode: Implement MWTransclusionTableCell" 2017-05-15 18:05:01 +00:00
David Lynch 0eb6b94b4c MWTransclusionNode: Implement MWTransclusionTableCell
Back in de98382a55, references to MWTransclusionTableCell were introduced,
but weren't followed through on. So, actually add it. Have cellable
Transclusions use it as their type.

Bug: T144122
Depends-On: I054f12f4218102a12d7a9ea843f9c61e8825c52c
Change-Id: I367f878bfd1c58e20b62368cb78120604b48d791
2017-05-15 12:09:11 -05:00
Ed Sanders 63c36c87da Always prefer wikitext for action=edit on non-SET wikis
Ideally we could use the preferred editor, but this breaks
tab switching to the old editor.

Bug: T165238
Change-Id: I5f5ee5566cdd2080ba7c89d43cf127b457537768
2017-05-15 12:48:30 +01:00
jenkins-bot 5e11f1669a Merge "Fix action=edit links for NWE" 2017-05-15 11:06:49 +00:00
Ed Sanders 9342e45f7b Fix action=edit links for NWE
We added support loading NWE from action=edit in I35208cce069
but missed this check in the front-end.

Bug: T165238
Change-Id: I2732eaa81a3f968b34c4e878b2ad36de981dd567
2017-05-15 11:52:06 +01:00
Translation updater bot dd9a7ad9f9 Localisation updates from https://translatewiki.net.
Change-Id: I3becfe7c241e510b558e65a54060d3e93cc907b5
2017-05-14 22:48:41 +02:00
Translation updater bot db24f81138 Localisation updates from https://translatewiki.net.
Change-Id: Ic7ce8924f898681caafe37761384f0f30919fc8c
2017-05-12 23:19:04 +02:00
Translation updater bot 898091bfed Localisation updates from https://translatewiki.net.
Change-Id: Ifa7703be93365df355b7de8db47e878a10b33256
2017-05-11 23:37:50 +02:00
Volker E f695877de7 Rename deprecated Card to current TabPanel
Renaming CardLayout to TabPanelLayout and all connected code instances.
Follow-up to Icfe1652cc038dc131b6b855ce9b45040b8ee5178

Bug: T164903
Change-Id: I9ce4e31e390522d469e126fb3a4b05787cef7fef
2017-05-10 11:46:49 -07:00
David Lynch 2f40972807 MWWikitextDataTransferHandlerFactory: Don't reimplement getText
I forgot about getText in 41ca528705, apparently.

Bug: T163237
Change-Id: Ibb646fc03a0293845c4449cbbe6c822ba63751f8
2017-05-10 10:58:42 -05:00
jenkins-bot 862c3ca22e Merge "MWWikitextDataTransferHandlerFactory: skip getWikitextFragment if possible" 2017-05-10 15:51:16 +00:00
jenkins-bot 24e4cb7d8b Merge "Update VE core submodule to master (fbeb0db2c)" 2017-05-10 15:36:39 +00:00
James D. Forrester 229d6cdf3b Update VE core submodule to master (fbeb0db2c)
New changes:
d61440346 Add logging to the rebase server and client
d1d2539ae rebaser: Add script to convert a log file to a test case
0896d5f05 lib: Update README files for OOjs and OOjs UI
045ae87fb Localisation updates from https://translatewiki.net.
04b276e16 VisualDiff: Make annotation whitespace trimming configurable
dd04912e5 Localisation updates from https://translatewiki.net.
11fc30709 MobileContext: fix button spacing
7898acd0b Fix typos and minor lint issues
4e3e2deb9 Avoid using the global namespace in test files
1ed81efa1 build: Update eslint to 0.4.0 and make a pass

Bug: T163473
Bug: T164166
Change-Id: I4bab4260d6b05ff0277cacd167186336acc02080
2017-05-10 10:02:54 -05:00
Translation updater bot 31bea72f3a Localisation updates from https://translatewiki.net.
Change-Id: I1acf037adbf8456802f4321377b7209cb7268462
2017-05-09 23:10:18 +02:00
David Lynch 41ca528705 MWWikitextDataTransferHandlerFactory: skip getWikitextFragment if possible
This lets us avoid a fraction of a second lag when someone pastes a plain URL
into source mode.

Bug: T163237
Change-Id: I0e673856dec5f273fb92731b27494762299d2d6c
2017-05-09 10:19:15 -05:00
jenkins-bot 0f903b09d1 Merge "Generate visual diff only after switching to visual diff tab" 2017-05-09 13:31:36 +00:00
Ed Sanders debcd678b5 Generate visual diff only after switching to visual diff tab
Bug: T164724
Change-Id: I48e49d4b68cc769b3e9d061983de4c78b5ad5c34
2017-05-09 10:09:39 +00:00
Translation updater bot 4296814235 Localisation updates from https://translatewiki.net.
Change-Id: I24e0b7ee282f937c0e7b1c44798a78439d723b63
2017-05-08 23:01:19 +02:00
Translation updater bot 3e31b869e8 Localisation updates from https://translatewiki.net.
Change-Id: I768ab6f09c49c7d3cdee0f0764a59ac0164bd445
2017-05-06 23:07:00 +02:00
Translation updater bot 021c91811e Localisation updates from https://translatewiki.net.
Change-Id: If05c18f72c4fb8276676c13e145ade05ec309739
2017-05-05 22:54:40 +02:00
Translation updater bot 6f96b1e9d1 Localisation updates from https://translatewiki.net.
Change-Id: Id74033215796baa8238a3635d8cba3fc1b08e0a2
2017-05-04 23:11:44 +02:00
jenkins-bot 75b762d5c4 Merge "Specify suggested parent node types for tables" 2017-05-04 18:50:48 +00:00
jenkins-bot 20465377db Merge "Allow headings in divs" 2017-05-04 18:49:09 +00:00
Ed Sanders 9d83efc747 Specify suggested parent node types for tables
This won't do anything useful until T164017 is resolved.

Bug: T164016
Change-Id: I39bffe2dc59a97888b81bdbe990e55ba95b0dd94
2017-05-04 14:50:49 +00:00
Ed Sanders 485a159037 Allow welcome dialog to be variable height
Bug: T164056
Change-Id: I277a709545151dbd51f92c21d6317a45b1088db2
2017-05-04 13:08:33 +01:00
Ed Sanders 8e6105fec8 Allow headings in divs
Bug: T164453
Change-Id: I986b1b376a592095c94d29a102278d4fde0a621f
2017-05-04 12:43:36 +01:00
jenkins-bot 9b86ebae7f Merge "Follow-up 57a06a6: Use the same attribute name on read and on write" 2017-05-02 22:00:40 +00:00
James D. Forrester 486bbd7609 Follow-up 57a06a6: Use the same attribute name on read and on write
Bug: T164054
Change-Id: I6770f6c91248fcd9ab39322413874e20a1b65552
2017-05-02 14:42:22 -07:00
Translation updater bot eafe281fa3 Localisation updates from https://translatewiki.net.
Change-Id: Ic48e5776fde9b30c47656b01718bbbf764e6b2da
2017-05-02 23:22:42 +02:00
Ed Sanders 54fc920622 Captcha improvements
* Fix focus and resize/scroll into view after the
  captcha has loaded (so after the image has loaded
  for FancyCaptch).
* Add margin between input and captcha
* Enable enter-to-submit on captch input field.
* Unify code for simple/math/questy and correctly
  render math as HTML (by looking at the mime type)

Change-Id: I10433cefbfea8569674c120dde5b489570e20966
2017-05-02 17:49:12 +01:00
Ed Sanders 998ae22b2d Follow-up I488fd7e74: Adjust saveFail calls for new function signature
Bug: T164157
Change-Id: I41b946af5a8b80211b0672d7012835f2c9e1dc2b
2017-05-02 16:39:04 +01:00
jenkins-bot 68d00a6a42 Merge "init: Fix checks for required skin elements to avoid false positives" 2017-05-01 22:37:16 +00:00
jenkins-bot 089d765c0e Merge "Avoid global variables in tests and build" 2017-05-01 15:56:58 +00:00
jenkins-bot dc8935ae41 Merge "MWSignatureNode/Tool: Avoid global variables" 2017-05-01 15:49:37 +00:00
jenkins-bot 13307dd556 Merge "Fix minor lint errors and typos" 2017-05-01 15:49:35 +00:00
Bartosz Dziewoński a02e68374e init: Fix checks for required skin elements to avoid false positives
* Do not try to load the editor on protected pages, or if the user
  doesn't have permission to edit pages.
* Move the check for required DOM elements after the check for
  pages without the editor (T162411) and after DOM ready (T163307).

Bug: T162411
Bug: T163307
Change-Id: I8149694ba8155682701f2cda6ca212d60f446caa
2017-05-01 11:24:01 +00:00
Translation updater bot 99656bae30 Localisation updates from https://translatewiki.net.
Change-Id: I3e87b5b23666918a904d77111c76160fbe3d0a74
2017-04-29 23:31:44 +02:00
Ed Sanders 59b3f2e0dc Avoid global variables in tests and build
Change-Id: I44dd3c3980f88e660798962c4aa0229b62760796
2017-04-29 12:37:53 +01:00
Ed Sanders ede81b493e MWSignatureNode/Tool: Avoid global variables
Change-Id: I0596b33e797830f3718f4edbe34075fdaced0831
2017-04-29 12:37:28 +01:00
Ed Sanders 7c0fc8d3b9 Fix minor lint errors and typos
* Commas that should be semicolons
* Unnecessary 'call's

Change-Id: I11a80702b5396a36e3deecc6e706a397cc354bd8
2017-04-29 12:36:17 +01:00
Translation updater bot 26e155035e Localisation updates from https://translatewiki.net.
Change-Id: Iccbb936fb34cf928fa72cf5d56c1654fe8ce86f4
2017-04-29 00:09:45 +02:00
jenkins-bot bcb62d7907 Merge "Synchronise VE availability checks in frontend and backend" 2017-04-28 17:02:54 +00:00
Ed Sanders cd8b059e7d Synchronise VE availability checks in frontend and backend
Adds better support for NWE loading on action=edit.

Change-Id: I35208cce0696607377378a1b58d426e914a3ba7d
2017-04-28 17:45:27 +01:00
Ed Sanders 381f143a27 QUnit: Remove all code for counting tests
Change-Id: Ifc20282a4da1aed9be2a9215c13f9a4e3e30168f
2017-04-28 17:03:20 +01:00
jenkins-bot 323f2479ea Merge "Add basic support for Parsoid HTML5 video/audio" 2017-04-28 15:26:44 +00:00
Ed Sanders 0c2bb3da9c Add basic support for Parsoid HTML5 video/audio
Change-Id: I30b787261c57e912e571170d8aa2d04726b6aa3a
2017-04-28 14:08:18 +01:00
Translation updater bot c198ea287d Localisation updates from https://translatewiki.net.
Change-Id: If183c1f7a7ddffa4dd2c61a6921ca5ad6f4b6bbe
2017-04-27 22:59:54 +02:00
jenkins-bot 604dc2d86a Merge "MWMediaTransferHandler: Allow uploading of dropped Blobs" 2017-04-27 19:32:42 +00:00