In 92c3055628 I changed `sectionId > 0`
to `sectionId !== '0'`. That was actually a mistake, as Parsoid's
section IDs can be negative, which indicates pseudo-sections, which
may not have headings.
https://www.mediawiki.org/wiki/Specs/HTML/2.1.0#Headings_and_Sections
Bug: T252238
Change-Id: I9133d4365a71d6db1fa58b69ae3b970166d15c1e
New changes:
e946a30cf Localisation updates from https://translatewiki.net.
15f596aa8 Localisation updates from https://translatewiki.net.
d4085dd7d Update principal authors
Change-Id: I5dce4f259ffe28438582f799c41aee7e48db5be4
* Drops Base64.js
Mentions some depedencies of lib/ve as this is the place we
acknowlege them on wiki (Special:Version/Credits/VisualEditor).
Change-Id: Ic54b8a9de9c07ce799e270a5445c58bb4797409e
Previously we didn't deactivate them, so if you opened VE, then
switched to NWE, then exited the editor, all three tabs would appear
active.
Change-Id: I904d6daf2896ceadf004f5e57a88c2359f33fd44
Goals:
* Allow other extensions to reuse these methods (maybe upstream them
to MediaWiki core later)
* Allow ApiVisualEditorEdit to extend ApiEditPage. We'll be able to
reuse its definitions for API parameters instead of duplicating
them, and we won't have to pass around unrecognized parameters.
Bug: T252573
Change-Id: If5c8d95560cbb078ae4980f4a912cbaeafe53d3e
We go through all this trouble to pass the config to the API modules,
and then we don't use it at all (we removed the uses recently in
ce094c72d and d85d30f9b).
If we end up needing the config there again, we can just get it by using
MediaWikiServices::getInstance()->getConfigFactory()->makeConfig( 'visualeditor' )
anywhere we want, like we do all over the place in VisualEditorHooks.
Change-Id: I9d254a9946f0d24783baf68c409b10291a8fd1b3
Code in ve.dm.MWTransclusionNode (which ve.dm.MWSignatureNode extends)
expects the node data to have an 'attributes' property.
We could override a bunch of methods to fix this, or add checks in the
original code, but it seems more future-proof to instead ensure that
the property exists.
Bug: T248585
Change-Id: I5bd721ca73605a396509669145b740db7283afd3
This is now consistent with all other events.
Needed for I9904e8af4a60b0f5e9a6e263cd4fd8e1e3fd1f98.
Change-Id: If52aa9d619eac08456874fc75c0f6e1adff01246
New changes:
42b098042 TargetWidget: Re throw 'submit' event from the surface
163b0b673 TargetWidget: Don't assume surface exists in setReadOnly
Change-Id: I56db786fac487dd282c8bf22a5f29181a74518e4
New changes:
8cc7bc479 Localisation updates from https://translatewiki.net.
6adf65179 lib: Update jQuery from 3.4.1 to 3.5.0
fe3f0d2f8 Update OOjs to v4.0.0
e82f2256d Update OOUI to v0.38.1
0010fd6c0 Localisation updates from https://translatewiki.net.
d1220be78 build: Upgrade karma-related devDependencies to latest
Change-Id: Ia30431823cf8fec93259c6478d6b2c9f3e293038
And factor out the common code for using a preference with a fallback to
localStorage or a cookie.
Bug: T235566
Change-Id: Ibb983319edcd2987225fe89677fd10e3ff8f9df6