Commit graph

16826 commits

Author SHA1 Message Date
Ed Sanders d62fc8b49a Use Array.prototype.forEach.call in copyAttributes
Change-Id: I6c890fecf6f6002d44b32f0c85a3193c0c2632e3
2020-08-18 23:17:03 +01:00
C. Scott Ananian 879f006b7b Fix regression when opening save dialog
DOM attributes are not arrays, and so don't have Array#forEach.

Fixed regression introduced in 4545f53245.

Change-Id: I1f0f44747a0f8a376c1fb7cbb8862c096a9d1dc9
2020-08-18 18:10:31 -04:00
jenkins-bot 970b0faeca Merge "build: Update eslint-config-wikimedia to 0.17.0" 2020-08-18 16:17:10 +00:00
Ed Sanders ac085df47e Create config option for making VE a BetaFeature, off by default
Currently we always register VE as a Beta Feature, and then
expect users to use $wgHiddenPrefs to hide it, hackily.

Also, set this new preference to false so that 3rd party
wikis don't show the BF by default.

Bug: T254349
Change-Id: I92fe3d44bb4d762ca7b1bc693b7d2e74367c84ec
2020-08-18 15:52:51 +00:00
Ed Sanders 4545f53245 build: Update eslint-config-wikimedia to 0.17.0
Fix instances of variable shadowing.

Change-Id: I6e2befb020d7d4b506c7b46131eafacd951aa6d1
2020-08-18 13:16:49 +01:00
jenkins-bot 09ad8d0686 Merge "ve.init.mw.DesktopArticleTarget.init: Update mediawiki.page.ready dependency" 2020-08-18 05:26:38 +00:00
Ed Sanders 42c7096dbf Gallery: Handle invalid titles
Items which are invalid titles will still get discarded if
the gallery is edited, but this is better than crashing.

Bug: T260584
Change-Id: I5dc20c233fd9ab41bdf48531829bddca2c5b25df
2020-08-17 18:22:42 +00:00
jenkins-bot 7d366a3f6a Merge "ApiVisualEditor: Fix 'false' used as content for non-existent system messages" 2020-08-17 12:29:49 +00:00
Translation updater bot 6442f46e5e Localisation updates from https://translatewiki.net.
Change-Id: Ia8100569e5d435574820211b7076cb21d8d33fae
2020-08-17 08:45:07 +02:00
Bartosz Dziewoński 8415d7f7bf ApiVisualEditor: Fix 'false' used as content for non-existent system messages
getDefaultMessageText() returns false when the message doesn't exist.
It was incorrectly treated as a string by this code.

Follow-up to 3ec5e04a37.

Change-Id: Ib94a30697bd20133e46cbd31c14caf5f0c4169dd
2020-08-16 21:06:18 +02:00
Bartosz Dziewoński f712a54384 Update VE core submodule to master (510130eaf)
New changes:
c9e4bc776 Use placeholder name as aria-label
37a4922a7 Localisation updates from https://translatewiki.net.
55a0d0488 Teardown the completion widget when menu is hidden by user

Bug: T253590
Bug: T259277
Change-Id: I7d6e19c45f1dc87d1f4127c75c4812aadd5c5cf5
2020-08-16 20:53:23 +02:00
Timo Tijhof 95d1ea520b ve.init.mw.DesktopArticleTarget.init: Update mediawiki.page.ready dependency
In MediaWiki core, Ic418c23a740 moves mediawiki.page.startup into
mediawiki.page.ready, leaving an alias behind. Once that change lands,
this change is safe to land as well to avoid the indirection and so
that the core alias can be removed swiftly (VE is the only user).

The dependency on mediawiki.page.startup was originally added in
I494b364b485e6 to make sure that accesskey tooltips are computed by
mediawiki.util, before VE initialises (this happened via mw.util.init,
which at the time was called from mediawiki.page.startup.js),
This has all changed a lot in the years since then and might not
actually be needed any more. If that's the case, feel free to remove
the dependency instead.

Depends-On: Ic418c23a7400abba22fd07b17f173d3c5f1d1d10
Change-Id: I250b38a836f28bfb440f19282a9677977f30c615
2020-08-14 23:37:47 +00:00
Translation updater bot 6c8dd899b2 Localisation updates from https://translatewiki.net.
Change-Id: I311205f32b68e4bc985a25d328eac157880fb774
2020-08-14 08:39:58 +02:00
jenkins-bot 0b23c62d7d Merge "Support private wikis in Parsoid zero configuration mode" 2020-08-12 10:11:33 +00:00
Translation updater bot e3dc5953e9 Localisation updates from https://translatewiki.net.
Change-Id: If6d721cad8cf8bb9e87ed55c21551fcc8f0dbf79
2020-08-12 08:20:03 +02:00
Kunal Mehta 45a02ee03e Support private wikis in Parsoid zero configuration mode
Set the 'forwardCookies' flag if the wiki is private (not everyone is
allowed 'read' access).

Bug: T260201
Change-Id: I0b958e8b75c04e4a27f50f91276be221a5b1404d
2020-08-11 16:40:44 -07:00
Translation updater bot 8b5f8988c8 Localisation updates from https://translatewiki.net.
Change-Id: Icbdae0eaa4c591dc86b0dbebd36254ec8ac0977e
2020-08-11 08:21:23 +02:00
jenkins-bot 7d3be3f3a6 Merge "Ignore non-checkbox fields for page saving dialog" 2020-08-10 18:04:44 +00:00
Bartosz Dziewoński 3f5f54264d Update VE core submodule to master (18920ed63)
New changes:
c5496ec1e TargetWidget: Use a white background, not transparent
4efa1529f Support headers in CompletionWidget
fe0ffe6e4 Update devDependencies

Bug: T252084
Bug: T259811
Change-Id: Ic60aaafb1d07db30c72832414e68bba71f5e93df
2020-08-10 18:39:47 +02:00
jenkins-bot 6de167aef6 Merge "Update VE core submodule to master (4b36b447d)" 2020-08-10 11:48:49 +00:00
Translation updater bot 480c379791 Localisation updates from https://translatewiki.net.
Change-Id: I2844a9aa8a23e49e39ab5c093e89764d56f49784
2020-08-10 09:02:21 +02:00
James D. Forrester 48dee93dd6 Update VE core submodule to master (4b36b447d)
New changes:
7cd74c97d Localisation updates from https://translatewiki.net.
84640d0a8 Localisation updates from https://translatewiki.net.
ec14afa43 Update OOUI to v0.40.1

Change-Id: I1a64b9aea121db8340b9d136fb41cb69f6be6d81
2020-08-07 14:51:39 +01:00
Translation updater bot 40e73ac303 Localisation updates from https://translatewiki.net.
Change-Id: I951f17d53aeabebf1d5f4caa57eab8e6fdad2e9e
2020-08-07 08:23:51 +02:00
Sam Wilson 82bfa015ec Ignore non-checkbox fields for page saving dialog
The 'checkbox' part of the edit form is now allowed to contain
non-checkbox form widgets, but these are not yet supported
by VisualEditor. Until they are, this skips them entirely
in order that no broken form field be shown.

Bug: T259546
Change-Id: If62c11b174df235be611b9d32eb28e4759ba5f66
2020-08-07 13:18:41 +08:00
Translation updater bot 065026ed76 Localisation updates from https://translatewiki.net.
Change-Id: I50df5df292f9e097351131ee209055e5e57b002e
2020-08-06 08:28:52 +02:00
Translation updater bot d80d177ba7 Localisation updates from https://translatewiki.net.
Change-Id: I9791ec0e8d6aa371f17812610f4921883619a3f3
2020-08-05 08:23:21 +02:00
jenkins-bot 2f92c6ead6 Merge "French spacing (mw:DisplaySpace) doesn't have mw:Placeholder any more" 2020-08-04 19:17:33 +00:00
Translation updater bot 3072c886ea Localisation updates from https://translatewiki.net.
Change-Id: Ic7bab0f311df98c163d106c056b94abe7439aa60
2020-08-04 08:33:42 +02:00
Ed Sanders 09f4af2a63 CollabTarget: Add close button on mobile
Move comment button into 'insert' menu to make room.

Change-Id: I00ace1477d08041e9af6d81ae2e6635151575f8b
2020-08-03 07:55:06 +00:00
Translation updater bot a218c1b52c Localisation updates from https://translatewiki.net.
Change-Id: I36b86e0a8d1e78269a9c5c1fc0500a1ae3f8ffd0
2020-08-03 08:34:21 +02:00
jenkins-bot 0bff0b186f Merge "MobileArticleTarget: Move MWBackTool to a separate file" 2020-07-31 16:40:19 +00:00
jenkins-bot 6ce3318d18 Merge "ExportWikitextDialog: Make height of wikitext input fit dialog" 2020-07-31 16:40:16 +00:00
jenkins-bot da9b811214 Merge "ExportWikitextDialog: Add explicit editfont dependency" 2020-07-31 16:40:14 +00:00
jenkins-bot b3eca2075e Merge "Make import button progressive (but not primary)" 2020-07-31 16:38:15 +00:00
Ed Sanders dd862a837d MobileArticleTarget: Move MWBackTool to a separate file
Change-Id: I1561f454bcc779f97c758ba7178b09d15f52fe42
2020-07-31 16:15:10 +00:00
Ed Sanders 76cea9b235 ExportWikitextDialog: Make height of wikitext input fit dialog
Change-Id: If60dc55a442ffb255248d3bf5c3e1d0e14b2821f
2020-07-31 16:27:27 +01:00
Ed Sanders 61edb5c2f7 ExportWikitextDialog: Add explicit editfont dependency
Change-Id: I74e3dd7a78093dd52b5ae6b0474ff3c1e1712775
2020-07-31 16:14:38 +01:00
Ed Sanders b32a066bbf Make import button progressive (but not primary)
Change-Id: I38136b05f59eb5a2ad59d4aee4f560289d02e1a6
2020-07-31 16:10:05 +01:00
Ed Sanders f57cfef00f Update VE core submodule to master (0866080cf)
New changes:
0866080cf GCN: Don't try to resolveAttributes when rendering.length=0

Change-Id: Iede8756df1fc98d72964871cc1c798b3d5803d02
2020-07-31 15:34:08 +01:00
jenkins-bot 31d7b7efa2 Merge "Special:CollabPad: Replace getPageClasses as if the page were an article" 2020-07-31 13:40:10 +00:00
Ed Sanders 341e86decb Special:CollabPad: Replace getPageClasses as if the page were an article
This stops Vector2 treating the page as a special page where
fixed width doesn't apply.

Change-Id: I4dfed639cfc46be565e491d0df7375e3248e1602
2020-07-31 13:36:04 +01:00
Translation updater bot 4fb995ba58 Localisation updates from https://translatewiki.net.
Change-Id: I41343c3a4e22386a0ee3f49470dbe32f60cdbe1b
2020-07-31 08:46:51 +02:00
jenkins-bot d377cbe9d1 Merge "Use mw.cookie instead of jquery.cookie" 2020-07-30 22:36:46 +00:00
David Lynch deb218aeec Use mw.cookie instead of jquery.cookie
jquery.cookie is no longer maintained, and we're coming up on maybe
running into issues with sameSite which jquery.cookie doesn't support.
Moving to mw.cookie will let us centralize that fix.

Also, removed some dependencies on jquery.cookie in code that doesn't
seem to ever use it.

Bug: T252597
Change-Id: I8634cfd42c2a5ab3c9d712417a7d1a55508274fd
2020-07-30 17:07:40 -05:00
jenkins-bot 42c533cfdd Merge "Follow-up I0a1a889: Show user uploads in gallery dialog" 2020-07-30 17:10:02 +00:00
Ed Sanders 69d8a195e5 Follow-up I0a1a889: Show user uploads in gallery dialog
Gallery dialog should behave the same as media dialog.

Bug: T62398
Change-Id: I601df9370b82868ba981e415fe24bd4f29399cdb
2020-07-30 17:01:04 +01:00
Ed Sanders ec872093aa ExportWikitextDialog: Add help text
Change-Id: I5508c167aa8119eb86356858fc0eedf69cc093bf
2020-07-30 16:43:59 +01:00
Ed Sanders a9d7884d3b ExportWikitextDialog: Add ellipses to "Export" buttons
This indicates these are not the final actions in the process.

Change-Id: I88227a1025f56ea59ef76a59b81cde22e81a959a
2020-07-30 16:23:02 +01:00
Ed Sanders 3ebcf5695d ExportWikitextDialog: Add copy button to wikitext
Change-Id: I8ed63a0ac38a812b09e51738b25b6b384ba30c04
2020-07-30 16:17:32 +01:00
Ed Sanders d8a0f475e4 ExportWikitextDialog: Fix title comparison
getImportTitle may be null

Change-Id: I04d3504e1b4d815859d3ea57fb846ea2277ee5fa
2020-07-30 16:17:32 +01:00