wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 11:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Don't log VEFeatureUse from DiscussionTools"

Browse source
This commit is contained in:
jenkins-bot 2020-05-18 17:54:13 +00:00 committed by Gerrit Code Review
parent b9e793d3b7 92f4e5432e
commit 5b21c5b67a
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
modules/ve-mw/init/ve.init.mw.trackSubscriber.js
View file

@ -224,8 +224,15 @@
return;
}
if ( ve.init.target && ve.init.target.constructor.static.platformType === 'phone' ) {
// handled in MobileFrontend for session-identification reasons
if ( ve.init.target && (
ve.init.target.constructor.static.platformType !== 'desktop'
) ) {
// We want to log activity events when we're also logging to
// EditAttemptStep. The EAS events are only fired from DesktopArticleTarget
// in this repo. As such, we suppress this unless the current target is at
// least inheriting that. (Other tools may fire their own instances of
// those events, but probably need to reimplement this anyway for
// session-identification reasons.)
return;
}