Commit graph

5396 commits

Author SHA1 Message Date
Ed Sanders 8bca6cc777 Inherit more functionality from core source mode
Change-Id: Id027681ab5f0c9f4b9ed127b583e45f0fe57ce69
Depends-On: I02f3849027a6652701c2d354d1b77ece9d1a56c1
2016-12-01 18:44:54 +00:00
James D. Forrester a835f4f9d5 Use canonical ve.dm.TransactionBuilder.static.newFrom* methods
Change-Id: I082048a677baa2699d94e21548373952d52db61b
2016-12-01 10:43:10 -08:00
Ed Sanders 218742d806 Update VE core submodule to master (ae30d71)
New changes:
f58ddea DiffElement: Use document slices with full internal lists
83800c0 DebugBar: Remove hard-coded i18n
b4f89e1 Update OOjs UI to v0.18.1
40c7bf6 Factor out active node functionality from SectionNode for captions
2d967be Move 'mode' property to surface, rename target property to 'defaultMode'
5d8c214 wrapAllNodes in sourcefragment
dd3d9e5 Refactor ve.dm.Transaction
9d61aca Use canonical ve.dm.TransactionBuilder.static.newFrom* methods
df4f72a Make table caption node an active node
b79f72d Core source mode
7533ac4 Localisation updates from https://translatewiki.net.
ae30d71 SourceSurfaceFragment: Check range is not collapsed

Local changes:
Get edit mode from surface where possible

Depends-On: Iec758c1892d518ad4bc2c0d1aaf6ca00fa354323
Change-Id: Ifaf6a26078b2731b374aaad2cb40c08928de9c84
2016-12-01 10:40:01 -08:00
jenkins-bot 551b6db912 Merge "Fix "Add new image" button in the gallery dialog" 2016-12-01 00:25:49 +00:00
jenkins-bot be4c0df032 Merge "i18n: Kill last two uses of 'parameter' in lieu of 'field'" 2016-12-01 00:19:30 +00:00
Thalia 4b9d1bed4f Fix "Add new image" button in the gallery dialog
Make sure the button is always visible in the
gallery dialog menu by fixing it to the bottom.

Bug: T151506
Change-Id: I560b0dffbaad9e18c6f7f703cb155356470580ee
2016-11-30 22:38:11 +00:00
jenkins-bot b6a468d0ff Merge "Clearer English for visualeditor-preference-newwikitexteditor-description" 2016-11-30 22:30:13 +00:00
Amire80 d561894db6 Clearer English for visualeditor-preference-newwikitexteditor-description
Change-Id: I698822637a212e4462c563cdf43e9b192459671b
2016-11-30 23:59:08 +02:00
Translation updater bot 2edf528f0f Localisation updates from https://translatewiki.net.
Change-Id: Ia83483409e59132a73cfce630a9f3ad6c00fb2a4
2016-11-30 22:22:29 +01:00
Ed Sanders 37910b78ec MWTemplateTitleInputWidget: Use new #getApi method from upstream
Depends-On: I81811cdd1a0750a8335432eee8f971ab9e0b8ee7
Change-Id: Ic73213df5ede6f82de85df8b69c60dd31f033792
2016-11-30 19:51:45 +00:00
Bartosz Dziewoński 491ecfe1d6 ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links
Bug: T151646
Change-Id: I693b190f762d93ffae0aa939ffc9550e567e8e24
2016-11-30 19:07:50 +01:00
Translation updater bot fd3e5f8398 Localisation updates from https://translatewiki.net.
Change-Id: Ib42d0dd37389381817efaefda3780bef0867db16
2016-11-29 22:25:32 +01:00
jenkins-bot 745e919f97 Merge "Update VE core submodule to master (9625e8f)" 2016-11-29 20:46:54 +00:00
James D. Forrester 32c966db97 i18n: Kill last two uses of 'parameter' in lieu of 'field'
Change-Id: I94fa70b17a210391b0444aca22c577b2e5e549e3
2016-11-29 12:08:35 -08:00
jenkins-bot 33db54ef28 Merge "Use upstream media search widget from core" 2016-11-29 20:04:46 +00:00
Ed Sanders aeafa6afca Update VE core submodule to master (9625e8f)
New changes:
f1297b8 [BREAKING CHANGE] Allow target widgets to be re-used

Local changes:
Re-use target widgets

Change-Id: I5decb918f398704d4b6c108a16fbc1cc073ef077
2016-11-29 11:48:15 -08:00
jenkins-bot 28a4b9f362 Merge "Handle missing pipes in Gallery syntax, and remove them when caption is empty" 2016-11-29 19:27:52 +00:00
Ed Sanders 44fee9b61d Wait until search panel is shown before setting a search query
Bug: T151659
Change-Id: I3eb3b903a8df1c7732da2a08e4b46b13b162617e
2016-11-29 11:13:54 -08:00
Ed Sanders 2ee9e62a4d Use upstream media search widget from core
Bug: T140166
Depends-On: If53ef7f4b62c7a5d4da565c14dd2a353778694e5
Change-Id: I28845e9c143e78d3a377f067606c62da212e3bf1
2016-11-29 17:19:14 +00:00
James D. Forrester ba232c9f75 2017 Wikitext Editor: Tweak Beta Feature i18n to be less expansive
Change-Id: Id9afdf27707f246a6c2f0fd69b92d239df88924b
2016-11-28 16:55:14 -08:00
Translation updater bot 986abb0d0f Localisation updates from https://translatewiki.net.
Change-Id: I54d71688837784c502dcb6d1615312986694a093
2016-11-28 22:33:50 +01:00
Ed Sanders 240ec23113 Handle missing pipes in Gallery syntax, and remove them when caption is empty
Bug: T146190
Change-Id: I703bcdf68b9631a47d839baf3abb42ff98b36bf2
2016-11-28 17:36:29 +00:00
Translation updater bot f2c444c1bd Localisation updates from https://translatewiki.net.
Change-Id: Ife8e7e01743c51b22ffacd8ac234434652bf3b10
2016-11-27 22:34:20 +01:00
jenkins-bot 6bcfed97a5 Merge "Separate out ArticleTarget as a module" 2016-11-26 23:22:32 +00:00
Translation updater bot 6e0ce959d6 Localisation updates from https://translatewiki.net.
Change-Id: I1ae8c3ead28026b79997175563d0a57175d39900
2016-11-25 22:55:55 +01:00
Translation updater bot 3991a12bfe Localisation updates from https://translatewiki.net.
Change-Id: Ica8875aafaf70d8ea6ae94a7eff98edf66de4108
2016-11-24 22:23:28 +01:00
Ed Sanders 4fe6be1f34 Separate out ArticleTarget as a module
Also move save button command help registration to ArticleTarget.

Bug: T151096
Change-Id: I941d17254a2e20a82aa46fd538abf887d757c0c3
2016-11-24 12:35:41 +00:00
jenkins-bot 1909c445bb Merge "Allow the gallery dialog to insert duplicate images initially" 2016-11-24 04:13:03 +00:00
Ed Sanders 0334263718 Missing i18n in gallery dialog
Change-Id: I369d5b9d42a5fd6b4d1afc12508632a282591320
2016-11-24 00:09:49 +00:00
Translation updater bot 10d348af8b Localisation updates from https://translatewiki.net.
Change-Id: Ie8f35a953ffb6e24acd7aa555b2cad555ee6e9f6
2016-11-23 22:41:42 +01:00
jenkins-bot fde5c3c2ff Merge "Follow-up I63ab27cb: Get rid of notices tool when there are no notices" 2016-11-23 01:17:42 +00:00
Thalia 003ec7b653 Allow the gallery dialog to insert duplicate images initially
Change I94f4fadd84cd3e prevents the gallery dialog from inserting
duplicate images into the gallery dialog after one request (e.g.
so double-clicking on an image in the search widget doesn't cause
the image to be inserted twice). However, galleries can
intentionally contain duplicates of the same image, so it is
possible to make a spearate request to insert a duplicate image.

When the dialog is first opened, it requests all the images in
the gallery at once, so the above change was causing the
duplicates in an existing gallery to be dropped. Duplicates
should be allowed to be inserted following this initial request.

Bug: T150894
Change-Id: I34353bc9b8db947488474c4be52292e0a1447705
2016-11-23 01:02:35 +00:00
jenkins-bot 508b4164bd Merge "Let gallery dialog handle unprefixed filenames" 2016-11-23 00:33:39 +00:00
Alex Monk b89a6ee463 Follow-up I63ab27cb: Get rid of notices tool when there are no notices
Bug: T151423
Change-Id: I3dd9d2cbfb1fa536490eb8b4b7d630e9c6cfdd48
2016-11-23 00:30:06 +00:00
Thalia 2364f530a3 Let gallery dialog handle unprefixed filenames
The namespace prefix before image filenames is optional
in galleries, but the API requires it. If the prefix is
omitted, add the file namespace prefix.

Change-Id: I3d126550c2ad2e84454122f92307ba4bc943780b
2016-11-23 00:20:32 +00:00
jenkins-bot 3d8a749cf2 Merge "init: Initialise 'active' property in mw.Target instead of subclass" 2016-11-22 23:35:10 +00:00
jenkins-bot 8370b98e3f Merge "Move around code that sets up edit notices to ensure it runs after we receive the notices to display" 2016-11-22 23:27:26 +00:00
Alex Monk 16e294fba7 Move around code that sets up edit notices to ensure it runs after we receive the notices to display
Bug: T151236
Change-Id: I63ab27cb236169f300295b2ed4c88e01048092e7
2016-11-22 19:16:09 +00:00
Timo Tijhof cde3d2a7f8 init: Initialise 'active' property in mw.Target instead of subclass
This is set to 'true' in mw.Target#setupSurface(), but not initialised or
used there in that class.

It was previous initialised in an indirect subclass (DesktopArticleTarget).
Move this to the parent class instead for clarity.

Change-Id: Ie3e12d254aa4b689fdce64620e110164311bc60a
2016-11-21 18:06:52 -08:00
Ed Sanders 7f2d5b5bee Don't re-bind edit tab in DAT when using SET
In SET the tab's events are already bound in DAT.init.

Bug: T151258
Change-Id: I04529dbdea2d2ff5e52b0f11035a4ac11946617b
2016-11-21 22:09:26 +00:00
Translation updater bot 0757c5e242 Localisation updates from https://translatewiki.net.
Change-Id: I70248fdc2480098dd966d59db36306e2e923cb77
2016-11-21 22:42:09 +01:00
Ed Sanders 6e64fba2f8 Unbreak education popup
Tools only setup once now, and that is during the dummy surface
phase, so we have to setup the education popups then.

Change-Id: Idf46fe42c893c0692dc442226297253074ef9bd7
2016-11-21 15:19:58 +00:00
Translation updater bot 01cefc47db Localisation updates from https://translatewiki.net.
Change-Id: I21e87c04625b6c87ac50ebcf8c014e6d2e29ed92
2016-11-20 22:21:47 +01:00
jenkins-bot 8fd396151c Merge "Migrate DesktopWikitextArticleTarget code upstream" 2016-11-20 03:06:55 +00:00
Ed Sanders e1a887ccf8 Migrate DesktopWikitextArticleTarget code upstream
Change-Id: Icca4715411737a561302b44b127d91d117e7e29b
2016-11-20 02:52:14 +00:00
Translation updater bot 0b257c12db Localisation updates from https://translatewiki.net.
Change-Id: Ie9a1877be552d5492c483cc7cb2468eba901212f
2016-11-19 22:08:59 +01:00
Translation updater bot f64099f7cb Localisation updates from https://translatewiki.net.
Change-Id: I314c1b19bc52e114055039301bf97ee7b4e0c36e
2016-11-18 22:17:43 +01:00
Translation updater bot dc0b0ea97a Localisation updates from https://translatewiki.net.
Change-Id: Idf5ec60855a5539b916f7a14aa44aea1e145600a
2016-11-17 22:56:27 +01:00
jenkins-bot c790944eb0 Merge "Setup htmlBlacklist and add rule for read-mode MW references" 2016-11-17 17:30:45 +00:00
Translation updater bot 59b4c5910c Localisation updates from https://translatewiki.net.
Change-Id: I856a87673d7e11bc10d2e240d506a816729e2bad
2016-11-16 22:54:25 +01:00
Alex Monk 86719eb90f Prevent endless error loop if falling back to wikitext (after a load failure) fails.
Change-Id: Id48fa13a33aee9fabf857d20a75d26463c329f44
2016-11-16 18:52:26 +00:00
jenkins-bot 51adc1b37f Merge "Fix handling of failure to load visual mode" 2016-11-16 18:48:16 +00:00
jenkins-bot 3483055c29 Merge "Remove max-width from save summary" 2016-11-16 17:55:35 +00:00
James D. Forrester f24e34de3c build: Bump eslint-config-wikimedia to v0.3.0 and make pass
Change-Id: I7449c11aa63c50fda667265c32021439cc53471f
2016-11-15 15:05:05 -08:00
jenkins-bot 65604802ac Merge "Fix attribute.style typo in gallery dialog" 2016-11-15 22:09:57 +00:00
Translation updater bot dccb137e0e Localisation updates from https://translatewiki.net.
Change-Id: Ia94028500a1e833f991162fb716b1bb7cbd9c6ef
2016-11-15 23:02:26 +01:00
Ed Sanders 134477a840 Setup htmlBlacklist and add rule for read-mode MW references
Logically depends on If1b20fefe4b.

Bug: T150418
Change-Id: I0e2249b64f3b452c0322e7a20515ee7b2b6c6f60
2016-11-15 17:20:17 +00:00
jenkins-bot 019aee30d4 Merge "Always set mode when activating the target" 2016-11-15 16:07:50 +00:00
jenkins-bot 961f59d8ce Merge "Normalise filename after image is chosen in gallery dialog" 2016-11-15 12:55:21 +00:00
Ed Sanders ff4761bbd9 Fix handling of failure to load visual mode
Reject the activating deferred making handleLoadFailure
redundant.

Fix logic for switching back to OWE aware of NWE.

Change-Id: I328fc944bb6b9152752742fe35c56b95e3255b88
2016-11-15 12:44:38 +00:00
Ed Sanders b4ff55a38c Always set mode when activating the target
Otherwise if the target was already loaded the mode will
not be changed, which can cause the wrong editor to load
in multi edit tab mode.

Change-Id: I64071dfdfc8511cce51bda20b9c62d7fc126c528
2016-11-15 12:44:38 +00:00
Ed Sanders 521c3c8436 Pass isModified when switching from VE to NWE
Bug: T150707
Change-Id: I9ae525aa7a5883bb45f91262db8abc082983ee1b
2016-11-14 23:05:21 +00:00
Thalia 97af378bb5 Fix attribute.style typo in gallery dialog
Change-Id: I71162652df5e09c4d974e0f863ea661c4bd7902e
2016-11-14 22:26:39 +00:00
Thalia 810202395e Normalise filename after image is chosen in gallery dialog
Bug: T150638
Change-Id: Iead7d0d3f8aa6c864dc6fba7089bab0767035812
2016-11-14 22:04:25 +00:00
Translation updater bot cd681d4bf4 Localisation updates from https://translatewiki.net.
Change-Id: I26e9cc640152465d37f834bf9c83d30497c6e2b4
2016-11-14 23:02:39 +01:00
Brad Jorsch 26e24c2d09 Update for API error i18n
See Iae0e2ce3. Since VisualEditor master requires core master, this just
depends on the master patch instead of trying to maintain BC.

Depends-On: Iae0e2ce3bd42dd4776a9779664086119ac188412
Change-Id: I0e802a47302725f062334a437bff84e3b2b8b9a6
2016-11-14 12:47:01 -05:00
jenkins-bot 0c1eff31ef Merge "Teardown the toolbar properly" 2016-11-14 17:26:54 +00:00
Translation updater bot 82b8afafc7 Localisation updates from https://translatewiki.net.
Change-Id: I4471a9107521394ae38e4b0fdd06cac730c7656b
2016-11-13 22:57:35 +01:00
jenkins-bot 6215f9a1bb Merge "eslint: Re-enable wrap-iife and partially enable dot-notation" 2016-11-12 23:43:32 +00:00
Translation updater bot 3dfe9de109 Localisation updates from https://translatewiki.net.
Change-Id: I1c9a170ee3c6e466731c4725a7ee81b064f2f9a1
2016-11-12 22:59:42 +01:00
Ed Sanders 37ccaca2ec eslint: Re-enable wrap-iife and partially enable dot-notation
Change-Id: I4420d66f528dcb18ebe2b9f63996661b2969f833
2016-11-12 14:43:43 +00:00
Ed Sanders f2e0b408b4 Teardown the toolbar properly
Depends-On: I53a86bf5e0322dc9766ae4ddf31ff0ae5568df7e
Change-Id: If9cc876a57272679584ebc653cf2ee8e17ddb821
2016-11-12 14:28:11 +00:00
jenkins-bot cf3c972a3a Merge "Move NWE URL changes into JS" 2016-11-12 00:02:50 +00:00
L10n-bot 62fc7e1b9b Merge "Localisation updates from https://translatewiki.net." 2016-11-11 22:03:58 +00:00
Translation updater bot 71b1c8af06 Localisation updates from https://translatewiki.net.
Change-Id: I55094810442134b6e688fe972c06ce42dfb15cb8
2016-11-11 23:01:14 +01:00
Ed Sanders b1b6f9836e Remove redundant narrow-threshold calculation
This is done upstream in OOUI.

Change-Id: Icc0e535f9d1113a14d2c1cc275efebbc98e3a38c
2016-11-11 18:54:30 +00:00
Alex Monk 807cb6b54e Move NWE URL changes into JS
Bug: T148077
Change-Id: Ic9b94184a48026254cf4a0a812fe6fc8455841b5
2016-11-11 18:31:22 +00:00
Ed Sanders 6f8e0d9699 Replace confirm with OO.ui.confirm
Also enable no-alert eslint rule to prevent alert/confirm/prompt
being used in the future.

Change-Id: I2851e1f58c1861f75dbb20192e5cf6c343da75db
2016-11-11 13:13:58 +00:00
jenkins-bot 95a8b8a30e Merge "Use a blank temp document when selection is empty" 2016-11-11 00:29:22 +00:00
Ed Sanders 003c5ac410 Use a blank temp document when selection is empty
shallowCloneFromRange can a broken document if you pass
a collapsed range. That should be fixed upstream but for
now this fixes a major bug (and is faster).

Bug: T150492
Change-Id: I9b539c588d91ef7f22e662c7cae0b3f89b21d33a
2016-11-11 00:08:11 +00:00
Translation updater bot 0b7f19e941 Localisation updates from https://translatewiki.net.
Change-Id: I18ad56399a23642d42db319d9c274c6b687a0513
2016-11-10 23:36:34 +01:00
James D. Forrester 26e7267f02 ArticleTarget: Use an OOUI MessageDialog, not window.alert()
We should avoid using alert()s as much as possible due to their unhealthy
interaction patterns with any other open tabs or user tasks.

Change-Id: Ib6a217c988322ad17bc7e649c3281eb053b54bbc
2016-11-10 12:55:49 -08:00
jenkins-bot 5ac488ba53 Merge "Revert "Temporarily override broken toolbar border colour"" 2016-11-09 21:49:54 +00:00
Translation updater bot aa1cb54a20 Localisation updates from https://translatewiki.net.
Change-Id: I8bb4d91acd719bc94ac20fa0e02220162e880c48
2016-11-09 22:45:52 +01:00
Jforrester dc8171d100 Revert "Temporarily override broken toolbar border colour"
This reverts commit 4c8a97f9e8.

[Pending next OOUI release.]

Change-Id: I890a7081ffa7c015bd32466fa88d61e3f38af4e6
2016-11-09 20:48:58 +00:00
jenkins-bot de72f77b1b Merge "Collapse to end after inserting WT signature" 2016-11-09 20:00:05 +00:00
James D. Forrester 79befe3d67 MWExtensionWindow: Use #setDir, not the removed #setRTL
Change-Id: I4090fa0375a93e095a644538b52853fd849b8749
2016-11-09 11:13:09 -08:00
Ed Sanders 1cb4c27378 Collapse to end after inserting WT signature
Bug: T150320
Change-Id: I06a8304499d92d0155c112449678fef34dc98424
2016-11-09 15:26:44 +00:00
jenkins-bot 28787b0f3c Merge "Rename methods used for setting up multiple edit tabs" 2016-11-09 00:45:01 +00:00
Translation updater bot 98fdfb3174 Localisation updates from https://translatewiki.net.
Change-Id: I0d1b052032dda69430e083751ee83934bae616e8
2016-11-08 22:50:21 +01:00
jenkins-bot 45a75047fa Merge "Move save dialog checkbox code up from DAT into ArticleTarget" 2016-11-08 17:14:45 +00:00
jenkins-bot d972d3f4f2 Merge "Hacks to get VE loading on mobile while user has NWE enabled" 2016-11-08 17:14:44 +00:00
jenkins-bot efb4133119 Merge "Use onEditTabClick handler in SingleEditTab" 2016-11-08 17:10:06 +00:00
Ed Sanders 55fcded32e Replace non-standard whitespace in comments
This is required to pass eslint:recommended.

Change-Id: If8c4876a366e5c021c414e54328ed1913b679969
2016-11-08 14:15:12 +00:00
Ed Sanders 2fa4cfef16 Rename methods used for setting up multiple edit tabs
Change-Id: I71d6dd0848e9cc3ee8531b0b914c29219b4697bd
2016-11-08 12:47:30 +00:00
Ed Sanders f6a205d77f Use onEditTabClick handler in SingleEditTab
Gives us extra functionality like  checking for
isUnmodifiedLeftClick which makes CTRL+click on SET
not change the current page, as expected.

Change-Id: Icb37d7383374ee63798443659a2bcb2f1545c8c5
2016-11-08 12:39:15 +00:00
Ed Sanders 526b2c0656 Remove max-width from save summary
Prevents mis-alignment of textbox and checkbox bar
on mobile.

Change-Id: I33d8a2bd4e30d2ed4d61942a7646299f9935bc32
2016-11-08 10:29:03 +00:00
jenkins-bot 8336720a5f Merge "Remove 'vesection' parameter" 2016-11-08 10:26:53 +00:00
Translation updater bot b2a60edf8a Localisation updates from https://translatewiki.net.
Change-Id: If90be9fb65286254cd6b386e931eb5093134e043
2016-11-07 22:40:27 +01:00
jenkins-bot 6f4ff421fc Merge "Clarify wording of __NOINDEX__ option in VisualEditor" 2016-11-07 18:54:10 +00:00