Commit graph

16028 commits

Author SHA1 Message Date
Bartosz Dziewoński ca3c887e36 Fix loading icons for historical diff mode switcher
The 'eye' icon is in the 'accessibility' pack, not 'alerts'.
Compare to the dependencies of 'ext.visualEditor.diffPage.init'.

Change-Id: Ie14ab6be756fd9e0bef59475466674a41273046f
2019-10-01 03:31:27 +02:00
jenkins-bot 73a92d847d Merge "ArticleTargetEvents: clean up some duplication" 2019-09-30 23:49:27 +00:00
jenkins-bot 78ed28fbf0 Merge "Update VE core submodule to master (084bdb77e)" 2019-09-30 18:09:46 +00:00
jenkins-bot 4d1d9677b5 Merge "Fix mw:MediaLink support" 2019-09-30 17:14:34 +00:00
David Lynch 651e00d529 ArticleTargetEvents: clean up some duplication
Change-Id: Ied2851f9d77d055db9fc22668b963a01ca098a95
2019-09-30 11:29:01 -05:00
James D. Forrester 3c9a8fe7f5 Update VE core submodule to master (084bdb77e)
New changes:
db8c96bc9 Localisation updates from https://translatewiki.net.
084bdb77e Localisation updates from https://translatewiki.net.

Change-Id: I527846592bc8f36c6e8197d3b861db96a1904ca7
2019-09-30 08:24:05 -07:00
Translation updater bot a70c9f4c1a Localisation updates from https://translatewiki.net.
Change-Id: I9899dde1be23258efba26d482e2315263f94b419
2019-09-27 09:22:04 +02:00
Translation updater bot 4d4228f7ad Localisation updates from https://translatewiki.net.
Change-Id: I217c3cf42562c1e12bb5785395e2243ec300eace
2019-09-26 09:15:40 +02:00
Bartosz Dziewoński e472a4bbd3 Fix mw:MediaLink support
* Handle mw:MediaLinks pointing to to non-existent files, which come
  with typeof="mw:Error" (similar to image nodes).

* Fix regression from c66f8e0547, which
  caused all mw:MediaLinks to be treated as plain external links again.

* Add test cases.

Bug: T232754
Change-Id: I9ae5bcfc4e24e8c0d22ef77d6a4d03f817fc9768
2019-09-24 22:46:03 +02:00
Translation updater bot 8e55547e4c Localisation updates from https://translatewiki.net.
Change-Id: Iba96ba8ec5658722dff777f62a3c906c748c83a4
2019-09-23 09:27:23 +02:00
TheSandDoctor 70e3e7cc8b VisualEditor: Replace deprecated editToken with csrfToken
The editToken key of mw.users.tokens is deprecated since MediaWiki 1.27.

Bug: T233528
Change-Id: I7297e6abb159e9bb758859454b1097292e607117
2019-09-22 10:22:01 -07:00
jenkins-bot 7f7cf6ce79 Merge "MWInternalLinkAnnotationWidget: adjust the input for relative links to subpages" 2019-09-20 11:23:40 +00:00
Translation updater bot 3193fc2543 Localisation updates from https://translatewiki.net.
Change-Id: I38e4369baaae5b2fa42527e287304e45b0895bf1
2019-09-19 10:00:31 +02:00
jenkins-bot 2de131d561 Merge "build: Update linters" 2019-09-18 18:44:54 +00:00
Ed Sanders 3bb8710715 build: Update linters
Change-Id: If2a45c63f435911ebd7a83df9c0723d45c040a5e
2019-09-18 19:11:45 +01:00
Bartosz Dziewoński 62f1deba4b Update VE core submodule to master (a817f9b0d)
New changes:
a817f9b0d TreeModifier: Never check originalDomElementsHash equality

Change-Id: I4f6a7325711b199e86bd997dcf795c01d569ef16
2019-09-18 19:54:18 +02:00
jenkins-bot 067ec50ff8 Merge "MWSaveDialog: add more instrumentation" 2019-09-18 15:13:10 +00:00
Bartosz Dziewoński ece13d7e16 Update VE core submodule to master (81e2e57a5)
New changes:
6bbfd9ecc Split TreeModifier into a tree diff generator and tree diff applier
f55f042dd TreeModifier: delete text nodes emptied by moveText operations
d7ccb2442 ve.ui.Surface: Fix check for active virtual keyboard in #adjustVisiblePadding
a9d533280 Localisation updates from https://translatewiki.net.
73a166cb0 build: Upgrade eslint-config-wikimedia from 0.13.1 to 0.14.0
077aaed03 build: Upgrade grunt-banana-checker from 0.7.1 to 0.8.1
81e2e57a5 Unwrap a solitary paragraph from data transfer items

Bug: T215567
Bug: T217769
Bug: T232942
Change-Id: Id943b49dd58a12553ddc19dcf8abcfb8e8a5b712
2019-09-17 20:44:54 +00:00
David Chan c4cb88aded Don't unwrap a solitary paragraph in Wikitext string transfers
This meant we were returning invalid documents with bare content outside
content branch nodes. Instead let ve.ce.Surface in VE core do the unwrapping.

Bug: T232944
Depends-On: I8799d51958b966c99307f4c70546ea326e67385c
Change-Id: I0479116b51cc3135a992fdf36b8edfb2c44916ba
2019-09-17 20:44:45 +00:00
Timo Tijhof aae62a87be Remove cache group setting from styles modules
Follows-up 35eead0f3. This caused an extra stylesheet and HTTP
request to be added to all page views, because
'ext.visualEditor.desktopArticleTarget.noscript' is a styles
module, which should be allowed to join the regular batch.

Also remove it from other styles-only modules known to be loaded
with addModuleStyles().

Bug: T233095
Change-Id: Iea1f33199ec8dc83a42ac7102595a033300e33e6
2019-09-17 19:06:23 +01:00
Translation updater bot 3da0f705d7 Localisation updates from https://translatewiki.net.
Change-Id: I9ca9d6cb298337d777e5e1b967d93344a98e42be
2019-09-17 09:10:26 +02:00
Bartosz Dziewoński f7cbbc9e81 Update VE core submodule to 509eeaa1
New changes:
e31dae794 Update OOUI to v0.34.1
fa584b5c6 Localisation updates from https://translatewiki.net.
06548e806 ve.ce.Surface: Actually default to showAsActivated=true in #deactivate

Change-Id: I3879dfe180707aad775f6fe45b385e32f7ceed34
2019-09-16 18:31:52 +02:00
David Lynch 001ed6a88e MWSaveDialog: add more instrumentation
Bug: T229079
Change-Id: I2e5b45a4a28b580fbca872d620df94a61fb8a24a
2019-09-16 10:48:31 -05:00
Translation updater bot a586842339 Localisation updates from https://translatewiki.net.
Change-Id: I570c7b1354e83e43732b482d5284b72f7cc5aab1
2019-09-16 09:58:20 +02:00
jenkins-bot 6c52d4b9da Merge "ve.init.mw.MobileArticleTarget: Really deactivate the surface" 2019-09-12 16:43:05 +00:00
jenkins-bot a7a4886a54 Merge "Add new EditAttemptStep stage: firstChange" 2019-09-12 15:19:46 +00:00
Bartosz Dziewoński 7c2e61d502 ApiVisualEditorEdit: Remove special handling for SpamBlacklist
No longer needed after Id36aa6bdb8f873fe7deb8123a7fc774103721c01,
which teaches SpamBlacklist to return its own error messages.

Depends-On: Id36aa6bdb8f873fe7deb8123a7fc774103721c01
Bug: T211443
Change-Id: I462c2002f9b596cbdfd7ce3673d4e362e5bd1aaf
2019-09-11 21:55:25 +00:00
jenkins-bot b75eb54bec Merge "Add another looser selector for catching pasted references" 2019-09-10 17:14:31 +00:00
David Lynch 22461568e0 Add new EditAttemptStep stage: firstChange
Depends-On: I79e04dda6323ebb05b129bb96c0323db112bcdd0
Bug: T229079
Change-Id: Icea7eed8a56e0c5a94c6dba4b0951ecf5f594da1
2019-09-10 10:41:13 -05:00
Ed Sanders 0371915832 Add unit tests for read-mode reference filter
Bug: T150418
Change-Id: I8b39694d5c01e0902491fe3d6f3a08451c7c5297
2019-09-10 14:46:45 +00:00
Ed Sanders 90426ba496 Use MW import rules in MW tests
Bug: T150418
Depends-On: I6ad87b53446d7d9fcaf82e1d60e3f9968c4409b6
Change-Id: I5d7f24a7e36ddd3624ef120783ceec5063cf3711
2019-09-10 14:46:37 +00:00
Bartosz Dziewoński f8d825838c Update VE core submodule to master (ad919ec0f)
New changes:
79b8dde0b Localisation updates from https://translatewiki.net.
af9512298 Localisation updates from https://translatewiki.net.
564d90dee Test utils: Use current target in mock surface
dff861435 Don't apply surface padding in dialog target widgets

Change-Id: Ia85f5aed91aa3800878d6b470660826ba4ea8f45
2019-09-10 16:44:47 +02:00
Ed Sanders c8582df1b9 Add another looser selector for catching pasted references
Bug: T232461
Change-Id: I82eef25fbbaa4b583fac660b172541db3160c99c
2019-09-10 12:32:10 +01:00
Bartosz Dziewoński 8eef588593 ve.init.mw.MobileArticleTarget: Really deactivate the surface
The call to selectFirstContentOffset() below would re-activate the
surface and (attempt to) show the keyboard if the surface was
deactivated, but not shown as deactivated.

This might have worked correctly by accident before
I39fe44eee8eab7129340bcff796b6b9b3a59a398 in VE core.

Change-Id: I500309cc0aa8cd794175ae683a17c2614fd58cc9
2019-09-09 20:00:53 +02:00
jenkins-bot a3eb620570 Merge "ve.ui.MWEditModeTool: Fix showing active editor" 2019-09-09 17:55:33 +00:00
jenkins-bot 03bdace1ba Merge "MobileArticleTarget: don't access the surface after it's destroyed" 2019-09-09 16:35:18 +00:00
Bartosz Dziewoński a02323698b ve.ui.MWEditModeTool: Fix showing active editor
This line of code seems to have been accidentally deleted in
1761b6d6d6.

Bug: T232359
Change-Id: I7d9568cc11a7c96e607203d41ab132c6f304d304
2019-09-09 18:32:56 +02:00
David Lynch 74d7fe01be MobileArticleTarget: don't access the surface after it's destroyed
Some post-save scrolling would try to access the view before the
handlers were cleaned up.

Bug: T232347
Change-Id: I30433ef027c52d541351972f8ebb09fe6d45e436
2019-09-09 10:01:34 -05:00
jenkins-bot f12cb6d1cf Merge "MobileArticleTarget: Remove unused code (adjustContentPaddingDebounced)" 2019-09-06 21:26:51 +00:00
jenkins-bot 5bbcf9bac1 Merge "MobileArticleTarget: Remove unused code (hideSpinner)" 2019-09-06 21:22:25 +00:00
Bartosz Dziewoński a1a082aafa MobileArticleTarget: Remove unused code (adjustContentPaddingDebounced)
As of I6c043e039fbef62a56f475b0dc365e171ab7bf59, this method is never
called. It was previously used to update the size of the toolbar when
context menus were displayed inside it, but they are now displayed
elsewhere.

Change-Id: I53030de1203a7f0d75780ae796bbb10082d5ef7a
2019-09-06 21:27:47 +02:00
Bartosz Dziewoński 08e16c0053 MobileArticleTarget: Remove unused code (hideSpinner)
As of I2f2495ab6c10116a6660f4361e49272cb95b988a in MobileFrontend,
the overlay never uses the default spinner.

Change-Id: Ie0aa624e33a5bd21fc20459697cca175d9de5606
2019-09-06 21:25:17 +02:00
jenkins-bot 19ca9a4768 Merge "Update VE core submodule to master (0b17a137b)" 2019-09-06 00:17:08 +00:00
James D. Forrester a05f9e4bf4 Update VE core submodule to master (0b17a137b)
New changes:
d4cb2f03e Update OOUI to v0.34.0
b0b481693 jsduck: Stop listing OOjs in upstream, it's using JSDoc now
0b17a137b Update OOjs to v3.0.0

Change-Id: If29a97ce689523763431face5a13929a461735b4
2019-09-05 13:03:41 -07:00
Ed Sanders af0ca43125 Mobile surfaceReady: Account for selection changing in listeners
Bug: T232136
Change-Id: Ia49ea99320a8191a4d73703f1cbf3b9ef89035ec
2019-09-05 19:25:33 +01:00
Ed Sanders 7f854ff6ca Fix HTML blacklist inheritance
Bug: T150418
Change-Id: Ic56f90d654bfd34e353edafbbf5954fe167157f6
2019-09-04 17:14:38 +01:00
Translation updater bot 8dc9650510 Localisation updates from https://translatewiki.net.
Change-Id: I01dcda8d4557a1575fbb14fe8586805087782d2d
2019-09-04 10:16:23 +02:00
Ed Sanders 901f107bd0 Delete mobile toolbar flexbox code, upstreamed to VE core
Depends-On: If973baa556a557c2fe5cb3aed44f937fc9d2b62e
Change-Id: I775fb24bd16572cfb8472f5260a7552b2fbb9930
2019-09-03 17:30:19 +00:00
James D. Forrester 87e533d121 Update VE core submodule to master (f2b6e7db9)
New changes:
347e8622e Localisation updates from https://translatewiki.net.
f2b6e7db9 Upstream mobile toolbar flexbox layout

Change-Id: Id38a67050522f33a8a5d3228925b4518a138b2ac
2019-09-03 10:18:47 -07:00
jenkins-bot d401562629 Merge "MWLinkAnnotationInspector: track edits to the label field" 2019-09-03 15:47:16 +00:00