wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 03:08:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ArticleTargetEvents: clean up some duplication"

Browse source
This commit is contained in:
jenkins-bot 2019-09-30 23:49:27 +00:00 committed by Gerrit Code Review
parent 78ed28fbf0 651e00d529
commit 73a92d847d
3 changed files with 7 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
View file

@ -748,7 +748,6 @@ ve.init.mw.DesktopArticleTarget.prototype.surfaceReady = function () {
editNotices = this.getEditNotices(),
actionTools = this.actionsToolbar.tools,
surface = this.getSurface(),
surfaceReadyTime = ve.now(),
target = this;
if ( !this.activating ) {
@ -769,15 +768,6 @@ ve.init.mw.DesktopArticleTarget.prototype.surfaceReady = function () {
this.transformCategoryLinks( $( '#catlinks' ) );
// Track how long it takes for the first transaction to happen
surface.getModel().getDocument().once( 'transact', function () {
ve.track( 'mwtiming.behavior.firstTransaction', {
duration: ve.now() - surfaceReadyTime,
targetName: target.constructor.static.trackingName,
mode: surface.getMode()
} );
} );
surface.getModel().getMetaList().connect( this, {
insert: 'onMetaItemInserted',
remove: 'onMetaItemRemoved'

4
modules/ve-mw/init/ve.init.mw.ArticleTarget.js
View file

@ -565,10 +565,6 @@ ve.init.mw.ArticleTarget.prototype.surfaceReady = function () {
this.restoreEditSection();
mw.hook( 've.activationComplete' ).fire();
surfaceModel.getDocument().once( 'transact', function ( transaction ) {
this.emit( 'firstTransaction', transaction );
}.bind( this ) );
};
/**

9
modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
View file

@ -18,7 +18,6 @@ ve.init.mw.ArticleTargetEvents = function VeInitMwArticleTargetEvents( target )
this.timings = { saveRetries: 0 };
// Events
this.target.connect( this, {
firstTransaction: 'onFirstTransaction',
saveWorkflowBegin: 'onSaveWorkflowBegin',
saveWorkflowEnd: 'onSaveWorkflowEnd',
saveInitiated: 'onSaveInitiated',
@ -78,6 +77,11 @@ ve.init.mw.ArticleTargetEvents.prototype.trackTiming = function ( topic, data )
*/
ve.init.mw.ArticleTargetEvents.prototype.onFirstTransaction = function () {
this.track( 'mwedit.firstChange' );
this.trackTiming( 'behavior.firstTransaction', {
duration: ve.now() - this.timings.surfaceReady,
mode: this.target.surface.getMode()
} );
};
/**
@ -218,9 +222,10 @@ ve.init.mw.ArticleTargetEvents.prototype.onSaveReview = function () {
};
ve.init.mw.ArticleTargetEvents.prototype.onSurfaceReady = function () {
this.timings.surfaceReady = ve.now();
this.target.surface.getModel().getDocument().connect( this, {
transact: 'recordLastTransactionTime'
} );
} ).once( 'transact', this.onFirstTransaction.bind( this ) );
};
/**