Commit graph

20582 commits

Author SHA1 Message Date
Bartosz Dziewoński be36f1fab1 DesktopArticleTarget.init: Remove code for updating edit links
This JS code duplicates the PHP implementation in VisualEditorHooks
in order to allow changes to the configuration of edit tabs
(e.g. wgVisualEditorUseSingleEditTab and wgVisualEditorTabPosition)
to take effect for logged-out users immediately, without waiting
for the HTML caches to clear.

It was worthwhile 10 years ago when VisualEditor was being rolled out
to new wikis or reconfigured daily, but it is not today when we hardly
ever change these settings.

It proved difficult to maintain as the skins change, it has several
known bugs (T292125, T306807, T346944), and probably several more
unknown ones, given that it hasn't been tested in about 10 years.

Let's remove it and save ourselves the headache. (Also also reduce the
amount of code we ship on all page views by almost a kilobyte.)

Bug: T292125
Bug: T306807
Bug: T346944
Change-Id: Ib82f5402872a2429445463a1e1ef92806d3326f9
2023-10-05 03:11:40 +02:00
jenkins-bot 86fb65ba90 Merge "Change icon for supported skins when both VE and source edit icons are present" 2023-10-04 23:20:19 +00:00
Jon Robson 47815e9d2b Change icon for supported skins when both VE and source edit icons are present
This introduces an extension attribute EditIconSkins which allows extensions
or skins to request the rendering of edit icons.

This will be used by Minerva in I3c9d59f49f1b939981a7b2b450448db6736d5958

Bug: T346944
Change-Id: I401805224c0f387ac85b52b50c1f298b83c03a91
2023-10-04 22:16:13 +00:00
Translation updater bot c066dc745a Localisation updates from https://translatewiki.net.
Change-Id: I6f6c46192e404a30cbf8a103eac20383f91330b2
2023-10-04 09:09:22 +02:00
jenkins-bot 8c21352cd5 Merge "Fix wikitext mixed toggling" 2023-10-03 21:31:20 +00:00
hmonroy 3e223bdf52 Fix wikitext mixed toggling
Allow Core to handle the toggling for Wikitext when the inline switch is
present to avoid duplicated functionality.

Bug: T345836
Bug: T346213
Bug: T346299
Depends-On: Ib88836f13cdb5cd2344e3ba12f6c942baa0fc1f1
Change-Id: I3bb9fcabe17a20c9934274766e3335f63d51aac4
2023-10-03 16:15:37 +00:00
Ed Sanders 70c116a17a Edit check: Simplify "experience" config to "maximumEditcount"
There's no product need for anything other than an upper limit
on edit count. If one arises in the future we can adjust accordingly,
but better to keep the JSON, and any UI implementation, simple
for now.

Change-Id: I892847ad78b19695f0f0f664002d3c566f7806de
2023-10-03 16:20:51 +01:00
Translation updater bot 47dc22d6c0 Localisation updates from https://translatewiki.net.
Change-Id: I33a2510f8dcc7b2ff9f05867839b7e5ea1fe3d23
2023-10-03 09:33:33 +02:00
David Lynch 177f07a759 Update VE core submodule to master (ca5f6c26d)
New changes:
ff87fe63c TableNode: Remove hack for ancient browser (FF39)
45516acbd Remove ve.isPassiveEventsSupported
f1cc17fb3 ve.ce.Surface: Remove IE support in copy/paste code
59b572c89 Localisation updates from https://translatewiki.net.
ab2524e41 RebaserTarget toolbar: use findIndex
599ffff20 Localisation updates from https://translatewiki.net.
b6b0b2f01 Localisation updates from https://translatewiki.net.
1c5dce24a build: Update linters
64fa7d401 Localisation updates from https://translatewiki.net.
8e6468945 Localisation updates from https://translatewiki.net.
169f721fc Localisation updates from https://translatewiki.net.
81d298f58 Localisation updates from https://translatewiki.net.
22527ef88 Localisation updates from https://translatewiki.net.
5560459a3 Only log context-shows if they're on a non-null fragment
b8cab4086 .gitreview: Swap to track=1
629b48057 Localisation updates from https://translatewiki.net.
2a2665a0d Localisation updates from https://translatewiki.net.
506d4c01f ve.repeatString: Use native implementation
c6dcc87b3 Localisation updates from https://translatewiki.net.
8cf97e8c8 ChromeHeadless: Do not pass a spurious empty flag
61990513c Provide alternate keyboard shortcut for toolbar search for mac Firefox
ca5f6c26d Localisation updates from https://translatewiki.net.

Bug: T324735
Bug: T341603
Bug: T347380
Change-Id: Ic1172a3eee32f688f2fab32a3a8eaf6dc829e600
2023-10-02 16:46:25 -05:00
Translation updater bot d6e9e9af06 Localisation updates from https://translatewiki.net.
Change-Id: I4a17e4464c6d0fae1a737003dabb7d75408515a0
2023-10-02 10:58:37 +02:00
jenkins-bot 9ce1a1d44e Merge "build: Upgrade grunt-banana-checker from 0.11.0 to 0.11.1" 2023-09-28 07:27:22 +00:00
Translation updater bot 63d4d6966b Localisation updates from https://translatewiki.net.
Change-Id: I23a7e91c0da62b69512585da8ad4187e108a1309
2023-09-27 09:21:21 +02:00
jenkins-bot de9b3936b8 Merge "Update comment w/ rename of Article::getRedirectHeaderHtml()" 2023-09-26 19:35:23 +00:00
James D. Forrester c7ee116f07 build: Upgrade grunt-banana-checker from 0.11.0 to 0.11.1
Change-Id: I9390d6f36ef029b0a29126421b4647948bac7147
2023-09-26 14:39:59 -04:00
Translation updater bot aa645e7381 Localisation updates from https://translatewiki.net.
Change-Id: I34cce5cd5975157a7b45409abf0863343a90c29a
2023-09-26 08:45:13 +02:00
thiemowmde c581f0e3bc Favor jQuery's .toggleClass() to reduce code duplication
Change-Id: Ic616ffbfac410849413e8fad6dde260514884efb
2023-09-25 18:59:10 +00:00
Translation updater bot 112f7af925 Localisation updates from https://translatewiki.net.
Change-Id: I4739ba42495affb3ad1cf9476ae328ae6655e41d
2023-09-25 08:47:16 +02:00
Translation updater bot 8488367377 Localisation updates from https://translatewiki.net.
Change-Id: I55853ad501fa7e2a550f25aaf44e81c38c44fcad
2023-09-22 08:47:50 +02:00
jenkins-bot 8d40677037 Merge "Remove the BetaFeatures integration" 2023-09-21 15:29:34 +00:00
jenkins-bot 29689414d4 Merge "Update banana check to use config.MessagesDirs" 2023-09-21 15:07:35 +00:00
Ed Sanders 6730748707 Update banana check to use config.MessagesDirs
Add missing qqq strings so the tests will pass.

Bug: T346170
Change-Id: I7c43cb6db24d5c98341de2de4387689982b35e96
2023-09-21 09:18:30 -05:00
jenkins-bot 9c175e3788 Merge "ApiVisualEditor: Pass section to IntroMessageBuilder" 2023-09-21 11:50:44 +00:00
Translation updater bot 20028b695d Localisation updates from https://translatewiki.net.
Change-Id: I6e1e15e4661d1266b16b12cbd882e97244182356
2023-09-21 10:16:59 +02:00
Translation updater bot d50c8f6114 Localisation updates from https://translatewiki.net.
Change-Id: I5b63d0ffa75645593bb8bcc59d4e470bcd82e26f
2023-09-20 08:56:11 +02:00
Bartosz Dziewoński dcfe952a3f ApiVisualEditor: Pass section to IntroMessageBuilder
Depends-On: I58b90d8e70d538d897d3130ead114d2522ecb703
Change-Id: I205d18b65224acef4f76fb5625bff3bbf002ece6
2023-09-19 20:14:15 +00:00
jenkins-bot 7af308fbd1 Merge "Edit check: Handle the manual citation workflow" 2023-09-19 17:02:31 +00:00
Translation updater bot 879d6da1e2 Localisation updates from https://translatewiki.net.
Change-Id: Ida5a6392c695f9d9e249b5c8ba2006d4d1009c83
2023-09-19 09:26:24 +02:00
Ed Sanders 27c90dcf0a Edit check: Handle the manual citation workflow
Assume that the next window closing promise is from
the plain "Cite" dialog and use that data to resolve
the edit check promise, instead of resolving it
as soon as a manual type is selected.

Bug: T346405
Change-Id: I5b7f084269c9e870446529f63aed27f8ed995e8c
2023-09-18 18:42:01 +01:00
Translation updater bot 00ad2c5ab5 Localisation updates from https://translatewiki.net.
Change-Id: I75bf03b1e85865b55017052e2212e8d52451223e
2023-09-18 08:45:22 +02:00
C. Scott Ananian 43e4a3363b Update comment w/ rename of Article::getRedirectHeaderHtml()
Change-Id: I20f29af6856129bd952bbb003ae967376a203984
Depends-On: I4d0de0e72473ae039dca420a2733bc746d8c2951
2023-09-15 15:14:19 -04:00
jenkins-bot 22bca2a005 Merge "Don't offer visual diffs for non-wikitext pages" 2023-09-14 14:42:03 +00:00
Bartosz Dziewoński 0cfaaa5ff4 Don't offer visual diffs for non-wikitext pages
Bug: T346252
Change-Id: I1be1690b0414bb643f137f74c421ba1034563c7b
2023-09-14 14:22:32 +02:00
Translation updater bot b9e876143d Localisation updates from https://translatewiki.net.
Change-Id: I67f5e8f32eac31af353a1f57d61304e2de6c33a8
2023-09-14 09:30:47 +02:00
Translation updater bot fc6a68a212 Localisation updates from https://translatewiki.net.
Change-Id: I48c83d915f5201021c30a0d194e39549557f1634
2023-09-13 08:32:50 +02:00
Ed Sanders cba0bf6da1 Edit check: Clean up when VE is deactivated
* Remove the vetags save field handler
* Reject the save process deferred

Bug: T344382
Change-Id: I1dccc3cedcd5bca14f83ea16fdcad567bd641136
2023-09-12 11:37:34 +01:00
Translation updater bot 3475d1d0bb Localisation updates from https://translatewiki.net.
Change-Id: Ic83723b06fd5787adf54b6d099b2e79ec8e3cc83
2023-09-12 08:27:26 +02:00
David Lynch 80f3ef9531 Edit check config: account-state and experience
Bug: T330112
Change-Id: If713a7edcb71a5ea8123da27a3b1bffc45992ad0
2023-09-11 15:56:42 -05:00
jenkins-bot a9c0d1e8ad Merge "Update edit check tag labels" 2023-09-11 18:44:08 +00:00
jenkins-bot a2d601b4ab Merge "Add mw-no-invert class to thumbnails" 2023-09-11 17:19:17 +00:00
David Lynch 5447004d2c Update edit check tag labels
Bug: T329593
Bug: T342462
Change-Id: I299dc0308522f4e0585e26637bbf2d814f5dc8e0
2023-09-11 11:55:50 -05:00
jenkins-bot f722ed83f8 Merge "Remove use of wgFlaggedRevsEditLatestRevision" 2023-09-11 13:15:50 +00:00
Translation updater bot 5e43577ff4 Localisation updates from https://translatewiki.net.
Change-Id: Iabcf0accc27ce477e009fe10c3a63a274c98a742
2023-09-11 09:05:35 +02:00
jenkins-bot e45da5269a Merge "Update edit check decline reasons and record tags for them" 2023-09-08 15:17:08 +00:00
jenkins-bot 0320f44ca4 Merge "Instrumentation for edit check features" 2023-09-08 15:13:19 +00:00
jenkins-bot 1a4ee92b86 Merge "Track when edit notices are shown" 2023-09-08 15:05:28 +00:00
David Lynch 8c47e0ecb0 Update edit check decline reasons and record tags for them
Bug: T329593
Change-Id: Ib8f465c31a6c601545d55bd58a6c1fa78139757a
2023-09-08 15:49:09 +01:00
David Lynch 81ab55407c Instrumentation for edit check features
Also alters the context/inspector names to be reference-specific.

Bug: T324735
Change-Id: I3cc943aa559f622899a8a5d2fbd42265ffe810a8
2023-09-08 15:47:19 +01:00
jenkins-bot 947210e29f Merge "Only trigger edit check when inserted text is in a new paragraph" 2023-09-08 00:08:11 +00:00
jenkins-bot d75d070992 Merge "Place reference before punctuation when configured" 2023-09-08 00:07:50 +00:00
jenkins-bot daad252ebf Merge "Share diff page initialization with non-text diffs" 2023-09-07 19:11:13 +00:00