This JS code duplicates the PHP implementation in VisualEditorHooks
in order to allow changes to the configuration of edit tabs
(e.g. wgVisualEditorUseSingleEditTab and wgVisualEditorTabPosition)
to take effect for logged-out users immediately, without waiting
for the HTML caches to clear.
It was worthwhile 10 years ago when VisualEditor was being rolled out
to new wikis or reconfigured daily, but it is not today when we hardly
ever change these settings.
It proved difficult to maintain as the skins change, it has several
known bugs (T292125, T306807, T346944), and probably several more
unknown ones, given that it hasn't been tested in about 10 years.
Let's remove it and save ourselves the headache. (Also also reduce the
amount of code we ship on all page views by almost a kilobyte.)
Bug: T292125
Bug: T306807
Bug: T346944
Change-Id: Ib82f5402872a2429445463a1e1ef92806d3326f9
This introduces an extension attribute EditIconSkins which allows extensions
or skins to request the rendering of edit icons.
This will be used by Minerva in I3c9d59f49f1b939981a7b2b450448db6736d5958
Bug: T346944
Change-Id: I401805224c0f387ac85b52b50c1f298b83c03a91
Allow Core to handle the toggling for Wikitext when the inline switch is
present to avoid duplicated functionality.
Bug: T345836
Bug: T346213
Bug: T346299
Depends-On: Ib88836f13cdb5cd2344e3ba12f6c942baa0fc1f1
Change-Id: I3bb9fcabe17a20c9934274766e3335f63d51aac4
There's no product need for anything other than an upper limit
on edit count. If one arises in the future we can adjust accordingly,
but better to keep the JSON, and any UI implementation, simple
for now.
Change-Id: I892847ad78b19695f0f0f664002d3c566f7806de
New changes:
ff87fe63c TableNode: Remove hack for ancient browser (FF39)
45516acbd Remove ve.isPassiveEventsSupported
f1cc17fb3 ve.ce.Surface: Remove IE support in copy/paste code
59b572c89 Localisation updates from https://translatewiki.net.
ab2524e41 RebaserTarget toolbar: use findIndex
599ffff20 Localisation updates from https://translatewiki.net.
b6b0b2f01 Localisation updates from https://translatewiki.net.
1c5dce24a build: Update linters
64fa7d401 Localisation updates from https://translatewiki.net.
8e6468945 Localisation updates from https://translatewiki.net.
169f721fc Localisation updates from https://translatewiki.net.
81d298f58 Localisation updates from https://translatewiki.net.
22527ef88 Localisation updates from https://translatewiki.net.
5560459a3 Only log context-shows if they're on a non-null fragment
b8cab4086 .gitreview: Swap to track=1
629b48057 Localisation updates from https://translatewiki.net.
2a2665a0d Localisation updates from https://translatewiki.net.
506d4c01f ve.repeatString: Use native implementation
c6dcc87b3 Localisation updates from https://translatewiki.net.
8cf97e8c8 ChromeHeadless: Do not pass a spurious empty flag
61990513c Provide alternate keyboard shortcut for toolbar search for mac Firefox
ca5f6c26d Localisation updates from https://translatewiki.net.
Bug: T324735
Bug: T341603
Bug: T347380
Change-Id: Ic1172a3eee32f688f2fab32a3a8eaf6dc829e600
Assume that the next window closing promise is from
the plain "Cite" dialog and use that data to resolve
the edit check promise, instead of resolving it
as soon as a manual type is selected.
Bug: T346405
Change-Id: I5b7f084269c9e870446529f63aed27f8ed995e8c