wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-27 15:50:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change icon for supported skins when both VE and source edit icons are present

Browse source 
This introduces an extension attribute EditIconSkins which allows extensions
or skins to request the rendering of edit icons.

This will be used by Minerva in I3c9d59f49f1b939981a7b2b450448db6736d5958

Bug: T346944
Change-Id: I401805224c0f387ac85b52b50c1f298b83c03a91
This commit is contained in:
Jon Robson 2023-09-28 12:20:27 -07:00 committed by Jdlrobson
parent 9ce1a1d44e
commit 47815e9d2b
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
includes/Hooks.php
View file

@ -607,6 +607,14 @@ class Hooks implements
$newViews = [];
$wikiPageFactory = $services->getWikiPageFactory();
$isRemote = !$wikiPageFactory->newFromTitle( $title )->isLocal();
$skinHasEditIcons = in_array(
$skin->getSkinName(),
ExtensionRegistry::getInstance()->getAttribute(
'VisualEditorIconSkins'
)
);
foreach ( $links['views'] as $action => $data ) {
if ( $action === 'edit' ) {
// Build the VisualEditor tab
@ -639,6 +647,7 @@ class Hooks implements
'text' => $veTabText,
'single-id' => $veTooltip,
'primary' => true,
'icon' => $skinHasEditIcons ? 'edit' : null,
'class' => '',
];
@ -690,6 +699,8 @@ class Hooks implements
$userOptionsLookup->getOption( $user, 'visualeditor-tabs' ) === 'multi-tab'
)
) {
// Change icon
$editTab['icon'] = $skinHasEditIcons ? 'wikiText' : null;
// Inject the VE tab before or after the edit tab
if ( $config->get( 'VisualEditorTabPosition' ) === 'before' ) {
// @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset