wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-04 18:58:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
13035 commits 14 branches 17 tags 199 MiB
Commit graph

5849 commits

Author SHA1 Message Date
L10n-bot ce86129067 Merge "Localisation updates from https://translatewiki.net." 2017-02-22 21:53:36 +00:00
Translation updater bot 18e340ef5f Localisation updates from https://translatewiki.net. 
Change-Id: I388c3a778615dc9d561e3ba15016fbed6bd825da
 2017-02-22 22:54:16 +01:00
Ed Sanders 501d0c94d2 Cache generated content request when inserting templates 
We request the generated content of a template to determine
if it will be block or inline. This is the same request as
the view makes later to show the rendering, so we should cache
this repsonse.

Bug: T156698
Change-Id: I0ffd36ccd0aa821aa44d99328f2e3a2abc23dc0f
 2017-02-22 04:00:38 +00:00
jenkins-bot 703e784d1a Merge "build: Bump grunt-jsonlint to latest and make pass" 2017-02-21 16:14:38 +00:00
Translation updater bot a3d001d7a5 Localisation updates from https://translatewiki.net. 
Change-Id: I716d04e411b2381f38381d80e9b70661007a3738
 2017-02-21 00:02:00 +01:00
Translation updater bot 50a0c7125a Localisation updates from https://translatewiki.net. 
Change-Id: Ie015f94ba4db43ac49f9a16e3fbe18ee715c27df
 2017-02-19 22:52:36 +01:00
Translation updater bot 63efc6c9af Localisation updates from https://translatewiki.net. 
Change-Id: Ibc99be0de6a97d39ccf7b13c40283410b8ac08a5
 2017-02-18 22:51:16 +01:00
James D. Forrester dddd2c0180 build: Bump grunt-jsonlint to latest and make pass 
grunt-jsonlint       1.0.8  →   1.1.0

Change-Id: I4a5cdd39f6215cc61a1ef530386a87fdcb0c0088
 2017-02-17 16:12:12 -08:00
James D. Forrester cc239a08da build: Bump stylelint and make pass 
grunt-stylelint              0.6.0  →   0.7.0
 stylelint-config-wikimedia   0.3.0  →   0.4.1

Change-Id: Id87b8df04d415e1f1058a4042a31408236402037
 2017-02-17 15:23:12 -08:00
Translation updater bot 2dd0e06e87 Localisation updates from https://translatewiki.net. 
Change-Id: Ia236c6849f1c3194ebb59c666006f1edf03687cf
 2017-02-17 22:55:18 +01:00
Translation updater bot 8f5380cc12 Localisation updates from https://translatewiki.net. 
Change-Id: I46eaee06ac9f40e39685ebfccc76bd342439803e
 2017-02-16 23:09:58 +01:00
jenkins-bot 9164b6e400 Merge "DesktopArticleTarget.init: Don't hardcode single-tab accesskey" 2017-02-16 19:19:42 +00:00
jenkins-bot 97d689c824 Merge "MWSaveDialog: Switch to save panel when showing message" 2017-02-16 17:14:12 +00:00
jenkins-bot 6b6df0759e Merge "Tables: Add support for editing mw-collapsible/mw-collapsed" 2017-02-16 16:39:36 +00:00
David Lynch 288422cb9e MWSaveDialog: Switch to save panel when showing message 
Fixing T107251 made it so that clicking "save" always switched back to the
save panel momentarily, causing a flicker of "maybe I can edit this"
experience. With this change, we can only switch back to the save panel when
saving from other panels if a message is being shown.

Bug: T156891
Change-Id: I8f67693283e61c39cfce40ee12d5c6788dd97932
 2017-02-16 10:32:21 -06:00
Ed Sanders 9337e6ecbd Tables: Add support for editing mw-collapsible/mw-collapsed 
We don't support editing <div>s right now (as they're BranchNodes) nor
<span>s (as they're annotations), but most of those are inside templates
and so not editable in VE anyway.

Bug: T157989
Change-Id: I647b2a544fd16952696d0de8d07cb72189b27ecb
 2017-02-16 17:21:44 +01:00
Bartosz Dziewoński 22df25c108 Pass $overlay to FieldsetLayout and FieldLayout in various places 
We now use dialog's overlay in every case where we have a FieldsetLayout
or a FieldLayout with a help popup inside a dialog.

Bug: T100571
Change-Id: I8bd0ed430637feca63ec0f13cb7e1e1c659391a5
 2017-02-16 02:56:03 +01:00
Bartosz Dziewoński c3be577216 ve.ui.MWAdvancedSettingsPage: Actually display help for settings about language variants 
Follow-up to 712ea472d3.

Change-Id: I2f3617fb4e9a80272e559b35c947052c0d8e534b
 2017-02-16 02:19:09 +01:00
Bartosz Dziewoński 2c78411113 ve.test.utils.createSurfaceFromDocument: Actually attach surface to DOM 
Bug: T158141
Change-Id: I999bcdc7095a3b9e2a86a7d5eca0e1f3ceb175ef
 2017-02-16 01:17:17 +01:00
Translation updater bot a21a89ac77 Localisation updates from https://translatewiki.net. 
Change-Id: I8a6a7bf01f41eed3d8d7c1cf5ccfb515c16586ce
 2017-02-15 22:47:52 +01:00
Translation updater bot 7d95edacde Localisation updates from https://translatewiki.net. 
Change-Id: I16205f62bba23e5d0d157d433a635feac710aba5
 2017-02-14 22:57:45 +01:00
David Lynch b1d68872b0 DesktopArticleTarget.init: Don't hardcode single-tab accesskey 
Bug: T156141
Change-Id: I1312283437714bf338a8ee3cf63e93ac67db1c45
 2017-02-14 11:24:50 -06:00
L10n-bot 6909c24d5d Merge "Localisation updates from https://translatewiki.net." 2017-02-13 22:19:02 +00:00
Translation updater bot ae92640bf3 Localisation updates from https://translatewiki.net. 
Change-Id: I79bc57730f31d46f3319d1108313d35547d7f2fc
 2017-02-13 23:19:33 +01:00
Bartosz Dziewoński 7beaf0ab9c ve.ce.MWTableNode: Provide preview of sortable table styling 
Algorithm for deciding which cells handle sorting is exactly
the same as in the real jQuery Tablesorter.

Depends on changes in VE core:
* I50426e173c68af7df49e47fe3bec0465a9a55c26
* Iabb372dfe7bf5feef314315ac74a788c6c58dc20

Bug: T139072
Change-Id: I4446be2ad459b05590754da9bb6c3dd8f796be42
 2017-02-13 21:36:43 +00:00
Ed Sanders 08b3f73f16 MWTableDialog: Extend initial values so 'done' button behaves correctly 
Depends-On: I608431365f2a482536affe1dae3fe21bc20e16b4
Change-Id: Idd468caa9417ffd8e0475083c884ef6c554ee152
 2017-02-13 08:30:51 -08:00
Ed Sanders 444ed0b7d8 MWTableDialog: Inherit actions from core 
Change-Id: Ice7f18ac2e1b7728a52a48482728d1b1278ca66f
 2017-02-13 08:30:51 -08:00
Translation updater bot 0b620cf417 Localisation updates from https://translatewiki.net. 
Change-Id: Id1187371077f15d98540f91be55ee2f074254ce5
 2017-02-12 22:44:26 +01:00
jenkins-bot 3c56d19e66 Merge "vw.ui.MWTableDialog: Add "Cancel" button" 2017-02-12 15:07:37 +00:00
Translation updater bot 30cb88940e Localisation updates from https://translatewiki.net. 
Change-Id: If95955b60c6c2b371bda27b1db2272939c3da982
 2017-02-10 22:55:28 +01:00
Bartosz Dziewoński aa22a8c482 vw.ui.MWTableDialog: Add "Cancel" button 
The dialog already supports cancelling by pressing Escape,
but the usual dedicated button was missing.

Change-Id: Ic63b5b59940a43474051466bdbbba0dbeb4342a9
 2017-02-10 15:26:33 +01:00
jenkins-bot a234120771 Merge "Check for 'veaction' when clicking section edit links" 2017-02-09 18:33:55 +00:00
Bartosz Dziewoński 5200f2ef34 ve.ui.MWSaveDialog: Show a hint to use Ctrl+Enter to submit when pressing Enter 
Or Cmd+Enter for Mac.

Depends on VisualEditor core changes:
* I93f50e325f993d82a821bf02f5e7f56fe1b9de62
* Id0a357b038fc5730f61bcf3ba730838dcda9b00e

Bug: T153241
Change-Id: I6b0a5e2c4e4ec72016463c8ba6576d33d59be8e5
 2017-02-09 16:47:41 +00:00
Ed Sanders 6bd650d50a Check for 'veaction' when clicking section edit links 
Such as in the 'add topic' link.

Bug: T157104
Change-Id: Ide2d4cf8c23a5d0db24456d15b4312f7c0a5f922
 2017-02-08 17:48:04 +00:00
Translation updater bot 02aa33cfbd Localisation updates from https://translatewiki.net. 
Change-Id: I74eab9790e644bb90f354ae5d6a9f3cbb7ca2d6b
 2017-02-07 23:07:39 +01:00
jenkins-bot 6e585c457c Merge "Move wikitext signature command to correct file" 2017-02-07 20:47:57 +00:00
Ed Sanders 8ab21d2ef5 Move wikitext signature command to correct file 
So that signature availability is checked.

Bug: T157286
Change-Id: If1e585ce02e0bc9f5aa93129d315f83f183f5952
 2017-02-07 20:21:32 +00:00
Ed Sanders f2cf73eaaf Define default HTML types for extension nodes 
Use span/div for inline/block nodes respectively.

Bug: T157389
Change-Id: I4c501a6af88a490eec83af26adaa515a2b1d18d1
 2017-02-07 20:12:39 +00:00
David Lynch 8a7d44224c ArticleTarget: try to refresh editToken if getWikitextFragment fails 
Refactor saveFail's badtoken handling out so it can be reused by
getWikitextFragment.

Bug: T156991
Change-Id: I686cddb5be4484211fa69640044db1bc34eacefc
 2017-02-07 11:20:59 -06:00
jenkins-bot 158807f86c Merge "Remove explicit toolbar indicator definitions" 2017-02-06 17:11:59 +00:00
Translation updater bot 19569f4b02 Localisation updates from https://translatewiki.net. 
Change-Id: If656029a98191aad2523fe743ac42b1a26920190
 2017-02-05 22:57:31 +01:00
Ed Sanders 7a058a4de8 Remove explicit toolbar indicator definitions 
These are now computed upstream based on position of toolbar.

The menu tool now needs its indicator explicitly hidden.

Change-Id: Id2280f70553e1e45f3a42af45684c5808797925c
 2017-02-04 10:25:37 +00:00
Translation updater bot bb029d2ebc Localisation updates from https://translatewiki.net. 
Change-Id: Ibe93c0e21b2c4adb1796c0d07f9f0843e834be4e
 2017-02-03 23:06:06 +01:00
jenkins-bot 61d449c9d2 Merge "ve.ui.MWSaveDialog: Prettify the 'messages' shown" 2017-02-01 23:50:58 +00:00
jenkins-bot 5015af4a32 Merge "ve.init.mw.ArticleTarget: Don't try to clear non-existent message" 2017-02-01 23:48:30 +00:00
jenkins-bot fbe31de0d3 Merge "ve.ui.MWSaveDialog: Remove unused $saveActions div" 2017-02-01 23:48:10 +00:00
Translation updater bot 8390b1f3fb Localisation updates from https://translatewiki.net. 
Change-Id: I1d46d45a3dda6243a24cddbdb0dd679f8628fee9
 2017-01-31 22:58:54 +01:00
Bartosz Dziewoński e8d99c5536 ve.ui.MWSaveDialog: Prettify the 'messages' shown 
This is currently used to display a warning about missing edit summary
and to display a CAPTCHA field. They now appear in a separated area at
the bottom of the dialog, which slides into view when a message is
added.

Change-Id: I7541284a92d5fd2fa8f469d479e059098c59c0ac
 2017-01-31 17:37:00 +00:00
Bartosz Dziewoński 6f367ea0ec ve.init.mw.ArticleTarget: Don't try to clear non-existent message 
This is just dead code. We never call `.showMessage( 'captcha', ... )`
(the CAPTCHA is shown in the 'api-save-error' message).

Change-Id: I48f51e89d5b366384d184e2ed505be9e7b8f3401
 2017-01-31 14:40:32 +01:00
Bartosz Dziewoński a0cb3029cb ve.ui.MWSaveDialog: Remove unused $saveActions div 
Change-Id: I47da48b29d3bddd598946de655cf1e8b086daf45
 2017-01-31 13:43:47 +01:00
Translation updater bot 2e690797c0 Localisation updates from https://translatewiki.net. 
Change-Id: Idc95868d10a1fd04899fcbec7a280b55743a874d
 2017-01-30 22:52:00 +01:00
jenkins-bot 7b46d105b1 Merge "Advanced Settings: improve displaytitle field" 2017-01-30 19:40:13 +00:00
David Lynch 00fb8c8e58 Advanced Settings: improve displaytitle field 
* Remove the checkbox; an empty field, or a value exactly equal to the page
  title means no displaytitle.
* Automatically fill the field with the current page title
* The field was mispositioned

Bug: T155818
Bug: T156665
Change-Id: I46db6b14616c9a021e757284972537cac00546a1
 2017-01-30 19:29:25 +00:00
WMDE-Fisch a0af0b0529 Disable VisualEditor in the TwoColConflict extension 
As for the Translate extension this will read a global set by the
TwoColConflict extension to disable the VisualEditor and its hooks
on the modified edit conflict page there.

Bug: T156251
Change-Id: I164d1546c9d98d8715650e13c63a01d06c76315d
 2017-01-30 14:06:59 +01:00
Ed Sanders 1d7f929a91 Update VE core submodule to master (139bdf7) 
New changes:
d79138b Overwrite selected content when pasting via DataTransferItem
3c4737f Ensure clipboard is never empty text
3b1339e Create dummy platform and target for tests
4d63c8e Pass text as string to insertDocument when detected as plain text

Local change:
Remove VE standalone module

Flow used to use it, but not anymore. Going forward no one should
be using it in MW.

Bug: T154020
Bug: T156302
Bug: T156498
Depends-On: I078c244ef524669da477a43f9b37c847252e5ad7
Change-Id: Ifc4be16269f819890f2dcdddbbdebf9694ad2868
 2017-01-29 18:50:47 +00:00
Translation updater bot 662789bb13 Localisation updates from https://translatewiki.net. 
Change-Id: Ib90e3f4f0482f1642fe8dde53dd0f601d3e942cc
 2017-01-28 22:56:32 +01:00
Translation updater bot 0383c3c61b Localisation updates from https://translatewiki.net. 
Change-Id: I19e481d7151511014ac3fabd241cdf01932a937e
 2017-01-27 15:00:35 +01:00
jenkins-bot 19c0dd3aa4 Merge "MWSaveDialog: only focus summary if we're on the save panel" 2017-01-27 07:25:31 +00:00
David Lynch 60866eade2 Override ui.CommentInspector so that copying from it sets text/x-wiki 
Bug: T154837
Change-Id: I3413c955aa23d34683e1a028a581b1ea34d55d49
 2017-01-27 01:13:41 -06:00
David Lynch b976f2cf38 MWSaveDialog: only focus summary if we're on the save panel 
Firefox throws exceptions when trying to focus hidden inputs. Using the
"preview" keyboard shortcut entirely bypasses the save panel, but the ready
process assumes it'll always be opened first.

Bug: T153958
Change-Id: Ifb3861116565e77c30b3874fe47889298c3ace6d
 2017-01-27 00:51:33 -06:00
jenkins-bot fb48db7227 Merge "Ignore section edit links when no action present" 2017-01-26 14:13:24 +00:00
Ed Sanders 1df022a6d6 Ignore section edit links when no action present 
BUg: T156282
Change-Id: If3d039da36db946dcbba123d3cdc4e99c45f6a4e
 2017-01-25 18:13:56 +00:00
Translation updater bot dc7ce167b3 Localisation updates from https://translatewiki.net. 
Change-Id: Ie1b9552f69f104a50f0b317d1c6db4d046526ffc
 2017-01-25 14:49:37 +01:00
jenkins-bot fb1d1cdfaf Merge "Use target=_blank for link in template 'extra description'" 2017-01-25 12:53:03 +00:00
jenkins-bot 7d9d6b35d2 Merge "Update actions on live inspectors and preview dialogs" 2017-01-23 23:33:44 +00:00
Translation updater bot 23bce58071 Localisation updates from https://translatewiki.net. 
Change-Id: Ib31aa19ef33f7b5017bf3ed49684cae670fd50c7
 2017-01-23 22:50:30 +01:00
Ed Sanders 133da969ce Use target=_blank for link in template 'extra description' 
We already do this for 'missing description'.

Bug: T155879
Change-Id: Iccf48070ab2b5890d6891856be4ee5cce5308d0d
 2017-01-23 13:07:53 +00:00
Translation updater bot 07f877d476 Localisation updates from https://translatewiki.net. 
Change-Id: I6a51ed82a750a1fd6c3bb5697bb9b69067b2e96d
 2017-01-22 22:45:16 +01:00
Translation updater bot e821a8e24b Localisation updates from https://translatewiki.net. 
Change-Id: Ib7a453738fc26748d5b202c7598db1009d72b145
 2017-01-21 22:46:51 +01:00
Thalia 43c2865f90 Update actions on live inspectors and preview dialogs 
Make inspectors inheriting from MWLiveExtensionInspector
and dialogs inheriting from MWExtensionPreviewDialog
update their 'done' action every time updatePreview is
called. Since both mix in ExtensionWindow, two new methods,
updateActions and isModified are added there.

This should make it more difficult to insert an empty node
accidentally or create a transaction just by opening and
closing an inspector or dialog.

For more complicated dialogs, or inspectors or dialogs
that don't live-update, this behaviour will have to be
implemented separately.

Bug: T155330
Change-Id: Iacafa01fcd419faaec9b112c96be86693a57d561
 2017-01-21 18:29:18 +00:00
Ed Sanders 171286c120 Fix typo in target config 
Change-Id: I5815ce5b0e05ce166e02bfcced520e3770f5453d
 2017-01-20 23:15:23 +00:00
Ed Sanders f58d00b110 Move #getWikitextFragment up to ArticleTarget 
Change-Id: Ice4b04db4a45c07ccffc3892e6db5d814c2ec37b
 2017-01-20 23:15:17 +00:00
Ed Sanders e5555d6d85 Remove MWMobileSurface & Context 
The hacks contained within context were ancient and no
longer used, and thanks to a typo in mw.MobileArticleTarget
neither of these classes was being used anyway.

Change-Id: I52f2b6d5aa5ddbcc45ac6107eaf9407570b73672
 2017-01-20 23:15:11 +00:00
Ed Sanders 1ae5c13cb9 Update VE core submodule to master (f0dcedb) 
New changes:
5b448fa [BREAKING CHANGE] Merge Mobile/DesktopSurface into Surface
2d8959b Localisation updates from https://translatewiki.net.
7eee772 Follow-up 2d8959b: Fix build for added language 'io'
f0dcedb ve.dm.TableMatrix: Really indent ASCII-art comments

Change-Id: I62708f7caeb03b16cd318aab0b0ee3c674e75a26
 2017-01-20 14:35:39 -08:00
Translation updater bot 015017376e Localisation updates from https://translatewiki.net. 
Change-Id: Id8ab05872453edaf2c54c841dcc6abf7b7e68f32
 2017-01-20 09:46:04 +01:00
Translation updater bot b0944d5ad3 Localisation updates from https://translatewiki.net. 
Change-Id: I08914c4a309c016d8ceff90da41328d3c3b12110
 2017-01-17 22:17:40 +01:00
jenkins-bot 1e32b1d31d Merge "Re-order all meta code to put categories first" 2017-01-17 02:39:55 +00:00
jenkins-bot faaf7d2b4f Merge "Fix correct default page for meta dialog in NWE" 2017-01-17 02:38:44 +00:00
Ed Sanders 96a3d38cf9 Re-order all meta code to put categories first 
For consistency.

Change-Id: Ia5e9728ca4f727f4ce30d5f0c88ac9df8c4d21d0
 2017-01-17 00:19:38 +00:00
Ed Sanders 1aeec314d5 Fix correct default page for meta dialog in NWE 
Bug: T154639
Change-Id: I49d0f2295b071ae667e111562e30d04b0174c251
 2017-01-17 00:17:51 +00:00
jenkins-bot 9c3f3646c8 Merge "Correct comment in MWBlockImageNode" 2017-01-16 20:24:45 +00:00
Translation updater bot 6a449d29ba Localisation updates from https://translatewiki.net. 
Change-Id: I12814771ed6d7d2005c5c09543e30f1e635a3289
 2017-01-16 14:32:09 +01:00
Thalia 8c4b8e55e5 Correct comment in MWBlockImageNode 
Change-Id: I99058f97ac74b57c648be51cdb267d24a197b16a
 2017-01-14 18:38:20 -08:00
Ed Sanders 337614d142 Open preview links in new tab 
Bug: T155159
Change-Id: Idddc6b25303c17382ba1bc763b9001b727e1040e
 2017-01-12 16:07:00 -08:00
jenkins-bot a4543a7336 Merge "Allow AceEditorWidget to accept autocomplete word list" 2017-01-12 02:00:14 +00:00
Thalia fc61fb9be0 Allow AceEditorWidget to accept autocomplete word list 
Bug: T155107
Change-Id: I2dd752fb55a4d5596dbc8b8dc69eb55083d7ec66
 2017-01-11 17:26:16 -08:00
L10n-bot 220b2ef042 Merge "Localisation updates from https://translatewiki.net." 2017-01-11 22:27:03 +00:00
Translation updater bot 1f90679b43 Localisation updates from https://translatewiki.net. 
Change-Id: I92917d08fd03456856c1983ab1bd07cd8d46943a
 2017-01-11 23:21:18 +01:00
jenkins-bot 7c49a23a33 Merge "ArticleTarget: Give users a specific message when HookAborted errors happen" 2017-01-11 22:21:13 +00:00
jenkins-bot 18ba046361 Merge "ArticleTarget#saveErrorUnknown: Handle the xhr being complete" 2017-01-11 20:37:08 +00:00
James D. Forrester 002b0adef0 ArticleTarget: Give users a specific message when HookAborted errors happen 
Change-Id: I7017412dc56200f5bb0adbd901aed15507447846
 2017-01-11 10:46:30 -08:00
James D. Forrester 2b502572ec ArticleTarget#saveErrorUnknown: Handle the xhr being complete 
Change-Id: I638b5b80c5a404a438ebd357b6e16bbab7871d6e
 2017-01-11 10:45:43 -08:00
jenkins-bot 0405f8c80a Merge "DesktopArticleTarget: Prevent infinite while loop if $content is empty" 2017-01-11 18:39:35 +00:00
Ed Sanders 889ffc0efc DesktopArticleTarget: Prevent infinite while loop if $content is empty 
Change-Id: I629b2c3f1a4af3441764db7d1d0a7cec96181396
 2017-01-11 18:29:16 +00:00
Translation updater bot 3c943c5817 Localisation updates from https://translatewiki.net. 
Change-Id: Ib66f2dc2241016540afa2df19cc4ac36523ae98b
 2017-01-09 15:56:06 +01:00
jenkins-bot 70a66d4070 Merge "More error handling fixes" 2017-01-09 02:24:17 +00:00
jenkins-bot 09829ae7b4 Merge "MWMetaDialog: Move categories to the top as they're used most" 2017-01-07 14:56:56 +00:00
Translation updater bot 9d29ec3d9c Localisation updates from https://translatewiki.net. 
Change-Id: I37e2fb1213d1db27e24219fba349638f75fc122f
 2017-01-06 23:14:55 +01:00
Translation updater bot a0bda5eb51 Localisation updates from https://translatewiki.net. 
Change-Id: Ied8c757544363b36e27cfccb4df80a0c22d78ce2
 2017-01-05 23:50:18 +01:00
Alex Monk 8fe5bbe39b More error handling fixes 
See T154565

Change-Id: I073aae149497342157503ad3f465b7d57aaad4fa
 2017-01-05 15:13:02 +00:00
jenkins-bot 50e7fd0653 Merge "Fix MWInternalLinkAnnotation.getTargetDataFromHref's behaviour with URLs containing query parts" 2017-01-05 15:08:33 +00:00
jenkins-bot 4d64196fcb Merge "Fix loadFail parameter handling" 2017-01-04 22:46:27 +00:00
jenkins-bot e91f8f913e Merge "Allow 'T-' prefixed sections, and redirect if section link title isn't current page" 2017-01-04 22:38:34 +00:00
Alex Monk 1bcaa9056c Fix loadFail parameter handling 
Rename them while we're at it.

Bug: T151278
Bug: T152429
Change-Id: I435ac148007db87da69e8cf48568fafa646abb71
 2017-01-04 22:31:08 +00:00
Translation updater bot f2947ed40d Localisation updates from https://translatewiki.net. 
Change-Id: I842b0b968551a988d1a848d8b08aa4ace0c10466
 2017-01-04 22:39:54 +01:00
James D. Forrester 6795430831 MWMetaDialog: Move categories to the top as they're used most 
Bug: T74399
Change-Id: I696d8484ed00c92340f178d5c9dcfe978998dce0
 2017-01-04 11:18:00 -08:00
Ed Sanders 808de2acea Add "templates used" page to meta dialog 
Bug: T149009
Depends-On: Id617f9afbddf094140133f9659efc4b4e746148c
Change-Id: I63e663d05aefb47274f1f28bdcafc5317c2fc4f6
 2017-01-04 18:30:11 +01:00
Ed Sanders b7dd6077b8 Allow 'T-' prefixed sections, and redirect if section link title isn't current page 
Bug: T153176
Change-Id: Ic6fda78d00715777df4a273e7d3e150f20185185
 2017-01-04 16:53:03 +00:00
jenkins-bot cbd88e10ed Merge "Use the monospace hack consistently" 2017-01-03 20:41:03 +00:00
jenkins-bot d816492ca1 Merge "rm stray fileRepoPromise property from media dialog" 2017-01-03 20:24:34 +00:00
jenkins-bot 1ac5ede187 Merge "Don't try to JSON stringify load error messages that are already strings" 2017-01-03 20:22:50 +00:00
jenkins-bot 4abdf21413 Merge "Also allow opening in source mode if VE is unavailable on action=edit" 2017-01-03 20:19:09 +00:00
jenkins-bot 2b913fb10c Merge "Add editintro to notices" 2017-01-03 20:19:06 +00:00
jenkins-bot a973528d67 Merge "Don't block VE/NWE from loading if 'editintro' is specified" 2017-01-03 20:13:29 +00:00
Alex Monk 17ced451f4 MWSaveDialogAction: Don't break on strange accesskey messages 
Quietly return instead.

Bug: T153472
Change-Id: I7c325624734f122c9fd939aee1192187c63d9247
 2017-01-03 11:37:09 -08:00
jenkins-bot f182d5d223 Merge "When switching check wikitext is a non string, not just empty" 2017-01-03 18:57:48 +00:00
jenkins-bot 78a38ae6ea Merge "Register shortcuts for minoredit/watchlist" 2017-01-03 18:54:26 +00:00
jenkins-bot 945d3d4cbc Merge "After saving a specific section, scroll to it" 2017-01-03 18:49:19 +00:00
jenkins-bot 9cc4736708 Merge "ve.ui.MWParameterPage: Restructure constructor to reduce needless work" 2017-01-03 18:44:56 +00:00
jenkins-bot ec6509e86b Merge "ve.ui.MWParameterPage: Hide the "Fall back to plain wikitext" button when in wikitext" 2017-01-03 18:44:54 +00:00
Alex Monk 5c2773539e After saving a specific section, scroll to it 
Bug: T153297
Change-Id: I233e5226abc44d5d0bf8e56957a133d595e7be6f
 2017-01-03 18:38:55 +00:00
jenkins-bot 6599aaf3f4 Merge "Give focus to preview panel for keyboard scrolling" 2017-01-03 17:58:32 +00:00
jenkins-bot f439843964 Merge "Factor out preferred editor check" 2017-01-03 17:50:42 +00:00
jenkins-bot f89a6a3880 Merge "build: Bump file copyright notices for 2017" 2017-01-03 17:11:04 +00:00
jenkins-bot 24d26f5e19 Merge "Move translate extension hack up to 'isAvailable'" 2017-01-03 17:04:11 +00:00
jenkins-bot 7c790f8d12 Merge "Use preferred number casting method" 2017-01-03 17:04:10 +00:00
jenkins-bot 7a81159941 Merge "Fix NWE-only edit tab" 2017-01-03 17:04:09 +00:00
jenkins-bot 80e0edd275 Merge "Allow switching between 'edit source' and 'add topic'" 2017-01-03 17:04:08 +00:00
James D. Forrester 122f49b2dd build: Bump file copyright notices for 2017 
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
 2017-01-03 08:58:33 -08:00
Ed Sanders 4628e9e68c When switching check wikitext is a non string, not just empty 
Also add documentation.

Bug: T154437
Change-Id: Icacc0ad522d3e7fa28ecea9876c2c0465c4eb8e6
 2017-01-02 18:40:07 +00:00
Translation updater bot daa5085917 Localisation updates from https://translatewiki.net. 
Change-Id: I1dbde448e5f2d60675d35d070969b3890ea2aa49
 2017-01-01 10:17:23 +01:00
Ed Sanders 58071f59f1 Add editintro to notices 
Bug: T56029
Bug: T51622
Change-Id: Ib43cc66b817ff394b4f1c82fcba4503df825819c
 2016-12-31 23:23:17 +00:00
Ed Sanders c853475a1a Give focus to preview panel for keyboard scrolling 
Bug: T154334
Change-Id: Ibc093e3111411b6183bf24528a2e0419ba8d40b6
 2016-12-31 22:04:19 +00:00
Ed Sanders fe85ee1ba6 Don't block VE/NWE from loading if 'editintro' is specified 
Later we should actually show the edit intro, but that is a
separate issue (T56029).

Bug: T153481
Change-Id: I97622a3d86b975866305aaa745bac51f6b55f217
 2016-12-31 15:22:11 +00:00
Ed Sanders 9eebfbcac5 Fix NWE-only edit tab 
Change-Id: I5d08e30f43fbe08eb8809692728a8ab37f3a1491
 2016-12-30 16:42:54 +00:00
Ed Sanders 3f47aec20b Use preferred number casting method 
Change-Id: I77215f2bdb6eb055375e5b803d23b6f26df2d8d1
 2016-12-29 20:33:15 +00:00
Alex Monk 4af862e6d3 Also allow opening in source mode if VE is unavailable on action=edit 
Bug: T153508
Change-Id: I5678d3b417c93707edc90bbb76ce4dafcd2098c6
 2016-12-29 20:32:58 +00:00
Ed Sanders c963b73e71 Factor out preferred editor check 
Change-Id: Ic2e2e2e1d24dba8854315dff068ea9ce5d409c5a
 2016-12-29 20:17:55 +00:00
Ed Sanders 7de023caee Allow switching between 'edit source' and 'add topic' 
Also between section editing and full page editing
by clicking on 'edit source'.

Change-Id: I9165a7ad4ac2a588a09532c7181ba72b6fd2f811
 2016-12-29 15:48:38 +00:00
Translation updater bot 2217913182 Localisation updates from https://translatewiki.net. 
Change-Id: If99a57be3026afdfd71533ff227649069c092674
 2016-12-29 10:25:31 +01:00
jenkins-bot 927856aff3 Merge "Use mw.Message#parseDom where appropriate" 2016-12-28 21:40:18 +00:00
Ed Sanders c625398b78 Use the monospace hack consistently 
Change-Id: I6b223e5f0760902c1f34fa5a284703055c763234
 2016-12-28 13:36:14 +00:00
Translation updater bot 786f354ec5 Localisation updates from https://translatewiki.net. 
Change-Id: I6a6785f8b9a0f0448a0f0e0af11dcebf2ab9ec3b
 2016-12-28 10:57:13 +01:00
Bartosz Dziewoński a811168c2a ve.ui.MWParameterPage: Restructure constructor to reduce needless work 
We were constructing a lot of widgets, and never using them all
(they were forever hidden or not even appended to DOM). For large
transclusions this was causing a noticeable performance hit.

I don't think this quite resolves T134814, but it should improve the
situation.

* this.rawFallbackButton is now constructed and appended only when needed.
* this.removeButton is now constructed and appended only when needed.
* this.infoButton can now be a PopupButtonWidget or a disabled ButtonWidget.

Bug: T134814
Change-Id: I2ea00a88a1ea22b73b0c6d10334a94f45734ec3b
 2016-12-27 23:54:49 +00:00
Bartosz Dziewoński e0c97ab2f0 ve.ui.MWParameterPage: Hide the "Fall back to plain wikitext" button when in wikitext 
We were trying to hide it by detaching, which did not work because it
was getting attached again in later code. Clicking the button just did
nothing.

Change-Id: I027550eb723c43dc85453959159b93e6e802e099
 2016-12-27 23:54:42 +00:00
Bartosz Dziewoński 90ff82a035 Use mw.Message#parseDom where appropriate 
Avoid turning DOM into HTML markup and parsing it back into DOM.

Change-Id: I34f56ee60b836a7e0556130a153fc95adb4f3467
 2016-12-27 23:54:12 +00:00
Ed Sanders 827d4185c4 Move translate extension hack up to 'isAvailable' 
All modes of VE should be disabled on these pages.

Bug: T153445
Change-Id: I5adfae940ee35c5ee6712e620a0ddda967a542ad
 2016-12-27 13:56:10 +00:00
Translation updater bot f5b1a5bb18 Localisation updates from https://translatewiki.net. 
Change-Id: I1c8e16e199bbef502b296802acbb3cc15ee417be
 2016-12-26 22:42:30 +01:00
Translation updater bot 2ea87fcaf3 Localisation updates from https://translatewiki.net. 
Change-Id: Ia3b0f68931e0894aa10d2992f90dc8703f8712cb
 2016-12-25 22:20:41 +01:00
Translation updater bot d87a54a31b Localisation updates from https://translatewiki.net. 
Change-Id: I21a43826c79cf6d234fb003f3f20c254758380fd
 2016-12-24 22:41:04 +01:00
Alex Monk 4c061de2e0 Fix MWInternalLinkAnnotation.getTargetDataFromHref's behaviour with URLs containing query parts 
ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref(
	'http://mediawiki.krenair.dev/mediawiki_dev/wiki/Main_Page?veaction=editsource',
	ve.init.target.surface.model.documentModel.htmlDocument
)

Wrong, current result:
Object {
	title: "Main Page?veaction=editsource",
	rawTitle: "Main_Page?veaction=editsource",
	hrefPrefix: "",
	isInternal: true
}

New result:
Object {
	title: "http://mediawiki.krenair.dev/mediawiki dev/wiki/Main Page?veaction=editsource",
	rawTitle: "http://mediawiki.krenair.dev/mediawiki_dev/wiki/Main_Page?veaction=editsource",
	hrefPrefix: "",
	isInternal: false
}

Change-Id: I3d6d7fcfeb0d8354623026c831605c7633c3e11a
 2016-12-24 20:12:44 +01:00
Alex Monk d7cf29f1c0 rm stray fileRepoPromise property from media dialog 
seems to have gone upstream to core's mw.widgets.APIResultsQueue

Change-Id: I3c2a6dbdca60ceadc9e7175e5f8ad83b7fc4b7a0
 2016-12-24 18:59:48 +01:00
Translation updater bot 55a9cf5208 Localisation updates from https://translatewiki.net. 
Change-Id: I39a587eeb157951e8f848cda002f9a46b77d162a
 2016-12-23 22:34:34 +01:00
Ed Sanders 7611ee5a2c Register shortcuts for minoredit/watchlist 
Bug: T153925
Change-Id: I3f569a75a66e816d0a5c4ad966344100510a4f2b
 2016-12-23 13:36:48 +00:00
Translation updater bot 2dc86af85a Localisation updates from https://translatewiki.net. 
Change-Id: Ic57783cd0222ba31b3c343881a4a4732ad7d0404
 2016-12-22 23:00:45 +01:00
jenkins-bot d5f66e4fe9 Merge "Preserve checkbox data when switching from VE to NWE" 2016-12-22 12:37:37 +00:00
jenkins-bot 50da8d8ab9 Merge "Add comments in some places where we really want to treat messages as HTML" 2016-12-22 00:32:23 +00:00
Ed Sanders aee5e665f1 Preserve checkbox data when switching from VE to NWE 
Bug: T153889
Change-Id: Ifc41ea9320c9f2627efff6f33d4ad87c59fad496
 2016-12-21 22:35:52 +00:00
Alex Monk 101b0ff45c Don't try to JSON stringify load error messages that are already strings 
Change-Id: Ib180c3ac7eb62d351e05153defd6330c3397c478
 2016-12-21 04:00:05 +01:00
jenkins-bot 8497b06287 Merge "ve.init.MWWelcomeDialog: Don't treat text messages as HTML" 2016-12-21 02:49:09 +00:00
jenkins-bot d1b243e660 Merge "Ensure document base is always correct, even in source mode" 2016-12-20 18:51:23 +00:00
jenkins-bot 477f892423 Merge "Change wikitext link inspector name to avoid conflict" 2016-12-20 13:44:36 +00:00
jenkins-bot ced46300cb Merge "MWTemplatePage: Show a link to the template even when there's a description" 2016-12-20 11:04:24 +00:00
Bartosz Dziewoński 72569159b8 Add comments in some places where we really want to treat messages as HTML 
Change-Id: I439338dabd4b031ed1c4cfc9d89af5a6f2971676
 2016-12-20 10:50:15 +00:00
Bartosz Dziewoński dc3bae7d36 ve.init.MWWelcomeDialog: Don't treat text messages as HTML 
This appears to be unintentional. The messages don't have any markup.

Change-Id: I6f6570c5ef90e4a06ead1a23f6f851021a77c234
 2016-12-20 10:50:10 +00:00
Translation updater bot f6ba11dec9 Localisation updates from https://translatewiki.net. 
Change-Id: I7601c2c303782796f9ca3090f0798b9e354baffa
 2016-12-19 22:50:11 +01:00
Ed Sanders 46385a557e Ensure document base is always correct, even in source mode 
Bug: T153624
Change-Id: I3f74f67ce975f5b371ab42adf5213256ae816f7f
 2016-12-19 21:08:58 +00:00
Ed Sanders 323050467f Change wikitext link inspector name to avoid conflict 
This was causing the VE link inspector to fail badly if
NWE was enabled.

Bug: T153668
Change-Id: Ie665715a5f5401e59fc6468b81a4122ca5ebd5a3
 2016-12-19 12:03:58 +00:00
James D. Forrester d576fac49f MWTemplatePage: Show a link to the template even when there's a description 
Bug: T51772
Change-Id: Ia7084dc7dd4e4c092c0d24b123da19721dca54a9
 2016-12-18 21:56:12 +00:00
Translation updater bot 4a1cd55503 Localisation updates from https://translatewiki.net. 
Change-Id: I19262ad5964b36fc84551c68ede397705980d44a
 2016-12-18 22:18:37 +01:00
Translation updater bot 56ba9a9839 Localisation updates from https://translatewiki.net. 
Change-Id: I8f757626dd2ed47aa772ee5c19e4bec5fe72a8c5
 2016-12-17 22:25:49 +01:00
Translation updater bot 7a8b171d01 Localisation updates from https://translatewiki.net. 
Change-Id: I04e37ca08cc134ce68b667deda2fd101d62f6eb6
 2016-12-16 22:18:10 +01:00
jenkins-bot 2f790bb7a8 Merge "Show HTTP status alongside 'Unknown error' when it's not 200" 2016-12-16 18:51:57 +00:00
jenkins-bot 57d49550a0 Merge "Add shortcut for show preview and resolve access key conflicts" 2016-12-16 18:14:17 +00:00
Ed Sanders 4d134cfefc Add shortcut for show preview and resolve access key conflicts 
Refactor save dialog setup so logic for canPreview/canReview
is external and passed in.

'Show preview' will show in the VE command help dialog until
I56c1036e6 is merged in core.

Bug: T149914
Change-Id: Id718ad622be43c03df61d12b8688d53462c59f36
 2016-12-16 13:33:57 +00:00
Alex Monk a9feb8869c Show HTTP status alongside 'Unknown error' when it's not 200 
Change-Id: If14dc14f2cc43a1f12c1314342d5028ec524c31e
 2016-12-16 11:28:38 +00:00
Alex Monk 96b8d35bff Wrap localStorage.getItem calls in try { ... } catch () {} 
Bug: T153291
Change-Id: Ic4f8c390bfe6936bd182b28b1f2c6d19bf459eba
 2016-12-15 23:08:30 +00:00
Translation updater bot c8995a6a88 Localisation updates from https://translatewiki.net. 
Change-Id: Ifc8297cbb54b183ee024b085006f0f7e69fb473a
 2016-12-15 23:20:22 +01:00
jenkins-bot ee2cb3048d Merge "DesktopArticleTarget: Generate the original page title if needed" 2016-12-15 16:50:47 +00:00
jenkins-bot 552e21b74b Merge "Properly clear this.section when switching from VE" 2016-12-15 04:18:37 +00:00
Ed Sanders 9728d78126 Resolve URLs in show preview against correct base 
Bug: T153277
Change-Id: Icaa6de4618de008fb2024d1dd428114688cb1043
 2016-12-15 03:19:16 +00:00
Ed Sanders 17a164363b Properly clear this.section when switching from VE 
Bug: T153276
Change-Id: Idc251c73c03bf87b6e6ca716be98b38d4fb68c5e
 2016-12-15 01:34:30 +00:00
Ed Sanders c92418e4da Fix wikitext handling of DataTransferHandlers when IVStore is used 
Bug: T153269
Change-Id: Ida6ffffac6e6a65784dc84a388d3702680a79db9
 2016-12-14 22:56:18 +00:00
Ed Sanders 1b726dc9bc Fix DataTransferHandlers when loading source editor directly (no etag) 
Bug: T153268
Change-Id: I0b43fd651e26c3d74a5f29e8ed80e5dee28ac399
 2016-12-14 22:56:00 +00:00
jenkins-bot 9c448dd827 Merge "Use deep clone for empty convertFromSource" 2016-12-14 22:27:19 +00:00
Ed Sanders 854256bb8e Use deep clone for empty convertFromSource 
Bug: T153254
Change-Id: I0dc6be0d20020e3fb385c9d065f9395dbda5a6b6
 2016-12-14 22:09:25 +00:00
jenkins-bot 5042fe3360 Merge "Extra section title for edit summary in source mode" 2016-12-14 21:51:02 +00:00
Translation updater bot 01d75a2e86 Localisation updates from https://translatewiki.net. 
Change-Id: Ifdb762bec4c05e58c37ad9fc28b39ceee00d535d
 2016-12-14 22:27:17 +01:00
Ed Sanders 61c7cc4a95 Extra section title for edit summary in source mode 
Bug: T153245
Change-Id: I3b3465f269831152fd7a820027f44bfaada067a8
 2016-12-14 21:22:10 +00:00
James D. Forrester ccbf20496b i18n: Point to a better page for NWE feedback 
Change-Id: I43db0b4dcab051aa17f4ad033628aad770738c60
 2016-12-14 19:38:58 +00:00
Ed Sanders 856d480f7d Follow-up Ic1f1de26: Fix typo in edit tab selector 
Change-Id: I0ac685f1d942a7d40c6926b8ae8d751db04e1474
 2016-12-14 17:35:09 +00:00
jenkins-bot 593474912f Merge "Fix logic for create accesskey=v, and bind to onEditTabClick" 2016-12-14 01:30:17 +00:00
David Lynch b1aed096cb DesktopArticleTarget: Generate the original page title if needed 
When switching from the old wikitext editor to VE, we stored "editing..." as
the original page title. Then restored that when saving / switching to "read".
Instead, detect if we're on top of the classic editor, and use the pagename
message to make a plausibly-correct title.

Bug: T126077
Change-Id: Ib0289de71c3ae947ca0a3e45fe1e620378689c35
 2016-12-13 19:28:15 -06:00
Translation updater bot 176329e9d8 Localisation updates from https://translatewiki.net. 
Change-Id: Ie7ab044b53ba3a2f3a40dd89b50da13c4eba1a13
 2016-12-13 22:46:43 +01:00
jenkins-bot 56927ad512 Merge "SaveDialog: Align colour palette and ensure sufficient contrast" 2016-12-13 19:38:51 +00:00
Volker E 48db1c16f8 SaveDialog: Align colour palette and ensure sufficient contrast 
Align the colors used in the save dialog to OOjs UI's MediaWiki theme,
increasing the contrast of edit summary counter slightly to ensure WCAG
AA accessiblity levels. Also remove unnecessary duplicated CSS
properties, which are already inherited from OOjs UI styles.

Bug: T153086
Change-Id: Iee6b38e0b11f777dd0ffb0f6802d0b3d7349ddee
 2016-12-13 19:26:39 +00:00
Ed Sanders 22f4614eee Show save button on show preview page 
Bug: T151261
Change-Id: If80bb8e4e9e412572ab88d13d07a3f92dd353b31
 2016-12-13 18:10:09 +00:00
jenkins-bot dc897662bf Merge "Resize save dialog after showing captcha" 2016-12-13 17:19:20 +00:00
jenkins-bot 16c5d489fc Merge "Don't restore scroll position when doing real section editing (NWE)" 2016-12-13 16:33:16 +00:00
Ed Sanders db447733b0 Fix logic for create accesskey=v, and bind to onEditTabClick 
Change-Id: I69020652f2946626c443ef5b724cf92e7905f247
 2016-12-13 16:06:57 +00:00
Ed Sanders d2ea716902 Don't restore scroll position when doing real section editing (NWE) 
Bug: T152946
Change-Id: I969a8edd4f23bbe6c73855aac059df732102c560
 2016-12-13 15:44:54 +00:00
Ed Sanders 69c0fb189a Fix action=editsource URL rewriting 
Always look for links unless the only tab is VE.

Bug: T153054
Change-Id: Ic1f1de26fb77098fe62f6263a25c8a40de0e09a7
 2016-12-13 15:36:34 +00:00
Ed Sanders 1f3bb5c9e5 Add section= param to URL after loading target 
This wasn't such a big deal in VE because we load the full
page anyway, but in NWE it is more annoying if you reload the
page and are dumped in a different edit area.

Change-Id: If49569cbe1a2759d8cbbd7ee42dd1b88da39a946
 2016-12-13 15:31:57 +00:00
jenkins-bot c4dacd9d24 Merge "Don't focus save dialog during setup to avoid scroll jumping" 2016-12-13 15:31:23 +00:00
Ed Sanders 56c34fbf79 Follow-up I6eda4a7c: Fix typos in #updateTabs 
Change-Id: Ib80dec3fb199ea03609d5d0f242ac606052f24cc
 2016-12-13 15:19:05 +00:00
jenkins-bot a962e7de3b Merge "Support section=new in NWE" 2016-12-13 13:55:33 +00:00
Ed Sanders 4064c91b8e Don't focus save dialog during setup to avoid scroll jumping 
Bug: T153010
Change-Id: Ia535cd5d4ebfc01994f4e440bb5cb7efa5c40802
 2016-12-13 12:57:34 +00:00
Ed Sanders 5a8106773c Support section=new in NWE 
Bug: T150709
Change-Id: I1002b97060d642df0988da15860a36c13712bade
 2016-12-13 12:20:55 +00:00
Ed Sanders 37190c3e8d Resize save dialog after showing captcha 
Change-Id: I219a1eae442bd580760235f22eee15a836d5ebae
 2016-12-13 12:05:42 +00:00
L10n-bot 34fbe31e93 Merge "Localisation updates from https://translatewiki.net." 2016-12-12 21:54:27 +00:00
Translation updater bot ae76bac942 Localisation updates from https://translatewiki.net. 
Change-Id: I469815663e16164751f4c202228ff48249993f63
 2016-12-12 22:44:06 +01:00
jenkins-bot 669995c8c2 Merge "Follow-up ae8a2750: Stop passing long-dead second parameter" 2016-12-12 21:20:08 +00:00
Ed Sanders a504aba7c5 MWWikitextLinkAnnotationInspector: Select links after creation 
Change-Id: If23d90dc695546e7dddb3c04637e54df47c6f528
 2016-12-12 20:09:52 +00:00
Ed Sanders 2d645d1631 Use Surface#setDisabled instead of deprecated #disable 
Change-Id: Idf998ddc0b95efbf6befbcfa493c42b4c3ba1bfc
 2016-12-10 20:03:07 +00:00
Ed Sanders d555b5ba33 Cleanup handling of 'section' param 
Provide a common function to parsing, and always pass
section to the target, instead of having the target
re-compute it itself.

Change-Id: If9fc24ffa51507cd969fa1b4dfc1519a0b50a572
 2016-12-08 20:24:19 +00:00
jenkins-bot 397eb403cc Merge "Simplify #updateTabs" 2016-12-08 19:59:29 +00:00
Ed Sanders cd87e7483b Expand dummy surface to be at least valid 
Change-Id: I3888dd2f72858bbe79c61fa4a6f7967f21c5cb7c
 2016-12-08 19:36:57 +00:00
Ed Sanders 66e4a5cbe8 Simplify #updateTabs 
Change-Id: I6eda4a7c27f0b7590aae5505b0459ced07d2cc48
 2016-12-08 19:22:11 +00:00
jenkins-bot bdfff4a3b1 Merge "DesktopArticleTarget: clear out originalCategories when they're updated" 2016-12-07 16:46:06 +00:00
David Lynch d720041fd7 DesktopArticleTarget: clear out originalCategories when they're updated 
Bug: T152571
Change-Id: I41b5d5aeea0a01cf922924fa1320369d54fef8cf
 2016-12-07 09:48:26 -06:00
Alex Monk c843824c97 Batch gallery imageinfo requests via ImageInfoCache subclass 
Also get rid of .join( '|' ) for API request parameters per Bartosz

Bug: T147067
Change-Id: If4444cca300d65e28d6fb9003fcac5e076a5129a
 2016-12-06 22:10:19 +00:00
jenkins-bot a04cef294e Merge "Update for API error i18n" 2016-12-06 20:04:24 +00:00
jenkins-bot 446a4e40c4 Merge "SaveDialog inherits from plain dialog, not FragmentDialog" 2016-12-06 19:37:41 +00:00
jenkins-bot 9382e0630a Merge "DesktopArticleTarget: Rebuild the category links when they're edited" 2016-12-06 18:31:43 +00:00
jenkins-bot bdd1a1b78c Merge "Scroll highlighted item into view in gallery dialog" 2016-12-06 18:30:22 +00:00
jenkins-bot 9b4bc7a3f2 Merge "Disable heights option in gallery dialog when mode is slideshow" 2016-12-06 18:28:51 +00:00
jenkins-bot a2e4d9fa82 Merge "Decrease height of gallery search results for better fit" 2016-12-06 18:23:38 +00:00
David Lynch af8aad0483 DesktopArticleTarget: Rebuild the category links when they're edited 
This has to go to the API, because it's skinnable. Also, separates out a few
of the initial page setup functions so they can be re-applied to the new
content inserted.

Bug: T151651
Change-Id: I8d5a6504edc2e0486a0b4f016d8ee6d9a6228de9
 2016-12-06 11:28:08 -06:00
Translation updater bot 2ab755aca9 Localisation updates from https://translatewiki.net. 
Change-Id: Iab69a8d0ae63daccd64d3c40545e87897b6e6661
 2016-12-05 22:52:43 +01:00
Translation updater bot 19f580a9af Localisation updates from https://translatewiki.net. 
Change-Id: I9c43a7a5a9449bf555985696cf57340a4931e11a
 2016-12-04 22:41:24 +01:00
Ed Sanders aa7dba9bdb Follow-up Ifaf6a2607: Display correct message when switching 
Use new mode, not old mode for choosing switch message.

Change-Id: I1ad0913b4a23fd6fbf5cdeb07d1a58ec72398d57
 2016-12-04 15:51:57 +00:00
Ed Sanders 4f7bba4de9 SaveDialog inherits from plain dialog, not FragmentDialog 
Change-Id: I934ab41567ea68e58cfa27451faf499febd68bd1
 2016-12-04 11:09:56 +00:00
Ed Sanders f01d617c53 Bypass API call when wikitext is empty string 
Change-Id: Ie0cedfaae286f73e73bcde7bfca3cb2ae6197924
 2016-12-03 17:44:04 +00:00
Ed Sanders c97e0b58d4 NWE: Disable progress bar when pre-parsing for WindowAction's 
The progress bar dialogs interfere with the life cycle
of the window you are trying to open. Just disable these
progress bars for now to avoid catastrophic behaviour.

Change-Id: I77c8ae67a2d502bbd189836deb320cd55c3cb11a
 2016-12-03 17:20:24 +00:00
Thalia 2fd30fb7c5 Decrease height of gallery search results for better fit 
Bug: T151509
Change-Id: I92c812952457df99251fc0b8f1a17d4e55fe52f7
 2016-12-03 16:31:23 +00:00
Thalia 1b4d70324b Disable heights option in gallery dialog when mode is slideshow 
Also disable relevant fields the first time the dialog is
opened, not just when the dropdown is changed.

Bug: T151482
Bug: T151512
Change-Id: Ic511e1832a9fcaaeaed71c1d495aecc65fdd1d3b
 2016-12-03 16:00:32 +00:00
Thalia 0b9228a926 Scroll highlighted item into view in gallery dialog 
Bug: T152053
Change-Id: I6b77f6c27d5629dc18e421f984cf31badfb2ff04
 2016-12-03 15:46:58 +00:00
jenkins-bot e1e55aa730 Merge "Correct class/classes typo in gallery dialog" 2016-12-03 15:20:53 +00:00
Thalia 295dd380de Correct class/classes typo in gallery dialog 
Bug: T152226
Change-Id: I569df87cf82359c13ad61a3ddffacd83f5f03bae
 2016-12-03 13:03:02 +00:00
Ed Sanders 9ceb13ce60 Update VE core submodule to master (5be61ce) 
New changes:
860954b [BREAKING CHANGE] Parse selection before applying source tools

Local changes:
Implement convertFromSource/convertToSource in WikitextSurfaceFragment

Depends-On: Iaa41c49e2f8e28af28a8a64cb6915f705fa35e8c
Change-Id: I746619d442fb565cd582cb09de3126526c73c333
 2016-12-03 03:43:59 +00:00
James D. Forrester f494067dea Follow-up ae8a2750: Stop passing long-dead second parameter 
Change-Id: Ifc43d9009c2057b5a189d3cc161b62dc4ca83a2c
 2016-12-02 14:31:26 -08:00
L10n-bot 95af1ba8c1 Merge "Localisation updates from https://translatewiki.net." 2016-12-02 21:24:28 +00:00
Translation updater bot a131668e46 Localisation updates from https://translatewiki.net. 
Change-Id: Ie5e6281811ea14485f919a9efcea2f24b009838b
 2016-12-02 22:21:13 +01:00
Ed Sanders 9b5adb8688 Remove WikitextWindowAction, inherits from core 
Depends-On: I2b14cc93bf3c855e157f0b26567337f74992fb96
Change-Id: I3e479c1441f548f62ff8a2f6e7b2ad450262921f
 2016-12-02 11:50:43 -08:00
jenkins-bot 3064890a91 Merge "Clear preview when document is modified" 2016-12-02 02:45:29 +00:00
jenkins-bot 36d976c4c0 Merge "Save Dialog: add shortcut for opening to the review panel" 2016-12-02 00:36:40 +00:00
David Lynch 2bd34cebd4 Save Dialog: add shortcut for opening to the review panel 
Create a new MWSaveDialogAction, which can be hooked up to triggers. Switch
the existing save dialog accesskey to just use the trigger system.
(Maintaining all the accesskey logic, so we don't change the shortcut on
people.)

Bug: T149914
Change-Id: I9b4ef8504148703556f802b266a517dd5098c06b
 2016-12-01 18:16:18 -06:00
Ed Sanders 915bbec307 Clear preview when document is modified 
Use same logic for 'Show preview' as for 'Show changes'

Change-Id: I69510b426548fca46dc9b0d113b77ad206502b21
 2016-12-01 23:59:07 +00:00
jenkins-bot 4e05b86cf3 Merge "Use widget.getApi, not this.getApi" 2016-12-01 23:43:16 +00:00
jenkins-bot e3c0a05b84 Merge "Prevent endless error loop if falling back to wikitext (after a load failure) fails." 2016-12-01 23:17:42 +00:00
Alex Monk 5bd95db994 Use widget.getApi, not this.getApi 
Bug: T152154
Change-Id: Id7e77323ffabf4eeee3e73481cf6bcb9a1e649dc
 2016-12-01 22:48:45 +00:00
jenkins-bot d254436f57 Merge "Use canonical ve.dm.TransactionBuilder.static.newFrom* methods" 2016-12-01 19:44:05 +00:00
jenkins-bot 2b453295ec Merge "ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links" 2016-12-01 19:35:45 +00:00
Ed Sanders 8bca6cc777 Inherit more functionality from core source mode 
Change-Id: Id027681ab5f0c9f4b9ed127b583e45f0fe57ce69
Depends-On: I02f3849027a6652701c2d354d1b77ece9d1a56c1
 2016-12-01 18:44:54 +00:00
James D. Forrester a835f4f9d5 Use canonical ve.dm.TransactionBuilder.static.newFrom* methods 
Change-Id: I082048a677baa2699d94e21548373952d52db61b
 2016-12-01 10:43:10 -08:00
Ed Sanders 218742d806 Update VE core submodule to master (ae30d71) 
New changes:
f58ddea DiffElement: Use document slices with full internal lists
83800c0 DebugBar: Remove hard-coded i18n
b4f89e1 Update OOjs UI to v0.18.1
40c7bf6 Factor out active node functionality from SectionNode for captions
2d967be Move 'mode' property to surface, rename target property to 'defaultMode'
5d8c214 wrapAllNodes in sourcefragment
dd3d9e5 Refactor ve.dm.Transaction
9d61aca Use canonical ve.dm.TransactionBuilder.static.newFrom* methods
df4f72a Make table caption node an active node
b79f72d Core source mode
7533ac4 Localisation updates from https://translatewiki.net.
ae30d71 SourceSurfaceFragment: Check range is not collapsed

Local changes:
Get edit mode from surface where possible

Depends-On: Iec758c1892d518ad4bc2c0d1aaf6ca00fa354323
Change-Id: Ifaf6a26078b2731b374aaad2cb40c08928de9c84
 2016-12-01 10:40:01 -08:00
jenkins-bot 551b6db912 Merge "Fix "Add new image" button in the gallery dialog" 2016-12-01 00:25:49 +00:00
jenkins-bot be4c0df032 Merge "i18n: Kill last two uses of 'parameter' in lieu of 'field'" 2016-12-01 00:19:30 +00:00
Thalia 4b9d1bed4f Fix "Add new image" button in the gallery dialog 
Make sure the button is always visible in the
gallery dialog menu by fixing it to the bottom.

Bug: T151506
Change-Id: I560b0dffbaad9e18c6f7f703cb155356470580ee
 2016-11-30 22:38:11 +00:00
jenkins-bot b6a468d0ff Merge "Clearer English for visualeditor-preference-newwikitexteditor-description" 2016-11-30 22:30:13 +00:00
Amire80 d561894db6 Clearer English for visualeditor-preference-newwikitexteditor-description 
Change-Id: I698822637a212e4462c563cdf43e9b192459671b
 2016-11-30 23:59:08 +02:00
Translation updater bot 2edf528f0f Localisation updates from https://translatewiki.net. 
Change-Id: Ia83483409e59132a73cfce630a9f3ad6c00fb2a4
 2016-11-30 22:22:29 +01:00
Ed Sanders 37910b78ec MWTemplateTitleInputWidget: Use new #getApi method from upstream 
Depends-On: I81811cdd1a0750a8335432eee8f971ab9e0b8ee7
Change-Id: Ic73213df5ede6f82de85df8b69c60dd31f033792
 2016-11-30 19:51:45 +00:00
Bartosz Dziewoński 491ecfe1d6 ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links 
Bug: T151646
Change-Id: I693b190f762d93ffae0aa939ffc9550e567e8e24
 2016-11-30 19:07:50 +01:00
Translation updater bot fd3e5f8398 Localisation updates from https://translatewiki.net. 
Change-Id: Ib42d0dd37389381817efaefda3780bef0867db16
 2016-11-29 22:25:32 +01:00
jenkins-bot 745e919f97 Merge "Update VE core submodule to master (9625e8f)" 2016-11-29 20:46:54 +00:00
James D. Forrester 32c966db97 i18n: Kill last two uses of 'parameter' in lieu of 'field' 
Change-Id: I94fa70b17a210391b0444aca22c577b2e5e549e3
 2016-11-29 12:08:35 -08:00
jenkins-bot 33db54ef28 Merge "Use upstream media search widget from core" 2016-11-29 20:04:46 +00:00
Ed Sanders aeafa6afca Update VE core submodule to master (9625e8f) 
New changes:
f1297b8 [BREAKING CHANGE] Allow target widgets to be re-used

Local changes:
Re-use target widgets

Change-Id: I5decb918f398704d4b6c108a16fbc1cc073ef077
 2016-11-29 11:48:15 -08:00
jenkins-bot 28a4b9f362 Merge "Handle missing pipes in Gallery syntax, and remove them when caption is empty" 2016-11-29 19:27:52 +00:00
Ed Sanders 44fee9b61d Wait until search panel is shown before setting a search query 
Bug: T151659
Change-Id: I3eb3b903a8df1c7732da2a08e4b46b13b162617e
 2016-11-29 11:13:54 -08:00
Ed Sanders 2ee9e62a4d Use upstream media search widget from core 
Bug: T140166
Depends-On: If53ef7f4b62c7a5d4da565c14dd2a353778694e5
Change-Id: I28845e9c143e78d3a377f067606c62da212e3bf1
 2016-11-29 17:19:14 +00:00
James D. Forrester ba232c9f75 2017 Wikitext Editor: Tweak Beta Feature i18n to be less expansive 
Change-Id: Id9afdf27707f246a6c2f0fd69b92d239df88924b
 2016-11-28 16:55:14 -08:00
Translation updater bot 986abb0d0f Localisation updates from https://translatewiki.net. 
Change-Id: I54d71688837784c502dcb6d1615312986694a093
 2016-11-28 22:33:50 +01:00
Ed Sanders 240ec23113 Handle missing pipes in Gallery syntax, and remove them when caption is empty 
Bug: T146190
Change-Id: I703bcdf68b9631a47d839baf3abb42ff98b36bf2
 2016-11-28 17:36:29 +00:00
Translation updater bot f2c444c1bd Localisation updates from https://translatewiki.net. 
Change-Id: Ife8e7e01743c51b22ffacd8ac234434652bf3b10
 2016-11-27 22:34:20 +01:00
jenkins-bot 6bcfed97a5 Merge "Separate out ArticleTarget as a module" 2016-11-26 23:22:32 +00:00
Translation updater bot 6e0ce959d6 Localisation updates from https://translatewiki.net. 
Change-Id: I1ae8c3ead28026b79997175563d0a57175d39900
 2016-11-25 22:55:55 +01:00
Translation updater bot 3991a12bfe Localisation updates from https://translatewiki.net. 
Change-Id: Ica8875aafaf70d8ea6ae94a7eff98edf66de4108
 2016-11-24 22:23:28 +01:00
Ed Sanders 4fe6be1f34 Separate out ArticleTarget as a module 
Also move save button command help registration to ArticleTarget.

Bug: T151096
Change-Id: I941d17254a2e20a82aa46fd538abf887d757c0c3
 2016-11-24 12:35:41 +00:00
jenkins-bot 1909c445bb Merge "Allow the gallery dialog to insert duplicate images initially" 2016-11-24 04:13:03 +00:00
Ed Sanders 0334263718 Missing i18n in gallery dialog 
Change-Id: I369d5b9d42a5fd6b4d1afc12508632a282591320
 2016-11-24 00:09:49 +00:00
Translation updater bot 10d348af8b Localisation updates from https://translatewiki.net. 
Change-Id: Ie8f35a953ffb6e24acd7aa555b2cad555ee6e9f6
 2016-11-23 22:41:42 +01:00
jenkins-bot fde5c3c2ff Merge "Follow-up I63ab27cb: Get rid of notices tool when there are no notices" 2016-11-23 01:17:42 +00:00
Thalia 003ec7b653 Allow the gallery dialog to insert duplicate images initially 
Change I94f4fadd84cd3e prevents the gallery dialog from inserting
duplicate images into the gallery dialog after one request (e.g.
so double-clicking on an image in the search widget doesn't cause
the image to be inserted twice). However, galleries can
intentionally contain duplicates of the same image, so it is
possible to make a spearate request to insert a duplicate image.

When the dialog is first opened, it requests all the images in
the gallery at once, so the above change was causing the
duplicates in an existing gallery to be dropped. Duplicates
should be allowed to be inserted following this initial request.

Bug: T150894
Change-Id: I34353bc9b8db947488474c4be52292e0a1447705
 2016-11-23 01:02:35 +00:00
jenkins-bot 508b4164bd Merge "Let gallery dialog handle unprefixed filenames" 2016-11-23 00:33:39 +00:00
Alex Monk b89a6ee463 Follow-up I63ab27cb: Get rid of notices tool when there are no notices 
Bug: T151423
Change-Id: I3dd9d2cbfb1fa536490eb8b4b7d630e9c6cfdd48
 2016-11-23 00:30:06 +00:00
Thalia 2364f530a3 Let gallery dialog handle unprefixed filenames 
The namespace prefix before image filenames is optional
in galleries, but the API requires it. If the prefix is
omitted, add the file namespace prefix.

Change-Id: I3d126550c2ad2e84454122f92307ba4bc943780b
 2016-11-23 00:20:32 +00:00
jenkins-bot 3d8a749cf2 Merge "init: Initialise 'active' property in mw.Target instead of subclass" 2016-11-22 23:35:10 +00:00
jenkins-bot 8370b98e3f Merge "Move around code that sets up edit notices to ensure it runs after we receive the notices to display" 2016-11-22 23:27:26 +00:00
Alex Monk 16e294fba7 Move around code that sets up edit notices to ensure it runs after we receive the notices to display 
Bug: T151236
Change-Id: I63ab27cb236169f300295b2ed4c88e01048092e7
 2016-11-22 19:16:09 +00:00
Timo Tijhof cde3d2a7f8 init: Initialise 'active' property in mw.Target instead of subclass 
This is set to 'true' in mw.Target#setupSurface(), but not initialised or
used there in that class.

It was previous initialised in an indirect subclass (DesktopArticleTarget).
Move this to the parent class instead for clarity.

Change-Id: Ie3e12d254aa4b689fdce64620e110164311bc60a
 2016-11-21 18:06:52 -08:00
Ed Sanders 7f2d5b5bee Don't re-bind edit tab in DAT when using SET 
In SET the tab's events are already bound in DAT.init.

Bug: T151258
Change-Id: I04529dbdea2d2ff5e52b0f11035a4ac11946617b
 2016-11-21 22:09:26 +00:00
Translation updater bot 0757c5e242 Localisation updates from https://translatewiki.net. 
Change-Id: I70248fdc2480098dd966d59db36306e2e923cb77
 2016-11-21 22:42:09 +01:00
Ed Sanders 6e64fba2f8 Unbreak education popup 
Tools only setup once now, and that is during the dummy surface
phase, so we have to setup the education popups then.

Change-Id: Idf46fe42c893c0692dc442226297253074ef9bd7
 2016-11-21 15:19:58 +00:00
Translation updater bot 01cefc47db Localisation updates from https://translatewiki.net. 
Change-Id: I21e87c04625b6c87ac50ebcf8c014e6d2e29ed92
 2016-11-20 22:21:47 +01:00
jenkins-bot 8fd396151c Merge "Migrate DesktopWikitextArticleTarget code upstream" 2016-11-20 03:06:55 +00:00
Ed Sanders e1a887ccf8 Migrate DesktopWikitextArticleTarget code upstream 
Change-Id: Icca4715411737a561302b44b127d91d117e7e29b
 2016-11-20 02:52:14 +00:00
Translation updater bot 0b257c12db Localisation updates from https://translatewiki.net. 
Change-Id: Ie9a1877be552d5492c483cc7cb2468eba901212f
 2016-11-19 22:08:59 +01:00
Translation updater bot f64099f7cb Localisation updates from https://translatewiki.net. 
Change-Id: I314c1b19bc52e114055039301bf97ee7b4e0c36e
 2016-11-18 22:17:43 +01:00