Commit graph

11315 commits

Author SHA1 Message Date
jenkins-bot ada244c6f8 Merge "build: Bump all devDependencies to latest" 2016-03-10 16:56:45 +00:00
jenkins-bot 067a48bb3a Merge "Update VE core submodule to master (bf1f2cc)" 2016-03-10 16:47:49 +00:00
James D. Forrester dadd8b9cd2 Update VE core submodule to master (bf1f2cc)
New changes:
6fd5cb7 Update OOjs UI to v0.16.2
ec19ac3 CommandRegistry: Provide getNames method in command registry
b856b17 Protect against calling .classList on text nodes
bf1f2cc KeyDownHandlerFactory: Prevent duplication in handlerNamesByKeys

Change-Id: I0d53340427da414a44112497295112e67883db13
2016-03-10 08:20:39 -08:00
James D. Forrester ee9e6cb20e build: Bump all devDependencies to latest
* grunt-contrib-copy: 0.8.2 -> 1.0.0
* grunt-contrib-csslint: 0.5.0 -> 1.0.0
* grunt-contrib-jshint: 0.12.0 -> 1.0.0
* grunt-jscs: 2.7.0 -> 2.8.0

Change-Id: I8c4b3e1ad4e10217e9e048eacd8dedc8fe5caf02
2016-03-10 08:19:48 -08:00
Ricordisamoa 368ba19acd build: Tweak jscs jsDoc rule 'checkAnnotations'
Require some value for @this, @source and @see tags

Change-Id: Ief2243aa130d6396299ae7e865b5de6953c28f4e
2016-03-10 05:09:06 +01:00
Translation updater bot d36a099939 Localisation updates from https://translatewiki.net.
Change-Id: I32293b4f2532d15e65b71f09e53ac9c2e8817356
2016-03-09 22:48:24 +01:00
jenkins-bot 2e89f4f658 Merge "[BrowserTest] Disable failing language screenshots" 2016-03-09 17:32:57 +00:00
jenkins-bot 67fb8dd07f Merge "[BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError" 2016-03-09 17:31:27 +00:00
Timo Tijhof cf1d7c0dab mw.DesktopArticleTarget: Fix "Uncaught: Cannot read done of undefined"
Regression from 863a2c2974.

Sometimes when clicking "Switch to source mode" in the toolbar this
error is thrown and the interface freezes because setEditorPreference()
only returns a promise if the value is different.

> Uncaught TypeError: Cannot read property 'done' of undefined
> - ve.init.mw.DesktopArticleTarget.switchToWikitextEditor

Change-Id: Ie59f06a8ed9af9c4fb8199b013c06992d0c4f700
2016-03-08 23:13:11 +00:00
Translation updater bot d8a9a11ca7 Localisation updates from https://translatewiki.net.
Change-Id: Ia668efdeff27d984848c2bca823bf41d370706f9
2016-03-08 22:46:51 +01:00
Ed Sanders d5e594b9f6 Link inspector: Remove premature call to onLinkTypeIndexSet
This causes the inspector to take focus early (line 291) on
first load, and is not necessary as this method fires when
needed anyway.

Bug: T129228
Change-Id: Ia69f76b68e89daf5cb01449c40e71de4ec32d400
2016-03-08 16:54:09 +00:00
jenkins-bot 7261cf5364 Merge "Link inspector: make height consistent" 2016-03-08 16:50:02 +00:00
jenkins-bot 2932308166 Merge "Update VE core submodule to master (5d4881e)" 2016-03-08 15:23:11 +00:00
Ed Sanders 7f31507e12 Link inspector: make height consistent
Make the DOM order sensible so we don't have to
use SearchWidget's position:absolute hacks.

Bug: T129173
Change-Id: I3517e0e0cfe2ab0eee4bed7390e41710d3140eb0
2016-03-08 10:26:31 +00:00
James D. Forrester 80139533ab i18n: Don't refer to the name of the tab in the beta notice given it changes
Change-Id: I9beb322aeabece0df483271b33dbaa41f5da732a
2016-03-07 16:58:32 -08:00
James D. Forrester b247ffd7bd i18n: Explain to returning users that their preferences are mutable
Change-Id: I8a47725d7271af54b30f2130e97b08edec0f0b59
2016-03-07 16:56:13 -08:00
James D. Forrester 9a6650ae1f i18n: Relabel the SET preference and dialog to 'mode'
Change-Id: Id876f4ba102800237cbc4a671d4db9a26f7f116d
2016-03-07 15:51:19 -08:00
jenkins-bot 8d7baccd5f Merge "DesktopArticleTarget: Add Edge and MSIE to whitelist" 2016-03-07 23:28:58 +00:00
jenkins-bot 7a5f34fac3 Merge "Education popup: Also handle clicks on dots" 2016-03-07 23:28:55 +00:00
jenkins-bot 1a64d83138 Merge "Simplify showtabdialog logic a little bit" 2016-03-07 23:28:50 +00:00
jenkins-bot 39f3cfa4a7 Merge "Keep summary and checkbox selections when swtiching WTE->VE" 2016-03-07 23:17:08 +00:00
jenkins-bot 075f569e51 Merge "Update ArticleTarget for new API token handling" 2016-03-07 23:14:32 +00:00
jenkins-bot 6ed2d23b13 Merge "Don't give the user the option to discard changes when changing editor" 2016-03-07 23:14:29 +00:00
jenkins-bot 15f8efed70 Merge "DesktopArticleTarget.init#getLastEditor: Check values for validity" 2016-03-07 23:14:26 +00:00
James D. Forrester 3986326050 Update VE core submodule to master (5d4881e)
New changes:
51c16df LinkAnnotationWidget: Implement createInputWidget's documented config parameter
6678cc3 Localisation updates from https://translatewiki.net.
5444bbe build: Bump various devDependencies to latest
c8c93ab Search documentNode for unicorn, not document
2cf61b6 Use normal whitespace for focusable nodes
628de0e DimensionsWidget: Return numbers as documented
7c48393 ve.ui.CommentInspector: Simplify autoresizing

Change-Id: Ic70cf04898beac2a675851925e4978593bc6ac39
2016-03-07 15:04:40 -08:00
James D. Forrester 79d1f92b42 DesktopArticleTarget: Add Edge and MSIE to whitelist
Bug: T128447
Change-Id: Ia7afe4ddd5abd4fd1de85ba2d2df1fefa6735d79
2016-03-07 14:58:10 -08:00
jenkins-bot 4d34f9ad75 Merge "Follow-up I65d96627: Remember the user's preference in WikiEditor too" 2016-03-07 22:31:54 +00:00
James D. Forrester d8eb68d7b6 Don't give the user the option to discard changes when changing editor
Bug: T128585
Change-Id: I02f31e46ae7b2dc7505ed55fc56cd00f538a90e3
2016-03-07 13:39:32 -08:00
Translation updater bot 98052e165d Localisation updates from https://translatewiki.net.
Change-Id: I1e160b1149c6f0a5abb31ad51ba0a099de151a1f
2016-03-07 22:27:34 +01:00
James D. Forrester b0407d840d Follow-up I65d96627: Remember the user's preference in WikiEditor too
Oh dear.

Bug: T129130
Change-Id: I12481ded12f99ab1ba59dbd403c1eed038235fd9
2016-03-07 13:03:35 -08:00
jenkins-bot 789979f223 Merge "Try to fix handling of empty document on WTE->VE switch" 2016-03-07 19:48:22 +00:00
James D. Forrester 302aeefd85 DesktopArticleTarget.init#getLastEditor: Check values for validity
Change-Id: I23e0884a97b3689dd42c3df11a6311cd0601c348
2016-03-07 11:27:23 -08:00
jenkins-bot fe19bfb0af Merge "Use iconWhenInvisible for alien extension nodes" 2016-03-07 18:34:38 +00:00
Ed Sanders bbf86a6768 Use iconWhenInvisible for alien extension nodes
Change-Id: I0bc9bfd040685855402f705f46973e36c42dc0db
2016-03-07 18:15:45 +00:00
jenkins-bot c930ac2779 Merge "Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry" 2016-03-07 16:32:13 +00:00
Translation updater bot 4dd9110c18 Localisation updates from https://translatewiki.net.
Change-Id: I894adeef0ad09824fad0d3fff544ced1f7f3b1ae
2016-03-06 22:18:45 +01:00
Alex Monk 73969d74cd Simplify showtabdialog logic a little bit
Don't unnecessarily nest if statements, don't check tabs preference twice

Change-Id: I788d978b2e13030104be7ea295137a09abc032a8
2016-03-06 00:07:06 +00:00
Ed Sanders 5cc10a810a Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry
This allows extensions to register their own rules for detecting wikitext,
e.g. matching '<ref>'.

Bonus: Strip the autogenerated <references/> tag which
gets inserted when converting a <ref>.

Bug: T128805
Change-Id: I7a38db45d25e86ff3f3f6199aa04425ec98f7cc4
2016-03-05 22:47:00 +00:00
Translation updater bot bcb8aed482 Localisation updates from https://translatewiki.net.
Change-Id: Icffb9dc8b7f78d2debad38046ba42ea678b969ae
2016-03-05 23:01:12 +01:00
Ricordisamoa 993015e03b Update ArticleTarget for new API token handling
action=query&prop=info was being used because it can be combined
with action=query&meta=userinfo, while action=tokens cannot.

However, since MediaWiki 1.24 the 'intoken' parameter of
action=query&prop=info is deprecated, while the preferred way of
retrieving tokens is action=query&meta=tokens which not only can
be combined with action=query&meta=userinfo but also spares the
need of dealing with page ids.

Change-Id: I5ded3c303ede20514eeb2840715fe240b3b2c7e1
2016-03-05 14:44:07 +01:00
jenkins-bot ea11c33e6d Merge "Handle API errors when refetching the edit token" 2016-03-05 02:16:32 +00:00
Roan Kattouw 6322be2e07 Handle API errors when refetching the edit token
This can happen when the user gets logged out on a private wiki.
We get a badtoken error, so we try to refetch the token, which
itself returns an error. Token refetches didn't have error handling
at all and got the save dialog stuck in the pending state.

We can't offer the user to proceed with a different identity here,
because we encountered an error while trying to figure out what their
current identity is. The best we can do is encourage them to
log back in in a different tab.

Bug: T128934
Change-Id: I17d4452f688ec22631dbd12af223731635004d66
2016-03-04 18:06:33 -08:00
jenkins-bot 074885d7cf Merge "Follow-up 2c24efae: fix typo in event name for unknown save errors" 2016-03-05 02:01:57 +00:00
Roan Kattouw 84d534997e Follow-up 2c24efae: fix typo in event name for unknown save errors
This probably means we stopped logging unknown save errors
back in August.

Change-Id: I4a5bac244a469e73643e8a7d978d9212dd838fb0
2016-03-04 17:31:40 -08:00
James D. Forrester 022d7c2694 Update VE core submodule to master (f77ac2b)
New changes:
4cef3da ve.test.utils: Don't require QUnit expect() anymore
70ee810 Localisation updates from https://translatewiki.net.

Change-Id: If37267012a10e611b3eae63e58a5da3c77ab8fdb
2016-03-04 15:56:36 -08:00
Translation updater bot 0d94d8312d Localisation updates from https://translatewiki.net.
Change-Id: I92baebf577ce098877cff730f2ff8de4974f79b2
2016-03-04 22:56:47 +01:00
Željko Filipin dc3944726a [BrowserTest] Disable failing language screenshots
Bug: T119482
Change-Id: I165fcb2ee94430d29e287b80e13a48e05a021f77
2016-03-04 15:54:13 +01:00
Alex Monk dde45949a3 Try to fix handling of empty document on WTE->VE switch
Bug: T128635
Change-Id: Iff83e1d71e7186b8da875aa507f9e19e8d9c23ce
2016-03-04 02:05:41 +00:00
Ed Sanders 67c207a6f5 Use abstract target widget creation
Change-Id: Ic7e43e80f4f48df99842cee702963d54205e5055
Depends-On: I6a667a641540b347052ea0c645af4e1e59cf333a
2016-03-03 11:49:44 -08:00
Ed Sanders d64436cc0c Use new surface executeCommand method
Change-Id: I84c718d9da4b7dd0627ba37d9c29c3a25cc5d73e
Depends-On: Id975ea9da43654cd9991a302b49a9fb32782078e
2016-03-03 11:49:44 -08:00