Commit graph

15651 commits

Author SHA1 Message Date
James D. Forrester aba4eeeda5 build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
Bug: T220036
Change-Id: Ia081ff5429547cf1c7e6d6e8b0cae94e8ca3e0b9
2019-05-06 13:33:16 -07:00
jenkins-bot bc764b1644 Merge "Fix some bad math in CSS code comments" 2019-05-06 20:13:25 +00:00
Bartosz Dziewoński b9dfb5debb Fix some bad math in CSS code comments
Change-Id: Iff405ab0defabe0fff8f3b2ad2e86ceae78ef546
2019-05-06 21:53:15 +02:00
jenkins-bot dd262c5089 Merge "Fix diffs in non-section-editing mode" 2019-05-06 18:13:39 +00:00
Bartosz Dziewoński ff15a2ba47 Fix diffs in non-section-editing mode
If the editor was opened via a section edit link, but visual section
editing was disabled (the editor contained the entire article),
generating visual diffs would fail.

Follow-up to ec6cbeaf5e.

Bug: T222489
Change-Id: I74d589bb9f7ee09312ef816148c581440beb65e5
2019-05-06 19:39:25 +02:00
Translation updater bot 0d897967ae Localisation updates from https://translatewiki.net.
Change-Id: I5744e2d6385d33e83e76967ee1c4a62fa7ab66f6
2019-05-06 09:05:42 +02:00
James D. Forrester dd5a1f0285 Follow-up f9330c8564: Don't auto-add MWSaveTool
Bug: T222325
Change-Id: I1ccd43c6de51cd2fc8d4fc3291b1870b99736d80
2019-05-02 15:57:34 -07:00
jenkins-bot a1dd9de915 Merge "ve.ui.MWSaveDialog: More save panel disappearing on iOS Safari" 2019-05-02 00:19:33 +00:00
Bartosz Dziewoński c31cf00432 ve.ui.MWSaveDialog: More save panel disappearing on iOS Safari
Bug: T221289
Change-Id: I6ec40bd78f5c36a6033e800466124fcbb4f6446d
2019-05-01 22:43:49 +02:00
Translation updater bot d547853523 Localisation updates from https://translatewiki.net.
Change-Id: If0337c5fae7d08c2763d7cc7754b36f423e588e1
2019-05-01 22:30:38 +02:00
jenkins-bot f6a8a097f2 Merge "DesktopArticleTargetInitModule: Avoid expensive $msg->exists check" 2019-05-01 17:28:00 +00:00
Ed Sanders 8068198efc ArticleTarget: Return dataPromise from #load
Allows users to get hold of the data promise, as
this.loading is reset to false on completion.

Change-Id: I90452ac21c898185ec993b05c12f80ae2edfb814
2019-05-01 16:48:31 +01:00
jenkins-bot 78a0b4ea0f Merge "ApiVisualEditor: Return structured block info as well as formatted notice" 2019-04-30 21:07:52 +00:00
Ed Sanders fae9fcb70c ApiVisualEditor: Return structured block info as well as formatted notice
Mobile builds its own block message from the block information,
rather than using parseAsBlock.

Bug: T209599
Change-Id: I8b200f258b50f7048aded22ec7ab81a49937c5a9
2019-04-30 20:41:03 +00:00
Translation updater bot c1ee2f012f Localisation updates from https://translatewiki.net.
Change-Id: I37dfecc96f5520db732c20725e218122a76f52e0
2019-04-30 22:18:34 +02:00
jenkins-bot 857c1bd3d1 Merge "Replace the save button with a save tool" 2019-04-30 19:51:36 +00:00
jenkins-bot d85062d1d1 Merge "Fix switching without changes" 2019-04-30 19:37:03 +00:00
Ed Sanders f9330c8564 Replace the save button with a save tool
Now shows correct tooltip for save button (including
the access key).

Bug: T163142
Change-Id: If14a1a5a5829fc215cb79827392173dc05c4bdd7
2019-04-30 19:32:33 +00:00
jenkins-bot cd70d287de Merge "API: Use formatversion=2 by default" 2019-04-30 19:30:21 +00:00
Ed Sanders 934572cdf7 API: Use formatversion=2 by default
V2 has better handling for booleans.

Change-Id: I5388bd2cc64ae0c9ed4a185adce1e3bb4cdd92fc
2019-04-30 19:31:28 +01:00
Ed Sanders 30095b68c3 Make mobile check icon progressive blue
Bug: T222187
Change-Id: Ie713aa662bdc8bf9a74c6de8add4848b3d1499d6
2019-04-30 16:05:28 +01:00
Ed Sanders 7739b1c79b Fix switching without changes
* Remove 'discardChanges' from switchToWikitext. This was
  intended to discard changes even when the document was
  modified, but it is no longer used as we always keep
  changes if we can.
* Remove 'leaveVE' param, it was only used once and has
  been replaced with a direct call to switchToFallbackWikitextEditor.
* Don't reset 'section' if there are no changes.

Bug: T221981
Change-Id: Ia39345da44d203ba67ae331917c8d5ece7d42ef7
2019-04-30 14:52:58 +01:00
Translation updater bot 8c1f00ffd0 Localisation updates from https://translatewiki.net.
Change-Id: Iafb4b732248a2f55e7dd6099d8168f7aa78b277c
2019-04-29 22:16:32 +02:00
James D. Forrester e006803fdf Update VE core submodule to master (36e90285e)
New changes:
ec868af45 Don't allow merging cells that aren't editable
7d611c668 Demo: Set nullSelectionOnBlur when changing page
f9efedaba Remove focus code from LinearContext
690d22d08 WindowAction: Don't re-activate surface until teardown complete
7b2e88166 Update activeAnnotations when applying new annotation

Bug: T221716
Bug: T222039
Change-Id: Icb65c880d8407733192f4cb953899399ecbe87f3
2019-04-29 10:41:54 -07:00
jenkins-bot 33e157eb78 Merge "MediaDialog: Use new icons" 2019-04-29 17:38:57 +00:00
jenkins-bot 90966ac74e Merge "Improve rendering of audio files" 2019-04-29 17:09:51 +00:00
Ed Sanders 31dd73ae81 MediaDialog: Use new icons
Bug: T222086
Change-Id: I09c0a4e039de224d3cb0dd92855c559668ed35d3
2019-04-29 10:00:06 -07:00
Ed Sanders 258965c8b2 Improve rendering of audio files
Use a static image of an audio player.

Also disable resizeable handle.

Bug: T206022
Change-Id: Ic41f381e65c40c3682f470b9993b2c9dbbb506c5
2019-04-28 23:56:08 +01:00
Ed Sanders ec6cbeaf5e Only diff <section> contents in section editing mode
Bug: T221903
Change-Id: I5989d0c899d35ca8ac5af9cdecdfa5ea4f6c22e8
Depends-On: Ie8e2a88eddbeca5fbf47ab038964885f12718df7
2019-04-28 15:32:47 +00:00
James D. Forrester e437d25be8 Update VE core submodule to master (e1d2a6d8c)
New changes:
fff5c8c1c ve.dm.VisualDiff: Allow sub-trees to be diffed

Bug: T221903
Change-Id: Ie9c9674cb7e1532319a5276a107bcf2c6bd34b65
2019-04-28 08:29:49 -07:00
James D. Forrester f75ee24d05 Update VE core submodule to master (b68520b6d)
New changes:
b68520b6d Check selection is a TableSelection before looking for cells

Bug: T221901
Change-Id: If25bda1c0b970d92b89014c862457a7a417b58cd
2019-04-26 23:26:12 -05:00
jenkins-bot eff1df9c59 Merge "ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes" 2019-04-26 20:48:48 +00:00
Translation updater bot ffdd2f33b7 Localisation updates from https://translatewiki.net.
Change-Id: I94203ebb0b5e66eee60908ddce7cd82c869de86d
2019-04-26 22:28:39 +02:00
Bartosz Dziewoński 75ff121b29 ve.init.mw.DesktopArticleTarget.init: Update for Minerva changes
I think mostly the incompatible changes were made in commit
I5a7d73b20617cb3c6d6379084ac4bea23ec3bc74, but I didn't try
to track them down.

Also fix an issue where hrefs in section edit links generated
by this code were wrong.

Bug: T208102
Change-Id: Ibf6564bc0dcb7fcb420739a897b54346a01add02
2019-04-26 20:52:52 +02:00
Ed Sanders 4fb17205b6 Allow switching from mobile visual to mobile source mode with data
Bug: T128422
Depends-On: I11b7195e9d63f9b279213201036c6338d71669f0
Change-Id: Ieaa2df17c1f73d681d935cd6103ef41c061e1a28
2019-04-25 22:37:53 +02:00
Ed Sanders 709530993b DesktopArticleTarget: Remove changing document opacity when switching to WTE
When this was introduced in 7b2cacbe57
(2013), the confimation dialog was a generic confirm() popup. Now that
it is a OOUI dialog, the dialog overlay serves the same function.

Change-Id: I9812ab55c7a8179524865d93a6d269e388d4c4ab
2019-04-25 21:08:42 +02:00
jenkins-bot d39c28ca69 Merge "ve.ui.MWSaveDialog: Work around save panel disappearing on iOS Safari as well" 2019-04-24 22:25:59 +00:00
Translation updater bot c444f0e40a Localisation updates from https://translatewiki.net.
Change-Id: Ic11c1dff4e6161ffdb4c366a11a1e2d71fabb6ee
2019-04-24 22:21:43 +02:00
James D. Forrester b89221be3b Update VE core submodule to master (b049d6049)
New changes:
c544dfc40 ve.ui.DebugBar: Fix Filibuster button
2009d0427 Remove list-specific logic from LinearEnterKeyDownHandler
1ee05602a Don't reactivate after opening tools/windows on mobile
3538c3870 (De)activate table selection on context menu toggle
39be19b54 Re-use existing table selection when re-activating
59cf5cdbd Add more granular code coverage targets
d0ff41a71 Update OOUI to v0.31.5
b049d6049 ve.ce.TableArrowKeyDownHandler: Movement from merged cells must collapse selection

Bug: T220633
Bug: T221286
Change-Id: I443e665e8831defd098eb410264c404942f3e2ec
2019-04-24 14:34:39 -05:00
Ed Sanders e3846ed09b EditSummaryWidget: Don't highlight first automatically
Bug: T50274
Change-Id: If9d46116caac381bfc7264652429377e60bb2a0b
2019-04-24 17:58:46 +01:00
jenkins-bot fa50329f62 Merge "Use PageEditStash services instead of static methods" 2019-04-24 15:11:19 +00:00
Bartosz Dziewoński 11673b21ad ve.ui.MWSaveDialog: Work around save panel disappearing on iOS Safari as well
Same thing as Ifb49ede450cabdcd8303b298b62f2ac632809b53, for
a slightly different case that we missed.

Bug: T221289
Change-Id: I0ca287af87e1058620fbed75a50d40f01513a567
2019-04-24 15:56:58 +02:00
jenkins-bot 52f62b7fe7 Merge "Update VE core submodule to master (ac38ec869)" 2019-04-24 10:55:01 +00:00
jenkins-bot 25b0475434 Merge "Remove block notice tracking" 2019-04-24 02:47:26 +00:00
jenkins-bot dc5e49aad1 Merge "ve.ui.MWSaveDialog: Fix preview of redirects" 2019-04-24 02:45:28 +00:00
James D. Forrester 3320d8ec58 Update VE core submodule to master (ac38ec869)
New changes:
64bad457a Localisation updates from https://translatewiki.net.
a4586f717 toggleMobileGlobalOverlay: check whether the target exists before using it
4d2f18871 Update RangeFix 0.2.6 -> 0.2.7
3433770e0 Restore re-activation hack

Bug: T221291
Bug: T221600
Bug: T221669
Change-Id: I783924aa8ba03a9f5969a9c3fc0c1c381a3f5741
2019-04-23 17:32:22 -05:00
Bartosz Dziewoński 5b0bb28323 ve.ui.MWSaveDialog: Fix preview of redirects
Incorrect order of operations caused all metadata to be removed before
we looked for the 'mw:PageProp/redirect' metadata item.

Bug: T221686
Change-Id: Ifcf210ad772babe1019fd0cfbaa7bd60d0e7e5fe
2019-04-23 23:02:24 +02:00
Aaron Schulz e2fa08f0f8 Use PageEditStash services instead of static methods
Change-Id: I1bcda750a22dcacfffa0f7400411a7653806a82e
2019-04-23 12:45:21 -07:00
Ed Sanders e91df06c32 Restore external paste sanitization of DOM elements
Was accidentally removed in I366a091ff4.

Bug: T221668
Change-Id: I6631f47b0afcbfb81ee72234f0b1cdabb24c1a85
2019-04-23 19:48:49 +01:00
Dayllan Maza 96de1353d3 Remove block notice tracking
This is a clean up after collecting the necessary data related to
blocks and how often users see the block notices

See: https://phabricator.wikimedia.org/T189724

Bug: T214214
Change-Id: I532a0cd95009109ba25caa8dd31badd5c1900da7
2019-04-23 11:31:37 -04:00