Commit graph

3688 commits

Author SHA1 Message Date
Alex Monk 5931751771 Trim external link before validating
We already trim it before setting it as the actual annotation href

Bug: T103450
Change-Id: I4c7117d7e1e89c98abbafb999033ab7b5f58bdff
2015-07-25 19:42:33 +01:00
Alex Monk 8ae71e205a Stop removal of only template placeholder from transclusion
Bug: T95252
Change-Id: Ibf0537fd63f8315750e398f72807741187985b19
2015-07-25 14:47:36 +01:00
Alex Monk f76b57f1e6 Close the wikitext switch confirmation dialog if serialisation errors
Bug: T103632
Change-Id: Id9aede04ff4f8919770e578fac24ad4a1178b9a6
2015-07-25 14:32:17 +01:00
jenkins-bot 43eb2acf84 Merge "Change reference context title from 'Basic' to 'Reference'" 2015-07-24 19:22:01 +00:00
jenkins-bot af015c120d Merge "Make missingref references uneditable, not uninspectable" 2015-07-24 19:21:59 +00:00
Translation updater bot 8a17282802 Merge "Localisation updates from https://translatewiki.net." 2015-07-24 19:11:37 +00:00
jenkins-bot 6cbdd4fb47 Merge "ParameterWidget: Connect to Search results widget 'choose' events" 2015-07-24 19:11:17 +00:00
Translation updater bot 55299c5f14 Localisation updates from https://translatewiki.net.
Change-Id: I6dc2d8008f023c02b0eac79f3527b25b9be032ae
2015-07-24 21:10:35 +02:00
Ed Sanders 29116355e1 Change reference context title from 'Basic' to 'Reference'
'Basic' only makes sense in the context of other reference types.

Change-Id: I8137af3481e4ccbd2589e917e24898ff204440b6
2015-07-24 12:03:05 -07:00
Ed Sanders 97e0cd28a5 Make missingref references uneditable, not uninspectable
Depends on I1ba8978dd in core.

Bonus: remove not-allowed-cursor & highlight title (which was
broken) now that we can display this information properly.

Bug: T106810
Change-Id: I1800490ba1b8e10ff54b26372a8a78661c1c7d68
2015-07-24 12:03:05 -07:00
Florian b390a32fda ParameterWidget: Connect to Search results widget 'choose' events
Instead of using the removed 'select' event submission on SearchWidget.

Rename event fired by MWParameterSearchWidget to reflect the new re-
emissioned choose event.

Follow up: I7fa97f208da0b3b185f1b09b87fef9c9afaee2f1

Bug: T106696
Change-Id: I1d954a7243649d7834373537d70bfadf68f52c9d
2015-07-24 20:25:01 +02:00
Ed Sanders 8250c8ad54 Separate 'isMissing' micro cache from full link data cache
Bug: T106819
Change-Id: I72f52d63968aa1ac842b2aa503150cf114f9d711
2015-07-24 16:17:35 +01:00
Alex Monk 3b978f0b4e Add save button to review mode on save dialog
Bug: T69868
Change-Id: I393a37333ea4988547c82e1fa9747b5e034de9bd
2015-07-24 01:34:13 +01:00
Alex Monk 82fb5f609a Parse SpamBlacklist error on the server-side
The client won't be able to deal with templates etc.

Bug: T99830
Change-Id: I78611a3f061b1afd73de052aa9ddff48dc368f2d
2015-07-23 18:49:42 +00:00
jenkins-bot 31e45cf530 Merge "build: Drop last jscs over-ride and make pass" 2015-07-23 18:48:48 +00:00
James D. Forrester 57f8fc5368 build: Drop last jscs over-ride and make pass
Change-Id: I4ff60af79cfc6e09e284d51f9b7ac2afa900f0f5
2015-07-22 15:13:09 -07:00
jenkins-bot 8d467915f7 Merge "Revert "For empty / whitespace-only headings, output <p> instead of <h#>"" 2015-07-22 22:05:34 +00:00
Translation updater bot ee6714fbec Localisation updates from https://translatewiki.net.
Change-Id: Iafc851800bbc9c8ebe4e1ad24288fa295edc616f
2015-07-22 22:18:38 +02:00
Translation updater bot f3ca976c84 Localisation updates from https://translatewiki.net.
Change-Id: I3a76ab4a4683f236d43b53691ac68a0d0f8b2f14
2015-07-21 21:48:58 +02:00
jenkins-bot 9924be7acc Merge "[BrowserTest] Add prefixes to language screenshot messages" 2015-07-21 16:38:34 +00:00
Translation updater bot 164be9e07a Localisation updates from https://translatewiki.net.
Change-Id: If9029fc72338d9db0e026ba8ab8b9f4c67b8c110
2015-07-20 21:59:30 +02:00
Bartosz Dziewoński 9134ec2d73 Disallow typing newlines in the edit summary
Prevent typing newlines by pressing the 'Enter' key on the keyboard,
like in a single-line <input type=text />; and filter newlines from
pasted / IME'd text.

Also:
* Use 'classes' config rather than .$element.addClass()
* Remove no-op 'tabIndex' setting (this is the default already)

Bug: T106325
Change-Id: I42d18f51f5ca989818577d6f045f6a516bb5b121
2015-07-20 13:57:25 +02:00
Amir E. Aharoni d231bcbb19 [BrowserTest] Add prefixes to language screenshot messages
Change-Id: I96c01763d1003619e9c8b0f549a53a1956dde16a
2015-07-20 00:24:42 -05:00
Translation updater bot 307c182569 Localisation updates from https://translatewiki.net.
Change-Id: I5c53115b8a2e7b1bf50a0e948da3e574680a5322
2015-07-19 21:39:56 +02:00
Ed Sanders 8e0394da5c Support command whitelist feature
Depends on I87d8aa3 in core.

Bug: T106061
Change-Id: I694e4e5a83f281da92380a895b72611141838f42
2015-07-18 18:20:49 -05:00
Ed Sanders bb46c34255 Update VE core submodule to master (edaa19b)
New changes:
aab2e90 Localisation updates from https://translatewiki.net.
826055a [BREAKING CHANGE] Rename SurfaceWidget to TargetWidget

Local changes:
* [PULL THROUGH] Rename MWSurfaceWidget to MWTargetWidget

Bug: T94066
Change-Id: If578e15c1ee7effd5ca1d6073521a6c59caac255
2015-07-18 17:19:05 -05:00
Translation updater bot fb78225f76 Localisation updates from https://translatewiki.net.
Change-Id: I2e20ea382c59661ad6c387cfe0798064b61f65c2
2015-07-18 22:04:02 +02:00
Vikas S Yaligar d42e10cacb [BrowserTest] Added screenshots scenarios for links and categories
Also minor cleanup of rspec old "should" syntax, changed all occurences to
"expect" syntax.

Change-Id: I0c2dfc18d06812ed9da2f6c0056c95b7755e5afd
2015-07-18 15:39:28 +00:00
jenkins-bot 0e5a6aca32 Merge "Don't set browser-prefixed transition CSS classes" 2015-07-18 05:35:45 +00:00
jenkins-bot 3d6af458dd Merge "ve.init.mw.TargetLoader: Error when RESTbase load call fails" 2015-07-18 05:21:37 +00:00
Kunal Mehta 0653804151 Don't set browser-prefixed transition CSS classes
jQuery will take care of this automatically: <https://api.jquery.com/css/#css2>.

Follows up bf56f56f3e.

Change-Id: I4db46fc70a5446a9ffc9f6d4375fae3b53609ee0
2015-07-17 16:31:56 -05:00
Translation updater bot 2db8d335f8 Localisation updates from https://translatewiki.net.
Change-Id: I56ecd8fe4e6957fa9af3b0b716b0589260b994c4
2015-07-17 22:26:26 +02:00
Vikas S Yaligar 8b7b20b934 [BrowserTest] Add true internationalized content support to language screenshot
* All translations will be in tests/browser/i18n folder
* Hebrew json’s are added, which needs to be translated.

Paired with Zeljko.

Bug: T105466
Change-Id: I4ae516758fb01a41f0dcf53c7cf3e609c7601cf3
2015-07-16 14:47:56 -05:00
Translation updater bot 43eb3493a8 Localisation updates from https://translatewiki.net.
Change-Id: I68b9b35168115f8007297d4a097c22976fc2f165
2015-07-15 21:43:32 +02:00
jenkins-bot 78a629f46b Merge "i18n: Remove references to 'VisualEditor', instead say 'the visual editor'" 2015-07-15 15:35:47 +00:00
Translation updater bot 89b2054b0c Localisation updates from https://translatewiki.net.
Change-Id: I48e93e1833483204d1a877143b918edfe94a7680
2015-07-14 22:03:32 +02:00
Translation updater bot 16263c9a67 Localisation updates from https://translatewiki.net.
Change-Id: I8b7e871ec998cfd7fe958405e5cb1785368f04f8
2015-07-13 21:36:33 +02:00
jenkins-bot c451470224 Merge "Remove listeners from deprecated search widget 'select' events" 2015-07-13 15:17:22 +00:00
jenkins-bot b7631330a8 Merge "ve.ui.MWReferenceResultWidget: Remove unused 'divider' code and styles" 2015-07-13 15:11:48 +00:00
Ed Sanders 0c1eb0cf33 Remove listeners from deprecated search widget 'select' events
Attach listeners to search *result* widget 'choose' events instead.

Also, pass reference model as 'data' to MWReferenceResultWidget, instead
of index so we don't have to do a lookup later.

Change-Id: I8a9b7ddaa70e29406726ac8463582a8bcf813128
2015-07-13 17:06:28 +02:00
Ed Sanders 5fb8d3a4d0 ve.ui.MWReferenceResultWidget: Remove unused 'divider' code and styles
Also, tweak documentation.

Change-Id: Iaf5045bd65d0d484c8810f4bbe097d6710ca6e7e
2015-07-13 17:06:27 +02:00
Translation updater bot 3991fca8ea Localisation updates from https://translatewiki.net.
Change-Id: I0244f2550f52200365d17c181f3af1a0f127a8b3
2015-07-12 21:52:24 +02:00
Translation updater bot 2653374352 Localisation updates from https://translatewiki.net.
Change-Id: Icabe5b8d0612d0f0d3ba67043285c88fac733b4f
2015-07-11 22:08:20 +02:00
Alex Monk 7653dec439 ve.init.mw.TargetLoader: Error when RESTbase load call fails
No retry right now, but we should at least stop failing silently. Doing this
in a window.alert() for now, as OOUI isn't available at this part of the
page load just yet (that will be coming soon).

Bug: T97041
Change-Id: Iacb195667215ee69d3991e4c41651ab6042243c5
2015-07-10 18:13:37 -07:00
jenkins-bot b4cef1cf01 Merge "Never use original data optimisation when in clipboard mode" 2015-07-10 19:49:41 +00:00
Ed Sanders aeedd808cd Never use original data optimisation when in clipboard mode
In clipboard mode we need the full body regardless of if the reference
has changed since load or not.

Bug: T104230
Change-Id: Ie59e04d381f2fd2680e8af0cf05a80df71052822
2015-07-10 19:45:56 +00:00
Translation updater bot e45674e881 Localisation updates from https://translatewiki.net.
Change-Id: I37e335f6f0dcc739c06d67eaf20fdde4fc9c92ae
2015-07-10 21:16:58 +02:00
jenkins-bot 0f44091150 Merge "Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text" 2015-07-09 23:22:48 +00:00
Translation updater bot dc66b82009 Localisation updates from https://translatewiki.net.
Change-Id: I99c36d2efef9db27b4956e5ca243f3666a72a1e1
2015-07-09 22:05:40 +02:00
Ed Sanders 924c58a893 Revert "For empty / whitespace-only headings, output <p> instead of <h#>"
Functionality is now provided by Parsoid's scrubWikitext.

This reverts commit 884f301aa0.

Change-Id: I19f340a1c2d9718bfa05c6667042488f3a589719
2015-07-09 11:46:50 +01:00
Alex Monk b8c39de8ef Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text
Bug: T104838
Change-Id: I0f754c949e494744adab5f191b5e8acce0c5d0fe
2015-07-09 02:03:04 +01:00
Translation updater bot d69efc426d Localisation updates from https://translatewiki.net.
Change-Id: Ia23b26ce63a463a9bc4d1d512c092bd100fc8683
2015-07-08 21:57:53 +02:00
jenkins-bot 2cf60686af Merge "Check if links are 'known' rather than 'exist' locally" 2015-07-08 19:29:22 +00:00
Ed Sanders 8971edb480 Check if links are 'known' rather than 'exist' locally
This data is used for marking links red, but links which are known
but don't exist (e.g. interwikis) are not red.

Also fix bug in API caused by trying to return a value of (bool)true which is
apparently not allowed. Use (number)1 instead.

Bug: T104604
Change-Id: I599a513a27b31f7167e688d73bc3685141249971
2015-07-08 20:26:04 +01:00
jenkins-bot 3039da4e30 Merge "Fix section scrolling" 2015-07-08 18:32:03 +00:00
jenkins-bot c39bd98597 Merge "Revert "Make toolbar save button frameless"" 2015-07-08 15:38:55 +00:00
Ed Sanders be5df39f5b Fix section scrolling
Core code now has a scrollIntoView animation triggered on focus
which needs to be cancelled before we scroll to the section heading.

Change-Id: I5eb6a5c98b38c2510d2d7f0108fe56e607b34bd6
2015-07-08 15:34:43 +01:00
Translation updater bot 5f89a6ca6e Localisation updates from https://translatewiki.net.
Change-Id: I63422a4e87f7a2f25a935a86ce6104b5aaa2cfa5
2015-07-07 22:12:04 +02:00
Bartosz Dziewoński 652da4afab Revert "Make toolbar save button frameless"
This reverts commit cb11cbd2f5.

Actually not needed after 3d36cac7fc4808f708f03b66f5c099de440e4569
in OOjs UI, and would change the UI in unexpected way.

Bug: T103403
Change-Id: Ia30b168ea29d03aa76ad81d1f9894a67604fdc08
2015-07-07 14:21:04 +00:00
Marc Ordinas i Llopis 7a33613d23 Use Parsoid's new Cite HTML and CSS
Starting with I21fbbd3247bf7801e5ef9bd5312f95777f4dd6ef, Parsoid
will emit a new HTML for its Cite extension, which enables CSS
styling. In I487095df8a7c4241a14f7b4480360f6774130bec the new
module 'ext.cite.style' is added to the Cite extension to style
this new HTML format.

This patch
* Loads the ext.cite.style module if the Cite extension is
  present.
* Uses the new HTML format for the internal structure of
  reference and reference list nodes, so they are correctly
  styled.

Backwards compatibility: Only new HTML is used internally in VE,
so as long as ext.cite.style can be loaded the new styles will be
used. It does not depend on which format Parsoid returns, so this
patch only depends on the Cite extension patch, not on the Parsoid
one.

Note: The only way I've found of adding a ext.cite.style dependency
only if Cite is present is to register the whole
ext.visualEditor.mwreference module in the
onResourceLoaderRegisterModules hook. Maybe someone can point to
a better way?

Bug: T86782
Change-Id: Ibf333a502d64d2ed6e029221458b7c606554e414
2015-07-06 14:23:18 -07:00
Translation updater bot cfb378930f Localisation updates from https://translatewiki.net.
Change-Id: I986d1348c91a5ea36b621d1328b71a37fdaf34dc
2015-07-06 21:48:50 +02:00
James D. Forrester 9b5639681e i18n: Remove references to 'VisualEditor', instead say 'the visual editor'
De-emphasising the product name as it's intimidating and irrelevant to most
users what the name of the software they're using is. Leaving the beta
welcome dialog alone, as that's being worked on as a larger piece.

Change-Id: I92e82ed004f7615f96818872df5f64fec38fbee0
2015-07-06 11:10:38 -07:00
Translation updater bot 2b33948661 Localisation updates from https://translatewiki.net.
Change-Id: Ia9d325d773eadb417d9e6787529d7f299ec104b2
2015-07-05 22:02:13 +02:00
Translation updater bot 16e9083113 Localisation updates from https://translatewiki.net.
Change-Id: I6c8cbcb76bec5789fdaec223e95f0fe8269fac30
2015-07-04 20:40:09 +02:00
jenkins-bot 36dac12958 Merge "Use core dimension widget times separator" 2015-07-03 22:20:33 +00:00
James D. Forrester 57a86aa0e2 Delete the never-used 'MW alien' Beta Feature hook/i18n
The feature is now available for all, so this won't be needed.

Change-Id: I553c9473953651c0963609dd22a895e17c2e2af5
2015-07-03 12:41:20 -07:00
Translation updater bot 422d82448d Localisation updates from https://translatewiki.net.
Change-Id: I818b50c7dc9fee48b5263ed17e170e567633b3ca
2015-07-03 20:51:56 +02:00
Ed Sanders 84eadef74a Use core dimension widget times separator
For de-duplication, and because trailing whitespace is not allowed.

Bug: T104691
Change-Id: I2e65799daae7e57e6e638b3d6dcf968a6f4582c7
2015-07-03 13:21:29 +01:00
jenkins-bot 9e730bf528 Merge "Save dialog: Show reload link next to FancyCaptchas" 2015-07-02 22:39:26 +00:00
jenkins-bot 3321989d82 Merge "Populate the internal target lookup menu when the user opens the link inspector" 2015-07-02 22:39:23 +00:00
jenkins-bot de8afeb833 Merge "MWInternalLinkAnnotationWidget: Force 'Open' button to use full path" 2015-07-02 22:39:21 +00:00
jenkins-bot 052405565c Merge "Revert "Show <newarticletext> as surface placeholder, not an edit notice"" 2015-07-02 20:45:28 +00:00
Alex Monk a5281d01c7 Populate the internal target lookup menu when the user opens the link inspector
Instead of only having it be populated upon setup.

Bug: T97723
Change-Id: I5ead32625efa79289b38955546a5843adef13101
2015-07-02 20:37:13 +00:00
Jforrester 96285182b2 Revert "Localisation updates from https://translatewiki.net."
Not sure if a TWN config change happened, but this breaks the repo pretty epically.

This reverts commit 57237c2133.

Change-Id: I3ed8140e7a9e052d4c547724648ce8859c27db38
2015-07-02 20:22:21 +00:00
Translation updater bot 57237c2133 Localisation updates from https://translatewiki.net.
Change-Id: If27897fa36a70187b38899985e7a346d54eb0766
2015-07-02 21:30:19 +02:00
Alex Monk c912f4e6dc Save dialog: Show reload link next to FancyCaptchas
Bug: T103227
Change-Id: Ib0548aa8ce3e2322dedc9980323e6e1f1cd705a0
2015-07-02 20:12:34 +01:00
Esanders b2ff7aaa17 Revert "Show <newarticletext> as surface placeholder, not an edit notice"
This reverts commit 5ac5c7a05b.

Bug: T104227
Change-Id: Id86dd228c2c671758acc6d2d3314c92da8917472
2015-07-02 15:20:24 +00:00
jenkins-bot 6e601a9930 Merge "Make toolbar save button frameless" 2015-07-01 22:48:16 +00:00
jenkins-bot 859f6daee6 Merge "Show <newarticletext> as surface placeholder, not an edit notice" 2015-07-01 15:49:12 +00:00
Alex Monk 5ac5c7a05b Show <newarticletext> as surface placeholder, not an edit notice
Bug: T104227
Change-Id: If0e1df48c1b3818235f7e02220144d467fb78fe9
2015-07-01 15:46:09 +00:00
Ed Sanders bef186c874 ViewPageTarget-vector.css: Fix non-HD mode typo
Missing comma between two selectors

Change-Id: I3e2ab561991f5f11598be1460f65a239e3c0d7ca
2015-07-01 15:35:55 +00:00
Ed Sanders cb11cbd2f5 Make toolbar save button frameless
Depends on I26b540dd2 in oojs-ui for styling.

Bug: T101165
Change-Id: I075b8cecf9df2026fb1da17e2ebdf0d848a3d250
2015-07-01 12:12:50 +01:00
Translation updater bot e47587c4ab Localisation updates from https://translatewiki.net.
Change-Id: Iad3cab6fae48a54087787fd41436e05f7fb44749
2015-06-30 21:26:38 +02:00
jenkins-bot b9da7365ef Merge "Make texts of edit tabs' tooltips more helpful to new users" 2015-06-30 18:44:19 +00:00
jenkins-bot 78aba18b1e Merge "Use new hasContent method on linear data" 2015-06-30 15:47:42 +00:00
Ed Sanders 472c98053d Ensure placeholder styling matches document
Bug: T96593
Change-Id: I23bb1393a9a6779b70ed1004496f3ca6ff038e43
2015-06-30 09:47:34 +01:00
Ed Sanders 6822635158 Use new hasContent method on linear data
Change-Id: I430e628a9db30970ecdf6996bc51e7440a474077
2015-06-30 09:45:24 +01:00
Roan Kattouw 6aac8eed78 Follow-up 8112c3ba30: fix JS error on link inspector teardown
LinkAnnotationInspector in VE core calls
this.setAnnotation( null ); on teardown, which causes
MWLinkAnnotationInspector#onInternalLinkChange to be invoked
with a null fragment.

Bug: T103176
Bug: T104231
Change-Id: Ibb50ba1696609bebdfc2857ea292ee30b6b5126a
2015-06-29 23:53:49 +00:00
Bartosz Dziewoński 6d18641e4d Specify 'associatedWindows' for link and citation tools
Depends on I21fb955ecb697060263538914014d5712e013695 in core.

Bug: T98845
Change-Id: Id7f59c0095e8d85bb608bed0ab60603665fbca47
2015-06-29 16:26:32 -07:00
jenkins-bot 1beb1cb386 Merge "Don't add basic reference tool to catch-all" 2015-06-29 21:17:07 +00:00
James D. Forrester 71623b0e53 Make texts of edit tabs' tooltips more helpful to new users
We used to re-label the other edit tab but this fell away for Wikimedia users
when we switched from adding a new tab to replacing the old one via config;
over-riding 'tooltip-ca-edit' looks like the best way of doing this here. The
mention of wikitext means it's less of a shock to users.

Bug: T99271
Change-Id: I0cb871095c9e5e8ef5a3c73b3bb105079b451dec
2015-06-29 13:39:27 -07:00
Translation updater bot 686dd8bfb5 Localisation updates from https://translatewiki.net.
Change-Id: I3fc86154fb067959491636dc13f48d139be363cb
2015-06-29 20:53:14 +02:00
Alex Monk 93c2ac5014 Don't add basic reference tool to catch-all
Bug: T101130
Change-Id: I225da5cb6a9b961af556029166bdf728197475e4
2015-06-29 19:42:00 +01:00
Translation updater bot 90b9f93ed2 Localisation updates from https://translatewiki.net.
Change-Id: I7d166d58cf13358820c2500d9b7a55930f4c0474
2015-06-28 22:19:08 +02:00
Translation updater bot 7280466b2c Localisation updates from https://translatewiki.net.
Change-Id: I6d6f22ee28c71fd668b15514f2936318e31705c8
2015-06-26 22:00:09 +02:00
jenkins-bot e3f439d5fe Merge "Get rid of Category: prefix when looking up categories from the API" 2015-06-26 15:34:35 +00:00
jenkins-bot 112d1e3744 Merge "MWLinkAnnotationInspector: Get HtmlDocument in a different way" 2015-06-26 10:45:16 +00:00
jenkins-bot bd394194e3 Merge "ve.init.mw.Target: Strip all <script>/<object>/<style>/<embed> on save" 2015-06-25 23:45:00 +00:00
Alex Monk d4e2c55cfc Get rid of Category: prefix when looking up categories from the API
Bug: T103777
Change-Id: I27a81d832e3da7a0177d1c69af605c0525415b6b
2015-06-25 20:19:15 +01:00
Translation updater bot 4f2b052fc2 Localisation updates from https://translatewiki.net.
Change-Id: I20c73ce767aa2de9866fe93febe2da838d1197f7
2015-06-25 20:49:25 +02:00