wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 00:00:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

ve.init.mw.TargetLoader: Error when RESTbase load call fails

Browse source 
No retry right now, but we should at least stop failing silently. Doing this
in a window.alert() for now, as OOUI isn't available at this part of the
page load just yet (that will be coming soon).

Bug: T97041
Change-Id: Iacb195667215ee69d3991e4c41651ab6042243c5
This commit is contained in:
Alex Monk 2015-06-29 21:11:36 +01:00 committed by James D. Forrester
parent 052405565c
commit 7653dec439
4 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
extension.json
View file

@ -272,6 +272,10 @@
"ext.visualEditor.track",
"mediawiki.api"
],
"messages": [
"visualeditor-loaderror-title",
"visualeditor-loaderror-message"
],
"targets": [
"desktop",
"mobile"

2
modules/ve-mw/i18n/en.json
View file

@ -245,6 +245,8 @@
"visualeditor-linkinspector-illegal-title": "Invalid page title",
"visualeditor-linknodeinspector-add-label": "Add label",
"visualeditor-linknodeinspector-title": "Simple link",
"visualeditor-loaderror-message": "Error loading data from server: $1.",
"visualeditor-loaderror-title": "The editor could not load",
"visualeditor-loadwarning": "Error loading data from server: $1. Would you like to retry?",
"visualeditor-loadwarning-token": "Error loading edit token from server: $1. Would you like to retry?",
"visualeditor-mainnamespacepagelink": "Project:Main namespace",

2
modules/ve-mw/i18n/qqq.json
View file

@ -254,6 +254,8 @@
"visualeditor-linkinspector-illegal-title": "Warning that the entered text is not a valid page title.",
"visualeditor-linknodeinspector-add-label": "Label of button that converts an auto-numbered, external, labelless link into a labeled external link",
"visualeditor-linknodeinspector-title": "Title of inspector for editing auto-numbered, external, labelless links.\n\nSee also:\n* {{msg-mw|Visualeditor-annotationbutton-linknode-tooltip}}",
"visualeditor-loaderror-message": "Text shown in a message box when the editor fails to load properly due to a RESTBase call failing.\n\nParameters:\n* $1 - an error message",
"visualeditor-loaderror-title": "Text shown as the title of a message box when the editor fails to load properly for some reason.",
"visualeditor-loadwarning": "Text (JavaScript confirm()) shown when the editor fails to load properly.\n\nParameters:\n* $1 - the error message from the server, in English. e.g. \"parsoidserver-http-err\"",
"visualeditor-loadwarning-token": "Text (JavaScript confirm()) shown when the editor fails to load properly.\n\nParameters:\n* $1 - the error message from the server.",
"visualeditor-mainnamespacepagelink": "Name of a page describing the main namespace (NS0) in this project.\n{{doc-important|Do not translate \"Project\"; it is automatically converted to the wiki's project namespace.}}",

4
modules/ve-mw/init/ve.init.mw.TargetLoader.js
View file

@ -144,7 +144,9 @@
// Page does not exist, so let the user start with a blank document.
return $.Deferred().resolve( '' ).promise();
} else {
mw.log.warn( 'One of the load requests failed (unhandled).' );
window.alert( mw.msg( 'visualeditor-loaderror-message', 'HTTP ' + response.status ) );
mw.log.warn( 'RESTBase load failed: ' + response.statusText );
}
}
);