Commit graph

12943 commits

Author SHA1 Message Date
Ed Sanders 981dd6c250 Don't set oldid if it is equal to curId
Change-Id: I0fff55ab1e8d9c5c24b39526aa5d8a893cd99a2a
2017-04-07 11:49:30 +01:00
Roan Kattouw 1e7e9044c9 MWVESwitchPopup: Follow-up 445f8b76a0: apply adjustment to anchor instead
Otherwise the anchor isn't correctly aligned below the icon.

Change-Id: I73a9db9be63354f1fa459e844eb40be1d3130189
2017-04-06 16:33:53 -07:00
Roan Kattouw 445f8b76a0 MWVESwitchPopupWidget: Fix alignment by removing margin
Since the PopupWidget rewrite, margins for aligning popup anchors
should be set on the anchor itself, not on the popup.

Change-Id: If8237ae5edbc2e8c5cb99147f392aae52e642765
2017-04-06 11:50:43 -07:00
jenkins-bot d4438549e5 Merge "ArticleTarget: building summary in source mode, strip links from section titles" 2017-04-05 23:57:18 +00:00
Bartosz Dziewoński c45ad46433 Allow loading progress bar to appear on skins other than Vector and MonoBook
The styles are not specific to the Vector and MonoBook skins, but rather
to the MediaWiki and Apex themes of OOjs UI. Rename them to reflect that.

Change-Id: I757e8d96625feb8290cbf7837b5d801961cda344
2017-04-05 20:13:28 +02:00
David Lynch 758b2fd689 ArticleTarget: building summary in source mode, strip links from section titles
Bug: T162017
Change-Id: I76e96d1e36f7bad0b3e17d8bb842c6ad1172f8cc
2017-04-05 11:16:11 -05:00
Translation updater bot 6d453076a4 Localisation updates from https://translatewiki.net.
Change-Id: Idf887a77ec667314758aa550b43c0e7c1c95bcb1
2017-04-04 23:01:49 +02:00
James D. Forrester aa5728141d Update VE core submodule to master (19a6c389c)
New changes:
5082dcba0 Localisation updates from https://translatewiki.net.
19a6c389c Remove DiffElement DOM element when destroying

Bug: T161877
Change-Id: Iaa162c5f87fb81136d35b8a5c81034398116583e
2017-04-04 10:41:59 -07:00
Ed Sanders d50f49de82 MWExtension describeChanges: Actually return value of parent
Bug: T161357
Change-Id: I7a81ab68dc2f632bd6f380caafef2cba326ad0ef
2017-04-03 22:57:49 +02:00
jenkins-bot ae59abc35e Merge "Use tabs to indent in json" 2017-04-03 17:23:29 +00:00
Translation updater bot f3a898aeab Localisation updates from https://translatewiki.net.
Change-Id: Ib35521981875291c847bff7b8704c301b2d399db
2017-04-02 22:58:12 +02:00
Translation updater bot 1f8550a7d1 Localisation updates from https://translatewiki.net.
Change-Id: If4fc7506912c647e02214140cd46c4eebd3210e4
2017-04-01 23:09:54 +02:00
jenkins-bot c599a82fe8 Merge "MWSaveDialog: Run links through a render function for preview & visual diff" 2017-04-01 15:22:09 +00:00
Umherirrender a16812428e Use tabs to indent in json
Change-Id: Ib0372c86bcaac368f4dd68a512273b504ca9b6b2
2017-03-31 23:50:07 +02:00
James D. Forrester 8463524e18 MWSaveDialog: Run links through a render function for preview & visual diff
Provide a utility funcition in ve.init.mw.LinkCache to do this.

Also use this in ve.ce.MWTransclusionNode/ve.ui.MWPreviewElement, and
introduce to ve.ce.MWExtenionNode

Bug: T73900
Bug: T153535
Change-Id: Ieb9a0274b8c5ae1932c431546f09d18000fa6dd9
2017-03-31 10:51:35 +01:00
Bartosz Dziewoński 285a078b21 Check magic link autolink sequences also after paste
Bug: T161152
Change-Id: Ie308cdb287f805da888325d4c9ba6d3c35bd017c
2017-03-30 23:13:00 -04:00
James D. Forrester 7b992e1cfa Update VE core submodule to master (a6c25d08e)
New changes:
803e45655 Serialize/deserialize for Transaction and IndexValueStore
fff77990b build: Bump various devDependencies to latest
d926b3bed Update OOjs UI to v0.20.1
50cbc8af5 Fix disabling of surface
f2223fcdb Localisation updates from https://translatewiki.net.
daf59c3af ve.Node: Fix getRoot/getParent/getDocument documentation
8d877214f Update OOjs UI to v0.20.2
2ceaa8e23 ve.ui.Sequences: Allow optional execution after pastes

Bug: T161152
Bug: T161611
Change-Id: I07deafbfce86af99fce7db6501e43a62a330911a
2017-03-30 23:11:32 -04:00
jenkins-bot 9e69bd360f Merge "WikEditor switch widget: Fix styling regression since OOui 0.20.1" 2017-03-30 21:31:37 +00:00
Translation updater bot 9c0b32277e Localisation updates from https://translatewiki.net.
Change-Id: Ieafdeebf002dc7a8c7c01928a19185d25c351a56
2017-03-30 23:20:20 +02:00
Ed Sanders 1b1b95acd4 WikEditor switch widget: Fix styling regression since OOui 0.20.1
Change-Id: I489e45a587e2c10cfb60ade2b5f180f872495324
2017-03-30 22:18:54 +01:00
jenkins-bot 90c16eb1d4 Merge "MWTransclusionDialog: Move box-shadows to Apex-only" 2017-03-30 16:57:12 +00:00
Ed Sanders 2bc3bd75dd MWTransclusionDialog: Move box-shadows to Apex-only
Use solid borders for MW theme.

Change-Id: I4a5418d006adf0c7d47dc58624868cf6bb4b7de6
2017-03-30 17:03:35 +01:00
Ed Sanders 003800f75a Follow-up I88d45aad2: Fix selflink detection
data.title is not set in the cache, use the query title
instead.

Bug: T52497
Change-Id: I6a3047d3c18110052c70277781bc7be6ead2e7b4
2017-03-30 11:56:13 +01:00
jenkins-bot 1dc16af006 Merge "Render self-links as if they were <strong>s" 2017-03-30 09:17:00 +00:00
James D. Forrester cb875a6ccc Render self-links as if they were <strong>s
This is a little inelegant, but it works in both CE and transclusion
content.

Bug: T52497
Depends-On: If058843924c3b30c116df2520aef93a004d98a5d
Change-Id: I88d45aad2aaa45e71b433350986b19764603a1f2
2017-03-29 23:47:01 +00:00
jenkins-bot da05545faf Merge "Replace $wgVisualEditorSupportedSkins with a check for required elements" 2017-03-29 23:14:53 +00:00
Ed Sanders 6d891dc049 Pass section when resolving conflicts in NWE
Bug: T154217
Change-Id: I61f69df228fcbe25840b166a2081cacdb0417431
2017-03-29 22:21:17 +01:00
Translation updater bot 9e893b715b Localisation updates from https://translatewiki.net.
Change-Id: I4adc48e289d109cbde9c890551bdcb8314afa88f
2017-03-29 22:50:25 +02:00
Bartosz Dziewoński ae8b0a1f36 Replace $wgVisualEditorSupportedSkins with a check for required elements
The bare minimum of elements that must be present on the page for
VisualEditor to start and mostly work is:

* '#content' to attach our interface (toolbar etc.)
* '#mw-content-text' to replace with the editing surface
* '#ca-edit' to start up the editor

When those elements are missing (and we expect them to be present,
e.g. we're not on a special page), we print a console warning.

For example, VisualEditor now launches on Timeless and CologneBlue.
It does not launch and prints a warning on Modern and Erudite.
(It is actually possible to edit and save pages on CologneBlue,
although various pieces of the interface look funny.)

This does not change which skins we claim to support: these are still
currently only Vector, MonoBook and Apex. But it allows third-party
skin developers to more easily test the editor and fiddle with their
CSS to make it look right.

Bug: T161373
Change-Id: I97c786f3c8c795c238b10bef332a129ea26f86c2
2017-03-29 18:13:05 +00:00
jenkins-bot 11f562c4e2 Merge "Don't use '#content #firstHeading', unnecessarily specific" 2017-03-29 18:02:22 +00:00
Bartosz Dziewoński 645eb8e543 Don't use '#content #firstHeading', unnecessarily specific
Simply '#firstHeading' does fine.

Change-Id: I7c72496f0d58b86582bd33c018b618e1b75f2c7a
2017-03-29 17:37:29 +00:00
Bartosz Dziewoński 38db8bbe0e Consistently use #catlinks to refer to category links container
The element has both the class and the id set to 'catlinks'. This is
just for consistency, I have no preference on which to use.

Change-Id: Ic96b0f21fe790d0aa03bfd6366ba246e8493a038
2017-03-29 17:36:58 +00:00
jenkins-bot dbe529bed3 Merge "Add template: don't try to add invalid templates when enter is pressed" 2017-03-29 16:39:00 +00:00
jenkins-bot 256241c23d Merge "VisualDiff automated screenshots" 2017-03-29 16:14:43 +00:00
jenkins-bot 459b88d275 Merge "Separate screenshot test runner from specific tests" 2017-03-29 16:14:42 +00:00
David Lynch 1f1be831c0 Add template: don't try to add invalid templates when enter is pressed
Bug: T161715
Change-Id: I12eabe3588fbcbed0fa18b94de7de7239ba490c2
2017-03-29 10:53:17 -05:00
Ed Sanders c0e188c602 VisualDiff automated screenshots
Change-Id: I422fc459ebc41a98f46e1ff7365a8ccaea2501d2
2017-03-28 22:43:02 +01:00
Translation updater bot f5d6ab9aa7 Localisation updates from https://translatewiki.net.
Change-Id: Iade5455bc90d8ba51dc481b7a4e9ac82ed2cc1e3
2017-03-28 23:03:46 +02:00
jenkins-bot 16918a08cf Merge "ve.init.mw.ArticleTarget: Don't construct element IDs dynamically" 2017-03-28 17:23:11 +00:00
Ed Sanders e7346f57eb Separate screenshot test runner from specific tests
Change-Id: Ic0eb773086aa7b6078c5095c1ad89ef3f6236019
2017-03-28 18:15:25 +01:00
Bartosz Dziewoński 6a9f8a1417 ve.init.mw.ArticleTarget: Don't construct element IDs dynamically
Easier to find the usages this way.

Change-Id: I38ce1389af1d30ff1f5e0214b68d094a67da046f
2017-03-28 19:01:46 +02:00
jenkins-bot efc0cad89e Merge "MediaDialog: flag caption widget as being in a dialog" 2017-03-28 16:57:22 +00:00
David Lynch 9e86d17260 MediaDialog: flag caption widget as being in a dialog
This means that cmd+enter won't add a newline when it closes the dialog.

Bug: T161555
Change-Id: I738c9acf8cce437ce6bc4c8db29f28d1fff3d2c9
2017-03-28 11:43:59 -05:00
jenkins-bot d3df69ee99 Merge "ve.init.mw.DesktopArticleTarget: Refactor redirect interface handling" 2017-03-28 16:41:40 +00:00
jenkins-bot 3d9b2fbd8a Merge "DesktopArticleTarget: Make the waiting module list extensible" 2017-03-28 15:59:02 +00:00
jenkins-bot 0dfe429a1e Merge "ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing" 2017-03-28 15:43:09 +00:00
Bartosz Dziewoński 0462b6ed8f ve.init.mw.DesktopArticleTarget: Refactor redirect interface handling
Redirect pages have two extra things not present on normal pages:
* Redirect subtitle: the "Redirect page" shown under the page heading.
* Redirect page content header: the "↳ Foo" at the beginning of content.

Our handling was pretty messy and had some bugs (T161614).

Notable behavior changes:
* Update 'wgIsRedirect' in mw.config after saving the page.
* Use #mw-content-text rather than .mw-jump for inserting the fake .redirectMsg.
  .mw-jump is not guaranteed to exist on the page (it's a skin feature).
* Never replace the real .redirectMsg existing on the page, except by the
  new HTML after a page is saved. Our fake is separate now.

Bug: T161614
Change-Id: I96a5e45a71bf10bf6a2b501dc0cf81e6c37060ec
2017-03-28 17:40:23 +02:00
James D. Forrester 51dbeca930 Update VE core submodule to master (495cd7d65)
New changes:
e0651b2df Move -hasDescriptions class toggle into #renderDiff
94dbb244d Fix dm.BlockquoteNode to inherit from ContentBranchNode
8715f7be7 Remove superfluous setting of canContainContent when inheriting from CBN
88e5b918d Replace instanceof ContentBranchNode with #canContainContent
c4b404408 DiffTreeNode: Use getters for type and attributes
869f3d34a SurfaceFragment: Avoid double-annotating in insertDocument, as well
931bd2410 Localisation updates from https://translatewiki.net.
f0cdae3ab Disable double-click & enter on focusable nodes when model is not editable
cb9ba7137 sync-gh-pages: Add .nojekyll file
495cd7d65 Re-apply "Remove $returnFocusTo hack now null is supported upstream"

Bug: T143261
Bug: T161262
Bug: T161547
Change-Id: I1a54293f9a2e0b27adc4fa0708b8dc1fdcca16b0
2017-03-28 10:50:20 -04:00
Bartosz Dziewoński d905d705ce ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing
To reproduce: start editing a page, turn it into a redirect,
cancel editing and go back to view mode. The "Redirect page"
subtitle under the page title should disappear.

Note that #redirectsub is correctly spelled all lowercase,
unlike #contentSub.

This reverts commit 0e1bc7309b
and fixes the code instead.

Change-Id: Ibacd73122dfec63268a77794bc77c4b88876d3ee
2017-03-28 01:31:29 +00:00
jenkins-bot 57d57cdbbf Merge "ve.init.mw.DesktopArticleTarget: Remove unused code" 2017-03-28 00:50:50 +00:00