Commit graph

18832 commits

Author SHA1 Message Date
Kosta Harlan 9241add01e Allow hook implementations to modify params
This is needed because the $params array is then passed on to
ApiEditPage, so if the hook implementer wants to alter the data used
with the edit, it needs to be able to modify the $params.

See I494d72a42d9103c28c4d44077cfe0f1269fc7b00 for an example where
GrowthExperiments would like to modify the 'tags' parameter for an
edit.

Depends-On: Idd052281898f99e4f13f241d5633294b59b29329
Bug: T304747
Change-Id: Ia4842a1593028f5fa145de167ccf9b72efa81351
2022-03-29 11:31:30 +00:00
Translation updater bot 09a378d515 Localisation updates from https://translatewiki.net.
Change-Id: I9ce9d4d898bf7c41e690610aab06a3d8c0d7ca83
2022-03-25 08:35:29 +01:00
Translation updater bot dbf21a69c1 Localisation updates from https://translatewiki.net.
Change-Id: Ide53e51336412411d7291e55eb2ed64e829d36e0
2022-03-24 08:35:27 +01:00
Ed Sanders be2a1ccf62 Respect useeditwarning user option when tearing down target
Also invert logic and rename variables to make tests in tryTeardown
and switchToWikitextSection identical.

Bug: T294463
Change-Id: Icb86a676c3f315e4a3d229f46eb383dcd7959973
2022-03-23 14:55:13 +00:00
Translation updater bot dac7de1355 Localisation updates from https://translatewiki.net.
Change-Id: I6b452c770a11a794cd44b15b8b9b262612c917d2
2022-03-23 08:25:51 +01:00
Thiemo Kreuz a6f784c095 Fix hiding unused template parameters sometimes not working
We ended mixing two concepts in a single method:

* We need a method that allows us to create the parameter list widget
when it's needed, even if it's empty. This is relevant when a template
is entirely empty, and the first parameter is added. This wasn't
working. Instead the parameter list was created with all parameters.

* On initialization we either want all parameters to be shown, or only
used ones. But this code is only needed once, on initialization. I
ended inlining this code in this patch.

Bug: T300640
Bug: T304046
Change-Id: I6620a870e4420dcb8fecf522b3274458eeec891d
2022-03-22 15:41:55 +01:00
Translation updater bot a824d0c5c8 Localisation updates from https://translatewiki.net.
Change-Id: Ia8f70d7d541c0776e57adadc90c46525fa315748
2022-03-22 08:30:27 +01:00
jenkins-bot 47ac0d243b Merge "Set desktop context / inspector padding to -10px in vector-2022" 2022-03-22 01:14:31 +00:00
jenkins-bot ce9809d113 Merge "Fix resize of MWAceEditorWidget when setting up" 2022-03-22 01:03:48 +00:00
jenkins-bot b98de01cac Merge "Preserve classes on broken media elements" 2022-03-22 01:03:17 +00:00
jenkins-bot 1b45db6d4b Merge "Use "Author" in media dialog" 2022-03-22 01:01:30 +00:00
Bartosz Dziewoński aec82d9a88 Update VE core submodule to master (fc0e3ed33)
New changes:
88a3a714a Localisation updates from https://translatewiki.net.
9b7c4d0fe Localisation updates from https://translatewiki.net.
eaadf3e61 Call parent #setup method in Merge/SumCellsContextItem
ddcb5821d Pass overlay padding when building desktop context (inspector)

Bug: T304202
Bug: T304233
Change-Id: I23d90f62f854cf5dead32104f5ea9e16f9eaabad
2022-03-22 01:34:12 +01:00
Arlo Breault dfa1c315bb Preserve classes on broken media elements
A class, mw-broken-media, was added in
I92359048b42d32fe8a0f2cb79cd348cf5f2c56cc

Bug: T304010
Bug: T270150
Change-Id: I542d7d879868c9030ce00b2686cdfd0077e49491
2022-03-21 17:42:39 -04:00
jenkins-bot 43a06844f9 Merge "Fix review button shown when review panel is already active" 2022-03-21 17:12:37 +00:00
Thiemo Kreuz 6eaf0ef55b Fix review button shown when review panel is already active
These two lines forcefully enabled the review/preview buttons, even
when the review/preview panel is already active.

Bug: T300448
Change-Id: I6dbe6ee88728a65233a455b768f17bff668fe3a8
2022-03-21 11:37:58 +01:00
Adam Wight b079440068 Fix template dialog parameter padding on mobile
In the mobile view, parameters don't have left padding so some styles
should only be applied to the desktop stylesheet.

Bug: T304167
Change-Id: I1846512c21aae36f212fe142b7d96ac91e46854b
2022-03-21 09:53:22 +01:00
Translation updater bot 66b76c3958 Localisation updates from https://translatewiki.net.
Change-Id: I8f25d70af6ad2df1e12b2241774ba07947d073e1
2022-03-21 08:15:41 +01:00
Ed Sanders 2fa21ebcdb Use "Author" in media dialog
"Author" is used on Commons and in various places in
MultimediaViewer. Artist is not used in these places.

Bug: T267501
Change-Id: Iccd2d926537a7d4147e6cc8b5c2c9c1ecf4d6b27
2022-03-19 22:22:00 +00:00
Ed Sanders 8c36a630db Set desktop context / inspector padding to -10px in vector-2022
Bug: T258501
Depends-On: Ifaaa0dad4ecda3ff25d5fac54ccd2c95087d6f50
Change-Id: Id1f0a6d74740cf979de2b4a7f2a9f2e197615a13
2022-03-19 13:47:39 +00:00
Ed Sanders f6ea2e3457 Fix resize of MWAceEditorWidget when setting up
Bug: T303964
Change-Id: Ic8efbd7df74213fddaec987aff60e733f9550db2
2022-03-18 22:30:54 +00:00
Adam Wight bf7f022686 Fix right padding on inline descriptions without the new sidebar
This fixes a styling issue with inline descriptions, for the scenario
when the inline description feature is enabled but the new sidebar is
disabled.

Bug: T304167
Change-Id: Ida4da4605da5143de2a27725d87d5876aea7065c
2022-03-18 17:16:48 +01:00
jenkins-bot 7a0ff5b56a Merge "eslint: Lint root files with server rules" 2022-03-18 12:35:52 +00:00
Translation updater bot 6d52a3584b Localisation updates from https://translatewiki.net.
Change-Id: I4d9cfb4c2aea85da292f948feccc4752885be91d
2022-03-18 08:45:33 +01:00
Ed Sanders 60c2239e06 eslint: Lint root files with server rules
Change-Id: I872ab9dd7844eb8885dc30b40a2429875f7591c7
2022-03-17 23:39:53 +00:00
jenkins-bot 401da7ee13 Merge "Remove MWDismissibleMessageWidget and use MessageWidget's showClose option instead" 2022-03-17 11:43:33 +00:00
Translation updater bot 8059f845a3 Localisation updates from https://translatewiki.net.
Change-Id: I21a6287eaae469b68c13cb21ca80685d25cb5aac
2022-03-17 08:37:49 +01:00
Translation updater bot a2a73aab7d Localisation updates from https://translatewiki.net.
Change-Id: I864345e8072818e4b525bcfce2a3d28e8dbda1cf
2022-03-16 08:08:23 +01:00
jenkins-bot 32d9150762 Merge "Rename ve-mw/init/styles to LESS" 2022-03-15 23:16:32 +00:00
Ed Sanders 627bbc4aaf Rename ve-mw/init/styles to LESS
Change-Id: I50969b8798637368942b2d9315e7290f2c579f77
2022-03-15 22:16:59 +00:00
jenkins-bot cada5a3ab8 Merge "Extract template scrollToTop method" 2022-03-15 12:17:50 +00:00
Translation updater bot b1478e8b84 Localisation updates from https://translatewiki.net.
Change-Id: I4680f9e44776042d1e6a205d963d23c32ca293ed
2022-03-15 08:25:58 +01:00
jenkins-bot e3d68ed7d9 Merge "Namespace rest of the extension" 2022-03-15 04:28:44 +00:00
jenkins-bot f63c483b56 Merge "Remove Apex skin files" 2022-03-15 01:12:21 +00:00
Reedy 239fbb64e4 Namespace rest of the extension
Change-Id: I4f3e2793099d81401035ea282f268a3afaa03067
2022-03-14 22:27:15 +00:00
Bartosz Dziewoński b22ba16b14 Update VE core submodule to master (6dd669298)
New changes:
3206d66bb Use $.parseHTML() in tests where appropriate
c99d63f66 Localisation updates from https://translatewiki.net.
cd5798146 Update OOUI to v0.43.2
98c7288fd Fix margin wrapper paragraphs in placeholders too
639d81bd1 FocusableNode: Documentation typo fix
23daa81a0 Localisation updates from https://translatewiki.net.
e84c40a5d ve.ui.Sequence: Put optional arguments in a config object
c79dcf48f Add backtick sequence for <code> formatting

Bug: T299817
Change-Id: I56b77aae31b80e2fdef113d3431740340419d2f0
2022-03-14 22:42:35 +01:00
jenkins-bot 3424cf9c86 Merge "Improve messages about duplicate template parameters" 2022-03-14 13:19:59 +00:00
Translation updater bot 9e47ab1892 Localisation updates from https://translatewiki.net.
Change-Id: I699c55784025b2adad6a0e8c145495ceb6f4c1d0
2022-03-14 08:15:01 +01:00
Ed Sanders 1fdda82b58 Remove Apex skin files
The Apex skin (not to be confused with the Apex OOUI theme)
is abandonware. Keeping files around that pretend to support it
is just maintenance debt.

Change-Id: I176e4e25307ab8ca4166a6e9b55e3bec4f058d05
2022-03-12 14:23:23 +00:00
WMDE-Fisch 96dc96da8d Extract template scrollToTop method
Also putting the findFirstSelected to where it belongs.

Bug: T302965
Change-Id: Ibc56abfdf84a0b5eade5b6a44903d769f424206d
2022-03-11 12:30:51 +01:00
WMDE-Fisch 824648b32a Streamline hide unused handling
Extracted the state change so we do not need the `internal` var.

Change-Id: I0ce1afab35abf3e0e656ad1a3601513d55406537
2022-03-11 12:02:32 +01:00
jenkins-bot 4a8ca84ecc Merge "Scroll template outline into view when hiding unused" 2022-03-11 10:22:37 +00:00
Translation updater bot 4fa2e2b13f Localisation updates from https://translatewiki.net.
Change-Id: I2b897c2f96aedcebd6e90c8c309103271c19ba64
2022-03-11 08:33:34 +01:00
jenkins-bot 174c7a39f6 Merge "tests: Use ve.test.utils.newMwEnvironment()" 2022-03-10 22:51:26 +00:00
jenkins-bot ecbfa2c19e Merge "Follow-up I560d8080: Fix getTargetDataFromHref to work with different wiki configs" 2022-03-10 22:50:22 +00:00
jenkins-bot beded65e85 Merge "Preserve classes on media wrapper links" 2022-03-10 20:35:59 +00:00
Arlo Breault 79120fc16c Preserve classes on media wrapper links
Parsoid added a class and, without it, we get selser complaining
about wrappers being modified, similar to T214649.

The "image" class is removed since Parsoid never added it (although it
now has "mw-file-description" for a similar purpose) and the legacy
parser doesn't apply it indiscriminately.

It doesn't seem like VE supports editing the |link= media option; it
just tries to roundtrip what's there and drops it on edit.  The patch
here works with that limitation.

Galleries are found to drop href's, breaking selser, and should be fixed
in a follow up.

Bug: T292657
Bug: T303469
Change-Id: I92359048b42d32fe8a0f2cb79cd348cf5f2c56cc
2022-03-10 10:41:14 -05:00
jenkins-bot 35e1f36b7b Merge "ApiVisualEditor: Remove $wgTitle hack, set page for {{PAGENAME}} when needed" 2022-03-10 13:07:10 +00:00
Translation updater bot f26359933c Localisation updates from https://translatewiki.net.
Change-Id: Id81c93d432af3fc66f7a222c6fb36720e5cdb182
2022-03-10 08:19:56 +01:00
Ed Sanders bc0e96f78a tests: Use ve.test.utils.newMwEnvironment()
This calls "parent" methods automatically, and allow us to
pass a config parameter for MW config.

Change-Id: I571d4599d7fca55727070bcac6083d1232b1f61c
2022-03-10 01:44:11 +00:00
Ed Sanders 77719b873c Follow-up I560d8080: Fix getTargetDataFromHref to work with different wiki configs
Change-Id: I8324a72418080beb3944314decc6792850392812
2022-03-10 01:10:45 +00:00