wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 08:10:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Streamline hide unused handling

Browse source 
Extracted the state change so we do not need the `internal` var.

Change-Id: I0ce1afab35abf3e0e656ad1a3601513d55406537
This commit is contained in:
WMDE-Fisch 2022-03-11 12:02:32 +01:00
parent 4a8ca84ecc
commit 824648b32a
1 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineToggleUnusedWidget.js
View file

@ -42,22 +42,32 @@ OO.inheritClass( ve.ui.MWTransclusionOutlineToggleUnusedWidget, OO.ui.ButtonWidg
* @fires toggleUnusedFields
*/
ve.ui.MWTransclusionOutlineToggleUnusedWidget.prototype.onClick = function () {
this.toggleUnusedParameters( !this.showUnusedFields, false, true );
this.toggleUnusedParameters( !this.showUnusedFields, true );
};
/** @inheritdoc */
ve.ui.MWTransclusionOutlineToggleUnusedWidget.prototype.setDisabled = function ( disabled ) {
ve.ui.MWTransclusionOutlineToggleUnusedWidget.super.prototype.setDisabled.call( this, disabled );
this.toggleUnusedParameters( this.showUnusedFields, true );
this.updateState( this.showUnusedFields );
};
/**
* @param {boolean} showUnused
* @param {boolean} [internal]
* @param {boolean} [fromClick]
* @fires toggleUnusedFields
*/
ve.ui.MWTransclusionOutlineToggleUnusedWidget.prototype.toggleUnusedParameters = function ( showUnused, internal, fromClick ) {
ve.ui.MWTransclusionOutlineToggleUnusedWidget.prototype.toggleUnusedParameters = function ( showUnused, fromClick ) {
if ( this.updateState( showUnused ) ) {
this.emit( 'toggleUnusedFields', this.showUnusedFields, fromClick );
}
};
/**
* @private
* @param {boolean} showUnused
* @return {boolean} Returns true when state changed.
*/
ve.ui.MWTransclusionOutlineToggleUnusedWidget.prototype.updateState = function ( showUnused ) {
showUnused = showUnused || this.isDisabled();
if ( showUnused !== this.showUnusedFields ) {
this.showUnusedFields = showUnused;
@ -65,10 +75,9 @@ ve.ui.MWTransclusionOutlineToggleUnusedWidget.prototype.toggleUnusedParameters =
'visualeditor-dialog-transclusion-filter-hide-unused' :
'visualeditor-dialog-transclusion-filter-show-all'
) );
if ( !internal ) {
this.emit( 'toggleUnusedFields', this.showUnusedFields, fromClick );
}
return true;
}
return false;
};
/**