wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-27 15:50:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Target#tryTeardown should succeed when target isn't active

Browse source 
It makes other code easier to write when we want to make sure
that no target is active.

Change-Id: Ica75f8334ef32ffbcc59109a46624acdf271847d
This commit is contained in:
Bartosz Dziewoński 2023-02-07 00:03:07 +01:00
parent 8eb272c2be
commit 5736f8ead6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
View file

@ -551,7 +551,7 @@ ve.init.mw.DesktopArticleTarget.prototype.teardownNewSection = function ( surfac
*/
ve.init.mw.DesktopArticleTarget.prototype.tryTeardown = function ( noPrompt, trackMechanism ) {
if ( this.deactivating || ( !this.active && !this.activating ) ) {
return this.teardownPromise || ve.createDeferred().reject().promise();
return this.teardownPromise || ve.createDeferred().resolve().promise();
}
// Just in case these weren't closed before