Commit graph

7542 commits

Author SHA1 Message Date
kaldari 849328c41f Split off core image components from pieces needed for image inspector
In mobile we define images as alien nodes, but still need for them to
be properly styled. This will allow us to give them proper HTML/CSS,
but without loading all the inspector code that we don't need.

Change-Id: I801340bd9c40270b8e77bde3d18f721866f753e6
2014-06-06 14:51:21 -07:00
jenkins-bot 06705465ec Merge "Fixing issues in the alignment select in Media Edit dialog" 2014-06-06 01:32:49 +00:00
Moriel Schottlender 8bca6add25 Fixing issues in the alignment select in Media Edit dialog
Fixing the behavior of alignment select and checkbox in the edit
dialog. Adding a check on all UI events to make sure they update
the model only if the model value is different than the UI value.

Also adding the ability to check the default direction of a
specific node type, to predict default alignment values.

Bug: 65916
Change-Id: I82f624fa788383dec0a12afb473aef01593e670e
2014-06-05 21:20:44 -04:00
Translation updater bot cc41066a29 Localisation updates from https://translatewiki.net.
Change-Id: I444e22b7097f8f42fc8fdf5b89c0d1a0515993a4
2014-06-05 20:47:37 +00:00
Cmcmahon 56684a9847 [BrowserTest] Update gems in support of WMF Jenkins
Next step in porting from Cloudbees

Change-Id: I1a9cc0a53f6d3edf01826ffbeb70b3f6f20da8fe
2014-06-05 10:01:45 -07:00
jenkins-bot 7573927724 Merge "[BrowserTest] new test for page options" 2014-06-05 16:56:46 +00:00
James D. Forrester 6e7bd901e7 Update VE core submodule to master (7a4d039)
New changes:
e33aeaf Update OOjs UI to v0.1.0-pre (6379e76bf5)
c0bfdb0 Apply 'default' or 'custom' size on load
62da3a2 Localisation updates from https://translatewiki.net.
001956f Grunt: Clean up
644d010 Move comment down so DOCTYPE is on first line
55b1ff9 Skip history#replaceState if not available
2f39260 Localisation updates from https://translatewiki.net.
34e22ae Fix potential race condition with nulling out Dialog/Inspector fragment
7a4d039 Update OOjs UI to v0.1.0-pre (cbc62ac803)

Change-Id: I9d04bfcb30ced7c98c0f72350f1f25732a76205b
2014-06-04 17:18:28 -07:00
jenkins-bot a733ea2aa3 Merge "Use promises for confirmation dialog instead of done event" 2014-06-05 00:16:21 +00:00
jenkins-bot 27abd137fc Merge "Update image size after changing type" 2014-06-04 23:50:54 +00:00
Moriel Schottlender 8ca025be5e Update image size after changing type
Make sure that if the image has default dimensions set up in the
media edit dialog, the scalable (and image CE rendering) receives
the correct dimensions.

Bug: 65886
Change-Id: I6bd2d1681a3d780554767fe77b2640795170184f
2014-06-04 16:48:43 -07:00
jenkins-bot cc14f33be9 Merge "Followup to small SVG default size" 2014-06-04 23:44:24 +00:00
Moriel Schottlender 4355ea4f10 Followup to small SVG default size
Make sure svg drawings on block images have the default size as
the wiki default, no matter their original set size.

Also took the opportunity to clarify the synchronization method
for scalable and image type in ve.dm.MWImageNode and call it when
the image model is loaded to make sure the details are always
synchronized before edit.

Followup to I682d832e456a501836f33ed1dfc7dbd78a4edf53

Bug: 62893
Change-Id: Ic47016d171634c532092067957cc2c3d431e9746
2014-06-04 19:38:15 -04:00
Alex Monk bc0049bc7c Change padding on media search results so we can display 4 results on a row with a scrollbar
This appears to fix the issue, no idea if it's the 'correct' solution or not.

Bug: 64911
Change-Id: If75272101cb60097345bcc0b77c16659beaf33cc
2014-06-04 16:34:17 -07:00
jenkins-bot 462a84787f Merge "Add tabindexes to template editor and required attribute where appropriate" 2014-06-04 23:28:21 +00:00
jenkins-bot 0ce474ab47 Merge "Don't allow inserting blank citations" 2014-06-04 22:57:27 +00:00
Alex Monk da5398909e Don't allow inserting blank citations
Bug: 64715
Change-Id: I76782bda12f7fbd7a162f179b78e1a36187a9257
2014-06-04 23:52:22 +01:00
Krenair 652136d712 Add tabindexes to template editor and required attribute where appropriate
At the moment, the natural tab order appears to simply ignore the info and
removal buttons

Bug: 65474
Change-Id: Ib18a9f7b0ce614bed9fee1199f1d36bc4bc012b9
2014-06-04 23:39:36 +01:00
jenkins-bot c8358205bd Merge "Adjust default alignment when switching from inline to block" 2014-06-04 22:37:06 +00:00
jenkins-bot 55952a32b3 Merge "Use subpage only for media search string" 2014-06-04 22:10:29 +00:00
jenkins-bot d69960aa1a Merge "Check last existing category for whether or not we're trying to re-add it" 2014-06-04 22:10:21 +00:00
Cmcmahon 336c1b8690 [BrowserTest] new test for page options
First pass at an Options test.

Checked in Firefox and Chrome

Change-Id: Ic5e6ec84d291c1642b8e4673c1a33517529e314b
2014-06-04 13:07:45 -07:00
Translation updater bot 957f2f3956 Localisation updates from https://translatewiki.net.
Change-Id: I3b91b9a33993ac91c6d97eaef5c249ac0dc69c78
2014-06-04 19:54:45 +00:00
Krenair 72f3c7808b Check last existing category for whether or not we're trying to re-add it
We were checking all the ones before it, just not the last.

Bug: 66105
Change-Id: Ic22233181a92860c288aa4e3176c469eba58ed43
2014-06-04 20:04:26 +01:00
jenkins-bot a6014563bc Merge "Small SVG images should still adhere to default thumb size" 2014-06-04 17:43:16 +00:00
jenkins-bot d8b44845e5 Merge "Gallery editor: Fix 'inpsector' typo to 'inspector'" 2014-06-04 17:07:47 +00:00
jenkins-bot 70fc15d6b3 Merge "Bump the MW required version to 1.24wmf6" 2014-06-04 04:03:01 +00:00
Timo Tijhof 0c60733ec5 Grunt: Clean up
* Use jshintrc:true which lets grunt defer autodiscovery of the file
  to jshint instead of forcing it to '.jshintrc'. This allows us to
  override certain settings from a subdirectory, to match behaviour
  of standalone jshint.

* Sort modules.

* Use plain string instead of single-value array.

Change-Id: Ib5cd48f3ff0367b8fc84627c29e4fb32452087c0
2014-06-04 05:07:12 +02:00
Moriel Schottlender cb35312c0b Use subpage only for media search string
In namespaces that allow for subpages, use the subpage part of the
page title for the initial search string in the MediaInsertDialog
search widget.

Bug: 51290
Change-Id: I31db88b484eee2206719dc337fbd7c70aef93b3a
2014-06-03 16:54:46 -04:00
James D. Forrester a3d51c0382 Bump the MW required version to 1.24wmf6
As of I87e93777 VisualEditor-MediaWiki now use the new MediaWiki core RL
module of mediawiki.skinning.content.parsoid, introduced in 1.24wmf6,
which has bumped our dependency to an alpha of 1.24.

Change-Id: I33db154980ec207edab75751d60cb4764144f32b
2014-06-03 13:46:12 -07:00
James D. Forrester 7f5acf6abe Gallery editor: Fix 'inpsector' typo to 'inspector'
Change-Id: Ia10987fb35549e721fa0242164f99a872512e569
2014-06-03 13:24:33 -07:00
Translation updater bot 0ef20f99f8 Localisation updates from https://translatewiki.net.
Change-Id: I94f658418782a3c33a8de3301f1c90813ceee969
2014-06-03 19:52:57 +00:00
Moriel Schottlender 6e096fcaef Small SVG images should still adhere to default thumb size
Make sure that SVG drawings have default size of the wiki default
even if their optimal defined size is smaller.

Bug: 62893
Change-Id: I682d832e456a501836f33ed1dfc7dbd78a4edf53
2014-06-03 13:47:18 -04:00
Moriel Schottlender 74a20b8ec9 Adjust default alignment when switching from inline to block
Once more with feeling; default alignment when switching between
inline to block and vise versa. This time, the problem was mainly
that the checkbox for position cannot be updated without triggering
its update event. It was triggered, however, before setting up the
positioning, which caused the model to run positioning twice and
get things wrong.

Another smaller fix in this commit was done to make sure that
the image model remembers the previous alignment, so when image
type changes from inline to block and vise versa, and the alignment
was default, it can recalculate default value for the new node.

Bug: 65564
Change-Id: I6c16a7855ad7e3ce302fa3d042d0a402251b31f0
2014-06-03 00:20:57 -04:00
Krenair 390d8ca793 Fix reference dialog apply button disabling when modifying existing reference
Existing references keep internal records of current saved data, which breaks
the current length check. Instead, use the new function to count all
*non-internal* elements

Relies on I8ecbf387
Related to bug 52182

Change-Id: I4b9bb866babe018d75dc083fab35375b9fb53d3c
2014-06-02 17:12:12 -07:00
Roan Kattouw 14c8dc8295 Update VE core submodule to master (26a1027)
New changes:
ed97f51 Localisation updates from https://translatewiki.net.
9382cb7 Localisation updates from https://translatewiki.net.
f3c057b Update OOjs UI to v0.1.0-pre (527ad0ee5a)
db83b1d Localisation updates from https://translatewiki.net.
cf8463e Add a function to ElementLinearData to count all elements that aren't in internalList

Change-Id: I1e07568b1c094d96d4ec8ab1af50b242f77346d6
2014-06-02 17:11:47 -07:00
jenkins-bot 1baf2f08e7 Merge "Remove link node inspector from insert menu" 2014-06-02 21:07:33 +00:00
Roan Kattouw 172ebb839e Remove link node inspector from insert menu
This inspector isn't designed for insertion mode yet; attempting to use
it in insertion mode causes nasty JS errors.

Bonus:
* Make its tool title "Simple link" rather than "Link", for when
  we do reintroduce it.
* Make double-clicking / pressing enter while selecting a link node
  open the link node inspector rather than the link annotation inspector.
* Make link nodes render with MW's external link arrow icon
* Move the link node inspector's messages to the right RL module

Bug: 66047
Change-Id: Ib94da7ed3a2a88297dbdd1529f20cd8dab7c8421
2014-06-02 21:05:07 +00:00
Translation updater bot 8eecdefe1f Localisation updates from https://translatewiki.net.
Change-Id: Ic7cc5b6cd68aa041ccbde62f5d19239f195c8bb9
2014-06-02 21:00:43 +00:00
jenkins-bot 05b377193b Merge "On category pages, only replace category description when saving" 2014-06-02 19:22:40 +00:00
jrobson fef33d30ec Add use existing reference to toolbar on mobile
Note currently a blank icon appears to the left of this.
This will need to be removed later.

Change-Id: Ia8be1f0e83a2154a48de3c3a47bd8feb0c9a2a2c
2014-06-02 12:12:32 -07:00
jenkins-bot 98f403f237 Merge "Use <visualeditor-toolbar-cite-label> correctly in the Media and Reference toolbars" 2014-06-02 17:38:36 +00:00
Trevor Parscal f58861b6c3 Cleanup save dialog counter label
This label is not needed, never visible, not internationalized and doesn't make sense.

KILL IT WITH FIRE!

Change-Id: Ia0b3eda5971598714644b9d0c4fec1fd44b6c440
2014-06-02 09:57:24 -07:00
Amir E. Aharoni c27d62d19f Use <visualeditor-toolbar-cite-label> correctly in the Media and Reference toolbars
Bug: 66039
Change-Id: Ie9cba04a0f117e1d5fb25a93f81df423787a9d79
2014-06-02 09:49:48 -07:00
Cmcmahon 1b6f55e0d7 [BrowserTest] Link UI text changed
Change-Id: I03c53f0f2bab321a48aae186580de1900926ab92
2014-06-02 07:03:48 -07:00
Translation updater bot c2024f2b9f Localisation updates from https://translatewiki.net.
Change-Id: Ic10bf19de14f3a5b6127859e6a57263450fe9b6c
2014-06-01 19:42:20 +00:00
Translation updater bot f20e97abfa Localisation updates from https://translatewiki.net.
Change-Id: Idb33e1311c945429b0bd7a844720b5885f8791db
2014-05-31 19:02:45 +00:00
Krenair e59b1e7f60 Use promises for confirmation dialog instead of done event
Should be merged at the same time as I70af4f4f
Unbreaks the confirm dialogs (I5f971852)

Change-Id: I7e7a5fcef4e749a3196f675e9f1f8e8bc5c11ca0
2014-05-31 16:25:27 +01:00
Trevor Parscal f65c3c6ef1 [BREAKING CHANGE] Update VE core submodule to master (88fe25f)
Switch to processes for windows (dialogs/inspectors)

This conversion also required the splitting of MWLinkInspector into
MWLinkNodeInspector and MWLinkAnnotationInspector.

New changes:
88fe25f [BREAKING CHANGE] Update OOjs UI to v0.1.0-pre (dd888aba5c)

Change-Id: I662d8985463c9fc881775f70aef87ebeb454a73f
2014-05-30 22:03:45 -07:00
jenkins-bot 4719978a47 Merge "Update VE core submodule to master (418cd67)" 2014-05-31 01:05:52 +00:00
Roan Kattouw d7ca1604d6 Clean up interaction with confirmation dialog
It now only sends a single 'done' event, which we can use .once on

Relies on I4f485d4f in OOjs UI.

New changes:
418cd67 Update OOjs UI to v0.1.0-pre (0f101c6f5d)

Bug: 65571
Change-Id: I19aa65612bf02bed056de292f212d2f5732a8fec
2014-05-30 16:39:07 -07:00