Commit graph

14585 commits

Author SHA1 Message Date
David Lynch 814e26f1e9 DesktopArticleTarget: view click handler should only run for active target
Not checking this results in handlers blocking click actions for "read" after
the teardown of the target.

Bug: T197445
Change-Id: I3a962c66c82a0e48ca54bf2f0b822a9a005da54c
2018-06-18 20:45:52 -05:00
jenkins-bot ad339f61aa Merge "Move apierror-readonly message to ArticleTarget module" 2018-06-17 19:14:10 +00:00
Ed Sanders 040a7e6635 Move apierror-readonly message to ArticleTarget module
Bug: T197498
Change-Id: I5f7d189918b5e699678321ebf7d15481ec6d2684
2018-06-16 14:19:26 +01:00
jenkins-bot 96c1836248 Merge "ve.init.mw.DesktopArticleTarget: Only change document title on activate" 2018-06-15 21:56:13 +00:00
Translation updater bot ad72bc396d Localisation updates from https://translatewiki.net.
Change-Id: I320b53e025656ce041ea387dacb19b11677cb495
2018-06-15 22:35:54 +02:00
Bartosz Dziewoński e484522161 ve.init.mw.DesktopArticleTarget: Only change document title on activate
Previously, we changed it on every load, which also occurs when
switching editor modes. That caused it to not be restored when editor
was closed.

Bug: T197490
Change-Id: Icb20c38309fd440553d5245d865b05145542313f
2018-06-15 22:10:25 +02:00
jenkins-bot 4f98d3bfb6 Merge "Check for normalized and converted titles in ve.init.mw.ApiResponseCache" 2018-06-15 19:44:42 +00:00
petarpetkovic 86615fcedc Check for normalized and converted titles in ve.init.mw.ApiResponseCache
Besides redirects, API can return from-to title pairs for normalized and
converted titles, as well.

Currently, doing an API query on eswiki for page info (prop='info' in params)
with titles='User:Title' returns normalized title 'Usuario:Title'.

processResult() method in ve.init.mw.ApiResponseCache.prototype.processQueue
sets page.title ('Usuario:Title') in cached results, and the promise for
actual queried title ('User:Title') gets rejected in rejectSubqueue() method.

Change-Id: I33fd4640b6eac8018e35c6fe21234f4c469dd97d
2018-06-15 21:27:31 +02:00
jenkins-bot a6ae8424f7 Merge "Use WindowAction to open the wikitext paste dialog" 2018-06-15 15:46:44 +00:00
James D. Forrester a4f8d28328 Update VE core submodule to master (30865fcfe)
New changes:
c414d3b44 Localisation updates from https://translatewiki.net.
fccd20b10 Converter: Don't try to apply attributes to non-node elements
d40a2d7ff FindAndReplace: Use the same tab index of items that are in correct DOM order
9401ddc3e TabIndexScope: ignore aria-hidden outside the tab scope root
fb5c6337a Use 'title' config option instead of 'iconTitle'
bb49c6fee bin/update-oojs.sh: Update for upstream movement of /dist files
30865fcfe Update OOjs to v2.2.2

Bug: T197185
Bug: T197250
Change-Id: I75880efe33ca69b7e0596ecb4c732cf09c9cd5dd
2018-06-14 16:53:30 -07:00
jenkins-bot e8c6b90a72 Merge "MWLanguageVariantInspector: Use 'title' config option instead of 'iconTitle'" 2018-06-14 22:51:41 +00:00
Bartosz Dziewoński 4ee35de02a MWLanguageVariantInspector: Use 'title' config option instead of 'iconTitle'
This way the tooltip is shown on the entire button, rather than only
on the icon. One should only use 'iconTitle' to display a different
tooltip on the icon than on the rest of the widget.

I think this was caused by bad documentation in OOUI, which I'm fixing
in I967d9b78014b3754720e80da9c4785124fffc2ba.

Change-Id: I8cc99bcfca56b80a8c8aff609ba48eb3f9c5ed7f
2018-06-14 22:45:18 +00:00
Translation updater bot bc4ee6c3d2 Localisation updates from https://translatewiki.net.
Change-Id: I972e290cb62e9e117c0db57669a09dece4ecd89e
2018-06-14 22:44:48 +02:00
James D. Forrester 5c48ef286a Update VE core submodule to master (fea37bcd2)
New changes:
fea37bcd2 SourceSurfaceFragment: Use own insertContent function inside insertDocument

Bug: T197091
Change-Id: I43d21731f974ed63a71a52b2b87ea7cd9aec742e
2018-06-13 09:17:38 -07:00
Ed Sanders b340f526e3 Use WindowAction to open the wikitext paste dialog
This adds in missing functionality, such as deactivating
the surface selection while the dialog is open.

Change-Id: I0d8652a989504a35e5c235224b0ef924b6dcbeed
2018-06-13 13:28:15 +01:00
Translation updater bot af43464e41 Localisation updates from https://translatewiki.net.
Change-Id: Ic39f7268264815a603ffe195c5eb237dea3755be
2018-06-11 22:34:34 +02:00
jenkins-bot 6876f6d489 Merge "Move module pre-loading from DAT.init to ArticleTarget" 2018-06-11 17:55:21 +00:00
jenkins-bot 59e59a5fdf Merge "VisualDiff: Don't compare images with different src's" 2018-06-11 17:44:48 +00:00
James D. Forrester 7a788364b7 Update VE core submodule to master (8231b4d88)
New changes:
a52e2ee1f Never store ve.debounce in prototype
eebbbfb30 DiffElement: Add test for full list replacement
443a8df59 Separate out list, leaf and tree diffs
8667e76ea DiffElement: Tests for new list diff functionality
5d9dd0391 Don't compare images with different src's
2723de16a Follow-up I125969a: Replace $.closest with $.parents + $.addBack
835442985 VisualDiff: Add test for add-simliar-and-indent

Bug: T184977
Bug: T187632
Bug: T196753
Bug: T196914
Change-Id: Iadea61960dfc91bceedef85087701978fa5028c4
2018-06-11 09:48:34 -07:00
jenkins-bot 4e17f2f131 Merge "Follow-up Ifdc951f: Don't use getLocalApi when VE not available" 2018-06-10 22:39:29 +00:00
jenkins-bot 7890f70d76 Merge "Minor code style fix (move semi colon)" 2018-06-10 22:38:18 +00:00
jenkins-bot 17d013f520 Merge "Never store ve.debounce in prototype" 2018-06-10 22:36:23 +00:00
Ed Sanders 6459de6978 Move module pre-loading from DAT.init to ArticleTarget
This makes this feature available on Mobile as well.

Change-Id: I26a2af63b3665f5563f8562f1a8e94287cad439f
2018-06-10 16:07:44 +01:00
Ed Sanders 6cc83781a3 Never store ve.debounce in prototype
This essentially creates a static debouncer, so if you have
multiple instances calling that method at the same time, only
one of them will fire.

Change-Id: I4c257b557e87f5638b459811655a14b8625de2e3
2018-06-10 16:00:37 +01:00
Ed Sanders 000559c790 Minor code style fix (move semi colon)
Change-Id: I00f635203c4fc58454aefa8840f0b204e1480c53
2018-06-10 15:59:26 +01:00
Ed Sanders e88cd81f94 Follow-up Ifdc951f: Don't use getLocalApi when VE not available
These popups on used on the 2010 wikitext editor as well, so
we can't use ve.init.target.

Change-Id: I7d4e97566dde10146893089427f95c0b598ef4bc
2018-06-10 14:14:23 +01:00
James D. Forrester b7594c7a32 Update VE core submodule to master (ae0ff21b9)
New changes:
d1b8a4141 Simplify conversion of images
e614bc70d Update OOUI to v0.27.3
b88f42a59 Refactor document drag/drop to use copy/paste methods
89220c69e Change image diff tests to use 'alt' instead of 'src'
bbb82023d deepEqual->strictEqual in modelRegistry tests
b6524e7a2 ModelRegistry: Prevent double registration

Change-Id: I1d7304091be256323f081810fe4e13cf8495dc0e
2018-06-08 08:20:11 -07:00
Bartosz Dziewoński 6840ac4dd1 ve.ui.MWSaveDialog: Remove unnecessary margin after last checkbox
Patch proposed on T196375 by Jack_who_built_the_house.

Bug: T196375
Change-Id: I30548650eab3d14e7c0de29c954ededcfa44648a
2018-06-08 09:57:01 +00:00
jenkins-bot c04e934361 Merge "Simplify conversion of images" 2018-06-07 20:51:51 +00:00
James D. Forrester 84eab48c68 Update VE core submodule to master (3cb400800)
New changes:
24e35e428 Factor out synchronous part of updateInvisibleIcon
7be1fc898 FocusableNode: Move getModel teardown check to updateInvisibleIconSync
6fe97c9f1 Performance improvements to compareElementsUnannotated
dfa42c223 Demos: Use SVG with well defined natural size
c2886b57b eslint: Enable qunit/no-assert-equal,no-early-return,no-negated-ok and enforce
4ca5a4088 eslint: Move qunit/resolve-async exceptions inline
eda91bd38 eslint: Move qunit env flag to test config
ce2983e52 Update OOUI to v0.27.2
e333fe327 Localisation updates from https://translatewiki.net.
3cb400800 ce.Surface: afterPaste should always remove ve-attributes

Bug: T196254
Bug: T196380
Bug: T196479
Change-Id: Ie7ce1fefdcede8eb61b722d8308ec9ee9b3bd1e3
2018-06-07 09:18:55 -07:00
jenkins-bot 1dc8d5db51 Merge "Add preview mode converter tests" 2018-06-06 21:28:19 +00:00
jenkins-bot 5e45047fe0 Merge "Fix parsing of external links, now Parsoid adds 'external' classes" 2018-06-06 21:28:10 +00:00
Translation updater bot a070e3ab3a Localisation updates from https://translatewiki.net.
Change-Id: I0f32f1f15372b041c161d7f69a0866b957f3e81b
2018-06-06 23:06:29 +02:00
jenkins-bot ef0f1db361 Merge "eslint: Move qunit env flag to test config" 2018-06-05 21:11:49 +00:00
L10n-bot a67813d8e5 Merge "Localisation updates from https://translatewiki.net." 2018-06-05 20:19:00 +00:00
Translation updater bot ed65185de2 Localisation updates from https://translatewiki.net.
Change-Id: I28b055d7d6180b6e815b85557966719886050636
2018-06-05 22:17:08 +02:00
Ed Sanders 7dbc4c7140 eslint: Move qunit env flag to test config
Change-Id: I290c436b25e306a3657324304ded08011ffcea7a
2018-06-05 21:12:56 +01:00
jenkins-bot cb62540fac Merge "eslint: Enable qunit/no-assert-equal,no-early-return,no-negated-ok" 2018-06-05 20:11:46 +00:00
Ed Sanders b668286e9b eslint: Enable qunit/no-assert-equal,no-early-return,no-negated-ok
Change-Id: I6a202a496ba9359c63febf623ef8b4dd3caa47dd
2018-06-05 20:41:39 +01:00
Ed Sanders dee50b778c MWTransclusionNode: Remove old createInvisibleIcon override
Bug: T196479
Change-Id: I99aab2e0eee3274305a6877263414ce21049fa5b
2018-06-05 18:50:14 +01:00
Ed Sanders b79c98f1e3 Simplify conversion of images
Assume that images provided by Parsoid will adhere to the DOMspec.

Change-Id: I52eb4f27e6b1e1cd092133c3e27e42021ae83783
2018-06-05 13:05:40 +01:00
Translation updater bot be1c31d988 Localisation updates from https://translatewiki.net.
Change-Id: Icbf7dc0eff8cb17579a06d162476bbabbc990fe3
2018-06-04 22:44:51 +02:00
Ed Sanders 98ec3947a9 Add preview mode converter tests
Change-Id: I58a2c9a9e8fd0bf8254819b960c5a5ad8190f643
Depends-On: I3f1a4772cbf67091b5fd52bab610390ebd9b16ef
2018-06-04 19:00:34 +00:00
Ed Sanders bb6cd33821 VisualDiff: Don't compare images with different src's
Bug: T196343
Change-Id: I99ddce806e044ca427bf01b41d164c89dd2e15fd
2018-06-04 18:49:18 +01:00
Ed Sanders a7049dacea Update language variant node to use new invisible icon API
Bug: T195887
Depends-On: I4eab7b9edf04454ef1a62535656b179480c3054b
Change-Id: I655757b13514e8ff89c312dcc2e1147d188a2718
2018-06-04 17:34:22 +00:00
James D. Forrester b998e3cae3 Update VE core submodule to master (aca98533e)
New changes:
d62da204c Fix documentation in dm.Surface, remove duplicate dm.Selection.equals
b2ee82d06 Bypass expensive hasRendering calculation for CommentNodes
522959e5c ve.ce.AlienNode: Fix hover highlight opacity in IE/Edge
06e67e2a1 ve.ce.FocusableNode: Remove "ve-ce-focusableNode-highlight-relocatable-marker"
d38b994d9 Localisation updates from https://translatewiki.net.
2056626bc Remove unused & untested HashValueStore.filter
49a8fbae4 Upstream comment node's invisble icon with label into focusable node

Bug: T195887
Change-Id: Id2da1f2da4e5e32acb3d604307d0f84f6a82bf39
2018-06-04 09:45:04 -07:00
jenkins-bot 6594055882 Merge "Paste conversion dialog shouldn't be escapable" 2018-06-04 16:44:39 +00:00
David Lynch d3fd979d3b Paste conversion dialog shouldn't be escapable
It doesn't have a "cancel and do nothing" route to fall back on, so pressing
escape does the non-progressive action, which is to paste-as-wikitext rather
than paste-as-plaintext. Neither of these is really an intuitive outcome.

Change-Id: I786b6fc87e3cdf3bb50898a070a15a353a242848
2018-06-04 11:16:19 -05:00
Santhosh Thottingal b049a82e8d
ApiResponseCache: Add a check for data.query before accessing redirects
Follow-up: If4f8c9b6719c123b31d852eb71f06a79cc0f7917
Change-Id: I5f1814f341ce401fcb3926487a2cea276698bca0
2018-06-04 13:50:27 +05:30
Translation updater bot a93d1e6102 Localisation updates from https://translatewiki.net.
Change-Id: I48d83893b5867283ea2835a31f879916f7055665
2018-06-03 22:36:44 +02:00