wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

VisualDiff: Don't compare images with different src's

Browse source 
Bug: T196343
Change-Id: I99ddce806e044ca427bf01b41d164c89dd2e15fd
This commit is contained in:
Ed Sanders 2018-06-04 18:14:45 +01:00
parent b998e3cae3
commit bb6cd33821
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
View file

@ -104,6 +104,11 @@ ve.dm.MWImageNode.static.getMatchRdfaTypes = function () {
ve.dm.MWImageNode.static.allowedRdfaTypes = [ 'mw:Error' ];
ve.dm.MWImageNode.static.isDiffComparable = function ( element, other ) {
// Images with different src's shouldn't be diffed
return element.type === other.type && element.attributes.resource === other.attributes.resource;
};
ve.dm.MWImageNode.static.describeChanges = function ( attributeChanges, attributes ) {
var key, sizeFrom, sizeTo, change,
customKeys = [ 'width', 'height', 'defaultSize', 'src', 'href' ],