New changes:
582ab6eda Localisation updates from https://translatewiki.net.
7eb90ef85 Make client utils a dependency of platform
2f7675785 Remove @abstract from ve.ce.View.getResolvedAttribute
ca3f685b3 ve.createDocumentFromHtml: Do not lose <style> tags in doc fragments
Bug: T273234
Change-Id: I4bced562f018bf4f28e18ca838c8218de68ee519
Remove using of User::isIP since this method will be hard-deprecated. Now it is soft-deprecated
Bug: T275602
Change-Id: Ia625be523706d1e24649f7aa15679491f9598b7f
New changes:
422cbd755 Re-apply "ve.ce.Surface: Allow tabbing out of surfaces without indentation features"
Bug: T172694
Change-Id: Ib81933da272e6b08bc7fa6c8612e5a65a887cd45
The failure was:
includes/VisualEditorDataModule.php:37 PhanTypeMismatchArgument Argument 2 ($pretty) is ResourceLoader::inDebugMode() of type int but \FormatJson::encode() takes bool|false|string defined at ../../includes/json/FormatJson.php:115
includes/VisualEditorDataModule.php:41 PhanTypeMismatchArgument Argument 2 ($pretty) is ResourceLoader::inDebugMode() of type int but \FormatJson::encode() takes bool|false|string defined at ../../includes/json/FormatJson.php:115
Probably triggered by changes to MediaWiki in commit
Ieaf04e0c289646dd5d5b027b4f1f8278167b2d57.
Change-Id: Iab139c4dd69c9a16c9f4f9e2fd47ec76a9003152
New changes:
40906ce3d Localisation updates from https://translatewiki.net.
bb7fd8081 ve.ui.ContentAction: Fix a documentation comment
4cb1a3258 ve.ce.GeneratedContentNode: Fix a typo in documentation comment
Change-Id: I9dd04b97c3e287466aa6de0ddcf09a851234f2b6
New changes:
4f7bf062b Rebuild language lists
289073126 Update of 'Live Demo' URL in README
a248cdbac Localisation updates from https://translatewiki.net.
Bug: T274222
Change-Id: I6f22ad177521ad286d59dfdeb6d632b891b62470
New changes:
248513f69 build: Updating eslint-config-wikimedia to 0.18.1
5e1fb5c18 Localisation updates from https://translatewiki.net.
c5b65e31d Localisation updates from https://translatewiki.net.
Change-Id: I7ab5adba7a931226d324eb3c2ad280c6424b9663
In QUnit 2, QUnit.setup()/QUnit.teardown() were renamed, to be called
QUnit.beforeEach()/QUnit.afterEach(). Though we are insulated by this
through MediaWiki's wrapper for backwards compatibility, changing the
names of the functions we pass to the new names allows us to drop the
old ones.
Bug: T170872
Change-Id: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
If someone has edited before the switch (2016-ish), never edited since
then, and try to edit again now, it's probably no longer helpful to
show them a popup dialog about a change that happened 5 years ago.
The immediate motivation for this, though, is T273189. We discovered a
bug with the preferences that, among other issues, caused this dialog
to not be shown in some cases where it should have been, and fixing
the bug now would cause it to be shown the on the next edit attempt.
If someone has edited before the switch (2016-ish), *and* edited since
then, and try to edit again now, it's definitely not helpful at all to
show them a popup dialog about a change that happened 5 years ago.
Bug: T273189
Change-Id: I4b5a3d8dbdf1c853eb39fcfc85a9fe87a4db0f21
We have two preferences used for enabling/disabling VE:
'visualeditor-enable' and 'visualeditor-betatempdisable'.
(And 'visualeditor-autodisable', which sometimes overrides
them both, but it's not relevant here.)
The user can only set 'visualeditor-enable' when VE is Beta Feature,
and they can only set 'visualeditor-betatempdisable' when it is not.
However, when deciding if VE should be loaded, we always checked both
of the preferences. This gives incorrect results when the preference
that is not supposed to be settable actually exists, due to being set
in GlobalPreferences on another wiki where it's settable.
A similar issue could occur if VE configuration is changed from Beta
Feature to a normal preference (or the other way around), and the
preference values for the previous configuration still persist.
Bug: T271434
Change-Id: I7399b3c516f762429050a662ac85d1d392392323
Depending on the config, we would sometimes define both the
'visualeditor-enable' and the 'visualeditor-betatempdisable'
preferences, even though they contradict each other.
Bug: T273188
Change-Id: I6ac7e4580bf232a5198ad8842f814bc381131e00
* VisualEditorNewAccountEnableProportion
* VisualEditorAutoAccountEnable
Seemingly never used on Wikimedia wikis, and untested since 2016.
Bug: T273177
Change-Id: Ic132ef2091399fd223626ae307830f278e72ec01
