wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-24 02:38:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stop showing the "Editing tabs" popup some time after SET switch

Browse source 
If someone has edited before the switch (2016-ish), never edited since
then, and try to edit again now, it's probably no longer helpful to
show them a popup dialog about a change that happened 5 years ago.

The immediate motivation for this, though, is T273189. We discovered a
bug with the preferences that, among other issues, caused this dialog
to not be shown in some cases where it should have been, and fixing
the bug now would cause it to be shown the on the next edit attempt.
If someone has edited before the switch (2016-ish), *and* edited since
then, and try to edit again now, it's definitely not helpful at all to
show them a popup dialog about a change that happened 5 years ago.

Bug: T273189
Change-Id: I4b5a3d8dbdf1c853eb39fcfc85a9fe87a4db0f21
This commit is contained in:
Bartosz Dziewoński 2021-02-03 20:43:09 +01:00
parent b91c8647fe
commit ef8e7945cc
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
extension.json
View file

@ -136,6 +136,9 @@
"VisualEditorSingleEditTabSwitchTime": {
"value": 20160101000000
},
"VisualEditorSingleEditTabSwitchTimeEnd": {
"value": 20210101000000
},
"VisualEditorSkinToolbarScrollOffset": {
"value": []
},

1
includes/VisualEditorHooks.php
View file

@ -446,6 +446,7 @@ class VisualEditorHooks {
if (
$config->get( 'VisualEditorUseSingleEditTab' ) &&
wfTimestampNow() < $config->get( 'VisualEditorSingleEditTabSwitchTimeEnd' ) &&
$user->isRegistered() &&
!$user->getOption( 'visualeditor-autodisable' ) &&
!$user->getOption( 'visualeditor-betatempdisable' ) &&