Commit graph

19687 commits

Author SHA1 Message Date
Bartosz Dziewoński 63641be8c9 Update VE core submodule to master (20902e538)
New changes:
0c1a95a5d Localisation updates from https://translatewiki.net.
0f31d4996 DiffElement: Add test cases for table merges
89356a90a DiffElement: Improve description of colspan/rowspan changes
0cb95be10 DiffElement: Add more table tests
82b1d170c DiffElement: Move some more var declarations inline
3bf324d84 DiffElement: Handle a node index of 0
429dd0c56 DiffElement: Show whole node when DocList has attribute change
ed551058c Follow-up I1bd7171: Test colspan/rowspan values of 1 being the same as undefined
7a5a14235 DiffElement: Collapse tree diff with no described changes
07ff4af98 Follow-up Ib79a964c: Fix test HTML
3f5bb3be4 Follow-up I9a67730: Pass current list node to appendListItem
83c3e959b Improve AlienNode matching
9fa17d0a3 Alienate when trying to <p>-wrap an annotation where <p> isn't allowed
653dd2d58 DiffElement: Handle AlienBlockNode in list
20902e538 DiffElement: Fix rendering of internal list items with multiple child nodes

Bug: T259957
Bug: T278186
Bug: T299475
Change-Id: I88a1c8ce43e129f2117672d8f7570dca19d6c608
2022-01-19 03:26:56 +01:00
Ed Sanders 110db0e3c7 Remove conflicting section IDs in diff views
Bug: T218492
Change-Id: I84c60a36859190efc37c68e380ae44225be06d9c
2022-01-19 01:26:14 +00:00
Ed Sanders 63603e0cba MWImage: Fix handling of error-image dimensions
Change-Id: Ic808930bbd49bab779bd2ed174e6ec2408d51554
2022-01-19 00:51:39 +00:00
Ed Sanders 658a08bc30 Broken image: Fix DM HTML for preview to include redlink text
Bug: T265655
Change-Id: I1283975fdafb219ae2b0c703ecf7c7b23bb0c067
2022-01-19 00:51:39 +00:00
Ed Sanders 64fa1d909f MWImage: Cache dataElement.attributes
Change-Id: I24a4d436a00e6300bf4234153188d02fd648f9ce
2022-01-19 00:51:39 +00:00
jenkins-bot 770884f14f Merge "Make sidebar header and search field sticky during scroll" 2022-01-18 12:55:11 +00:00
Thiemo Kreuz 33a2f21589 Disable edit button while loading template dialog
Bug: T297773
Change-Id: I51fc0af4c3b29fd0801fc06a1dc07ad3fd7f1da3
2022-01-18 12:29:27 +00:00
Translation updater bot 16257eb72a Localisation updates from https://translatewiki.net.
Change-Id: Iff81b77eeea259df00c0a4b541b70ca2b1d9782b
2022-01-18 08:11:32 +01:00
jenkins-bot b4e3c3b1e5 Merge "Add mobile specific styling for TemplatePage" 2022-01-17 17:14:00 +00:00
Ed Sanders 2dd810da85 Image model: Clear originalWidth/originalHeight attributes when changing source
Bug: T269035
Change-Id: I52e5e7fd46ce86a2190b9ef5484898f741105646
2022-01-17 15:32:30 +00:00
Adam Wight a244f510c4 Make sidebar header and search field sticky during scroll
The search field will stay at the top of the window while scrolling a
single template.  In multi-part transclusions, the header will also
be sticky.

Hides the template header in single-part transclusions.

Bug: T298618
Change-Id: Ib050e30a50ef965c1524e977d3a600c3ff836774
2022-01-17 16:09:54 +01:00
Translation updater bot 0ec4a5a291 Localisation updates from https://translatewiki.net.
Change-Id: I4cad34e72516a7e42081bcbee54ce6f280827368
2022-01-17 08:13:23 +01:00
jenkins-bot 8d119a4356 Merge "Re-duplicate deduplicated TemplateStyles" 2022-01-16 00:24:31 +00:00
Bartosz Dziewoński 005a8d24ef Re-duplicate deduplicated TemplateStyles
Bug: T287675
Bug: T299251
Change-Id: I7711c30131cb441f84b3e2137983f0ba2a50b46f
2022-01-14 21:35:11 +00:00
Bartosz Dziewoński 8e98a689a6 Update VE core submodule to master (61ee718b4)
New changes:
1685748d5 Tests: Add tests for ve.ce.Surface#getViewportRange
d7d777667 getViewportRange: Handle node not being rendered
61ee718b4 ve.ce.Surface: Use selectFirstVisibleContentOffset when focusing a document

Bug: T296910
Change-Id: I3e7dd7095d10d618e0f2c6da8021eadd0ec92da2
2022-01-14 20:34:36 +01:00
Bartosz Dziewoński 6ed44ef009 Update VE core submodule to master (57e82187b)
New changes:
d90d1fb78 DiffElement: Change order of z-index fixes
bb46539c9 DiffElement: Move more var declarations inline
eb46b62ed DiffElement: Make processQueue a method
12c078f2c DiffElement: Separate processQueue and renderQueue
57e82187b DiffElement: Collapse context to spacers in isDiffedAsDocument nodes

Bug: T188170
Change-Id: Icf1ecd042d8c1da99d665580a4c16c1a55b5b53a
2022-01-14 18:55:58 +01:00
Bartosz Dziewoński 7b72145ba1 Update VE core submodule to master (ad9958477)
New changes:
67d78e763 Fix type hint in ve.ui.Command
c0a5da784 Use boolean RegExp.test() instead of .match() where possible
2a7c5f994 Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused
c55e24a67 Always convert to wrapper paragraph inside lists

Bug: T297773
Bug: T298609
Change-Id: Ic100641be04c81e17627c820d7dde10cd98ce4d8
2022-01-14 18:17:35 +01:00
jenkins-bot 2819958a8a Merge "Add button to sidebar to hide/show unused fields" 2022-01-14 11:35:19 +00:00
WMDE-Fisch 20435b319c Add button to sidebar to hide/show unused fields
Bug: T298259
Change-Id: I8e5091b97dfb19eba981b2a919b82b6f14823990
2022-01-14 11:09:04 +00:00
jenkins-bot 1150891885 Merge "Include TemplatePage styling on mobile" 2022-01-14 11:07:59 +00:00
jenkins-bot 9b42e71bd8 Merge "Fix positioning of the "add parameter" button on mobile" 2022-01-14 09:05:17 +00:00
Translation updater bot 4e27b5c540 Localisation updates from https://translatewiki.net.
Change-Id: I7ee1d5b5a211cb2310b84abf89d9084846963d73
2022-01-14 08:16:57 +01:00
James D. Forrester 1fb72b6047 Update VE core submodule to master (1036b82b4)
New changes:
c138462d7 selectFirstVisibleContentOffset: Only apply line height hack when scrolling
1982be888 ve.dm.example: Build test code for commentNodePreview using a real widget
70c15c80b Update OOUI to v0.43.0
29482de0f getViewportRange: don't error in a no-contentoffsets document

Bug: T296910
Change-Id: I1bb6aa75b28f263543ea069496cf34bdaa5d02e0
2022-01-13 22:53:52 +00:00
Andrew Kostka 2e7d4dabd1 Fix positioning of the "add parameter" button on mobile
Bug: T292749
Change-Id: I8c73189fcb94541087c6d44fbe7a82d14f9c3483
2022-01-13 15:18:40 +01:00
Andrew Kostka 914d9f7aaf Add mobile specific styling for TemplatePage
Bug: T292746
Change-Id: I3f2bc156d3f1be6e78b3a5d257c0cc484a65611c
2022-01-13 14:42:41 +01:00
Andrew Kostka 8c07926d4b Include TemplatePage styling on mobile
Bug: T292746
Change-Id: I52dcc8b489598ea8a892ad6c049c20d40f410d5b
2022-01-13 14:03:02 +01:00
Thiemo Kreuz 0907b3eb49 Fix missing return value and related docs in MWTransclusionNode
Change-Id: I3c2c87c2644c45f934c8b1c98958c01a43579da9
2022-01-13 11:56:06 +01:00
Adam Wight 7264e2ee42 Change confirmation-reject text for consistency
Use the same language as the core `mw-widgets-abandonedit-keep`
message.

Bug: T297792
Change-Id: I64f72bbd3a7656b0b677856f0bbd3cb4b342a614
2022-01-13 10:59:21 +01:00
Translation updater bot 0c84e59fef Localisation updates from https://translatewiki.net.
Change-Id: If31984657362a4461155816a90ad16e91fb599e2
2022-01-13 08:27:35 +01:00
Adam Wight 587ba4c662 Confirm before closing template dialog
Reuse the back button confirmation dialog for the close button.  The
condition is slightly different: need confirmation if there are any
manually-entered values for any parameter AND the user has edited
the template in this session.

The "reset" action was synthetic, only used internally and not
connected to buttons or menus.  Canonically, action='' is the close
action for OOUI.

Bug: T297792
Change-Id: I4ff644c7ab24ed9ba1a4c27d762563c5d6771cfc
2022-01-12 10:47:21 +01:00
jenkins-bot 1dbfad3503 Merge "Reuse touched-content logic" 2022-01-12 08:34:09 +00:00
Translation updater bot 328763526e Localisation updates from https://translatewiki.net.
Change-Id: Idf59385ca3e56b7144b3314d7ecfee927a9cc12b
2022-01-12 08:25:52 +01:00
Ed Sanders c0f3fc3a78 Pass visibleSection & visibleSectionOffset to target
* Find the first section below the top of the viewport
  (usually visible) and measure its offset.
* After loading the editor, ensure this heading is still
  at the same position on the page.

Bug: T296910
Change-Id: I9a05ea74ba3c19a4a91ddc1bc0afe311851c53e6
2022-01-11 20:39:27 +00:00
jenkins-bot e1b9e6a98e Merge "Watchlist API update: Call correct method" 2022-01-11 18:41:49 +00:00
Ed Sanders aea22d546e Watchlist API update: Call correct method
We changed the arguments, but not the function name.

Change-Id: Ic7b36f666ead57bc62aa6e40e148821ea267ee80
2022-01-11 18:21:12 +00:00
jenkins-bot 11ff2c8452 Merge "Update VE core submodule to master (f06e0ff04)" 2022-01-11 18:15:53 +00:00
jenkins-bot 9b659687c7 Merge "Introduce ArticleTarget#afterSurfaceReady" 2022-01-11 18:11:50 +00:00
jenkins-bot 4f9f14f383 Merge "Replace confirmation overlay with a popup dialog" 2022-01-11 17:59:48 +00:00
Bartosz Dziewoński 37a2a77cc4 Update VE core submodule to master (f06e0ff04)
New changes:
f06e0ff04 Initialise toolbar height to 0

Change-Id: I97b936f9a42bd3b2f8b3b1e2ea52c0cda43f6ecb
2022-01-11 18:42:37 +01:00
Adam Wight 28e706b3dd Reuse touched-content logic
Without changing behavior, consolidate the logic for detecting
whether the editor has made changes to the template.  This is
responsible for enabling and disabling the "Apply changes" button.

Change-Id: Ic4755b13f30fb738a7cb1eebaddef0435ea61d34
2022-01-11 17:39:22 +00:00
Adam Wight cbe2fd634f Replace confirmation overlay with a popup dialog
Currently, the insert template dialog includes a back button in the
upper corner.  Confirmation of abandoning unsaved changes was
accomplished in an overlay panel.  This patch rewrites as a dialog
and updates the on-screen text.

Bug: T297792
Change-Id: Ifa2ff97c9284609ee2a784f455789c56a762ba50
2022-01-11 18:37:29 +01:00
jenkins-bot 83d1211ef6 Merge "Give getUniquePartId method a better name" 2022-01-11 13:31:10 +00:00
Bartosz Dziewoński 67b7b90847 Update VE core submodule to master (6eb23a10f)
New changes:
22f6db516 Fix getViewportRange when section editing
7d948731c Toolbar: Remove unnecessary unfloat() in detach()
2d14351b9 Toolbar: Set toolbar height from $bar when floating, and updating size when switching surface
f18dab62f Improve getViewportRange behaviour around text wrapping
6eb23a10f Try to select a visible offset when focusing a null-selection surface

Bug: T296910
Change-Id: I1265be30bb11076576a32feea7299303f74b197c
2022-01-11 05:07:12 +01:00
Ed Sanders 6c471c5b1e Introduce ArticleTarget#afterSurfaceReady
This method should be called once the surface is visible
and ready to be focused.

Change-Id: I43a1d9cabd59181d2beab8f4a29700d031903c22
2022-01-11 03:33:04 +00:00
Ed Sanders 93df71af77 ArticleTarget#scrollToHeading fixes
* Use this.getElementWindow
* Use this.surface.padding to avoid race condition
  when the toolbar hasn't fully rendered yet.

Change-Id: I055b1d9458d73e435ede6096941a3e72c9c1ce74
2022-01-11 03:32:52 +00:00
Bartosz Dziewoński c5d987b3fc Update VE core submodule to master (2db326345)
New changes:
04bd5c1da Localisation updates from https://translatewiki.net.
4147426da DiffElement: Manually number ordered lists with value attribute
ef3536361 DiffElement refactor: Pass diff objects to renderDiff instead of using state properties
593fe9026 DiffElement refactor: De-duplicate logic inside getNodeElements & wrapNodeData
a7b5eed5f DiffElement refactor: Create an iterateDiff method and unify function signatures
2db326345 Diff some nodes as if they are documents, e.g. <div>s

Bug: T188170
Bug: T298410
Change-Id: I28a048a02c62fb9bb96f29e472767d46c3b45804
2022-01-11 00:28:42 +01:00
jenkins-bot ed77e22e98 Merge "Update skinStyles with new vector skin key." 2022-01-10 23:11:27 +00:00
jenkins-bot b92f414e23 Merge "Use new wikipage.watchlistChange hook" 2022-01-10 22:42:17 +00:00
Clare Ming 1e1638145b Update skinStyles with new vector skin key.
Bug: T292599
Change-Id: I6a2db3012b37e4164e03f3701dc11fa36f2dbf92
2022-01-10 15:38:48 -07:00
Ed Sanders 3800daf354 Use new wikipage.watchlistChange hook
Bug: T294254
Depends-On: I88af8585e8fc75f77ebef867d267199aeb2c6592
Change-Id: I60400124976093060b3b5478c6d7d9e6844cc217
2022-01-10 23:16:41 +01:00