Commit graph

17519 commits

Author SHA1 Message Date
James D. Forrester cce248ce01 Update VE core submodule to master (0c024f431)
New changes:
5866b762f build: Re-enable Firefox testing
501e8354e ve.dm.Converter: Remove unused branch
84086e60f Localisation updates from https://translatewiki.net.
e1eb88ea2 Unify `list-style` CSS
d8eae968d ve.dm.Converter: Move var declarations inline
a26ff5fa6 ve.ce.Surface: Move var declarations inline
47a2d36f3 Localisation updates from https://translatewiki.net.
cf97b4938 build: Merge eslint main and html tasks back together
381ade44c build: Updating grunt to 1.4.0
d98f7995a Localisation updates from https://translatewiki.net.
c6bc154d2 Check if alien context item is registered before using
e645b06af Localisation updates from https://translatewiki.net.
58830c0dd build: Updating postcss to 8.2.15
f7b193a7e Localisation updates from https://translatewiki.net.
9730bd748 Update OOjs to v6.0.0

Bug: T240955
Bug: T282194
Change-Id: I7a26365a24103ac4e4b1279fda3b74ac6e4a9497
2021-05-17 17:35:37 -07:00
jdlrobson 2a40996cb7 Add mw-body-content to surface element
VisualEditor recreates the mw-body-content element. The element
with mw-parser-output already exists as a child. All skins now
consistently follow this pattern.

To limit the impact to the editor, we use ArticleTarget and add the class
to the surface, which corresponds to the mw-body-content element of a skin.
This avoids unrelated regressions in experiences such as DiscussionTools.

Bug: T283014
Change-Id: I4833d1ca9fda4fc0bd433760e47fe7010f00db05
2021-05-17 19:06:54 +00:00
jenkins-bot a01b56bcf1 Merge "Invert template search result highlighting" 2021-05-17 12:30:49 +00:00
Adam Wight 9cac71676e Invert template search result highlighting
Bug: T275048
Change-Id: I50fc7407b4357e2cea9d5421d0de46a81d39c69d
2021-05-17 14:12:02 +02:00
Andrew Kostka b2aa35a90a Show a warning before resetting the transclusion dialog
Bug: T272355
Change-Id: Id97190a149ed7642eda82300eeee623e0debf528
2021-05-17 13:27:37 +02:00
Adam Wight f444610fbc Support isEmpty on transclusion dialog elements
Returns true if there is no meaningful user input yet.

Will be used in the next patch.

Bug: T272355
Change-Id: I4f88ce31662bbc46755f78d574c46b907581d438
2021-05-17 13:26:11 +02:00
Andrew Kostka b2c9b225bd Add back button to the transclusion dialog
Bug: T272354
Change-Id: I08c4a7db6239b485439bf547e3e8b4d6f7aeede8
2021-05-17 13:18:14 +02:00
Andrew Kostka e0bbf0b979 Show a delete button only in the transclusion context menu
Bug: T274263
Change-Id: Ifd81994c212cd03c1318c5fd762251ce828d9195
2021-05-17 12:26:37 +02:00
Adam Wight 85f45fd49d Introduce feature flag for template dialog sidebar changes
Bug: T274263
Change-Id: If274efa94474c3de79c5917b76c1a290f93172e1
2021-05-17 12:25:46 +02:00
Translation updater bot 9ff35ae7c9 Localisation updates from https://translatewiki.net.
Change-Id: I70a074440574e9d28c2b1b2722e7d11a3b91fb37
2021-05-17 08:44:17 +02:00
libraryupgrader 1d300c3d54 build: Updating npm dependencies
* hosted-git-info: 2.8.8 → 3.0.8
  * https://npmjs.com/advisories/1677 (CVE-2021-23362)
* postcss: 7.0.35 → 8.2.15
  * https://npmjs.com/advisories/1693 (CVE-2021-23368)

Change-Id: I62b12274213389625fed11a27d32694e4946f8b3
2021-05-15 09:59:29 +00:00
jenkins-bot 71a4ad4f8e Merge "Template dialog bigger size uses "larger" preset" 2021-05-14 11:27:44 +00:00
jenkins-bot c3dd0115f8 Merge "Use add template when adding a new transclusion part" 2021-05-14 10:14:48 +00:00
Translation updater bot c35c2bb022 Localisation updates from https://translatewiki.net.
Change-Id: I23d807cbf884e0c72acfdd28b757bb1e50615920
2021-05-14 08:45:57 +02:00
Ed Sanders ea9ea1d17f NWE: Always paste rich text as plain, and show context item to convert
Bug: T282789
Change-Id: I1bc32c9e16140190baef9bcb08d49b4b21896883
2021-05-13 15:56:19 +01:00
Adam Wight 9607cb3ed0 Template dialog bigger size uses "larger" preset
Rather than invent our own size, we'll reuse the "larger" format and
tweak the dialog height to 90%.

Bug: T273971
Change-Id: Ibef85c1912267b14d83396b089b81934751a8328
2021-05-12 11:31:40 +02:00
Translation updater bot c34f64ba04 Localisation updates from https://translatewiki.net.
Change-Id: I4b8eb213599997af1cfe70ff0c3a2398363f4ec3
2021-05-12 09:23:45 +02:00
Thiemo Kreuz 333cadd5d4 Add star to template search term only when it's possible
Discussed in T274903#7077957. Note this might not be the
"perfect" solution. We are still experimenting, and this is
all hidden behind a feature flag. This is the change with the
most minimal impact. Actively trimming the input is another
solution, but with a bigger impact we might want to discuss
first.

Bug: T274903
Change-Id: I2ed06c04bb96c7b61bd7e87ad001e639ea6d06a2
2021-05-11 16:31:42 +00:00
WMDE-Fisch 42b557ff80 Use add template when adding a new transclusion part
We have two cases now that we want to cover here:
- Either we're inserting a new template and start a "fresh"
  transclusion, then we want to use "search" in the headlines
- Or we're adding a new template to an exsisting
  transclusion, then we want to use "add" in the headlines

Bug: T277028
Change-Id: I9fa294cf732598d58f848c75b353d2e1742eb4e8
2021-05-11 13:13:44 +02:00
Translation updater bot 03c277e96a Localisation updates from https://translatewiki.net.
Change-Id: I0e8507be3cf38c993020e5ea05144b6a53eeba33
2021-05-11 09:08:30 +02:00
WMDE-Fisch 3b38ecf690 Use sentence case for template search label
Bug: T277028
Change-Id: I4be6ab078053a50d33a6d67f7b5702d4051d4ef1
2021-05-10 17:34:39 +02:00
Svantje Lilienthal 2665734b10 Renaming temporary config variable and splitting it from cirrus search lookup
This allows using the config variable independendly from the cirrus search extension.
This way it can be used for all subtickets of T271802.

Bug: T277028
Change-Id: I1b3bdda5fa6fbfe5c531c3b51c2c8e2a28ed1faf
2021-05-10 14:47:31 +02:00
Adam Wight f89301bedf Optional verbose template search
Renames "Add a template" to "Template Search" in most cases and
provides inline help for the workflow.

Bug: T277028
Change-Id: I3fee87cb89b5044e785596e71ef3f1a18f2694ce
2021-05-10 12:45:12 +00:00
Andrew Kostka c1d36072ea Add collapsible descriptions to the transclusion dialog
Bug: T273426
Change-Id: I793a66f5c5877451b70058e9388dd86b3fcaadd7
2021-05-10 11:18:17 +00:00
Translation updater bot 752cc487e2 Localisation updates from https://translatewiki.net.
Change-Id: Ie07dc3f2354dadbb464c60706a11c8339c1653e4
2021-05-10 08:54:22 +02:00
libraryupgrader e6ad9eddff build: Updating npm dependencies
* grunt: 1.3.0 → 1.4.0
* hosted-git-info: 2.8.8 → 3.0.8
  * https://npmjs.com/advisories/1677 (CVE-2021-23362)

Change-Id: Ibbb79989dd9c92a9f5ac6c14d537de0cd0c9cd47
2021-05-07 21:18:30 +00:00
Translation updater bot 39dea795d9 Localisation updates from https://translatewiki.net.
Change-Id: I59dd6fb5c903595e0995998bd0e290c6ac14ca83
2021-05-07 08:43:59 +02:00
libraryupgrader 2a1923c0d7 build: Updating npm dependencies
* lodash: 4.17.20 → 4.17.21
  * https://npmjs.com/advisories/1673 (CVE-2021-23337)
* hosted-git-info: 2.8.8 → 3.0.8
  * https://npmjs.com/advisories/1677 (CVE-2021-23362)

Change-Id: Ie1ff6f02a80b57ba71005c6c8a7c0b30a8f7b9e3
2021-05-07 05:02:04 +00:00
jenkins-bot 5d1e79630f Merge "Introduce VisualEditorApiVisualEditorPostSaveHook" 2021-05-06 17:57:38 +00:00
jenkins-bot 68f8f26fd7 Merge "ArticleTargetLoader/Saver: Move vars inline" 2021-05-06 16:14:13 +00:00
Translation updater bot 856ed66544 Localisation updates from https://translatewiki.net.
Change-Id: Id188839d03f008d4e10da82af1e6ba973cc51c2e
2021-05-06 08:55:21 +02:00
Ed Sanders 2cf163fa23 Move vars inline in preinit code
Change-Id: Ice86931a48b4563a881af16d2fe8e344d49bc73f
2021-05-05 18:06:37 +01:00
Ed Sanders db90e1e610 ArticleTargetLoader/Saver: Move vars inline
Change-Id: I4afe5d0c68cb6284fe5178674e8942afb2b9d5bd
2021-05-05 16:56:49 +01:00
jenkins-bot 396876fe43 Merge "Check if actionTools.notices is set before using" 2021-05-05 15:16:44 +00:00
Kosta Harlan 298cb41ed3 Check if actionTools.notices is set before using
Ib957eac2d checked to see if actionTools.notices existed before
destroying it, but assumed it always existed if editNotices was
set. This patch adds a check before attempting to show editNotices.

The error occurs because Ibc7fa48df unregisters the 'notices' tool
(along with many others) for AddLinkArticleTarget.js in
GrowthExperiments. I92a3162ef in GrowthExperiments will empty out
any notices to work around this problem.

Bug: T281960
Change-Id: Idacd365efa82ecd5c0074ead035eda0cb9444b1f
2021-05-05 08:27:55 +00:00
Translation updater bot 06df721657 Localisation updates from https://translatewiki.net.
Change-Id: I836cf1089d1f9cccff43885b78f4afb02830b1a7
2021-05-05 08:39:34 +02:00
Adam Wight d5b5300fc1 Container as a local field
We're about to replace this jQuery element by a OOUI container, and
can take an initial step by reducing its lexical scope.

Change-Id: I4123c8d22c01040fc2f61180304254498b21f5fd
2021-05-04 16:25:45 +02:00
Adam Wight cd60daf072 Internally rename container for parameter docs
The name "description" conflicts with the TemplateData field name,
which is only one of several documentation fields.

Change-Id: I0942701204fe8499e8890740585b9a02c1d14c63
2021-05-04 16:24:07 +02:00
Adam Wight abdbb7d7ff Internally rename container for adding an undocumented paramter
The internal name "more" conflicts with new collapsible buttons.

TODO: looks like TemplatePage has an analogous field?

Change-Id: I10b24758316a6cc3fbd236c77daffa014fcdafc6
2021-05-04 16:23:53 +02:00
jenkins-bot b20ad7c730 Merge "Optional feature makes the transclusion dialog bigger" 2021-05-04 10:49:44 +00:00
Translation updater bot 613bc9d4fb Localisation updates from https://translatewiki.net.
Change-Id: Id9101c7eb9a10e9753550bca1b774b5345c15c1b
2021-05-04 08:53:27 +02:00
jenkins-bot 172684b543 Merge "Make convert to wikitext on paste feature configurable (temporarily)" 2021-05-03 22:19:53 +00:00
Ed Sanders fab7ad9d92 Make convert to wikitext on paste feature configurable (temporarily)
Bug: T280745
Change-Id: Icc716563e5536b4ef33a48ba10a72f3a39bdec35
2021-05-03 21:16:54 +00:00
Volker E c468f529fc Remove obsolete vendor prefixed properties
With updated basic support, let's remove obsolete vendor prefixed
properties.

Bug: T278670
Change-Id: I13ceec520559745c877588200024ebce16944da1
2021-05-03 08:09:01 -07:00
Adam Wight ded8c40915 Optional feature makes the transclusion dialog bigger
When $wgVisualEditorTransclusionDialogInlineDescriptions is set to
true, the template dialog will use a larger format.

Bug: T273971
Change-Id: Iad3c3f4d65125c83e35414ce15f793f6a1b192ef
2021-05-03 16:53:27 +02:00
Ed Sanders 1f50769cff ArticleTarget: Always set fromEditedState when preloaded is true
This means we don't need to check this.preloaded again anywhere else.

Bug: T279448
Change-Id: Ic8abdd87074d404a47ab8a82abf36e5443f3d163
2021-05-03 14:34:25 +01:00
jenkins-bot a4d1863a80 Merge "Use standard search API when searching for templates" 2021-05-03 08:12:35 +00:00
Translation updater bot ee2f55d14d Localisation updates from https://translatewiki.net.
Change-Id: I63d01d86369e3e3bd292df0114bc1a6bf7e3b35f
2021-05-03 08:38:34 +02:00
jenkins-bot 8878570696 Merge "Update VE core submodule to master (831a75cdb)" 2021-04-30 20:35:20 +00:00
Kosta Harlan f035ce51f1 Introduce VisualEditorApiVisualEditorPostSaveHook
What:

Add hook that runs after a save attempt is made in ApiVisualEditorEdit.
The hook receives the same data available in ApiVisualEditorEdit, and
implementations of the hook can modify the API response.

Also introduce templated
parameters (https://www.mediawiki.org/wiki/API:Templated_parameters) in
the API parameters; this allows plugins to pass arbitrary data along
with their request using e.g. plugins=linkrecommendation&data-linkrecommendation=foo

Add ServiceWiring files, a PHP namespace, and a HookRunner class to
support the above changes.

Why:

VE plugins may wish to send additional data when saving an edit and take
action based on that data on the server-side. See for example the
AddLink plugin in I7a052f8e which sends annotation data, and then uses
the new hook to perform a database operation.

Change-Id: I392691475fbdcec766acbd832600e82efcb5bfe8
2021-04-30 20:50:01 +02:00