wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-11 05:56:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Container as a local field

Browse source 
We're about to replace this jQuery element by a OOUI container, and
can take an initial step by reducing its lexical scope.

Change-Id: I4123c8d22c01040fc2f61180304254498b21f5fd
This commit is contained in:
Adam Wight 2021-04-26 11:13:14 +02:00
parent cd60daf072
commit d5b5300fc1
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
View file

@ -43,7 +43,6 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
this.$labelElement = $( '<div>' );
this.$field = $( '<div>' );
this.$addUndocumented = $( '<div>' );
this.$doc = $( '<div>' );
// Note: Calling createValueInput() sets some properties we rely on later in this function
this.valueInput = this.createValueInput()
@ -60,9 +59,10 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
// Construct the field docs
this.$doc
var $doc = $( '<div>' )
.addClass( 've-ui-mwParameterPage-doc' )
.append( $( '<p>' ).text( this.spec.getParameterDescription( paramName ) || '' ) );
.append( $( '<p>' )
.text( this.spec.getParameterDescription( paramName ) || '' ) );
if ( this.parameter.isRequired() ) {
this.statusIndicator
@ -70,7 +70,7 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
.setTitle(
ve.msg( 'visualeditor-dialog-transclusion-required-parameter' )
);
this.$doc.append(
$doc.append(
$( '<p>' )
.addClass( 've-ui-mwParameterPage-doc-required' )
.text(
@ -83,7 +83,7 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
.setTitle(
ve.msg( 'visualeditor-dialog-transclusion-deprecated-parameter' )
);
this.$doc.append(
$doc.append(
$( '<p>' )
.addClass( 've-ui-mwParameterPage-doc-deprecated' )
.text(
@ -96,7 +96,7 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
}
if ( this.defaultValue ) {
this.$doc.append(
$doc.append(
$( '<p>' )
.addClass( 've-ui-mwParameterPage-doc-default' )
.text(
@ -106,7 +106,7 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
}
if ( this.exampleValue ) {
this.$doc.append(
$doc.append(
$( '<p>' )
.addClass( 've-ui-mwParameterPage-doc-example' )
.text(
@ -134,7 +134,7 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
}
if ( !veConfig.transclusionDialogInlineDescriptions ) {
if ( this.$doc.text().trim() === '' ) {
if ( $doc.text().trim() === '' ) {
this.infoButton = new OO.ui.ButtonWidget( {
disabled: true,
title: ve.msg( 'visualeditor-dialog-transclusion-param-info-missing' ),
@ -146,7 +146,7 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
this.infoButton = new OO.ui.PopupButtonWidget( {
$overlay: config.$overlay,
popup: {
$content: this.$doc
$content: $doc
},
title: ve.msg( 'visualeditor-dialog-transclusion-param-info' ),
framed: false,
@ -214,8 +214,8 @@ ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config )
if ( veConfig.transclusionDialogInlineDescriptions ) {
this.$field.addClass( 've-ui-mwParameterPage-inlineDescription' );
this.$doc.addClass( 've-ui-mwParameterPage-inlineDescription' );
this.$info.after( this.$doc );
$doc.addClass( 've-ui-mwParameterPage-inlineDescription' );
this.$info.after( $doc );
}
if ( !config.readOnly ) {