Commit graph

15955 commits

Author SHA1 Message Date
Bartosz Dziewoński 8aac97cc30 Update VE core submodule to master (311a3dff1)
New changes:
bb8471c98 Edit cards: Don't show keyboard when going from focusable to link
80feb00ae BranchNode: Add comment to internalItem hack
9c2f1241b FocusableNode: Avoid DOM manipulation in setup

Change-Id: Iad906dc3aeff1b777ad11f276a277381a99b4113
2019-07-16 01:06:27 +02:00
Ed Sanders c958ea383d Add number of images to gallery context
Change-Id: I3e54c6cb2b29ecb1153afd5f2f61adaabceb095b
2019-07-16 01:04:08 +02:00
Ed Sanders 377ed366cd Add validation to feedback to internal links
Turns out we had this message lying around unused,
so use it (even though an invalid title is quite
hard to come up with).

Change-Id: I0200678820fe88a59869f7fad8f491b4c5b77482
2019-07-15 22:35:59 +00:00
Ed Sanders fba9585dbf Add validation feedback to external link
Bug: T227899
Change-Id: I165ed59402bdffb63b0c79b68a41d509c4574837
2019-07-15 22:35:46 +00:00
James D. Forrester d8b6509d78 Update VE core submodule to master (e16b98e25)
New changes:
616f2c40d Fix some typos in code comments
22c03cc02 Render internal item nodes when requested individually

Bug: T228070
Change-Id: I99ee90f0b88c00455995d165745509121df1b2b0
2019-07-15 14:11:20 -07:00
jenkins-bot 14539bfe22 Merge "Make page title the target title" 2019-07-15 19:08:11 +00:00
tcreusc 57317a20e4 Make page title the target title
There are cases where the page title and the real/desired page name
are not the same. Fixing that also fixes the suggestions that appear
in dialogs (see related bug).

Bug: T193132
Change-Id: Iafa84c05bea08ebb061ee6d1323eb50945b39815
2019-07-15 17:22:17 +00:00
jenkins-bot 5f85137285 Merge "MWSaveDialog: Use close flag for close actions, move 'back' button" 2019-07-15 15:34:22 +00:00
Translation updater bot abda55d5dd Localisation updates from https://translatewiki.net.
Change-Id: I5b11126d64c28b18e1b272062a7ffe8bf0c95511
2019-07-15 08:35:39 +02:00
Ed Sanders b64cd4ced1 Update VE core submodule to master (213b79783)
New changes:
6cd9ba63f Localisation updates from https://translatewiki.net.
c9cebed32 Update OOUI to v0.33.2
65c66b8a6 Localisation updates from https://translatewiki.net.
8d94ad13f Replace unrendered parts of the view tree with a stub node
213b79783 Basic unit tests for attachedRoot functionality

Bug: T215717
Change-Id: I7bd8106a82e4fa7c912ce9f8d4fab86bfb546702
2019-07-14 15:26:28 +01:00
Bartosz Dziewoński f259bb9c02 MWSaveDialog: Use close flag for close actions, move 'back' button
When previewing/reviewing changes, the "Return to save form" button
now replaces the "Resume editing" button in the top-left corner (and
receives the 'back' flag). Effectively, you tap 'back' once to go back
to the edit summary, and twice to go back to editing. This seems to me
like a much more natural interaction than two separate buttons.

Bug: T225021
Bug: T227049
Bug: T227857
Change-Id: Id27ccf06923c8aa86b1c1a9292bc43bb825ce6c8
2019-07-12 20:33:02 +00:00
Translation updater bot 7ed1a9ba95 Localisation updates from https://translatewiki.net.
Change-Id: If146cd0932f83bb8b1e2f9324f1c9555e050953f
2019-07-12 08:45:01 +02:00
James D. Forrester 18472d84a2 Follow-up Id330efac: Only hide the welcome dialog on mobile
Change-Id: I8fa3c6100652d2f29a60bc22c8e08a4d9e79d37a
2019-07-10 13:10:27 -07:00
jenkins-bot 5358d67342 Merge "Remove non-existing showRedlink from ve.ui.MWInternalLinkAnnotationWidget" 2019-07-10 19:06:16 +00:00
Bartosz Dziewoński cde7946bdc MobileArticleTarget: Don't show the welcome dialog
Bug: T227670
Change-Id: Id330eface30d5fad8c7264a2be1ceeb4df3a4952
2019-07-10 18:28:02 +00:00
Niklas Laxström ea66017b4b Remove non-existing showRedlink from ve.ui.MWInternalLinkAnnotationWidget
It was removed in 3e31a31 in 2016.

Change-Id: Ib7383a4ff585258a98d6795487e912597b41900e
2019-07-10 12:18:48 +02:00
James D. Forrester 9aca5ab86c build: Upgrade phan-taint-check-plugin from 1.5.0 to 2.0.1
Change-Id: Ie2bd989a52ec61ad881fd4f12d0598b42f4ca2e0
2019-07-09 13:00:47 -07:00
jenkins-bot 2ec5bd5447 Merge "MWLinkAnnotationInspector: Work around annoying syntax highlighting bug in Gerrit" 2019-07-09 17:09:40 +00:00
David Lynch e32f460a5c Extra logging for link inspectors
Bug: T221249
Change-Id: I4e5991f7aa90d08598d5ba7ac14839956bee9b94
2019-07-09 10:12:33 +00:00
Bartosz Dziewoński 9ba3255c26 MWLinkAnnotationInspector: Work around annoying syntax highlighting bug in Gerrit
Wrap a regexp in parentheses to avoid confusing Gerrit's New UI syntax
highlighter, which goes crazy if a line starts with a regexp.
https://github.com/highlightjs/highlight.js/issues/1962

Change-Id: I7e4ca4d5c4d449925af7168147016ed2fb8a6e33
2019-07-09 10:08:23 +02:00
James D. Forrester a0aacd89e1 Update VE core submodule to master (d49575d46)
New changes:
3bc3dfd87 build: Upgrade various devDependencies to latest and make pass
a0165b985 Fix visible whitespace rendering in source mode
261535e2d Avoid jQuery.map
bf1398cc3 Remove unused :visible check

Bug: T226478
Change-Id: I9b6a79ea0fdb1679036372b46b8df3b885ffb135
2019-07-08 11:17:16 -07:00
Translation updater bot e6c654c6e4 Localisation updates from https://translatewiki.net.
Change-Id: I6cfaabf68d29c794391986bde37d09a18a22145c
2019-07-07 22:42:02 +02:00
James D. Forrester 24a017e980 Update VE core submodule to master (89805a657)
New changes:
ee6c423cf Add transition to iOS menu bar hack
f11192b6d Localisation updates from https://translatewiki.net.
22eb0e4ca Replace #serialize methods with #toJSON
1fe8a1afb Provide defaults for ve.dm.Change constructor
ce0123260 Explicitly pass store length argument to pushTransaction
89805a657 Set max width on mobile demo

Change-Id: Ic2de7c5d5ab9f8d416a4de01a5125128533abe64
2019-07-05 15:51:01 -07:00
jenkins-bot 454a4da6b1 Merge "Log editor switches to visualeditorfeatureuse" 2019-07-04 19:30:42 +00:00
David Lynch 38e3c3fbdb Log editor switches to visualeditorfeatureuse
Depends lightly on a patch to WikiEditor, which will hook up the logging there
for the case where the switch is happening from WikiEditor to VisualEditor on
the same pageload.

Bug: T221191
Change-Id: Ibafec77b2eabd3b3b3767472b7b5a40e3312bf18
2019-07-03 23:58:30 -05:00
James D. Forrester 56df3cc4cb Update VE core submodule to master (75510a515)
New changes:
a3d860daf Localisation updates from https://translatewiki.net.
0421bf6f0 Gather annotations from clicked node where possible
2d2491877 Change#squash: Compact multiple transactions into one
dc0e4650e Fix documentation of ve.dm.Change#serialize
a40f8314f Fix contexedAnnotations equality check
ec62ccb34 Use 16px font size on SA mobile demo
57984c072 Update OOUI to v0.33.1

Add lib/ve/src/dm/ve.dm.TransactionSquasher.js to debugScripts.

Bug: T188026
Bug: T226708
Change-Id: I6eb4ab50ef2c6774963f692f600f059662bf0ac3
2019-07-04 00:31:57 +00:00
Translation updater bot ecffdff814 Localisation updates from https://translatewiki.net.
Change-Id: Ida828f4de44f39ada7a05f43813d21604eed8913
2019-07-03 22:46:50 +02:00
jenkins-bot a5e87bca9a Merge "Pass newRevId through to MobileFrontend" 2019-07-02 19:16:07 +00:00
jenkins-bot bad500da7b Merge "ArticleTarget: saveSuccess wasn't receiving expected arguments" 2019-07-02 19:16:03 +00:00
jenkins-bot 1d2b9d20cf Merge "Dialogs: Use close flag for close actions" 2019-07-02 19:01:36 +00:00
David Lynch 4d3ddb07e0 Pass newRevId through to MobileFrontend
Bug: T226847
Change-Id: I22daf4e7637c412aa444d98ec971bb294e4ade06
2019-07-01 15:59:55 -05:00
jenkins-bot 7796b569c9 Merge "MobileArticleTarget: Prevent unwanted page zooming on focus on iOS" 2019-07-01 16:14:35 +00:00
David Lynch c898838585 ArticleTarget: saveSuccess wasn't receiving expected arguments
Way back in 2c24efae in 2015 this got disconnected, which resulted in
saveComplete logging not having the expected updated revision_id.

Bug: T226847
Change-Id: I6dc14bb4b2dacedbe27493a97fa25c9b0542818c
2019-07-01 11:06:16 -05:00
Bartosz Dziewoński 2563bb3d89 MobileArticleTarget: Prevent unwanted page zooming on focus on iOS
Bug: T216446
Change-Id: I48beb1e120b5b087533b0827904212be9286529f
2019-07-01 15:53:29 +02:00
jenkins-bot 98c5db96aa Merge "Update VE core submodule to master (681aa3fbc)" 2019-07-01 13:12:43 +00:00
Translation updater bot e7d8c89010 Localisation updates from https://translatewiki.net.
Change-Id: I00d571201b4ad4212bdd69fd8e364eac0ca69178
2019-06-30 22:40:07 +02:00
James D. Forrester 3f38f54a12 Update VE core submodule to master (681aa3fbc)
New changes:
9cbe6ed65 Use 'unLink' icon for unlinking
e6f489f8d Dialogs: Use close flag for close actions
f2260bc47 Update RangeFix 0.2.7 -> 0.2.8

Bug: T225021
Bug: T225725
Change-Id: I36f27fe4b2b7a2fffa319cbff0b160b4435e806b
2019-06-28 13:36:18 -07:00
jenkins-bot d1c47b38a4 Merge "Remove citefromid alias support" 2019-06-28 18:50:55 +00:00
jenkins-bot d1b9844300 Merge "Simplify pulsating dot to one DOM node using :before/:after" 2019-06-28 16:40:05 +00:00
jenkins-bot 8f4c75bc1f Merge "Update VE core submodule to master (f93b871a6)" 2019-06-27 21:31:53 +00:00
James D. Forrester 928153f268 Update VE core submodule to master (f93b871a6)
New changes:
33c9871e4 ve.ce.Surface: Clear active annotation highlight when blurring on mobile
24e442efc Enhanced instrumentation for context items and inspectors
17e0a80ea Localisation updates from https://translatewiki.net.
39ba2e196 Update OOUI to v0.33.0

Bug: T221252
Change-Id: I06eb0f99557dbada022bcad44fff48ec0709e004
2019-06-27 10:43:03 -07:00
Ed Sanders 3f892fe368 Simplify pulsating dot to one DOM node using :before/:after
Change-Id: I81af08d58a33b6d3751bfc5012217b9bd98e69dc
2019-06-27 15:35:50 +01:00
James D. Forrester 34158b8568 Stop loading oojs-ui.styles.textures, gone as of OOUI 0.33.0
Change-Id: I38aa1ce529bed43175d2ecdcecd1c6a2a0ed603f
2019-06-26 20:54:49 -07:00
jenkins-bot 72418fea56 Merge "Update VE core submodule to master (cf99ae2e0)" 2019-06-26 21:44:26 +00:00
jenkins-bot 3e13dd7af6 Merge "build: Upgrade stylelint-config-wikimedia from 0.5.0 to 0.6.0" 2019-06-26 21:44:22 +00:00
James D. Forrester 97484d3b7a Update VE core submodule to master (cf99ae2e0)
New changes:
2c8676497 Rename call to deprecated scrollCursorIntoView
f04991f64 Fix missing resize handles in dist

Bug: T182312
Change-Id: I90e3672780356d352f2b08c824c59905e8936b6d
2019-06-26 14:11:06 -07:00
James D. Forrester 22344dae69 build: Upgrade stylelint-config-wikimedia from 0.5.0 to 0.6.0
Additionally a bump to grunt-image and grunt itself for security
reasons. Also, commit package-lock.json, which is what we do now.

Change-Id: I2beab15d7f5b1453ccbb3c46b6dd0800c78ed15b
2019-06-26 14:11:06 -07:00
jenkins-bot 2699566577 Merge "iOS browser menu bar tap stealing hack for bottom contexts" 2019-06-26 20:38:47 +00:00
Ed Sanders 5c62ae20ef Clear edit summary when switching section and discarding changes
Bug: T191590
Change-Id: I1d3c4528dd07fcff90ffa378ade1d6982fc68791
2019-06-26 19:51:16 +00:00
jenkins-bot b57aaa59cd Merge "MW link inspector: Empty before appending" 2019-06-26 19:23:12 +00:00