wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 11:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ArticleTarget: saveSuccess wasn't receiving expected arguments"

Browse source
This commit is contained in:
jenkins-bot 2019-07-02 19:16:03 +00:00 committed by Gerrit Code Review
parent 1d2b9d20cf c898838585
commit bad500da7b
2 changed files with 22 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/ve-mw/init/ve.init.mw.ArticleTarget.js
View file

@ -96,6 +96,17 @@ OO.inheritClass( ve.init.mw.ArticleTarget, ve.init.mw.Target );
/**
* @event save
* @param {string} html Rendered page HTML from server
* @param {string} categoriesHtml Rendered categories HTML from server
* @param {number} newid New revision id, undefined if unchanged
* @param {boolean} isRedirect Whether this page is a redirect or not
* @param {string} displayTitle What HTML to show as the page title
* @param {Object} lastModified Object containing user-formatted date
* and time strings, or undefined if we made no change.
* @param {string} contentSub HTML to show as the content subtitle
* @param {Array} modules The modules to be loaded on the page
* @param {Object} jsconfigvars The mw.config values needed on the page
* Fired immediately after a save is successfully completed
*/
/**
@ -680,7 +691,7 @@ ve.init.mw.ArticleTarget.prototype.saveComplete = function () {
this.initialEditSummary = null;
this.saveDeferred.resolve();
this.emit( 'save' );
this.emit.apply( this, [ 'save' ].concat( Array.prototype.slice.call( arguments ) ) );
};
/**

13
modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
View file

@ -106,9 +106,16 @@ ve.init.mw.ArticleTargetEvents.prototype.onSaveInitiated = function () {
/**
* Track when the save is complete
*
* @param {string} content
* @param {string} categoriesHtml
* @param {number} newRevId
* @param {string} content Rendered page HTML from server
* @param {string} categoriesHtml Rendered categories HTML from server
* @param {number} newRevId New revision id, undefined if unchanged
* @param {boolean} isRedirect Whether this page is a redirect or not
* @param {string} displayTitle What HTML to show as the page title
* @param {Object} lastModified Object containing user-formatted date
* and time strings, or undefined if we made no change.
* @param {string} contentSub HTML to show as the content subtitle
* @param {Array} modules The modules to be loaded on the page
* @param {Object} jsconfigvars The mw.config values needed on the page
*/
ve.init.mw.ArticleTargetEvents.prototype.onSaveComplete = function ( content, categoriesHtml, newRevId ) {
this.trackTiming( 'performance.user.saveComplete', { duration: ve.now() - this.timings.saveInitiated } );