Commit graph

14674 commits

Author SHA1 Message Date
David Lynch 54e9de44c3 ApiVisualEditor: warn of deleted pages in edit notices
Replicate the EditPage#showIntro segment which shows a warning and the
deletion log if attempting to recreate an already-deleted page.

Bug: T199087
Change-Id: I3c680e712c010dc614710b3aa9f41c8ec17999a7
2018-07-12 11:34:22 -05:00
James D. Forrester 3160429959 Follow-up dfe27be: Add missing i18n keys to manifest
I thought I'd done this. I didn't.

Bug: T198064
Change-Id: I1c78ce957f26e8c297d97d6f78b3451600b4657c
2018-07-10 15:55:56 -07:00
Translation updater bot 992b0b16d5 Localisation updates from https://translatewiki.net.
Change-Id: I921ca1926a5bfb08bfb6c11debda963e24a6a413
2018-07-10 22:16:31 +02:00
jenkins-bot 74957f35b1 Merge "init.mw.ArticleTarget: make sure renderCategories preserves order" 2018-07-10 20:03:39 +00:00
James D. Forrester 27f56a57f9 Update VE core submodule to master (58eb2cb97)
New changes:
634908a57 build: Upgrade to eslint 5.x
08a5f34cd Register dummy triggers for clipboard actions
f15f7832b Add getNameByTrigger to TriggerRegistry

Change-Id: Ia943df83aca831a72cf0e984fb4c982d1d4dfdf4
2018-07-10 10:54:24 -07:00
David Lynch 9d8d4255cc init.mw.ArticleTarget: make sure renderCategories preserves order
The linkCache fetch can push the categories out of order unless everything is
already in cache. As such, remember the initial order and enforce it after the
promises have resolved.

Bug: T197759
Change-Id: I9ea8d5e642f62c96475d0713f2c79258abb33b19
2018-07-10 12:30:30 -05:00
jenkins-bot 55428c849e Merge "Fix doc in GalleryDialog and add todo" 2018-07-09 22:34:35 +00:00
jenkins-bot fd48ac89a1 Merge "build: Bump devDependencies related to the screenshots task" 2018-07-09 21:31:36 +00:00
Ed Sanders f80b029444 Fix doc in GalleryDialog and add todo
Change-Id: I4e1ad8ec3d7a1c85a600bf1dafc449054c115203
2018-07-09 22:03:52 +01:00
Translation updater bot ca7071775e Localisation updates from https://translatewiki.net.
Change-Id: Ic86dc77fb778ea0d5bdd104cfbd0fefd98304ec7
2018-07-09 22:11:27 +02:00
James D. Forrester 6e71e1c0c3 build: Bump devDependencies related to the screenshots task
This fixes a bunch of warnings from `npm audit`.

Change-Id: I31321f2f19421944787279923e010f8093789d5e
2018-07-09 10:50:40 -07:00
jenkins-bot 1d17c089d5 Merge "init.mw.ArticleTarget: sort categories correctly in renderCategories" 2018-07-09 17:50:09 +00:00
jenkins-bot 47db68cf1c Merge "build: Enable and make pass no-prototype-builtins" 2018-07-09 17:09:34 +00:00
jenkins-bot a10b0b2492 Merge "build: Bump linters for eslint 5 and make pass" 2018-07-09 17:07:25 +00:00
David Lynch 71e42d50fe init.mw.ArticleTarget: sort categories correctly in renderCategories
I.e. don't sort them, because they're provided in source order and that's all
we need.

Bug: T197759
Change-Id: I3b9508ff49233ccfbeba1d111a6df9f29f0fc318
2018-07-09 09:25:41 -05:00
Translation updater bot 9bb4ebda5c Localisation updates from https://translatewiki.net.
Change-Id: If53e521615b01b40e64baa85e9fbf82d62db9e36
2018-07-07 22:52:45 +02:00
Translation updater bot d9a8ab77de Localisation updates from https://translatewiki.net.
Change-Id: Ifd4b4904fee3dcc1c1eee2add0f01d58b51349fd
2018-07-06 22:39:23 +02:00
James D. Forrester 3c6ca93b92 build: Enable and make pass no-prototype-builtins
Including a spectacular whoops in MWGalleryDialog.

Change-Id: Id9863f6dc3701cb0df6684380fa5ecac4526d37d
2018-07-06 10:58:18 -07:00
James D. Forrester ceab9e6510 build: Bump linters for eslint 5 and make pass
Change-Id: I88627028e5806c2fdceb76fd26bcb57d44ed4c20
2018-07-06 10:58:18 -07:00
James D. Forrester dfe27be40c Update VE core submodule to master (bbe825690)
New changes:
e761c7e80 Localisation updates from https://translatewiki.net.
7ffaf8c86 Change clear styling label in contexts
8727b8823 Localisation updates from https://translatewiki.net.
903fe9a6e Localisation updates from https://translatewiki.net.
2d0db8666 Change transaction manipulation functions into methods
198b35a70 Handle ctrl+click events on links
90ea4832e Fix cleanup of PreviewElement after render
3f888e8b2 ve.ui.TableLineContext: Use automatic width
37d42880e Create basic tests for PreviewElement

Bug: T145850
Bug: T195707
Bug: T198064
Bug: T198826
Bug: T198871
Change-Id: Id02adf9f5d85574ee9c7d3ef7c32c19bfcb06a45
2018-07-05 16:09:49 -07:00
Translation updater bot 97596165b7 Localisation updates from https://translatewiki.net.
Change-Id: Ia99ec0525d2a770f7427f765197f9904b2f65f82
2018-07-05 22:44:14 +02:00
jenkins-bot 097fb6a18f Merge "MWImageNode: Make 'mw' attribute optional again" 2018-07-05 20:17:33 +00:00
James D. Forrester ba3e5a3690 MWWelcomeDialog: Shrink the background image by 1/3 so the CTAs show
Bug: T191095
Change-Id: Id1fd76a37d02a9572cc29909409cd53e28ce0bb9
2018-07-05 20:04:57 +02:00
Bartosz Dziewoński b4456cc482 MWWelcomeDialog: Refactor splash image to allow resizing it
We relied on some white space baked into the background-image
to "reserve the space" for the text. If we tried to make the image
smnaller, the text would start overlapping it.

Remove 100px of vertical white space from the image files, adjust
the styles so that text is displayed below the image rather than
overlapping it.

Bug: T191095
Change-Id: I2f19128a2044b3505cdea93c3f587fe62553071d
2018-07-05 20:04:57 +02:00
jenkins-bot 67e4799d39 Merge "DesktopArticleTarget.init: Fix URI comparison if it contains a port number" 2018-07-03 23:16:33 +00:00
jenkins-bot 13e4f0bbd0 Merge "DesktopArticleTarget: consolidate edit tab behavior" 2018-07-03 22:27:42 +00:00
Bartosz Dziewoński 9ef039dd4b DesktopArticleTarget.init: Fix URI comparison if it contains a port number
If the wiki runs on a host that contains a port number, section edit
links would always reload the page, and the "Add section" tab would
not work.

As it happens, my local testing wiki runs on localhost:3080.

It is an unfortunate naming mishap:
* mw.Uri#host is equivalent to location.hostname
* mw.Uri#getHostPort is equivalent to location.host

In this case, we have to compare the port too, otherwise a setup (my
setup ;) ) where one starts up another wiki on localhost:3081 to test
cross-wiki features would fail.

Change-Id: Ib7de4ba3c3a84888f24186af03bd9dcced131051
2018-07-04 00:11:48 +02:00
Translation updater bot 0d35cd8759 Localisation updates from https://translatewiki.net.
Change-Id: I0c4370afdbe00dfee217ea58e26c6092dad11eb8
2018-07-03 22:16:54 +02:00
Bartosz Dziewoński a247fd4e90 MWImageNode: Make 'mw' attribute optional again
It contains some rare options that we don't currently make editable,
and we don't set it when creating new image nodes.

We could change our code to always set it, and consider it required,
but that would theoretically be a break in backwards-compatibility.

Bug: T198660
Change-Id: I6e77cce257f733f0f8f6e896b967177ff01658c6
2018-07-03 21:03:46 +02:00
jenkins-bot e2132eeff5 Merge "ve.ui.MWTemplatePlaceholderPage: Avoid Firefox rendering issue" 2018-07-03 18:57:11 +00:00
Bartosz Dziewoński 5827b17ad0 ve.ui.MWTemplatePlaceholderPage: Avoid Firefox rendering issue
There is something about ActionFieldLayouts with `align: 'left'` (the
default) and no label that causes Firefox to render them differently
than we expect. I am not sure if the bug is in OOUI or Firefox, but it
is easily avoided by just using `align: 'top'` instead (it looks the
same, since there is no label, and it avoids the issue).

Bug: T198274
Change-Id: Ic6077e576b504e7a0cd761c8bac24d4079ae6702
2018-07-03 20:13:28 +02:00
jenkins-bot 43d5e767e8 Merge "De-duplicate and fix updating of file link in media dialog" 2018-07-03 17:27:37 +00:00
Ed Sanders 6bf9210abe De-duplicate and fix updating of file link in media dialog
Bug: T198565
Change-Id: I7d06d3316b317fb85edb9461080f5f2e5cd439fe
2018-07-03 17:59:43 +01:00
jenkins-bot 4a7e160d4f Merge "Fix window target when opening feedbackUrl" 2018-07-03 16:55:56 +00:00
Ed Sanders 452545fa2e Fix window target when opening feedbackUrl
'_new' should be '_blank', but '_blank' is also the
default, so just remove the argument.

Change-Id: I8f922b835b2bc14e5641e0ab29bf002b32301490
2018-07-03 17:36:35 +01:00
Ed Sanders f1b506bb6a Fix toolbar group names
Bug: T198583
Change-Id: I7b2e15dc65655bf048a02d9902a8f6e1c491edef
2018-07-03 14:23:21 +01:00
David Lynch 92c4e231f2 DesktopArticleTarget: consolidate edit tab behavior
What happens when an edit tab is clicked is spread across handlers in
DesktopArticleTarget and DesktopArticleTarget.init. Consolidating the logic
into the handler in DesktopArticleTarget.init makes it easier to understand.

It could be moved further into DesktopArticleTarget, but the init handler has
to exist to activate the target in the first place.

This patches a hole where clicking "edit source" while in visual mode would
sometimes not switch to source mode, because it didn't think it was changing
the current section.

Also, fix a typo in the documentation.

Bug: T198272
Change-Id: I12d958b6af1b9fa9aca68b498eb2a1a2d76b5a82
2018-07-02 16:17:15 -05:00
jenkins-bot dd794ddd40 Merge "Replace wfMemcKey with $wgMemc->makeKey" 2018-07-02 15:06:57 +00:00
Jack Phoenix d9066c829c Replace wfMemcKey with $wgMemc->makeKey
Change-Id: I959edd0816917bc49deb40d6990517afdcbeae15
2018-07-02 14:43:06 +00:00
Translation updater bot 596579ec8e Localisation updates from https://translatewiki.net.
Change-Id: I503c8a7fa65485a9ad523520855f2dcaa2138391
2018-06-30 22:30:56 +02:00
Translation updater bot 6f2886823e Localisation updates from https://translatewiki.net.
Change-Id: I3fc6aaa516d4d988a2ce33f84bd665a52debe9d8
2018-06-29 22:28:10 +02:00
jenkins-bot 4c88fc7ef4 Merge "Pass page parameter for multipage file (PDF, DjVu) thumbnails" 2018-06-29 20:08:55 +00:00
jenkins-bot 611ef4ef1c Merge "Pass video thumbtime to thumbnail metadata request" 2018-06-29 20:07:42 +00:00
Ed Sanders 715d67b564 Pass page parameter for multipage file (PDF, DjVu) thumbnails
Bug: T182392
Change-Id: Ib3bc7b13f24493da27078631a41e9c08bcc6c0f4
2018-06-29 19:26:42 +00:00
Translation updater bot fd1ac29964 Localisation updates from https://translatewiki.net.
Change-Id: I93f6fd3175e80121b6cf430f3a2c064d7f593c12
2018-06-28 22:21:46 +02:00
Ed Sanders 5cdbc17899 Pass video thumbtime to thumbnail metadata request
Bug: T198150
Change-Id: Ic8895c359a92fcc60ac486e3daf86db02599d3ff
2018-06-28 15:52:50 +01:00
jenkins-bot 08b1d31d84 Merge "Update VE core submodule to master (49fd5e439)" 2018-06-28 11:08:10 +00:00
jenkins-bot 17041d3f07 Merge "Don't call Resizable constructor conditionally" 2018-06-27 21:49:31 +00:00
Translation updater bot eb3c3e7484 Localisation updates from https://translatewiki.net.
Change-Id: If87d2bcfbb7339de504bd0e6919b7a0d8a9a77a9
2018-06-27 22:20:50 +02:00
James D. Forrester 22979cdc8b Update VE core submodule to master (49fd5e439)
New changes:
49fd5e439 Update OOUI to v0.27.4

Change-Id: Ib70a0f2d41d9d22ed9232ba6b6dbeb604fc5eb12
2018-06-27 11:31:04 -07:00