wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-26 19:56:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

init.mw.ArticleTarget: sort categories correctly in renderCategories

Browse source 
I.e. don't sort them, because they're provided in source order and that's all
we need.

Bug: T197759
Change-Id: I3b9508ff49233ccfbeba1d111a6df9f29f0fc318
This commit is contained in:
David Lynch 2018-07-09 09:25:41 -05:00
parent 9bb4ebda5c
commit 71e42d50fe
1 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/ve-mw/init/ve.init.mw.ArticleTarget.js
View file

@ -2624,19 +2624,7 @@ ve.init.mw.ArticleTarget.prototype.renderCategories = function ( categoryItems )
}
return $list;
}
function categorySort( a, b ) {
var sortA = a.sortkey || a.category,
sortB = b.sortkey || b.category;
if ( sortA < sortB ) {
return -1;
}
if ( sortA > sortB ) {
return 1;
}
return 0;
}
if ( categories.normal.length ) {
categories.normal.sort( categorySort );
$normal = $( '<div class="mw-normal-catlinks" />' );
$normal.append(
renderPageLink( ve.msg( 'pagecategorieslink' ) ).text( ve.msg( 'pagecategories', categories.normal.length ) ),
@ -2646,7 +2634,6 @@ ve.init.mw.ArticleTarget.prototype.renderCategories = function ( categoryItems )
$output.append( $normal );
}
if ( categories.hidden.length ) {
categories.hidden.sort( categorySort );
$hidden = $( '<div class="mw-hidden-catlinks" />' );
if ( mw.user.options.get( 'showhiddencats' ) ) {
$hidden.addClass( 'mw-hidden-cats-user-shown' );