Commit graph

8054 commits

Author SHA1 Message Date
James D. Forrester eec5946d17 Update VE core submodule to master (48772a2)
New changes:
77dd12e Prevent deletion of focusable nodes by typing
da66427 Update OOjs UI to v0.1.0-pre (97dbb50137)

Change-Id: Ia6d83495a523106e92b184c8b60f815d3739d1fa
2014-07-16 16:00:14 -07:00
Moriel Schottlender 2a114815ab Listen to widget changes in MediaDialog
Attach event listener to the alternate text and the media size widget
in the MediaDialog, so that when either of those are changed the
'Apply Changes' button is enabled.

Related to I88c3f3dcc7667b3ffdd2a8a8433cb47b82ba1531

Bug: 67684
Change-Id: I03efbed2f9b2909b055d96b9ae1e27b6d5e2bdbf
2014-07-16 22:46:47 +00:00
jenkins-bot e5fba68036 Merge "[BrowserTest] update switch-edit-mode test for new UI" 2014-07-16 22:43:56 +00:00
jenkins-bot ccbee28161 Merge "Update VE core submodule to master (ad18102)" 2014-07-16 22:43:51 +00:00
Trevor Parscal 1be1c469de Enable mwreference, mwtransclusion modules on all targets including mobile
Bug: 67701
Change-Id: Icdf2a208c9efa7abd897d48aed02bf923328d53c
2014-07-16 22:40:00 +00:00
Cmcmahon d0b8f62276 [BrowserTest] update switch-edit-mode test for new UI
Also add new checks for switch-modal Discard and
Cancel options

Change-Id: I228b0dee1d110f6a72be4966bbc5918f294ab717
2014-07-16 15:38:52 -07:00
Moriel Schottlender e94a185fda Update VE core submodule to master (ad18102)
New changes:
65042de Fix alien test data
83dccbe Add toolbar menu labels to each group for consistency
2e40ef9 Move 'language' tool from the insert to the styling menu, like in VE-MW
6fb21b2 Add toolbar action section to SA demo with keyboard shortcuts tool
f3eb000 ve.ui.Toolbar: Optimise onSurfaceViewKeyUp performance
eb4e9eb Make sure the document is focused when setting a selection
48584d3 Fixes to getRelativeOffset and getRelativeRange		
fcc427f [BREAKING CHANGE] Remove generatedContents argument from afterRender
825e4be Documentation fixes in test utils		
dbbbe0b Unit tests for showSelection		
1ba9234 Don't handle up/down on focusableNodes even if backwards
a667b87 Remove label from 'insert' menu, and instead use a large plus icon
88885b1 Localisation updates from https://translatewiki.net.		
1f3b79f Initialize data first		
18369b1 Add 'clone' and make 'getDimensionsFromValue' static in ve.dm.Scalable		
92e6b7b Switch to 'custom' when MediaSizeWidget updates		
d0cd87e Localisation updates from https://translatewiki.net.		
1ee21ff Remove lies from documentation		
164f07f Safely ignore requests to open unrecognized windows

Local changes:
Work on a cloned scalable when editing images

Make sure the image model handles a cloned copy of the node's
scalable object, which is then shared with the media size widget.

Bug: 67687
Change-Id: Ie3676b715f5bae3d83da03d667cef3a6a847e212
2014-07-16 22:38:09 +00:00
Alex Monk c1c80f6985 Set title of page to use if discarding changes when changing to the wikitext editor
Turns out it's a bad idea to do most testing on the default page

Bug: 68121
Change-Id: Ie9729dba4e8ca690625a6553703e9ff30cb5106e
2014-07-16 23:15:26 +01:00
jenkins-bot de9491ea0e Merge "Make a message dialog for cancelling VE" 2014-07-16 20:45:28 +00:00
jenkins-bot 1ff53d1b77 Merge "Don't allow document save if we're already tearing down the surface" 2014-07-16 20:45:24 +00:00
Translation updater bot 2c390f41ec Localisation updates from https://translatewiki.net.
Change-Id: Ifdf8cb5fa2726e419277638ae1f0c06978345c6c
2014-07-16 22:02:30 +02:00
Cmcmahon ea96b33c2c [BrowserTest] update template test
Change-Id: I0956bf58e15b1998b995bbcaddbe2514a8d7a058
2014-07-16 12:21:57 -07:00
jenkins-bot bb213db797 Merge "[BrowserTests] update References test for new UI" 2014-07-16 18:27:03 +00:00
Cmcmahon 48044d0ec5 [BrowserTests] update References test for new UI
Change-Id: I9c91a195cb42136422dec59e22d4a3164deaa8d9
2014-07-16 11:24:37 -07:00
Cmcmahon 0791e5c761 [BrowserTests] update Options test for new UI
Change-Id: If435620bc730a3b9d04918fcd4181e08d286e5a1
2014-07-16 11:12:46 -07:00
Alex Monk b9ad2fb406 Don't allow document save if we're already tearing down the surface
Otherwise you get "Uncaught TypeError: Cannot read property 'messages' of null"
if you press the save button late enough in the saving process. The bug refers
to a different error which I have not been able to reproduce.

Bug: 68073
Change-Id: Ia8fa325f1450329b6e0e4ee9af5302aa4857d637
2014-07-16 17:52:00 +01:00
jenkins-bot 97d286aa0f Merge "[BrowserTest] update links test" 2014-07-16 15:27:24 +00:00
Cmcmahon a8c33dfdd7 [BrowserTest] update links test
This may not be the last update, I want to see how this works in
the Jenkins build

Change-Id: Ib2123d030bc13e84099601a858a5f69aee3a03a4
2014-07-16 08:24:22 -07:00
Cmcmahon 8d39658d6c [BrowserTest] update media test for new UI
Change-Id: I35f75b8cb0fac27167d4f949069c48baac499b02
2014-07-16 07:37:36 -07:00
jenkins-bot 726fae1cc8 Merge "Rename "test" folder to "tests"" 2014-07-16 01:06:02 +00:00
Željko Filipin f850ddf73b Rename "test" folder to "tests"
All other repositories have tests in “tests” folder. For more
information see:

http://lists.wikimedia.org/pipermail/qa/2014-July/001663.html
http://lists.wikimedia.org/pipermail/qa/2014-July/001667.html
http://lists.wikimedia.org/pipermail/qa/2014-July/001672.html

Change-Id: Ib1e4fa4b7203bd8217615db1ceac23a329c081f1
2014-07-15 18:00:32 -07:00
jenkins-bot 1c099f4184 Merge "Always initialize data before use" 2014-07-16 00:52:09 +00:00
Cmcmahon 2786af8625 [BrowserTest] Update edit test for new UI
Change-Id: Ib126e2f429695d812bc2af566e21b2934b0f0fe9
2014-07-15 17:21:49 -07:00
Alex Monk 54a1a85e6e Make a message dialog for cancelling VE
Confirm dialog was replaced in refactor, so until this is merged the 'Cancel'
button is broken.

Bug: 68068
Change-Id: I77d1c82bf0d68013eef361174a134860a197cd44
2014-07-16 00:07:24 +01:00
Cmcmahon c9646604b0 [BrowserTest] Update bullets test for new UI design
Change-Id: I2dd9076bea844116ca5cb30f7d290081102ed859
2014-07-15 15:54:54 -07:00
Bartosz Dziewoński 5ed43c266a MWLinkNodeInspector: Actually preserve annotations when converting to link annotation
This was implemented, but didn't work because the node was removed
before its annotations were copied.

Also fixed:
* Don't do an unnecessary transaction to change attributes of a node
  we're going to remove anyway.
* Apply the same link href fixups when converting as when not
  (previously, changing the href to 'example.com' and clicking "Add
  label" would break the link in interesting ways).
* Do a single transaction from replacement instead of removal+insertion
  when possible.

Bug: 67377
Change-Id: I0318ae62c799300fb7696506a9736b839e2c8578
2014-07-16 00:50:23 +02:00
Trevor Parscal f30336bc2e Always initialize data before use
LinkNodeInspector was broken when you clicked away/pressed escape, because data was not set.

Normalizing on data being initialized at the top of get*Process methods if used.

Change-Id: I89728ac558545a6f2c325014b6f457ec6bef17b8
2014-07-15 15:49:51 -07:00
jenkins-bot 6f54034e68 Merge "MWImageModel unit tests" 2014-07-15 22:12:13 +00:00
jenkins-bot a9b757a174 Merge "MWTitleInputWidget: Remove prefixColon option and use relative title instead" 2014-07-15 22:10:42 +00:00
jenkins-bot a7f9e955c6 Merge "ve.ce.MWExtensionNode: Don't escape content of wikitext tags on preview" 2014-07-15 22:09:10 +00:00
jenkins-bot a5e1cfcf78 Merge "ve.ui.MWExtensionInspector: Prevent from setting impossible content" 2014-07-15 22:09:06 +00:00
Translation updater bot b37a947f78 Localisation updates from https://translatewiki.net.
Change-Id: Ie46b8801476574031135d86cfda2d75e811111be
2014-07-15 22:08:39 +02:00
jenkins-bot 5a367aec52 Merge "Simplify visualeditor-help-title and visualeditor-timeout" 2014-07-15 18:31:31 +00:00
jenkins-bot 74786a31cb Merge "[BrowserTest] Added support for page elements in iframe" 2014-07-15 13:30:43 +00:00
vikassy e3ecff4dcb [BrowserTest] Added support for page elements in iframe
Bug: 62737
Change-Id: Id60c7268dd6e3e4e755bdc53fef7e7d714d4ab0b
2014-07-15 13:26:09 +00:00
Moriel Schottlender 537e751abe MWImageModel unit tests
Change-Id: I87d1383b383e2a7cd6cb38ed51710cc36a59f63e
2014-07-15 12:47:32 +01:00
Trevor Parscal 8ebea5a75b Close the citation dialog after the apply changes button is clicked
Change-Id: If3976389f0a1574fce993f5b79b9b18067a88878
2014-07-14 17:09:24 -07:00
Federico Leva 760fc0e6ca Simplify visualeditor-help-title and visualeditor-timeout
The less repetition and the less undefined concepts where possible,
the more clarity. Suggestions thanks to James' explanations at
* https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Visualeditor-timeout/en
* https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Visualeditor-help-title/en

Change-Id: I05857e5287f5f15f0206a8faa46922e7aa7c3c1b
2014-07-15 00:00:59 +00:00
James D. Forrester fbdff76263 Update VE core submodule to master (f2277ea)
New changes:
56de6f5 Localisation updates from https://translatewiki.net.
f8bda64 Widgetise demo menu
6ac48d8 Localisation updates from https://translatewiki.net.
365e131 builderloader: Omit value for boolean "disabled" attribute per HTML5
706e4b3 Prevent double counting of DM nodes in getNodeAndOffset
b141a7d Update OOjs UI to v0.1.0-pre (d2451ac748)
c5b3921 Localisation updates from https://translatewiki.net.
1606983 Update reference to ConfirmationDialog to use MessageDialog

Deletions:
* Styles for ve.ui.MWBetaWelcomeDialog - not needed anymore because
  OO.ui.MessageDialog provides them
* Styles for ve.ui.MWGalleryInspector - not needed anymore because
  ve.ui.MWExtensionInspector provides part of them and the rest are being
  replaced by programatic sizing

Modifications:
* ve.ui.MWLinkTargetInputWidget - Added support for validation and href
  getter
* Split message between tool and dialog title for ve.ui.MWEditModeTool
  and ve.ui.MWWikitextSwitchConfirmDialog

General changes:
* Updated inheritance.
* Added manager param to constructors of dialogs and inspectors.
* Updated use of show/hide with toggle.
* Added meaningful descriptions of dialog and inspector classes.
* Configured dialog and inspector sizes statically.
* Configured dialog action buttons statically.
* Interfaced with OO.ui.ActionSet to control action buttons.
* Moved applyChanges code into getActionProcess methods.
* Always using .next in setup/ready process getters and .first in
  hold/teardown process getters.

Change-Id: Ia74732e6e32c0808eee021f0a26225b9e6c3f971
2014-07-14 23:24:45 +00:00
Translation updater bot 73beda2c10 Localisation updates from https://translatewiki.net.
Change-Id: I1f6a557082525ae68b261079a3b7a890be0e26b2
2014-07-14 22:03:53 +02:00
jenkins-bot 5e5e3680df Merge "[BrowserTest] Fixed language screenshot upload script" 2014-07-14 10:00:32 +00:00
vikassy 7ca18bacb2 [BrowserTest] Fixed language screenshot upload script
Bug: 62737
Change-Id: I7be433f711b422c156da863dbcbd30e089cc67c7
2014-07-14 11:58:07 +02:00
jenkins-bot 1ea89677ef Merge "Remove ext.visualEditor.editPageInit alias" 2014-07-13 21:06:27 +00:00
Translation updater bot 1ed589eccd Localisation updates from https://translatewiki.net.
Change-Id: I106d07e16120881cafcd59a0c3cbcd30d44a0e96
2014-07-13 22:25:27 +02:00
Bartosz Dziewoński 7656398e79 Remove ext.visualEditor.editPageInit alias
Created in 2012… (9a0380c6)

Change-Id: Ie302e9e0c22aea37de62e3037738320c6b82e36b
2014-07-13 14:37:16 +02:00
Translation updater bot ba3ccd46f8 Localisation updates from https://translatewiki.net.
Change-Id: Ia0436f75950d914826f2bb14b82b4a2e6a8a2d6d
2014-07-12 23:25:05 +02:00
Translation updater bot 9524a58bea Localisation updates from https://translatewiki.net.
Change-Id: I33438e5fb2f431d5d48f2ee78efdb55819db57da
2014-07-11 21:58:18 +02:00
jenkins-bot 8b25cb9717 Merge "generateContents -> generatedContents" 2014-07-10 21:58:42 +00:00
Ed Sanders b1fb9c1b82 generateContents -> generatedContents
Change-Id: Idfe609d0830ba2b29901211f56dd355ddf8ab96e
2014-07-10 22:47:48 +01:00
Alex Monk 3acca7cdf5 Fix cite/template dialogs
I1a7fc7f2 broke cite/template dialog - onDescriptionClick is not defined.
I can't find it anywhere in the VE-MW or OOUI source.
Before my change, it was simply a no-op. But now we try to bind it in a way
that breaks everything. This commit just removes that line since it was
apparently not doing anything.

Bug: 67814
Change-Id: I0b9c3318b3de8530e0ba9e355cd73eb7f70a6b5a
2014-07-10 21:37:07 +01:00