Commit graph

3536 commits

Author SHA1 Message Date
Ed Sanders b7f92605b2 Move test registry hacks into QUnit setup/teardown hooks
Change-Id: I7b56bc7a9a69f64073ab97bdb1911d17b328b8b8
2015-06-02 14:36:10 +01:00
jenkins-bot ee9da3101e Merge "ve.dm.MWTemplateSpecModel: Account for data.maps being undefined" 2015-06-02 01:50:26 +00:00
Timo Tijhof f2875141d8 ve.dm.MWTemplateSpecModel: Account for data.maps being undefined
This new property is optional and should not be assumed to be present.
Follows-up 2ac7959849.

The constructor defaults 'maps' to an empty object, so there's no need
to add a "|| {}" in extend() or getMaps(). We merely need to make sure
we don't accidentally dereference the default in exchange for undefined.

Change-Id: Id2cb93696d12a20ee14f9d59705877dc174e6564
2015-06-02 01:48:21 +00:00
Ed Sanders e9384ad9ac Update VE core submodule to master (83d45d1)
New changes:
9d162ce Restore the selection to a sensible place when closing FindAndReplace
57229ac Only apply annotations if 'done' is clicked
bfb17ee Always show cancel button on annotation inspectors
91672cf Disable 'done'/'insert' button when input invalid
aef9cbd Only create annotations from text input if it is valid
a384b96 [BREAKING CHANGE] Make getTextFromAnnotation/getAnnotationFromText static
fa09ab7 Scroll table selection into view when it changes

Local changes:
Make getTextFromAnnotation/getAnnotationFromText static

Change-Id: Id3c2a1efb1f327fa6d5b93d57d90bb5bb8ee88f8
2015-06-02 00:47:13 +00:00
Roan Kattouw b3d2e9013f Account for MWTitleInputWidget having been moved into MW core
Depends on I43fb412ff6 in MW core.

Change-Id: Ia189e19f0ccb71adf9f3eeba4d600c2bcb360037
2015-06-01 17:24:52 -07:00
Translation updater bot ed936bdb11 Localisation updates from https://translatewiki.net.
Change-Id: I8858442868cbff32cf91ab77e73c2d1fedb28d41
2015-06-01 23:00:00 +02:00
Translation updater bot b36a5b854a Localisation updates from https://translatewiki.net.
Change-Id: I695c8f695e575dbea4a5a7d9e821f2e584d741ed
2015-05-31 22:18:47 +02:00
Translation updater bot a83a826cf6 Localisation updates from https://translatewiki.net.
Change-Id: I14a6803824061d66df3c4281c8bb5cde8238b46c
2015-05-30 23:11:38 +02:00
Translation updater bot c2c0736bc8 Localisation updates from https://translatewiki.net.
Change-Id: Id38e445ed4aceeb262aa10ca3a7bc89957532c4c
2015-05-29 22:44:16 +02:00
Translation updater bot ee8c7f328e Localisation updates from https://translatewiki.net.
Change-Id: Ic54584edec2dffaf9cf7ee741dad3599dd8778e0
2015-05-28 22:56:26 +02:00
Translation updater bot 49584ad67f Localisation updates from https://translatewiki.net.
Change-Id: I401f0e6979d762545108c9847c1120e275545ebd
2015-05-27 22:33:41 +02:00
Ed Sanders 20d3526ae6 Use updateMwData when doing a live preview
Change-Id: Iadca47339c7d16034c5715677e0789de286f3ecf
2015-05-27 15:47:48 +01:00
Translation updater bot 7023dc6bb3 Localisation updates from https://translatewiki.net.
Change-Id: Ic49f04f294daf78fca462b703bea9f4f7eb41fb6
2015-05-26 22:29:00 +02:00
Translation updater bot 4b29bc5a4d Localisation updates from https://translatewiki.net.
Change-Id: I5d04a0fbdec99aa8d7e830dd72e011f236247c26
2015-05-25 22:40:54 +02:00
jenkins-bot c500ee8537 Merge "Representation for the red-linked inline images in VE" 2015-05-25 15:28:35 +00:00
suchetag dc2247460c Representation for the red-linked inline images in VE
The red-linked inline images in VE are now identifited as red links and image errors.
They can be changed and thereby be modified just as any other inline image on the editor.

Change-Id: Idb6f6f2da14379fd7db6ca19613dad32fe40023d
2015-05-25 15:18:15 +01:00
ryasmeen@wikimedia.org cb1612b60a [BrowserTest] Fixing the test for general markup
Identifier mismatch.Updated now.

Change-Id: Ibf7b6aea144e2435d2a23e4768481a11cb8a6619
2015-05-25 14:43:56 +02:00
jenkins-bot 8491c363b5 Merge "[BrowserTest] Fixing broken test for Page Options test The test was broken as some identifiers were wrong. Updated it." 2015-05-25 12:00:16 +00:00
Translation updater bot 54872540f2 Localisation updates from https://translatewiki.net.
Change-Id: Idaf1d3bf4140bff7d0c02d8c8c6b4106acb95b5a
2015-05-24 23:10:16 +02:00
ryasmeen@wikimedia.org 058da228dd [BrowserTest] Fixing broken test for Page Options test
The test was broken as some identifiers were wrong. Updated it.

Change-Id: I03541e4ae0ed7e4c121b801a036e49bebe4d5909
2015-05-24 21:30:53 +02:00
ryasmeen@wikimedia.org 0da5989eb7 [BrowserTest] Fixing the broken test for bullets
The test was broken for using wrong identifier in the test. Updated them correctly.

Change-Id: I46a9c4ebaf1b44f0db24f2b64dcd863697011203
2015-05-24 14:30:59 +00:00
Translation updater bot 5e5adeb04c Localisation updates from https://translatewiki.net.
Change-Id: I67abd055973d8acfc38c8960ed27dec253a7964a
2015-05-24 00:20:06 +02:00
Translation updater bot e85e395844 Localisation updates from https://translatewiki.net.
Change-Id: Ib9c5783f1d1d2c9901be91e9a3beacc6561f6cf0
2015-05-21 23:03:56 +02:00
Translation updater bot 0ee7352dc7 Localisation updates from https://translatewiki.net.
Change-Id: I4b5c9cd94019efff9c1aa2b0ab8fcc700db03c7b
2015-05-20 22:20:04 +02:00
Translation updater bot 8373a0376c Localisation updates from https://translatewiki.net.
Change-Id: I01f7e7e95469eb819a248cd47f957f351115094d
2015-05-19 22:37:02 +02:00
jenkins-bot 1b1ddff1a5 Merge "Update VE core submodule to master (3c1f698)" 2015-05-18 22:07:47 +00:00
Translation updater bot 01c2cd6b80 Localisation updates from https://translatewiki.net.
Change-Id: I7c631518037209a20147eb7ade9b7e1154c8e537
2015-05-18 22:24:27 +02:00
Ed Sanders 2f087d9ae7 Update VE core submodule to master (3c1f698)
New changes:
a6144f3 [BREAKING CHANGE] Allow models to specify which extra RDFa types they support

Local changes:
* Use new allowedTypes property in model registry
* For reference nodes, allow 'dc:references'.
* For transclusion nodes, allow any other types.
* For image nodes, allow 'mw:Error'.

Bug: T98999
Change-Id: I7eb2b61eb9336792535e9fd6d5a8dd2d57065f04
2015-05-18 19:42:43 +01:00
Translation updater bot 7df26561ad Localisation updates from https://translatewiki.net.
Change-Id: Ia69f588c779ffb02188f21bc2524f9cab85bb40d
2015-05-17 22:15:36 +02:00
Alex Monk d39e4c3ee9 Make sure reference result menu can wrap
OOUI was effectively overriding this with it's own rule for labels in an option
widget.

Bug: T99267
Change-Id: I82ce2d5ec1a859075d7bf1010ca76cdea9ead1a0
2015-05-17 14:23:45 +01:00
Alex Monk b2319433da Fix tabbing to info/delete buttons in template dialogs
We were selecting the outer <div>s rather than the actual links which you could
interact with via the keyboard.

Bug: T97323
Change-Id: I797739e45f2c0b4a1d39e4b1901bc0836c82f281
2015-05-17 14:03:04 +01:00
Translation updater bot c6ad199561 Localisation updates from https://translatewiki.net.
Change-Id: Ic4d6c59d99a15f648c3a8664b28491a070a3fdd1
2015-05-16 22:01:45 +02:00
jenkins-bot 5a2b1b6aed Merge "Representation of red-linked images in VE" 2015-05-16 16:36:50 +00:00
suchetag de12c761a3 Representation of red-linked images in VE
The red-linked images in VE are now identifited as red links and image errors.
They can be changed and thereby be modified just as any other image on the editor.

Bug: T52788
Change-Id: I9cbb992c34d71b7073157fe276fee04e901845b1
2015-05-16 17:15:51 +01:00
Translation updater bot fd6784375a Localisation updates from https://translatewiki.net.
Change-Id: Iab0929170ba0afb9dc6a5cbbfe66ffc26ebbe2ae
2015-05-15 21:47:30 +02:00
jenkins-bot 2e24426fdf Merge "[BrowserTest] Fix the lists and indentation screenshot scenario" 2015-05-15 13:35:47 +00:00
jenkins-bot f7b6fea4a2 Merge "[BrowserTest] Fix the special character button screenshot" 2015-05-15 13:35:22 +00:00
Amir E. Aharoni 462315f16f [BrowserTest] Fix the lists and indentation screenshot scenario
* The element's class name changed.
* Zooming is removed - it was breaking the test and
  it's not needed anyway.
* Fix another element with the same class.

Change-Id: I46a867619ed49936c3868f6b1b15e773bdb6f6b1
2015-05-15 15:02:34 +03:00
Amir E. Aharoni e471860536 [BrowserTest] Fix the special character button screenshot
The element moved out of the Insert menu to the toolbar.

Change-Id: I7c563af858a37f360bd2e4b4ba2e8a7098bc94e6
2015-05-15 13:56:47 +03:00
Amir E. Aharoni f30f90ace0 [BrowserTest] Fix the text formatting screeshot scenario
The element's class name changed.

Change-Id: I7070c1e06f6639783097b953cc384b12eff2a23b
2015-05-15 13:49:52 +03:00
Translation updater bot 02e6c740ba Localisation updates from https://translatewiki.net.
Change-Id: Ia009d790e8867acfddf28bfeec9114e7e656f7f1
2015-05-14 22:11:16 +02:00
Translation updater bot 6b36fc47e7 Localisation updates from https://translatewiki.net.
Change-Id: I4f2e7bb58dc0238bd5010c52d679268566e1a27e
2015-05-13 22:40:48 +02:00
Translation updater bot 98298282fd Localisation updates from https://translatewiki.net.
Change-Id: I3983d407a2ee27f119345043478ec045439364dd
2015-05-12 22:31:42 +02:00
jenkins-bot da3a5dbfc4 Merge "Improve progress bar" 2015-05-12 12:27:28 +00:00
jenkins-bot 788d0b0047 Merge "Remove 3px gap above toolbar in Monobook" 2015-05-12 12:24:42 +00:00
jenkins-bot c35be097d1 Merge "ve.init.mw.ViewPageTarget: Simplify toolbar save button and inner toolbar code" 2015-05-12 12:19:22 +00:00
Trevor Parscal 4297301948 Close the bottom of Vector tabs in VisualEditor
Change-Id: Ie1a0b45300dbc21fb388ee7fc94e0851d0cd5924
2015-05-12 12:56:30 +01:00
Trevor Parscal 293e032786 Remove 3px gap above toolbar in Monobook
Change-Id: I3ccfc4556d2d19e5caa2a4a21b81fab54ca4f414
2015-05-12 12:56:03 +01:00
Bartosz Dziewoński e459c14442 ve.init.mw.ViewPageTarget: Simplify toolbar save button and inner toolbar code
All this is no longer needed since 121216184718e7ebe22d6ecc8f5af5fe4e202465 in
OOjs UI and started causing issues after bb9c9c4f6a2fca6aed0e671e904e469d57da5f34.

Bug: T98795
Change-Id: I6493d6b52b313aac521aee2b0cff1571ea63bbe5
2015-05-12 13:50:40 +02:00
Translation updater bot d49df79adc Localisation updates from https://translatewiki.net.
Change-Id: I8a7fceb761b65be52d87c6f98c83c69da290bad4
2015-05-11 21:53:43 +02:00
Ed Sanders bf56f56f3e Improve progress bar
* Add a 3rd stage will triggers on API load
* Allow stages to complete in different order (as happens
  on second load)
* Use CSS transitions
* Start slow and speed up using ease-in and progressively
  shorter transitions

Bug: T95137
Change-Id: Ib9090e6c80b7a186bf353c40921d40456d90211a
2015-05-11 13:26:32 +01:00
Translation updater bot c1d0f73e2e Localisation updates from https://translatewiki.net.
Change-Id: Ia80d3d13e3d740ef0cb2b4e7bda5e94d12f6c3b7
2015-05-09 21:54:30 +02:00
Ed Sanders 1962234efd Remove this.$ remnants
Change-Id: Ia32eebd4f6da156209fc0e9cc858e99ea454c262
2015-05-09 11:48:30 +01:00
Bartosz Dziewoński 82ae88a4a0 ve.ui.MWReferenceContextItem: Update context's size after rendering
Bug: T98430
Change-Id: I45eda8387774840020919948e164430038135f63
2015-05-09 01:59:21 +02:00
jenkins-bot f7839b9e8b Merge "Make sure switch to source editing button does not get disabled" 2015-05-08 23:32:42 +00:00
jenkins-bot b33ed74181 Merge "Use new selectItemByData method where possible" 2015-05-08 23:31:13 +00:00
Alex Monk db036ddd8d Make sure switch to source editing button does not get disabled
Was broken by Ief769ba0

Bug: T97646
Change-Id: I43ea85373a6ca427bf6a1c9e01d70b960d93db91
2015-05-09 00:25:19 +01:00
Ed Sanders 9d3d24ac81 Remove MWGeneralReferenceDialog
This was only opened by the Citoid inspector, which now
embeds a MWReferenceSourceSelectWidget.

Change-Id: Ic6fb3f3675de238f606acecc163ceda04ca78fb4
2015-05-08 11:11:33 -07:00
Ed Sanders 431f2abcfd Use new selectItemByData method where possible
Change-Id: I32f213bf2977623a0bde83fb9119fda42a1e9848
2015-05-08 16:15:51 +01:00
jenkins-bot 14f9edc493 Merge "Use new TabSelectWidget in link inspector" 2015-05-08 09:08:07 +00:00
jenkins-bot db741011b8 Merge "Update VE core submodule to master (2c0224d)" 2015-05-08 09:04:46 +00:00
Ed Sanders ec8a813dce Use new TabSelectWidget in link inspector
Don't use the full IndexLayout for now as it doesn't
work easily in variable height situations.

Depends on this feature being preset in MW core.

Bug: T97878
Change-Id: I5d949bf69b0721b288c37c1f12210b0265658eb5
2015-05-08 09:03:24 +00:00
Ed Sanders ff9bf1fcb3 Update VE core submodule to master (2c0224d)
New changes:
68959f2 Localisation updates from https://translatewiki.net.
2c0224d [BREAKING CHANGE] Link widget refactor
f81eefa [BREAKING CHANGE] Rename LinkInspector to LinkAnnotationInspector

Local changes:
Adjust for link inspector refactor

Create separate widgets for internal and external link
annotations. Remove annotation specific logic from link
target input widget.

Change-Id: I054c3fe7ac9c61fbc3302471abd58cab89fed5a4
2015-05-08 09:56:11 +01:00
jenkins-bot b07fe99249 Merge "ve.ui.MWParameterPage: Simplify handling of required parameters a bit" 2015-05-08 04:21:56 +00:00
jenkins-bot 07c85458c5 Merge "mw.Target: Fix API breakage of watchlist preference check" 2015-05-07 23:29:25 +00:00
Translation updater bot 7cb85d8e7c Localisation updates from https://translatewiki.net.
Change-Id: Id4a1efe832f63cc8ebdd4e3050f3a66e14ca77a8
2015-05-07 21:31:17 +02:00
Alex Monk 6c86046bd8 mw.Target: Fix API breakage of watchlist preference check
Bug: T97838
Change-Id: I413c300ad26dd87d9d6a7c6f0032a8165ea7f2c9
2015-05-07 08:40:03 -07:00
Bartosz Dziewoński 5a896f726f ve.ui.MWParameterPage: Simplify handling of required parameters a bit
OOjs UI now implements this behavior with the right configuration.

Change-Id: I7c25508d0e2e59bd013b3ce7aff75fb05f58d9b0
2015-05-07 16:55:18 +02:00
jenkins-bot 9275a0ae15 Merge "Follow-up 5c38995bd9: don't destroy toolbar twice" 2015-05-06 23:24:23 +00:00
Roan Kattouw e644d33a8d Follow-up 5c38995bd9: don't destroy toolbar twice
The toolbar.destroy() call that was added in 5c38995bd9 was
needed to destroy the dummy toolbar when tearing down VE
before a surface had been intialized. But when tearing down
VE after the surface had been initialized (e.g. exiting using
the Read tab), we would do:

* setTimeout in tearDownToolbar()
** Set toolbar height to 0 and wait for transitionend
*** toolbar.destroy() once transition complete
* toolbar.destroy() in cancel()

This meant that we'd listen for a transitionend event
on an unattached element (because once the setTimeout runs,
the toolbar has already been destroyed by the second call),
which of course never fires, so we'd never resolve the
tearDownToolbar deferred and never finish tearing down VE.

Bug: T98388
Change-Id: I504f0cb0bf13643773fc98cb18b7b380cccb2f88
2015-05-06 16:18:45 -07:00
jenkins-bot f1a6e87bc5 Merge "Don't show placeholder references in lists" 2015-05-06 23:17:28 +00:00
Translation updater bot ed9d7a8e08 Localisation updates from https://translatewiki.net.
Change-Id: I5aed29e22daedd8ffa0552b34e60edfd6a93c419
2015-05-06 22:03:28 +02:00
James D. Forrester 38239707b0 jshint: Kill file-level globals and add "moment" to the list
Change-Id: I923ba3490f5fc9b2aaf52d10a163f75dd6401c71
2015-05-06 19:01:27 +00:00
Ed Sanders 9811bc4fd9 Don't show placeholder references in lists
Allow references to be created as placeholders and exclude
them from ReferenceListNodes and the ReferenceSearchWidget.

Bonus: Fix reference numbering when items are skipped (in
list nodes and search widget).

Change-Id: I8dc5146c21f309e89ff4ddd939f7c65a0c358378
2015-05-06 19:15:20 +01:00
Ed Sanders 283047b604 Refactor reference source selection out into a widget
This can be re-used by Citoid.

Bonus: Improve placeholder copy.

Change-Id: I429ce5d7faae56955bcc09a9662d8a36c5098e44
2015-05-06 19:11:35 +01:00
jenkins-bot 873baa22b6 Merge "Revert "Be more selective in application of 0.8em font size"" 2015-05-06 17:33:57 +00:00
Bartosz Dziewoński d008a3bc7c Revert "Be more selective in application of 0.8em font size"
Causes more problems than it fixes.

This reverts commit cab44b55ef.

Bug: T98193
Change-Id: Id40919ceda36a665e23c6f84965a3b979bb33289
2015-05-06 17:08:49 +00:00
jenkins-bot 79fd08b1d6 Merge "Remove bold from result titles so that query highlighting works" 2015-05-06 13:44:50 +00:00
Translation updater bot ddb5aa3691 Localisation updates from https://translatewiki.net.
Change-Id: Icb02aa756fbfe636b6aa9c670185cfe7c31434cc
2015-05-05 22:45:56 +02:00
Ed Sanders d2c096ceb8 Remove bold from result titles so that query highlighting works
Change-Id: I2ee03604ff000bbf9504236b4b3cf1120e1e100c
2015-05-05 19:17:15 +01:00
jenkins-bot b488dbeb8b Merge "Be more selective in application of 0.8em font size" 2015-05-05 17:50:17 +00:00
jenkins-bot b1e426d805 Merge "Convert 'external' links to internal pages pasted into the search field" 2015-05-05 17:47:43 +00:00
Amir E. Aharoni 6c28e1696e Replace "articles" with "pages"
This is the usual convention for consistency and portability.

Change-Id: I2df05ee38d85aa42b79a189bebaa176c2b2c6c4b
2015-05-05 16:28:37 +03:00
jenkins-bot 7d85bc3ae3 Merge "Highlight matching parts of link suggestions" 2015-05-05 10:12:28 +00:00
suchetag 6983fbe3d0 Highlight matching parts of link suggestions
Bug: T93697
Change-Id: I1778dc204e45e0b124e3a171b9cce171a3138a58
2015-05-05 10:08:26 +00:00
jenkins-bot 316d490ad8 Merge "Fix page restoration when Parsoid load fails" 2015-05-05 01:26:57 +00:00
jenkins-bot 1094dc82cc Merge "MWTemplateTitleInputWidget: Add missing local var" 2015-05-05 00:00:45 +00:00
Ed Sanders d921a942b4 MWTemplateTitleInputWidget: Add missing local var
Change-Id: I7faf7610d3d75a4df1fa0f565fb32b08581e44d1
2015-05-04 16:55:02 -07:00
jenkins-bot bb9ed54659 Merge "Make 'Search articles' / 'External links' i18n messages" 2015-05-04 22:25:04 +00:00
Translation updater bot 536ff31288 Localisation updates from https://translatewiki.net.
Change-Id: I9775130c406bfa88fbde903145fe4ab0af70ea0d
2015-05-04 22:28:50 +02:00
jenkins-bot c1b6632a53 Merge "ve.init.mw.ViewPageTarget.js: Fix indentation" 2015-05-04 20:06:07 +00:00
Ed Sanders 4a5cf2062d ve.init.mw.ViewPageTarget.js: Fix indentation
Change-Id: I09c4eac94b36e425cdc77a16fb4b9d30e5b8695d
2015-05-04 20:03:52 +00:00
Translation updater bot 67d8556d70 Localisation updates from https://translatewiki.net.
Change-Id: Ibce9ebba21b1861e4bce59123594ac003b59322a
2015-05-03 21:53:56 +02:00
Ed Sanders 563bb66fc6 Make 'Search articles' / 'External links' i18n messages
Change-Id: I85e13821079c1c04c5f183fc63ba9243ce01a12d
2015-05-03 12:54:33 +01:00
Ed Sanders cab44b55ef Be more selective in application of 0.8em font size
Prevents read-mode elements placed inside the target from
getting scaled down (e.g. firstHeading).

Change-Id: I55ed38e2855c4eb317ec71cebb1842b9b70790b6
2015-05-03 12:05:57 +01:00
Ed Sanders 5c38995bd9 Fix page restoration when Parsoid load fails
Change-Id: I42cd7801af73c97d8fa07a4537c6e1c104e52ac4
2015-05-03 11:51:48 +01:00
Translation updater bot bd112111a5 Localisation updates from https://translatewiki.net.
Change-Id: I83134541db3046f6501b30e4521e673a3bb42bbd
2015-05-02 22:07:36 +02:00
Ed Sanders f95cebd8b1 Divide surface margins by 0.8
Change-Id: Ic9a0b3f4d8e82127649bb5ac100e3cbf42001489
2015-05-01 23:17:35 +01:00
Translation updater bot f698593366 Localisation updates from https://translatewiki.net.
Change-Id: I116109929440b27ab7cd7f89bab42e5b0ff9a7d2
2015-05-01 22:07:53 +02:00
jenkins-bot 0cda56dc15 Merge "ve.ui.MWParameterPage: Remove dead CSS" 2015-05-01 00:47:39 +00:00