wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 11:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
11463 commits 153 branches 1 tag 185 MiB
Commit graph

9102 commits

Author SHA1 Message Date
Roan Kattouw 6322be2e07 Handle API errors when refetching the edit token 
This can happen when the user gets logged out on a private wiki.
We get a badtoken error, so we try to refetch the token, which
itself returns an error. Token refetches didn't have error handling
at all and got the save dialog stuck in the pending state.

We can't offer the user to proceed with a different identity here,
because we encountered an error while trying to figure out what their
current identity is. The best we can do is encourage them to
log back in in a different tab.

Bug: T128934
Change-Id: I17d4452f688ec22631dbd12af223731635004d66
 2016-03-04 18:06:33 -08:00
jenkins-bot 074885d7cf Merge "Follow-up 2c24efae: fix typo in event name for unknown save errors" 2016-03-05 02:01:57 +00:00
Roan Kattouw 84d534997e Follow-up 2c24efae: fix typo in event name for unknown save errors 
This probably means we stopped logging unknown save errors
back in August.

Change-Id: I4a5bac244a469e73643e8a7d978d9212dd838fb0
 2016-03-04 17:31:40 -08:00
Translation updater bot 0d94d8312d Localisation updates from https://translatewiki.net. 
Change-Id: I92baebf577ce098877cff730f2ff8de4974f79b2
 2016-03-04 22:56:47 +01:00
Željko Filipin dc3944726a [BrowserTest] Disable failing language screenshots 
Bug: T119482
Change-Id: I165fcb2ee94430d29e287b80e13a48e05a021f77
 2016-03-04 15:54:13 +01:00
Alex Monk dde45949a3 Try to fix handling of empty document on WTE->VE switch 
Bug: T128635
Change-Id: Iff83e1d71e7186b8da875aa507f9e19e8d9c23ce
 2016-03-04 02:05:41 +00:00
Ed Sanders 67c207a6f5 Use abstract target widget creation 
Change-Id: Ic7e43e80f4f48df99842cee702963d54205e5055
Depends-On: I6a667a641540b347052ea0c645af4e1e59cf333a
 2016-03-03 11:49:44 -08:00
Ed Sanders d64436cc0c Use new surface executeCommand method 
Change-Id: I84c718d9da4b7dd0627ba37d9c29c3a25cc5d73e
Depends-On: Id975ea9da43654cd9991a302b49a9fb32782078e
 2016-03-03 11:49:44 -08:00
Ed Sanders 62d16e5a8a Update VE core submodule to master (ac24b50) 
New changes:
0b7e689 FindAndReplaceDialog: don't use tabindex
17b10a5 Localisation updates from https://translatewiki.net.
a4133e4 [BREAKING CHANGE] Make whitespaceHtmlCharacters a real static property

Local changes:
* MWEntityNode: Fix lookup of whitespaceHtmlCharacters

  Property is now in 'static', and use registry to look up
  TextNode by symbolic name.

Change-Id: Ied8c0c6feb69141c7c53fc4cc790774dee2cb63c
Depends-On: I7537b46a9fd58dfb2bd18dc4ed469aa221b96e86
 2016-03-03 08:13:33 -08:00
Ed Sanders 115bf4b3d2 CategoryWidget: Remove reorder event fix after upstream fix 
Change-Id: I9088c931433b0824f72b4c77d0fd05cb062068f7
Depends-On: I67945db3652b0edb24b490089b8ea5a43f0b29d0
 2016-03-03 15:53:49 +00:00
Željko Filipin 8e0e40d5cc [BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError 
Sauce Labs browsers raise
Selenium::WebDriver::Error::StaleElementReferenceError
if a test tries to use an element but VisualEditor is not loaded.

Bug: T128731
Change-Id: Icb01b4dee256a0270d722492d11dabf0cfc4f8c4
 2016-03-03 14:58:14 +00:00
jenkins-bot 659b9c3576 Merge "[BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages" 2016-03-02 23:33:32 +00:00
Translation updater bot 61cda9824f Localisation updates from https://translatewiki.net. 
Change-Id: Ife76752d154e4b595a570e8c8fefed114362dc9f
 2016-03-02 23:40:57 +01:00
Alex Monk a3f77d9479 Education popup: Also handle clicks on dots 
Bug: T128440
Change-Id: I25728cf3dd3462cb1a13476fe45d7fc3755429dd
 2016-03-02 21:48:05 +00:00
Alex Monk 4ed6fd4010 Change Accept header a bit 
Per post-merge commit on I77af4b58 by Subbu

Bug: T128233
Change-Id: I30c4c1ad5b68e5b8a006d7a6c7bcbaac7e2eb164
 2016-03-02 15:37:37 +00:00
Željko Filipin 301b152ec8 [BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages 
Looks like local browsers raise
Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs)
browsers raise Selenium::WebDriver::Error::UnknownError if a test tries
to use an element but VisualEditor is not loaded.

Bug: T126966
Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
 2016-03-02 13:50:44 +01:00
Alex Monk 21334a0fa8 Keep summary and checkbox selections when swtiching WTE->VE 
Bug: T128529
Change-Id: I8a7deac1c4d9390c1db7d78c3e0a11d927ef127b
 2016-03-02 11:55:50 +00:00
Ed Sanders d94d98ebfe ArticleTarget: Update documentation 
'onReady' no longer exists

Change-Id: I6fbcf619ba471f69380a64ba02994bd6ef0ca246
 2016-03-01 22:03:07 +00:00
jenkins-bot 7d1ddae652 Merge "MWTemplateSpecModel: Use namespace constant" 2016-03-01 21:56:51 +00:00
jenkins-bot 1619ca17aa Merge "MWTemplatePage: Don't assume template is the template namespace" 2016-03-01 21:51:19 +00:00
Ed Sanders 1e800f2fdf MWTemplateSpecModel: Use namespace constant 
Change-Id: I4404ee726550ca9aa9322720736f6f3778278df7
 2016-03-01 21:41:10 +00:00
Ed Sanders 5b17cbca67 MWTemplatePage: Don't assume template is the template namespace 
Content can be transcluded from any namespace using '{{:'.

Bug: T128333
Change-Id: Ifa076960958d1e72f302c5bfd5d896427a0e721f
 2016-03-01 13:40:38 -08:00
Translation updater bot eceb548e6c Localisation updates from https://translatewiki.net. 
Change-Id: Id1453f111870ee703f552fa407dab76b19d786f5
 2016-03-01 22:04:45 +01:00
jenkins-bot a0caedc6d9 Merge "API: Send Accept: header to RESTbase" 2016-03-01 03:24:45 +00:00
Alex Monk 2f135e9590 API: Send Accept: header to RESTbase 
Bug: T128233
Change-Id: I77af4b58e5469a898063a3f838802e4f5769514b
 2016-03-01 01:14:02 +00:00
Alex Monk d46c5e9f91 Fix WTE->VE switching in prefer-wt SET mode 
Bug: T128402
Change-Id: I56af672f2334214f048a4bbfe2f9fab891832792
 2016-02-29 23:46:11 +00:00
David Lynch 7486f74c6f MWMediaDialog: Only cache relevant information 
Trim the cached image data from the media dialog down so that it only caches
the same information that would have been fetched for a non-uploaded image.
Consistency!

Bug: T126081
Change-Id: I0f057c111b66f29c6360e27f97256384f5320b75
 2016-02-29 10:16:34 -06:00
jenkins-bot e39d8a744b Merge "Show welcome dialog on mobile too" 2016-02-29 03:02:03 +00:00
jenkins-bot 517bb92a79 Merge "Give a useful message in the temporary blank edit screen" 2016-02-29 02:56:12 +00:00
Translation updater bot 7546362fa9 Localisation updates from https://translatewiki.net. 
Change-Id: I7bade8021975fc1c3e2426211e6805a913f07891
 2016-02-28 22:00:32 +01:00
jenkins-bot 70a9cee5f3 Merge "Update VE core submodule to master (0371bbe)" 2016-02-28 01:12:55 +00:00
jenkins-bot 03448253b3 Merge "Revert "Compress PNGs with zopflipng"" 2016-02-28 00:29:30 +00:00
Legoktm 7ebac23f86 Revert "Compress PNGs with zopflipng" 
This reverts commit cbb7831938.

Change-Id: Ide4880a4a980847bb14cc5880662a4d2142581b8
 2016-02-28 00:07:50 +00:00
Alex Monk ade0862db1 Give a useful message in the temporary blank edit screen 
Bug: T128028
Change-Id: Ife0a9de96965a9848f362696fc403708fd344825
 2016-02-27 21:42:10 +00:00
Translation updater bot e7ad07513a Localisation updates from https://translatewiki.net. 
Change-Id: I88bf6d9f401bfbeab5e256a3b6169541ce8ac0eb
 2016-02-27 21:59:35 +01:00
James D. Forrester ab4d3e956b Update VE core submodule to master (0371bbe) 
New changes:
0371bbe [BREAKING CHANGE] Refine VisualEditorSupportCheck call and document pattern

Local changes: Use new VisualEditorSupportCheck pattern

Change-Id: I7dc0c360b54a93397180b18d88d72532e439da5c
 2016-02-26 12:26:56 -08:00
Ed Sanders 34d607d546 EducationPopupTool: Use vendor prefixes for animation 
Bug: T128133
Change-Id: Ic061b50e1ed68ea35ac0ccbefbcb5252f917d35f
 2016-02-26 15:34:06 +00:00
Ed Sanders 8f028813e5 CategoryWidget: Update to work with new DraggableGroupElement 
Change-Id: Iefac99dba0e6b8ed3eaaa1d5f1d92e402e3cf2db
 2016-02-25 16:07:50 -08:00
Alex Monk ced27f348f Show welcome dialog on mobile too 
Bug: T112599
Change-Id: Ie04aab468c80dabc84e1386e7529138e1101450e
 2016-02-25 22:03:00 +00:00
Translation updater bot cef228ec1d Localisation updates from https://translatewiki.net. 
Change-Id: I8a8e0b9b879d18d8011821e49dc8c23624652a38
 2016-02-25 22:22:09 +01:00
jenkins-bot 7bef4c9a20 Merge "Warn for empty summary when edit section used" 2016-02-25 18:56:57 +00:00
Translation updater bot 48a2404923 Localisation updates from https://translatewiki.net. 
Change-Id: I0a5b177af81d7f05a86b18f5089a76545b2b8860
 2016-02-24 22:03:55 +01:00
jenkins-bot 222a5361ba Merge "[BrowserTest] Fix ve.init is undefined error messages in Selenium tests" 2016-02-24 17:56:57 +00:00
jenkins-bot 79d8849b49 Merge "Make surface measurable while activating" 2016-02-24 01:33:47 +00:00
Translation updater bot 4fdef459ae Localisation updates from https://translatewiki.net. 
Change-Id: I32522ae9e647712d6256174fade8e0314808b739
 2016-02-23 22:35:50 +01:00
Ed Sanders 229a088f34 Make surface measurable while activating 
If the surface is display:none then $.width always
returns 0, which breaks features like FocusableNode's
invisible icon.

Bug: T127319
Change-Id: Ib157ffaeb56fca2bdc26868d830c4bf8feafa2a8
 2016-02-23 17:05:09 +00:00
wctaiwan 5da37932a2 Warn for empty summary when edit section used 
Warn the user about an empty edit summary when the "edit section"
link is used to trigger VE.

Re-does Ic7b456ca a different way.

Bug: T114857
Change-Id: I319c9c5bed47140a81eb409d490c9f82b89a49fe
 2016-02-23 00:34:12 +00:00
jenkins-bot 74b2489276 Merge "Link to file description pages in media dialog" 2016-02-22 21:07:43 +00:00
Translation updater bot ed26366723 Localisation updates from https://translatewiki.net. 
Change-Id: Ib209a100469a77418cc66174d69bc6955101a7a3
 2016-02-22 21:42:37 +01:00
jenkins-bot 0b8f6b576d Merge "Transclusion dialog: Simplify example/default value labels" 2016-02-22 15:48:07 +00:00
Ed Sanders 816fca78e8 Transclusion dialog: Simplify example/default value labels 
'Value' comes across as a bit technical. 'e.g.' is more common
for 'example value'. Truncate 'Default value:' to just 'Default:'.

Change-Id: Ie03fb64a01846071ccdcb673439fc568b9d0de78
 2016-02-22 15:40:19 +00:00
jenkins-bot 705fc76e62 Merge "MediaDialog: Use CC logo from upstream (ooui-icons-wikimedia)" 2016-02-22 06:34:05 +00:00
jenkins-bot 0f9a09be73 Merge "Make platform language functions actually work" 2016-02-22 06:34:02 +00:00
Ed Sanders 083182debd Make platform language functions actually work 
Previously arguments were not getting passed through.

Change-Id: I19fbd6f8a7f32163a85dda01fa46ac56a8c78cf8
 2016-02-22 00:05:05 +00:00
Translation updater bot 56e29facc9 Localisation updates from https://translatewiki.net. 
Change-Id: I8f4817ee86f71cf8233069b48b5dfd842d0fadff
 2016-02-21 22:30:14 +01:00
Ed Sanders deb676e73d MediaDialog: Use CC logo from upstream (ooui-icons-wikimedia) 
Change-Id: I4fabf5f8d87b9b21623883203b9d6965a0ff33a0
 2016-02-21 18:20:30 +00:00
Alex Monk ca5cab52af Link to file description pages in media dialog 
Bug: T125227
Change-Id: I243f5479ab27ab098d41db08ff4a53195d382577
 2016-02-21 03:45:37 +00:00
Ori Livneh cbb7831938 Compress PNGs with zopflipng 
Zopfli is the most efficient DEFLATE compression algorithm, trading run-time
performance for file sizes that are typically 3-8% smaller than those produced
by zlib with the maximum compression setting. Its output is Deflate-compatible,
so no specialized decoder is needed.

This change was created by running zopflipng against all the PNG files in this
repository. The exact invocation was:

  git ls-files --exclude-per-directory=.gitignore -- '*.png' \|
    parallel zopflipng -m -y {} {} \;

Files which zopflipng was not able to compress more efficiently were left unmodified.

Bug: T127608
Change-Id: Id5807b1ec56320b3474878290dd05600c1e389d5
 2016-02-21 00:14:58 +00:00
Translation updater bot 3fd583d1d7 Localisation updates from https://translatewiki.net. 
Change-Id: I035d1386ec12fdcd6152cf25a029d9c133c7c1f9
 2016-02-20 22:25:46 +01:00
Translation updater bot d300f6a1ff Localisation updates from https://translatewiki.net. 
Change-Id: I826fa20c2850c5711e81863104d39453daaa40b3
 2016-02-19 22:12:30 +01:00
jenkins-bot 30e6acfff2 Merge "MWMetaDialog: Fix setup of pages" 2016-02-19 19:52:55 +00:00
Ed Sanders 15a47665c8 Meta dialog: Use window action to open windows 
Because abstraction.

Change-Id: I9811db4380c6cf37a73a76b97c8439f94723c5a6
 2016-02-19 17:37:42 +00:00
Translation updater bot acc2347eee Localisation updates from https://translatewiki.net. 
Change-Id: I7dae6beab2b97fefffa0bdc72766e553da7a4c75
 2016-02-18 22:18:44 +01:00
James D. Forrester 6e6ac1656f MWPopupTool: Update Phabricator URL broken by upgrade 
Change-Id: I17fc6178729e246643e999e622b84e34fc7959b3
 2016-02-18 11:24:00 -08:00
Ed Sanders b70eb51491 MWMetaDialog: Fix setup of pages 
Only call setup in ready process, as setup includes setting
focus. Defer fitInput call to category widget until transition
is finished so measurements are correct.

Change-Id: I49a30402cf58e36f16316e3ab04fa3349d19954e
 2016-02-18 17:14:45 +00:00
Ed Sanders 704ec7ad3f MWCategoryWidget: Improve caching 
For every title request, store an entry in noramlizedTitle to
avoid ever making an API request for that category again.

This prevents API requests from being fired every time a
category was moved, which in turn prevents the list from
flickering as it waits for the API request to resolve.

Also normalise the spelling of normalize to en-US/en-GB-oxendict

Bug: T127317
Change-Id: Ie26d9d60fb83981c45ff27199e38ae98e5560a28
 2016-02-18 17:14:33 +00:00
Željko Filipin 60a08f925c [BrowserTest] Fix ve.init is undefined error messages in Selenium tests 
All scenarios that are passing are enabled to run in Jenkins.
(The commit increases the number of passing scenarios from 2 to 18.)

Bug: T126966
Change-Id: I9789ca42717133120197c4625bb8dad4ea496aa8
 2016-02-18 15:42:05 +01:00
Ed Sanders 7eeb136d94 MWCategoryWidget: Use namespace constants from config 
Change-Id: I63661ce49dbb0fac62cb7dbd65c466cfdd6e57b0
 2016-02-18 11:36:31 +00:00
James D. Forrester cebaacb546 Update VE core submodule to master (cdfd84e) 
New changes:
c02ea46 Clarify documentation of directionality methods
43c9b6f Move initialisation browser support checking from downstream
c89be66 Localisation updates from https://translatewiki.net.
5fb7907 Follow-up c89be66: Fix build for added language 'nan'
fc74fab dm.ElementLinearData.compareElements: Add a few missed test cases

Local changes:
Use initialisation browser support checking from upstream

Depends-On: I27a8e7b4376647f01cee648de987dc3ca6a060d5
Change-Id: I3fc79422ee5e487cf5fae3929fe492f21cd2840a
 2016-02-17 20:04:16 -08:00
Translation updater bot dabeb4218d Localisation updates from https://translatewiki.net. 
Change-Id: Iaabe8dd045b2670aeb9fc0164fcb30f682f73b6c
 2016-02-17 22:52:14 +01:00
Alex Monk 83d8a7d9bb Don't remove .ve-activated after successfully activating 
hideLoading always gets called after activating, not just failing

Follows-up: I13058ae1

Bug: T127184
Change-Id: I47d1892feacbfcf832aa32f689f173601b76c4ba
 2016-02-17 15:36:18 +00:00
Translation updater bot 3ec98ab32d Localisation updates from https://translatewiki.net. 
Change-Id: I18bd9573f32007ef6a112b035d0bea503d4c581b
 2016-02-16 23:13:41 +01:00
jenkins-bot 88c5316f22 Merge "Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit" 2016-02-16 16:56:15 +00:00
Translation updater bot 6c9b6f0fd7 Localisation updates from https://translatewiki.net. 
Change-Id: I2ac29726abb9a68893926d5ab1e06985b5a81cf9
 2016-02-15 21:42:28 +01:00
Željko Filipin 966f2f7bbb [BrowserTest] Jenkins runs only passing Cucumber scenarios 
To get at least some Cucumber scenarios running in Jenkins, disable all
of them that are failing and run only ones that are passing.

The next step will be to fix failing scenarios.

Bug: T94162
Change-Id: Id0338c1d6b86d6b45220c5c0802074be397fb607
 2016-02-15 13:18:19 +00:00
Translation updater bot db852aff65 Localisation updates from https://translatewiki.net. 
Change-Id: I3e66b91d4c39d676e167e5d0cfdc914e44c51fa4
 2016-02-14 21:31:45 +01:00
Translation updater bot 747a90ada2 Localisation updates from https://translatewiki.net. 
Change-Id: If10088f3fc527750ea96bd73d55e8c412d5c1c66
 2016-02-13 23:02:29 +01:00
Alex Monk 9a1c0762cb Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit 
Bug: T125998
Change-Id: I2982f6e5f26086a1175b9fc8c3039a2143a44659
 2016-02-13 02:56:01 +00:00
Alex Monk 1c1d018bc7 Unbreak VE 
Follow-up to I13058ae1

Change-Id: Icb30f87746bea3911379fca9766877a36e8b5975
 2016-02-13 00:58:42 +00:00
Translation updater bot 685bacc990 Localisation updates from https://translatewiki.net. 
Change-Id: Ibd9a19ca100c3c0d392ec40095601db780d29103
 2016-02-12 22:12:14 +01:00
jenkins-bot bcae181cec Merge "Try to make MW->VE switching failures break less things" 2016-02-12 17:29:29 +00:00
Translation updater bot 40bbaa9c71 Localisation updates from https://translatewiki.net. 
Change-Id: Ia32d187a8afac039d4d2fb71a233fc25e0f87039
 2016-02-11 21:41:11 +01:00
Alex Monk 4a288a5866 Try to make MW->VE switching failures break less things 
* Try to hide loading bar on failure
* Don't set wgAction back to 'view' if we're dropping the user back to the
  wikitext editor

Bug: T125580
Change-Id: I13058ae131a1dda3b172e78d9b143d70831c47f1
 2016-02-11 02:39:06 +00:00
Ed Sanders af8e23ec6e Remove code for varying MWLinkInspectorTool title 
The title is visibly varied in the context menu separately, and
we don't usually change the link tool's title - so this is just
a performance drain (updateState happens a lot).

Change-Id: I9cf2aa509a6aac3a2914fa52167cb4463843cd72
 2016-02-11 02:22:16 +00:00
Translation updater bot 35cf5524b3 Localisation updates from https://translatewiki.net. 
Change-Id: Ide3b91bb90a8fd3c566bd657a13997211d8a345c
 2016-02-10 21:11:44 +01:00
jenkins-bot 0611527d77 Merge "Remove translations of messages since moved to Cite/Citoid" 2016-02-10 08:08:51 +00:00
jenkins-bot 4a751524c4 Merge "Edit mode switch: Show popup next to VE switch button" 2016-02-10 01:51:57 +00:00
Ed Sanders 80124c88a6 Edit mode switch: Show popup next to VE switch button 
Only show if the user came from VE.

Change-Id: Ic362ba534d135fca5516c8ba401f6b2a22886ff1
 2016-02-10 01:36:32 +00:00
Alex Monk 863a2c2974 Don't try to tell the server to set preferences to their current values 
It's rather pointless.

Change-Id: I8065af1d61108ce843c0afd2eaa0f1f9b85b6998
 2016-02-10 01:04:47 +00:00
Ed Sanders e073a431fc Remove translations of messages since moved to Cite/Citoid 
Change-Id: I692f03b374ec28ec6d81aab2d2d6fcd7705cedc5
 2016-02-10 00:39:18 +00:00
Translation updater bot 829b2cd430 Localisation updates from https://translatewiki.net. 
Change-Id: I28e88ed6e5da7567693ee2833e501696251deecd
 2016-02-09 21:42:50 +01:00
jenkins-bot d5f6c220d3 Merge "Follow-up I7e1edcf05c: Remove MonoBook z-index hack" 2016-02-09 14:28:16 +00:00
jenkins-bot 1844af1588 Merge "ve.init.mw.trackSubscriber: Sample at 6.25%" 2016-02-09 01:06:23 +00:00
James D. Forrester a1db489d95 ve.init.mw.trackSubscriber: Sample at 6.25% 
Bug: T125598
Change-Id: I1915a6456ba5dfc10e4a52df24cee2e68b27e526
 2016-02-08 13:22:33 -08:00
Translation updater bot 047517fa22 Localisation updates from https://translatewiki.net. 
Change-Id: I475a76215ab50328eb2c65d68b2c4be2a5afd6e2
 2016-02-08 22:17:32 +01:00
jenkins-bot e5eb83ff8b Merge "build: Bump various devDeps to latest and make pass" 2016-02-08 18:18:03 +00:00
Ed Sanders 25be46a57d Fix transclusion node cloneElement method 
* Override the static cloneElement. getClonedElement shouldn't
  be overridden as doing so misses static invocations.
* Apply the same fix to extension nodes
* Fix DOM loop to reference clone.originalDomElements[ i ]

Logically depends on Id8024c171c to work.

Bug: T126169
Bug: T126114
Change-Id: Icf4d3115db5b12b97a6c805ff3d0b71d9e88b804
 2016-02-08 15:29:19 +00:00
jenkins-bot a996356e12 Merge "MWImageModel: Use clearDefaultDimensions" 2016-02-08 12:52:10 +00:00
Ed Sanders cfe21d317d MWImageModel: Use clearDefaultDimensions 
setDefaultDimensions( {} ) is a no-op.

Bug: T126078
Change-Id: I1ef7cae04574e2561d21d4071d19a0067d81b263
 2016-02-08 12:37:26 +00:00
James D. Forrester e6e492efc6 build: Bump various devDeps to latest and make pass 
* grunt-contrib-jshint: 0.11.3 -> 0.12.0
  This version of the linter cleans up a number of options. 'es5' is now assumed to be
  true by default, and replaced as 'esversion'; 'latedef' is extended to also cover
  functions' defintions, disabled for us for now; 'futurehostile' is introduced to aid
  future-incompatible names for ES6+ support.

  I adjusted ve.init.mw.DesktopArticleTarget.init.js based on this, as this file is
  meant to be loaded by all JS-capable clients to determine if it is (amongst other
  things) capable of ES5, so now we assert ES3 compatibility via jshint.

* grunt-jscs: 2.5.0 -> 2.7.0
  Minor version bump that doesn't affect us.

* grunt-jsonlint: 1.0.6 -> 1.0.7
  Trivial version bump that doesn't affect us.

Change-Id: Ieb7b6748b0cecf275cfc284fc66617189372461f
 2016-02-07 19:41:21 -08:00
jenkins-bot 2b01e43777 Merge "DesktopTarget: Move generic VE desktop styles into a separate module" 2016-02-08 01:59:56 +00:00
Ed Sanders 739f924e98 Follow-up I7e1edcf05c: Remove MonoBook z-index hack 
The cited reasons were that the the logo and search bar
have a z-index of 3, but that doesn't matter as they are
nested in other elements with z-indexes.

Change-Id: I7ff279efe7c01ba1ffb1fa0d460d59a493ccc47a
 2016-02-07 17:40:50 -08:00
Ed Sanders c51cef07b9 DesktopTarget: Move generic VE desktop styles into a separate module 
Here they can be re-used by other VE desktop targets,e.g. Flow.

Change-Id: I18431ff73fc1c6ab5639a579e85b0f0cc48cb9ce
 2016-02-07 17:39:57 -08:00
Translation updater bot 0138f6a71f Localisation updates from https://translatewiki.net. 
Change-Id: Ia7c748204f03aa2be7f403846118753c5f174669
 2016-02-07 22:22:53 +01:00
jenkins-bot 16c498fa97 Merge "DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface" 2016-02-07 10:30:06 +00:00
Ed Sanders efd41fbc74 Remove global overlay hack now fixed in Vector 
Change-Id: Ic5cfb7ae4d244799be56e12b4b0a44b6ddd00303
Depends-On: I5ebb4e59e3714dfaa3d755ecf6285009efe7b62a
 2016-02-07 03:26:02 +00:00
Ed Sanders 9bf010c33c DesktopArticleTarget: Cleanup styles 
* Use more specific ve-init-mw-desktopArticleTarget class
* Add comments and reorder in places

Change-Id: Ic9291d3e50304fe3a0efa7ace1ce93c7fba91d98
 2016-02-06 19:26:06 -08:00
Alex Monk 138fafbbb9 DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface 
So the normal logic is used to close other windows etc.

Bug: T125479
Change-Id: Iee9ef7484de745f3adced28cdbcc87a0c2b597f5
 2016-02-06 02:02:39 +00:00
jenkins-bot e0de4c4447 Merge "Remove all Extension:Cite code, now moved there" 2016-02-05 22:17:08 +00:00
jenkins-bot 5a360f4cbb Merge "Remove mwReference tests, moved to Cite extension" 2016-02-05 22:16:24 +00:00
James D. Forrester 1e0486a679 Remove all Extension:Cite code, now moved there 
Depends-on: I39936ed83d5a60471a0a75da753f498e80aef234
Depends-on: Ifd853bf9f901065798bd0063aeaa786a3761aa71
Depends-on: I32c93c5118eafe5f071252290c58d3de8dacc81a
Change-Id: Iba0f25b3ebe4e5e63377da57afb760d6980f9907
 2016-02-05 21:36:56 +00:00
Ed Sanders 094555cb3c Remove mwReference tests, moved to Cite extension 
Change-Id: I07a2bf45117c2d14c7b00875c0a710e20980a23a
 2016-02-05 21:36:56 +00:00
Translation updater bot bd848ac4f1 Localisation updates from https://translatewiki.net. 
Change-Id: Ic65af97f6c29c1e0c47317997b18ab064f80a2f5
 2016-02-05 21:54:43 +01:00
Translation updater bot 7c07b2706b Localisation updates from https://translatewiki.net. 
Change-Id: Ibd8991424c15ff9d6700c5103c75aff17aa452d9
 2016-02-04 22:18:02 +01:00
Ed Sanders 5864a62134 Default extensions to not use the 'invisible icon' 
Bug: T125767
Change-Id: I58c58080382974a887ebc52c1ac80cb5970db8c7
 2016-02-04 19:38:16 +00:00
Translation updater bot 622ca082ca Localisation updates from https://translatewiki.net. 
Change-Id: I29d93111a508e8af12752b6b93dc13d106f01d5f
 2016-02-03 23:09:41 +01:00
Translation updater bot 0acd4160f4 Localisation updates from https://translatewiki.net. 
Change-Id: Id1d12847d0c09993453c889af16266b9bac9d9ee
 2016-02-02 21:33:11 +01:00
jenkins-bot 804ab26fb2 Merge "Check xhr.responseText is set before trying to send it to $.byteLength" 2016-02-02 19:08:08 +00:00
Alex Monk 9808d04bfe Check xhr.responseText is set before trying to send it to $.byteLength 
Bug: T125399
Change-Id: I09881fe8b6db7d95e32732129d043c4a13fa7a9a
 2016-02-02 18:52:56 +00:00
Ed Sanders 98bc5daba1 Use new iconWhenInvisible feature in Transclusion/Extenion nodes 
Change-Id: Iba55676c06a1cd625187c38c1ae0c9c20b065827
Depends-On: I127bb5d34850cdc545ea3c05d0fc41a8ae1c6dea
 2016-02-02 18:07:13 +00:00
Translation updater bot 9ec0705a2b Localisation updates from https://translatewiki.net. 
Change-Id: If02911bde5c9cdbaeeaf52a45f4746b1b61b7d16
 2016-02-01 21:56:13 +01:00
Ed Sanders db5ed236dd Add controls for wikitable and sortable to table dialog 
Bug: T95189
Depends-On: Ife3f3505b845db28dd29a07e9be1533c39726ce1
Change-Id: I1672d8cd2e138df1fad19dcfd948700942e87f2c
 2016-02-01 10:58:42 -08:00
Ed Sanders 74358498da Update VE core submodule to master (70ff8cc) 
New changes:
242ab45 DesktopContext: Float the context when it goes beyond the viewport
405c44d Rename TableContext to TableLineContext
6c564be Sort messages alphabetically
70ff8cc Introduce table and table cell context

Change-Id: I4357162bc192c90f99ca0aec12eb67bf848e5504
 2016-02-01 10:51:26 -08:00
Ed Sanders 5e296a959b Sort messages alphabetically 
Change-Id: I45b440b1b020ea79ab4c1eba78effb526c41ddc4
 2016-02-01 17:36:43 +00:00
Translation updater bot 122d76bfbe Localisation updates from https://translatewiki.net. 
Change-Id: Ib037f762e584c8b6bc153a469057b362e31393fc
 2016-01-31 21:42:24 +01:00
Translation updater bot 1b33f7b912 Localisation updates from https://translatewiki.net. 
Change-Id: I499a7c36f46bed65f06c881de3df9fdf53e20036
 2016-01-30 22:50:35 +01:00
Alex Monk 8cc034b9af Run VE->WTE modification checks regardless of how the user got into VE 
I think this fixes a bug similar to the one described in the bug below.

Bug: T124708
Change-Id: I61558227315bec36b71dac281b8da311a3d6bb1a
 2016-01-30 03:06:46 +00:00
Translation updater bot de5f372ac5 Localisation updates from https://translatewiki.net. 
Change-Id: Idfb5e5fdd92cae124b428c768fd89baa6239541c
 2016-01-29 22:43:50 +01:00
Ed Sanders 0ed45dbf61 MWTable: use new sanitization method 
This prevents tables from getting sanitized even on
VE to VE copy. Also by calling ClassAttributeNode sanitize
extra CSS classes are removed.

Bug: T97462
Bug: T125220
Depends-On: Ia3ce386b2a03bc227818b10423bca72c736c0656
Change-Id: Ifd91e00b40665b446bbdcdf8859d2bb641bc0e67
 2016-01-29 10:29:19 -08:00
jenkins-bot 66b0ff5111 Merge "ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl" 2016-01-29 17:00:38 +00:00
Translation updater bot 77a11811fb Localisation updates from https://translatewiki.net. 
Change-Id: If88cee4c9c766aabdccc4d996d48c0151e5611bb
 2016-01-28 21:11:06 +01:00
Bartosz Dziewoński fb54d03a59 ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl 
Change-Id: Iae61d13a6c776c86bcec6744a2153b14c07722e9
 2016-01-28 19:02:38 +01:00
jenkins-bot e4e7fce00e Merge "Create a more neutral warning message" 2016-01-28 07:57:33 +00:00
Justin Du 854f0a3692 Create a more neutral warning message 
Change was made because editing mode is not always left to go to view mode,
but for example also because of clicking on "History".

Bug: T121754
Change-Id: Ibc1ba697081e60b8a797f5ea1b814a320ba812c3
 2016-01-28 07:29:09 +00:00
Translation updater bot e181ca806b Localisation updates from https://translatewiki.net. 
Change-Id: I694abc3d49df4ed6b580a10bdc37ba24fc288ac0
 2016-01-27 21:46:32 +01:00
jenkins-bot f78dd8ad72 Merge "MWWelcomeDialog: Let the user switch editors" 2016-01-27 00:20:10 +00:00
James D. Forrester d8769edd01 MWWelcomeDialog: Let the user switch editors 
Change-Id: If88942d866278f3012dae7972d464a3d2a6a4f82
 2016-01-27 00:14:07 +00:00
jenkins-bot fc43d61ec5 Merge "MWTargetWidget: Add missing indent commands to blacklists" 2016-01-26 23:53:51 +00:00
Ed Sanders abb094babd MWTargetWidget: Add missing indent commands to blacklists 
Bug: T124619
Change-Id: If2a5d98673db6e2d29fe49f1e7f5307437ba3866
 2016-01-26 23:46:12 +00:00
James D. Forrester 2c76dc5b50 MWEditingTabDialog: Use 'small' size 
Change-Id: Icb30d4fbea21653cf2fb6c782a4314be97a3e0a2
 2016-01-26 14:51:55 -08:00
jenkins-bot 75b0a8de63 Merge "Don't try to load VE over the top of the wikitext editor we just switched to" 2016-01-26 17:01:24 +00:00
Alex Monk 589437a772 Don't try to load VE over the top of the wikitext editor we just switched to 
(if we discarded changes)

Bug: T124316
Change-Id: Ic5e6ee8f4b6e75c3ae877021bcb29733b881e6d2
 2016-01-26 16:49:50 +00:00
Alex Monk d7183d7e64 Check user permissions for viewsource before loading VE on-load on action=edit/submit etc. 
Clicking 'View source' should probably not cause VE to load

Bug: T124650
Change-Id: I236de38b0f90f1aaa5d04b57cb7759e5951baf2b
 2016-01-26 16:47:26 +00:00
Alex Monk bfa15c44a5 Check user preferences before loading VE on-load on action=edit/submit etc. 
Bug: T124743
Change-Id: I2e8a19014464a2b7fb76de08676e7cb808e06956
 2016-01-26 02:48:27 +00:00
Translation updater bot 71c0473094 Localisation updates from https://translatewiki.net. 
Change-Id: I159863f04ee8af735dde305b24d8f5cd0a5c8b2b
 2016-01-25 22:33:02 +01:00
jenkins-bot 6666bfcaea Merge "MWTableNode: Mixin ve.ce.ClassAttributeNode" 2016-01-25 20:54:15 +00:00
Ed Sanders ba0b084813 MWTableNode: Mixin ve.ce.ClassAttributeNode 
The DM side already had the mixin, the CE side was still using custom
logic that has since been moved to ce.ClassAttributeNode.

This fixes the issue of tables not getting the wikitable class in VE
as it was only applied on attribute change previously, which never happened.

Change-Id: I197347762fc9228034f7664484539e5888722bcf
 2016-01-25 16:35:49 +00:00
Translation updater bot 8e5a9e71a9 Localisation updates from https://translatewiki.net. 
Change-Id: I401186574b88f3c5c810644799b55f2af5740f8c
 2016-01-24 21:22:34 +01:00
Translation updater bot d246540ccf Localisation updates from https://translatewiki.net. 
Change-Id: Ie90b5f4eb9a6303d4374b99c98c0dfeb8e595fbc
 2016-01-23 22:30:32 +01:00
jenkins-bot d29524c8b3 Merge "When loading VE from action=edit/submit, replace the title shown" 2016-01-22 20:43:02 +00:00
Alex Monk 38180b5d4d When loading VE from action=edit/submit, replace the title shown 
Bug: T117643
Change-Id: Ice21389d02ea10adc668c5b0a64ba2b0b9cf5744
 2016-01-22 20:27:01 +00:00
Ed Sanders b66aa990ba Follow-up I9714cf3: Add tests for wikitable paste 
Bug: T85577
Change-Id: I8e2893c9a6f80fafe6cae142e4f50ffbe6d550ac
 2016-01-22 20:13:26 +00:00
jenkins-bot e6c61052a0 Merge "MWTableNode: Apply wikitable class to pasted tables" 2016-01-22 19:10:41 +00:00
Ed Sanders bf50e2a570 MWTableNode: Apply wikitable class to pasted tables 
Bug: T85577
Change-Id: I9714cf3e8ccc165f91af939481c845c3ec9c5f6b
 2016-01-22 18:43:47 +00:00
Thalia 16330ac05d Add method for setting minimum number of rows in Ace editor widget 
Bug: T123891
Change-Id: Ia2e094071f385628449f1935f0250cbeb75196f0
 2016-01-22 17:05:35 +00:00
Translation updater bot b382eced8c Localisation updates from https://translatewiki.net. 
Change-Id: Idce091710bdb8936a362df1ce2f000b792b1b286
 2016-01-21 21:56:24 +01:00
Translation updater bot 27261322b4 Localisation updates from https://translatewiki.net. 
Change-Id: I6f9e970a0cb80e33849c67d1a850ce019cdcd76e
 2016-01-20 21:09:24 +01:00
jenkins-bot 3bc62ba61d Merge "SaveDialog: Fix alignment of checkboxes" 2016-01-20 18:36:46 +00:00
Translation updater bot 5b95d6c1e6 Localisation updates from https://translatewiki.net. 
Change-Id: I5b3ed86498fcc81cb448d056d32b53cb9a15a579
 2016-01-19 21:22:21 +01:00
Ed Sanders 74e4450c92 SaveDialog: Fix alignment of checkboxes 
Change-Id: Ia7718e7cebe7c533a76533dc82bcf93f8da49d15
 2016-01-19 16:40:32 +00:00
jenkins-bot ee70cc5c44 Merge "Single Edit Tab: simplify logic; make 'prefer-wt' just disabled" 2016-01-18 21:28:26 +00:00
Translation updater bot 9b0ba61924 Localisation updates from https://translatewiki.net. 
Change-Id: I45ba38e70875a2e7783144aa0756f4bc8989c835
 2016-01-18 21:38:20 +01:00
James D. Forrester aa08d34318 Single Edit Tab: simplify logic; make 'prefer-wt' just disabled 
Change-Id: I090375933656f29636c355c4d2ce358dd7f7f074
 2016-01-18 11:23:59 -08:00
James D. Forrester 68ea08cd5e Drop support for adding prefix/appendix labels to edit tabs/links 
Depends-On: I264599a1c4f60b37a46d49c808cf271ba0a8f882
Change-Id: Icebc378f5c00aac57ad361f8ba85da93b8178650
 2016-01-18 03:06:33 +00:00
Translation updater bot f0b2ce2ded Localisation updates from https://translatewiki.net. 
Change-Id: If3cb31818a635b6f5b4ac4796fced777f5517dd0
 2016-01-17 22:35:39 +01:00
Translation updater bot 81a33e1ddc Localisation updates from https://translatewiki.net. 
Change-Id: If2e5f3a07d289d3575ada8cc712b80ed11e2f532
 2016-01-16 21:59:41 +01:00
Translation updater bot 5a8b1c294e Localisation updates from https://translatewiki.net. 
Change-Id: I1653aca5124b19dbd879d82196ec381070ccce13
 2016-01-14 22:26:26 +01:00
Translation updater bot 6606c25902 Localisation updates from https://translatewiki.net. 
Change-Id: I913124a4a85545e9abc179a225ec3ee5746bda11
 2016-01-13 23:32:14 +01:00
Translation updater bot cec85b9e3c Localisation updates from https://translatewiki.net. 
Change-Id: I76a506a5fb58dee87fd3459d557b29190ad7e777
 2016-01-12 22:49:13 +01:00
Translation updater bot c37fbf1f70 Localisation updates from https://translatewiki.net. 
Change-Id: Ie52c778d1291121d3d78dcae9ae8a5d23d5c27b8
 2016-01-11 22:55:11 +01:00
Translation updater bot 946163d758 Localisation updates from https://translatewiki.net. 
Change-Id: Ib5d617cc8a22b6c5e5248c3a374d10d08cd3434f
 2016-01-10 23:15:09 +01:00
Translation updater bot f26501b4f6 Localisation updates from https://translatewiki.net. 
Change-Id: I6c324c98c20cc8d4b7b1b51f7eec5b5a608eee2b
 2016-01-08 22:22:26 +01:00
Translation updater bot d1386ae5b8 Localisation updates from https://translatewiki.net. 
Change-Id: Icf5edd18f9fa08c0ff63808c750b2f64698066bf
 2016-01-07 23:39:13 +01:00
jenkins-bot 7a39be3798 Merge "Stop using broken image links in tests" 2016-01-07 01:21:25 +00:00
David Lynch 3cffb489bb Stop using broken image links in tests 
They make it a little bit more cluttered to hunt down problems when
testing. So, use the minimum image instead of just "Foo" or similar.

Bug: T121636
Change-Id: I3209c377ad870f669cac7d40d991968cff52c39e
 2016-01-06 17:11:38 -08:00
Dan Duvall 96677fb74a [BrowserTest] Experimenting with JS object references 
References to JS objects for VE elements can determined by referencing
the VE and OOUI API documentation[1][2] and interrogating the objects in
a browser console. Errors should be closer to what developers understand
but testers should pair with developers to better understand how to
define new page elements and where to go for documentation/help.

The VE entrypoint for the singleton reference is `ve.init.target` (if
there's only one instance of VE target; there may be multiple in some
cases like Flow).

[1] https://doc.wikimedia.org/VisualEditor/master/
[2] https://doc.wikimedia.org/oojs-ui/master/js/

Change-Id: I1f642807cdd3059d8e7e885a8b239ac01b9b3024
 2016-01-06 17:07:35 -08:00
Translation updater bot 739b4c796d Localisation updates from https://translatewiki.net. 
Change-Id: I406227f147f21b4deed2a5a6e9f556e84cd32a65
 2016-01-06 21:56:55 +01:00
Translation updater bot 94126edb04 Localisation updates from https://translatewiki.net. 
Change-Id: I1d7295d5aee0dd72a7469c6467b12177187988dc
 2016-01-05 22:31:09 +01:00
Translation updater bot b3a11a9325 Localisation updates from https://translatewiki.net. 
Change-Id: I79bdcd360cf4c879b8344f75af927fdfac89dcd2
 2016-01-04 22:38:41 +01:00
jenkins-bot 3591a0e63d Merge "Education popups: Only show for DesktopArticleTarget" 2016-01-04 20:00:58 +00:00
Ed Sanders e7ee5c20c6 Education popups: Only show for DesktopArticleTarget 
For now they are not well supported by other targets
(e.g. Flow and Mobile).

Change-Id: Ibd1f3c8994611661b52c0cf36438b41f623b9451
 2016-01-04 10:43:43 -08:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016 
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
 2016-01-03 14:57:25 -08:00
jenkins-bot e59e36e225 Merge "Refactor MediaResources(Provider/Queue)" 2016-01-03 22:55:39 +00:00
James D. Forrester 4a781a3a16 EditingTabDialog: Shorten the copy to make snappier, drop 'Edit' tab name 
Change-Id: Idd5f373d9fef364318efddcc98ea2de5e91860a8
 2016-01-03 13:44:54 -08:00
Translation updater bot 93b4a43b18 Localisation updates from https://translatewiki.net. 
Change-Id: I26cf69fe5f4593ca22c9a170fd16fb02549b187e
 2016-01-03 21:45:19 +01:00
Alex Monk 85bb085418 DesktopArticleTarget: Preserve oldid when switching from WTE into VE 
Change-Id: I8682a2a2b90ae2e42f1a8e01e16d0f9f3d66a2d5
 2016-01-03 10:59:21 -08:00
jenkins-bot 26e3c0ad1d Merge "Preserve oldid when switching from VE into WTE" 2016-01-03 06:35:58 +00:00
Translation updater bot f80e0c7482 Localisation updates from https://translatewiki.net. 
Change-Id: I58460ed4632db989f00464d0401a7bba5cd072da
 2016-01-01 20:07:11 +01:00
Translation updater bot f1df0e0df4 Localisation updates from https://translatewiki.net. 
Change-Id: I88a173f67541d0a5d1c8628e81871cbfce6db393
 2015-12-30 21:46:23 +01:00
Željko Filipin 2cfaa9528c [BrowserTest] Update mediawiki_selenium Ruby gem to the latest version 
Bug: T114241
Change-Id: Ic6cf69516a1e36173fbbf6b86494e845721a19d0
 2015-12-30 11:46:23 +00:00
Translation updater bot 8eca31d729 Localisation updates from https://translatewiki.net. 
Change-Id: I8c80187c5efb9b45b2a0df338a778a6074d467ac
 2015-12-28 21:05:28 +01:00
Translation updater bot 7dcba8dbf4 Localisation updates from https://translatewiki.net. 
Change-Id: I03f05bd052a77b75d731994fb8b247d21dff1077
 2015-12-27 20:38:22 +01:00
Translation updater bot ac555fd695 Localisation updates from https://translatewiki.net. 
Change-Id: If3e7e7050a93934732703d239b76c3b7c31069cb
 2015-12-26 21:12:39 +01:00
Translation updater bot 97dd3ee12d Localisation updates from https://translatewiki.net. 
Change-Id: I491b5cdaa05e954fffc5c11e6db6e12629064893
 2015-12-25 21:55:54 +01:00
jenkins-bot 3231220774 Merge "SET: Don't try to do any client-side section link magic if we're not supposed to." 2015-12-23 23:18:57 +00:00
Alex Monk 76cb69ecec SET: Don't try to do any client-side section link magic if we're not supposed to. 
Ugh.

Bug: T121599
Change-Id: I47a93d5dbedc5ae989a2973fb793ac99edfb139a
 2015-12-23 22:10:20 +00:00
Translation updater bot fa66daef6c Localisation updates from https://translatewiki.net. 
Change-Id: Ie2040e33f23c85fc0f6a2a66773c67c30aa6ac83
 2015-12-23 22:08:06 +01:00
Ed Sanders 2afd7c903d DesktopArticleTarget: Improve teardown sequence 
* Ensure activating classes are removed by rejecting activatedDeferred
  as soon as teardown starts.
* Try to teardown surfaces is surfaces exist, not just if the target is active.
* Remove noop teardownDebugBar. The debugbar lives inside the surface now.
* Ensure progress bar is always reset, even if target setup is aborted.

Bug: T99139
Change-Id: I16a071c0d4bc8bbc6af2e03e63ee0ffc18d55c75
 2015-12-23 12:13:50 +00:00
Translation updater bot 9cc9b8f1a1 Localisation updates from https://translatewiki.net. 
Change-Id: Ia72cf64c778cf9ab82f24700ec90e404bd0f9432
 2015-12-22 22:12:49 +01:00
Ed Sanders 93f0e8b30c Refactor MediaResources(Provider/Queue) 
Create a subclass for MediaSearch(Provider/Queue) and make the parent
class a more generic representation of API requests for media.

Change-Id: Iea8b90e829d532d210bfef3c96d6798c64e15eed
 2015-12-22 14:00:10 +00:00