wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-16 02:51:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
14728 commits 161 branches 1 tag 190 MiB
Commit graph

6837 commits

Author SHA1 Message Date
Ed Sanders b5371c791f Add comment to htmlBlacklist item 
Bug: T150418
Change-Id: I0c48ff6f187cde4c378e5aa193e62d107bc7919c
 2018-05-07 21:49:34 +01:00
Ed Sanders 86fdda21c6 Remove some no longer required CSS from switch popup 
Change-Id: Ic965c147b195b4546f8f1e7d36395c96597a159e
 2018-05-07 21:35:24 +01:00
Ed Sanders 5974c59b97 Follow-up Ifdc951fdc: Don't use target when it doesn't exist 
Change-Id: Idf546f7b1d2c12f59b5024f3365665214e4e5f49
 2018-05-07 21:22:09 +01:00
jenkins-bot 7bca14c182 Merge "Add an 'api' parameter to ApiResponseCache" 2018-05-07 15:53:18 +00:00
jenkins-bot 5722a3c59f Merge "Remove references to global singleton inside LinkCache" 2018-05-07 15:53:01 +00:00
jenkins-bot 93c1f0d9b4 Merge "Create an MWSurface and move langChange handling there" 2018-05-07 15:52:08 +00:00
jenkins-bot 95d831c2de Merge "Create getters for localised APIs (getContentApi/getLocalApi)" 2018-05-07 15:51:45 +00:00
jenkins-bot 9a79c10fc2 Merge "Remove unused overrides in internal link annotation inspector" 2018-05-07 15:41:33 +00:00
jenkins-bot 25d2eb2848 Merge "Use ve.resolveUrl in MediaContext/Dialog" 2018-05-07 15:28:52 +00:00
Ed Sanders b980150df4 Update link cache to use new descriptions API 
Bug: T191333
Change-Id: If1e7f50208a44bda6c30ff1d6c60a085f9da74e7
 2018-05-07 15:59:02 +01:00
Ed Sanders 4b00c765ff Add an 'api' parameter to ApiResponseCache 
Change-Id: Ie68b70472447a4bb2c9be8ed505a91f24858059d
 2018-05-07 11:53:23 +01:00
Ed Sanders 5eb89cdc51 Remove references to global singleton inside LinkCache 
Use 'this' instead.

Change-Id: Ie3138f2c62ff4e4938e8ed21e79b3433d98e2737
 2018-05-07 11:53:23 +01:00
Ed Sanders 8bddec44e3 Create an MWSurface and move langChange handling there 
Change-Id: I8a75b5f431f454b66441fc301b90e5f28636612e
 2018-05-07 11:53:23 +01:00
Ed Sanders 478b0bcbb9 Create getters for localised APIs (getContentApi/getLocalApi) 
Pass through the current document when available, otherwise
assume the current surface's document.

Also add a getter for getPageName, so that can vary based
on the target document.

Bug: T193856
Change-Id: Ifdc951fdc6a43b924d102e3fcd7e59e52023757b
 2018-05-05 14:32:55 +01:00
Ed Sanders b54f427078 Remove unused overrides in internal link annotation inspector 
Removes an unused call to mw.util.getUrl.

Change-Id: I3988311b7160af628ea4ceeafcfdc3cc0a7a3774
 2018-05-05 14:32:55 +01:00
Ed Sanders 3b4923fa74 Use ve.resolveUrl in MediaContext/Dialog 
Change-Id: I53e28d6cec13ac77718ba3cae425c4c43c96e174
 2018-05-05 14:04:15 +01:00
jenkins-bot 1f6cf4883d Merge "ve.init.mw.DesktopArticleTarget.init: Edit the latest revision when viewing a FlaggedRevs-stable one" 2018-05-05 01:03:04 +00:00
Bartosz Dziewoński 192a232410 ve.init.mw.DesktopArticleTarget.init: Edit the latest revision when viewing a FlaggedRevs-stable one 
When the user is viewing the last stable revision of a page which has
newer unreviewed revisions, FlaggedRevs wants us to open the latest
(unreviewed) revision of the page for editing.

Use the JS config variable 'wgFlaggedRevsEditLatestRevision', provided
by FlaggedRevs since change I4c9804fe2c4924e28770807881379ddca4fd8b76.

Also add an extra comment about loading latest revisions in general.

Bug: T165283
Depends-On: I4c9804fe2c4924e28770807881379ddca4fd8b76
Change-Id: Ic47491e690153d0ad87ce64bfc9e7a28a06fc6e2
 2018-05-04 22:04:02 +00:00
jenkins-bot 829089008f Merge "DesktopArticleTarget: track mwedit.ready even if skipping temp editor for new sections" 2018-05-04 21:59:27 +00:00
Ed Sanders ebcf1e1151 Check imageModel exists in #checkChanged 
Bug: T193879
Change-Id: Ic6eda7a056e5207042b575609b9da1869e3a759e
 2018-05-04 14:52:03 +01:00
David Lynch 3f91a27809 DesktopArticleTarget: track mwedit.ready even if skipping temp editor for new sections 
Bug: T193206
Change-Id: I78555b84bde3d5bd14b032862e5a020121fc5c2e
 2018-05-02 11:35:42 -05:00
Ed Sanders e49b5628d8 MWBlockImage: Make zoom link unclickable 
As it sticks out beyond the focus shield we
need to disable it manually.

Change-Id: I92baf24e6bb9294e46821311805ca0bb77f892a6
 2018-05-02 11:57:33 +01:00
jenkins-bot f9cac9f0ce Merge "ve.init.mw.DiffPage.init: Do not duplicate diff table header" 2018-04-30 21:26:55 +00:00
Ed Sanders 3dd3073bd2 Update VE core submodule to master (a8e0eef6d) 
New changes:
a8e0eef6d Simplify usage of dummy target

Local changes:
Simplify usage of dummy target, ceating an MWDummyTarget, extending
DummyTarget instead of mw.ArticleTarget.

Depends-On: I01a6860387087db8149c73793e9bd4294d33aea8
Change-Id: I227486159fe416c219e2c37a1d054201084fe285
 2018-04-30 13:05:02 -07:00
Bartosz Dziewoński 6d4a7f932e ve.init.mw.DiffPage.init: Do not duplicate diff table header 
The duplicate header, especially the duplicate elements with identical
IDs, were difficult to handle for other scripts.

Now instead of hiding the entire wikitext diff, we only hide the
"content" rows but keep the header, and adjust our attributes on the
header back-and-forth when switching diff modes.

Bug: T192755
Change-Id: I3a6bb4730fefd81f533b786ec3b20241c4cb8d13
 2018-04-30 19:23:16 +02:00
Ed Sanders 1bd430c9d1 Convert most uses of isForClipboard to doesModeNeedRendering 
Depends-On: I0f1b90056e9d1a4fa0e188700604709297593924
Change-Id: I6fa1cde51ffc859b57ab557e3ddf8a76d92bf94f
 2018-04-30 16:10:27 +00:00
jenkins-bot ffac6b14dd Merge "Check link 'host' in onEditSectionLinkClick" 2018-04-30 15:17:45 +00:00
jenkins-bot f4f78d3384 Merge "Follow-up Iea7ad832: Fix context in MWPopupTool" 2018-04-30 15:06:06 +00:00
Ed Sanders f8cebb8f51 Follow-up Ib7e769e: Fix typos in static method calls 
Also move desktop-only methods to DesktopArticleTarget.

Bug: T193217
Change-Id: Icc2bb6602a62057da9f841793d8fe06d9814230e
 2018-04-30 11:05:43 +01:00
Ed Sanders ad170023e6 Check link 'host' in onEditSectionLinkClick 
Bug: T193323
Change-Id: Id67798e5689af9d528bf29bb1b42047adaedaabd
 2018-04-30 10:57:45 +01:00
Ed Sanders 8fdc1f7085 Follow-up Iea7ad832: Fix context in MWPopupTool 
Bug: T193043
Change-Id: I2b035a50543093988a291ea8c8958a3a7cc9e7ba
 2018-04-29 21:45:10 +01:00
Ed Sanders cddf206f5b Set surface's $overlayContainer in DesktopArticleTarget 
Logically depends on Ia96b1a89dd9582303b80be85b3971cf3341cad24.

Bug: T166217
Change-Id: Icc54f87bac46d39e8c49010ed052e1db66827f06
 2018-04-27 21:55:12 +00:00
Ed Sanders 95258a9969 Visual diff: Describe redirect changes 
Change-Id: Id31e8399556dab9b47bc1d21c62cb82af3a0e7bb
 2018-04-27 21:07:41 +01:00
Bartosz Dziewoński e1635fdc52 Update custom styles for format menu after OOUI changes 
Bug: T193098
Change-Id: I00d28f16b03a31ecda1dc57050945e98e8eb37e8
 2018-04-26 01:48:28 +02:00
jenkins-bot fd082e577b Merge "ve.init.mw.DesktopArticleTarget: Setup toolbar before section title input" 2018-04-24 16:24:42 +00:00
Bartosz Dziewoński e3378e6d77 ve.init.mw.DesktopArticleTarget: Setup toolbar before section title input 
When we set up the new section title input and possibly set its value
(preloading from URL query, or from autosave), the "Save" button on
the toolbar must already exist, because we try to enable it.

Bug: T192901
Change-Id: I3bba86a8c8a9b81014d425db256ff49f06bdaea6
 2018-04-24 18:11:42 +02:00
David Lynch 44469f0f06 MWWikitextSurface onCopy: set text/x-wiki content if available 
Equivalent to some existing copy-code in inspectors which handle raw wikitext.
Lets us shortcut content-sniffing with html/text content onPaste.

Change-Id: I27ded82a9675abdb3ee98ee29390e7079d11cf05
 2018-04-23 16:04:49 -05:00
jenkins-bot c0364bc6a6 Merge "Teardown target before reloading article" 2018-04-23 21:00:43 +00:00
jenkins-bot ec8be1bfa1 Merge "Add a plain text paste transfer handler for source mode" 2018-04-23 21:00:41 +00:00
Ed Sanders 1f4baa7b58 Teardown target before reloading article 
Ensures that auto-save data is cleared after
creating a new article, or restoring a revision.

Bug: T192770
Change-Id: I348b8522c1a935d7db1243ba8fcbd5b24e3383a2
 2018-04-23 21:30:37 +01:00
gopavasanth 3e541774e8 Change http://www.mediawiki.org/ to https://www.mediawiki.org/ 
In other files, links to mediawiki site are https://www.mediawiki.org/

Bug: T189687
Change-Id: I0279a7ffdb9544a87a11ffdab7ff5d5d38ea6035
 2018-04-23 15:08:43 +00:00
David Lynch 6f8e58fa8a Add a plain text paste transfer handler for source mode 
This allows plain text pasting into source mode without interfering with the
possible-conversion that should happen when it's pasted into visual mode.

Bug: T190590
Bug: T192320
Depends-On: I47a5bf321fb64d4a631ec6fd728bee269d4cdae0
Change-Id: I71db368c683a6a846569d7627f4cc73e907a61d2
 2018-04-22 12:52:56 -05:00
jenkins-bot 6e44244af5 Merge "Sortable table header: Account for null entries in table matrix" 2018-04-19 16:08:01 +00:00
jenkins-bot 9ecd73f771 Merge "NWE: Fix selection when applying async links" 2018-04-19 16:01:22 +00:00
Ed Sanders 24ae471fd1 Sortable table header: Account for null entries in table matrix 
Bug: T192545
Change-Id: I05bb80a0afce72a8202209499947781efe684584
 2018-04-19 14:27:22 +01:00
jenkins-bot 5ae421d715 Merge "Refactor ve.dm.MWTransclusionNode.static.describeChanges" 2018-04-18 07:26:10 +00:00
jenkins-bot bc12e25b35 Merge "MWExtensionNode: Diff mw.attrs" 2018-04-18 07:26:08 +00:00
jenkins-bot 69f0ff1016 Merge "Blacklist images with data URLs" 2018-04-17 19:48:20 +00:00
Ed Sanders 6625fc5c85 Blacklist images with data URLs 
These aren't supported by VE-MW, so must just be
garbage from a browser plugin.

Bug: T192392
Change-Id: I24646244daf2847e4dee88273058658300880dfc
 2018-04-17 20:10:51 +01:00
jenkins-bot 6902e81768 Merge "Use ellipsis on toolbar save/publish button" 2018-04-17 18:34:17 +00:00
jenkins-bot a8e6d1ddd5 Merge "Add label to Options dialog > Categories input fields" 2018-04-17 18:18:55 +00:00
jenkins-bot d325f793a9 Merge "Show revision info on historical diffs" 2018-04-17 17:36:21 +00:00
Ed Sanders 53e758a427 NWE: Fix selection when applying async links 
Change-Id: I31dc6f2d9fcd563bdbd8245bda6336d317aa512a
 2018-04-17 16:33:23 +00:00
Ed Sanders b38500f102 Only resolve wikitext promise when progress dialog has closed 
Logically depends on I0cdb004011 to fix the bug.

Bug: T182402
Change-Id: I8ecd695c052a6c759b8261e81fb25c771bdf3d56
 2018-04-17 16:33:14 +00:00
James D. Forrester 58c5643f1e Update VE core submodule to master (a64ba1cc6) 
New changes:
aee32648a Allow access to a fragment's async state
a64ba1cc6 Add extra copy/paste tests for <span> clipboard keys

Local changes:
* Fix signature of runSurfacePasteTest

Change-Id: Idbc2f2c25eaf0606c51d9dff8ec23562f5244c08
 2018-04-17 16:02:04 +00:00
hunter be5289689f Add label to Options dialog > Categories input fields 
Add label to indicate the function of the input field underneath the
categories label in the options dialog. The <label> element is
preferred for screen readers and users with visual disabilities.

Bug: T146966
Change-Id: Ib300ca7a1fd55d320c1a1a8c8c7fd01ab8b0b9c5
 2018-04-17 06:28:32 +00:00
jenkins-bot 3a9ec6bcce Merge "Fix layout of welcome dialog on smaller screens" 2018-04-12 22:55:39 +00:00
Ed Sanders 62d2211aed Mobile: Hide top-level toolbar labels on narrow screens 
Change-Id: I8049b935204834201d2a185d04070bbf81520d1e
 2018-04-12 23:32:33 +01:00
Ed Sanders 4f448a8c96 Hide stray checkmarks on mobile toolbar 
Change-Id: Iae5ad6f736197f9d88d973a51b3b04bddc101826
 2018-04-12 23:22:26 +01:00
Ed Sanders 2496fcefb0 Fix layout of welcome dialog on smaller screens 
Bug: T191095
Change-Id: Ic329fe22a6758fe58ec56dc3b5a293b83d9b38fb
 2018-04-12 23:15:15 +01:00
Ed Sanders bcf3783c1c Refactor ve.dm.MWTransclusionNode.static.describeChanges 
Removes some duplication.

Change-Id: If68401617cde60cf151bf132f33e5d9dc42bbf72
 2018-04-12 17:46:47 +01:00
Ed Sanders 4fdf5b08b4 MWExtensionNode: Diff mw.attrs 
Bug: T191450
Change-Id: Ia6bfc4d2f04243970d6f65fd0ccfd650aee5da06
 2018-04-12 17:46:47 +01:00
Ed Sanders 3682ab070d mw.Target: Remove .protectedClasses, only used in ArticleTarget 
Also fix documentation

Change-Id: I3fa93dd95c3ef47f649d3f92a38e14750a411333
 2018-04-12 15:38:23 +00:00
Ed Sanders 50a2ab7418 Show revision info on historical diffs 
Bug: T187614
Change-Id: Ie28d4af6443a17e2e25b2520f0e0dbf5ba4076cc
 2018-04-10 20:42:06 +02:00
Ed Sanders 637d869d99 Convert href-less links to spans 
Bug: T191598
Change-Id: I0993869ed53842f9de60ff7e68f79a69da1d23c7
 2018-04-09 18:04:08 +00:00
jenkins-bot b7abb924c2 Merge "Abstract API calls to 'parsefragment'" 2018-04-09 16:13:27 +00:00
jenkins-bot 2306717eb1 Merge "Use 'imageBroken' icon for missing images' contextItem" 2018-04-08 19:13:16 +00:00
James D. Forrester ac2b5e1ef8 Update VE core submodule to master (3ea11b8b1) 
New changes:
f97bdb039 PlainTextStringTransferHandler: Allow as paste
5a0007e49 Expand ce.Surface tests for plain text pasting
bab28c8d3 Localisation updates from https://translatewiki.net.
82bc2c014 Fix language input design now that indicator-next is gone
c14c6ac56 Fix z-index of context elements in diff

Bug: T190590
Bug: T190916
Change-Id: Ibe8b1b62a8300f380b753f978bed6a6f8d520044
 2018-04-06 10:52:54 -05:00
Ed Sanders 924f9ec730 Use 'imageBroken' icon for missing images' contextItem 
Change-Id: I3ba8f34a8ff03c949c18df102e7334449abb6e27
 2018-04-06 15:32:55 +01:00
Ed Sanders 16211cdc09 Abstract API calls to 'parsefragment' 
Change-Id: Id0be3207219a6d93cebff2b6b5061cd24898d5cb
 2018-04-06 13:49:16 +01:00
jenkins-bot f5c483af52 Merge "Gallery: Use 'poster' attribute for video thumnails" 2018-04-05 21:33:29 +00:00
Ed Sanders 43a8004abb Gallery: Use 'poster' attribute for video thumnails 
Bug: T191098
Change-Id: I0f4e456ec7a52ee71dcfca581c73415fc8ee6178
 2018-04-05 22:14:16 +01:00
David Lynch c4c5582121 MWTransclusionDialog: remove extra padding from framesets 
Bug: T191234
Change-Id: I6cfec45607f2dd428347879c134dbe286397f8b6
 2018-04-05 11:30:05 -05:00
Ed Sanders 8b42a5917c Add img.src's to gallery DM output 
Bug: T191377
Bug: T191436
Change-Id: Ie6b3593876c92f8e6f08fb005d876304223491ed
 2018-04-05 12:57:18 +01:00
jenkins-bot 7b1d248ec1 Merge "ve.ui.MWMediaDialog: Use dropdown for image type selector" 2018-04-05 11:02:22 +00:00
jenkins-bot f3ba1a780f Merge "ve.ui.MWParameterPage: Pass $overlay to PopupButtonWidget" 2018-04-04 21:36:39 +00:00
jenkins-bot f5b0d655cf Merge "FeedbackTool: Add the ability to vary feedback page for source mode" 2018-04-04 21:24:09 +00:00
jenkins-bot a903f5c1cc Merge "ve.ce.MWInlineImageNode: Fix rendering of non-linked images" 2018-04-04 21:20:59 +00:00
Bartosz Dziewoński 0cf02e0155 ve.ui.MWParameterPage: Pass $overlay to PopupButtonWidget 
Also, pass $overlay to all PageLayout subclasses used in ve.ui.MWMetaDialog
and ve.ui.MWTemplateDialog/ve.ui.MWTransclusionDialog, for consistency.

Bug: T191395
Change-Id: Ib7ed2e2c04ff7930be1161bd2b981180ee59557a
 2018-04-04 22:45:13 +02:00
Bartosz Dziewoński 24e828c627 ve.ce.MWInlineImageNode: Fix rendering of non-linked images 
The bug is easiest to reproduce with `[[File:Example.jpg|link=]]`,
but it also affected video embeds.

jQuery appendTo() method returns the set of inserted elements.
Because `this.$element` is undefined at this point, the `<img>`
was not actually being inserted anywhere, and an empty set was
returned, causing MWInlineImageNode to have no CE rendering.

This was not an issue prior to c4f93b14, because `this.$element`
was being defined by the parent constructor (OO.ui.Element)

We don't actually want to insert it anywhere, this appendTo()
call was a remnant of wrapping code removed in a22aeafc.

Bug: T191406
Change-Id: If1dbf9fef0e0ac9debfdb3049ebcccac70948515
 2018-04-04 21:22:58 +02:00
jenkins-bot 884d0137a0 Merge "Remove <section> unwrapping code from ve.ce.MWTransclusionNode" 2018-04-04 19:05:54 +00:00
James D. Forrester 31730cc5b3 FeedbackTool: Add the ability to vary feedback page for source mode 
Wikis with a local link over-ride configured will need to do so here
for the new message `visualeditor-sourcefeedback-link`; wikis with a
remote link configured will need to update their configuration ahead
of this being deployed, setting $wgVisualEditorSourceFeedbackTitle.

Bug: T157953
Change-Id: Iea7ad8328b03f69e01d7c67ca1ddbb7ae7906288
 2018-04-04 18:11:10 +00:00
jenkins-bot 737a0446be Merge "GalleryNode: Pass through all arguments in describeChanges override" 2018-04-04 17:41:08 +00:00
Ed Sanders 63f94f929f GalleryNode: Pass through all arguments in describeChanges override 
Change-Id: I66bb6bc2a5e95607beee103e925b3fa641f432d5
 2018-04-04 18:00:41 +01:00
jenkins-bot 242eb68b96 Merge "Improve diff description on gallery nodes" 2018-04-04 16:50:03 +00:00
Ed Sanders 1159471730 Improve diff description on gallery nodes 
* Deep compare mw.attrs on gallery nodes, ignoring 'caption'
* Ignore computed attributes on gallery image node

Bug: T191441
Change-Id: If1d9ec15a45001f3c420d20481be43ae38ae201a
 2018-04-04 17:38:48 +01:00
jenkins-bot 459f35924c Merge "DiffPage: Remember chosen diff mode" 2018-04-04 16:34:54 +00:00
jenkins-bot 9c82472546 Merge "MWExternalLinkAnnotation: add CSS to override plainlinks styling" 2018-04-04 15:53:51 +00:00
Ed Sanders b5be51db7e Use cog icon for options 
Bug: T191099
Change-Id: I68638dcfa2531ce01843ae3517d9245deb716769
 2018-04-04 13:22:00 +01:00
jenkins-bot cb0ae22be4 Merge "Define childNodeTypes for gallery image node" 2018-04-03 20:26:00 +00:00
jenkins-bot f04563faba Merge "Show redirect link in preview" 2018-04-03 19:01:02 +00:00
jenkins-bot 6ce963665f Merge "Move redirect building methods from DesktopArticleTarget to ArticleTarget" 2018-04-03 19:01:01 +00:00
Thalia 367509287f Define childNodeTypes for gallery image node 
Change-Id: I9ad78d26dfa16a7bc6da8bc94d7ef4e38fdec409
 2018-04-03 19:40:12 +01:00
Ed Sanders 36e0f8988d Show redirect link in preview 
Bug: T191128
Change-Id: I08fc03dd869e6b074a24698f9037380b26e3dd2c
 2018-04-02 17:34:51 +01:00
Ed Sanders 11eaab48c8 Move redirect building methods from DesktopArticleTarget to ArticleTarget 
These are not specific to desktop.

Also make the static builders static, and move VE target specific
code to caller, such as the click handler.

Change-Id: Ib7e769e3d6d339b9e66e1bc924480b0b0d5db17d
 2018-04-02 17:32:24 +01:00
jenkins-bot 45afe665c1 Merge "Visual diffs in source mode section edits" 2018-04-02 16:05:34 +00:00
jenkins-bot b29de616c9 Merge "Fix source copy when clipboardData not available" 2018-03-29 23:39:19 +00:00
Ed Sanders ec3c6b65c0 Remove <section> unwrapping code from ve.ce.MWTransclusionNode 
Has been fixed upstream in Parsoid.

Bug: T181226
Change-Id: I7dfe228e6d1008c4e66377d501f2e4af72c1813d
 2018-03-29 14:05:32 +01:00
Ed Sanders 58054d49da Fix source copy when clipboardData not available 
Bug: T190881
Change-Id: I8569dec0c03caa30cb7fcbbbfeed126dc9db57e4
 2018-03-29 13:58:00 +01:00
jenkins-bot ea9a0d56df Merge "Update VE core submodule to master (4922429f7)" 2018-03-28 16:32:26 +00:00
Bartosz Dziewoński f8522b7aac Update VE core submodule to master (4922429f7) 
New changes:
4922429f7 Merge all theme overrides into single files

Local changes:
* Update extension.json module definitions for 4922429f7
* Merge all VE-MW theme overrides into single files

Change-Id: Ie8bb4a78c3c50dd4e930f25f6f72bc2f395bd10c
 2018-03-28 09:17:12 -07:00
David Lynch 7f5b6fafb4 MWExternalLinkAnnotation: add CSS to override plainlinks styling 
Was causing the active link highlight to look broken.

Bug: T190582
Change-Id: Ia59e762689211625027367511ffd922f445a13ae
 2018-03-28 10:57:10 -05:00
jenkins-bot 476a590c3c Merge "Parse title in show preview using hack" 2018-03-27 20:29:35 +00:00
jenkins-bot 5b36d88eae Merge "Make edit notices popup wider (320 -> 380)" 2018-03-27 17:24:58 +00:00
Ed Sanders d3e5385944 Visual diffs in source mode section edits 
Bug: T190845
Change-Id: I938352eec8b49f27784c12ddea72bbe69fdd6cb2
 2018-03-27 17:53:54 +01:00
David Lynch d77ea2bf16 DesktopArticleTarget: use -published message instead of -saved 
Bug: T183901
Change-Id: I09f6e44f9f743f079ca5504ec06706c764ce6e25
 2018-03-27 10:49:03 -05:00
Esanders 3cd35b95e9 Make edit notices popup wider (320 -> 380) 
Bug: T184379
Change-Id: Ic68f5e117bb0057bb5fa8b83834707abfbadb3b3
 2018-03-27 14:16:25 +00:00
Bartosz Dziewoński b8bcba8cbe ve.ui.MWMediaDialog: Use dropdown for image type selector 
The dialog is not wide enough to fit four buttons side-by-side.

Bug: T74187
Change-Id: I6a4e5692b5f1b2ca9bb78d4e6c6103036f371a52
 2018-03-27 14:40:39 +02:00
jenkins-bot fe625aa5ea Merge "ve.ui.MWPopupTool: Allow labels of buttons in help menu to wrap" 2018-03-27 11:55:16 +00:00
jenkins-bot 6deaeffa95 Merge "Revert "Make edit notices popup wider (320 -> 450)"" 2018-03-27 11:30:12 +00:00
Bartosz Dziewoński 4fd4a5259b ve.ui.MWPopupTool: Allow labels of buttons in help menu to wrap 
Bug: T190796
Change-Id: I7889119a60133100825d7db4a02e6d0a7c797eba
 2018-03-27 12:31:24 +02:00
Bartosz Dziewoński a0dacccd83 Revert "Make edit notices popup wider (320 -> 450)" 
This reverts commit d5a61eb95d.

Bug: T184379
Change-Id: I0198c6d1faf1474ea0faab7e05ec95cfb43c9206
 2018-03-27 10:13:45 +00:00
Volker E e837512cc6 Replace deprecated 'comment' with 'speechBubble' icon 
Bug: T183600
Change-Id: Iebebba61a099193051cffc11f41e366bdb1c19e1
 2018-03-26 21:14:35 -07:00
James D. Forrester fe525e3bcc *Dialog: Don't set to small size, which is the default 
Change-Id: I3b7a19acd0ee5112d104257bdc1e9ff0e9b4ff24
 2018-03-26 15:02:11 -07:00
jenkins-bot dc3e192179 Merge "Make edit notices popup wider (320 -> 450)" 2018-03-26 21:31:07 +00:00
jenkins-bot 58f9cf7050 Merge "Autosave section title when adding new section in source mode" 2018-03-26 21:19:26 +00:00
jenkins-bot 5f8d287e12 Merge "Autosave recovery prompt" 2018-03-26 20:55:18 +00:00
jenkins-bot 44720da389 Merge "*Dialog: Drop verbose option, ignored since v0.20.0" 2018-03-26 16:18:49 +00:00
jenkins-bot 5325424988 Merge "Match audio & video elements in gallery DOM" 2018-03-26 16:18:46 +00:00
jenkins-bot ce425c1d56 Merge "[BREAKING CHANGE] Use upstream tryTeardown instead of close in MobileArticleTarget" 2018-03-26 16:12:35 +00:00
jenkins-bot 132d3fbaac Merge "Move some deactivation code from DesktopArticle to ArticleTarget" 2018-03-26 16:10:49 +00:00
James D. Forrester 9e01553f0b *Dialog: Drop verbose option, ignored since v0.20.0 
Change-Id: If0bc7946b67aaae97886e8dbd956e9338b0e0b40
 2018-03-26 08:55:03 -07:00
Ed Sanders 95fc150a4f Remove unused static overrides from dialog 
Change-Id: I31f0310baa5c438b17f16749368102d8cede22db
 2018-03-26 15:49:04 +01:00
Ed Sanders 28d8d2923e [BREAKING CHANGE] Use upstream tryTeardown instead of close in MobileArticleTarget 
Change-Id: I33bcc98bc75ab049568de47faceb3f3390df5901
 2018-03-26 15:32:55 +01:00
Ed Sanders 307e6c2922 Move some deactivation code from DesktopArticle to ArticleTarget 
Also rename tryDeactive to tryTeardown.

Change-Id: Ie89d59a62826bcfe3d30ad04f89d3c4211cc34f4
 2018-03-26 15:32:55 +01:00
Ed Sanders f89856f0ba Match audio & video elements in gallery DOM 
Bug: T190631
Change-Id: Ic09927728b449dda43cf115fa9612ebd7a2bf23f
 2018-03-25 22:04:57 +01:00
jenkins-bot 966e46ac80 Merge "Fix the image sizes in ve.ui.MWInternalLinkContextItem" 2018-03-23 05:36:51 +00:00
Ed Sanders f7b0118de0 Fix layout of media info fields 
Bug: T190468
Change-Id: Ic81781318a9003064e7d8f283901d70a5bae6ebc
 2018-03-22 22:15:52 +00:00
jenkins-bot 511dfc41ca Merge "Make save commands only executable when article is saveable" 2018-03-22 17:03:37 +00:00
Ed Sanders 8a974f25e6 Fix the image sizes in ve.ui.MWInternalLinkContextItem 
Remove the image size styles from the class
.ve-ui-mwInternalLinkContextItem-hasImage too

Bug: T97631
Follow up: I84edeec38ecfb90f5d53
Change-Id: I39937bf4ba12f7047545b187c54a1c5fae157e4a
 2018-03-22 17:03:19 +00:00
Ed Sanders 3a56d42901 Make save commands only executable when article is saveable 
Change-Id: Ia22fbae45201254867bf6e8920aff944ba9276b9
 2018-03-22 10:44:30 -05:00
Ed Sanders bfb59e9c8a Follow-Up I84edeec38: Use font-size: 1em instead of unset for invisible templates 
Leaving it unset falls back to 'inherit' which is too large.

Change-Id: I0dd90b247b51070bbe10aad4941a9dc4a7ac60c1
 2018-03-22 13:29:49 +00:00
David Lynch 75af29b57d DiffPage: Remember chosen diff mode 
Use a new preference: visualeditor-diffmode-historical.

Bug: T189896
Change-Id: I0575cc0a86dc0683758d24c0f597834e38cf1095
 2018-03-22 01:41:14 -05:00
jenkins-bot bfd4a5870f Merge "Use single-line editor for image captions" 2018-03-22 01:32:09 +00:00
Ed Sanders a58b529104 Autosave recovery prompt 
Prompts the user before recovering if the document
has been edited since last load.

Bug: T190077
Change-Id: Ibc0e1d1342510fbca57ad599c1816918c84e5487
 2018-03-21 16:23:35 -07:00
jenkins-bot 663b9f9a35 Merge "Remove special font-size treatment following-up UI unified in 14px base" 2018-03-21 21:07:16 +00:00
jenkins-bot e03f3e2c73 Merge "Update icons for new 20px grid" 2018-03-21 20:59:23 +00:00
jenkins-bot 5aa1bb8537 Merge "MWTransclusionNode: describe parameter changes for Visual Diffs" 2018-03-21 20:03:21 +00:00
James D. Forrester ece430258b Update VE core submodule to master (dc98cb7ec) 
New changes:
617708fe1 Update rel attribute checks to be aware of multiple rel values
c22428f81 ve.ce.LinearSelection: Don't throw exceptions only to catch on the next line
406db2ce3 Localisation updates from https://translatewiki.net.
33f94faf7 tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior
d85bf0d68 Use documentFragments when DOM splicing
110519f1c Update documentation now describeChange can return jQuery
ff7fa5fa0 Change http://www.mediawiki.org to https://www.mediawiki.org
09faa4a3d Fix error with tabs per this:
a329edf67 Localisation updates from https://translatewiki.net.
da864cc5e demos: Separate out and fix mobile-dist
380cc90c5 VisualDiffs: Unit test for timeout behaviour
601173c02 Clarify the "Log" button label on the debug bar
c52a2e07e demos: Fix auto-save by only storing doc state if not recovered
1b8d2c457 Auto-save: Save and restore last known selection
9e279e77e Fix deprecated icon name 'alignCentre' > 'alignCenter'

Local changes:
tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior

Bug: T189687
Bug: T189939
Depends-On: I2059d8ce9140b733ee92436de395d735ab06b9df
Change-Id: I3c210112c84e2d2bd8226de3dad195bf17afb4c2
 2018-03-20 16:38:54 -07:00
jenkins-bot cf9ddabe23 Merge "Disable visual diffs on source mode section edits" 2018-03-20 23:02:33 +00:00
Ed Sanders 8bfb270168 Use single-line editor for image captions 
Depends-On: I2be081c766fab41b152d03b43e7e936e3f636166
Change-Id: Ifcdc34826ad81e96c22fd68ceb637107cde24d4a
 2018-03-20 22:51:27 +00:00
jenkins-bot 2c96d24c76 Merge "Avoid jQuery.parseHTML" 2018-03-20 21:44:37 +00:00
jenkins-bot 0ed47a025e Merge "Only use pre-computed measurements for position loading bar" 2018-03-20 21:44:36 +00:00
Volker E d44bb0bc1b Remove special font-size treatment following-up UI unified in 14px base 
Removing `0.8em` VE special base `font-size` for UI as we're unifying
OOUI interfaces to `14px` equals to `0.875em` at user agent default size.

Bug: T97631
Depends-on: I693d168d2ccf2babbcfe8952af3e1c262aa97773
Change-Id: I84edeec38ecfb90f5d53199f3b26fc3f83ab0611
 2018-03-20 20:03:19 +00:00
Bartosz Dziewoński d80099dad1 Update icons for new 20px grid 
Set viewBox to "2 2 20 20" to trim 2px off each side of our
existing 24px icons, therefore aligning them to the new 20px
grid. All of them had been drawn with large margins, so none
of the graphic is lost.

Bug: T177432
Bug: T190151
Change-Id: I23a6daa5dc2d4a9afc50f275da5df370d2319277
 2018-03-20 20:03:11 +00:00
jenkins-bot 9d004c4d35 Merge "Use OOUI 'markup' icon instead of local 'alienextension'" 2018-03-20 19:50:55 +00:00
Ed Sanders 0f56af016d Use ellipsis on toolbar save/publish button 
Bug: T189803
Depends-On: Ic29717a660de5e80ee2a37f583b2a61c11fa87c4
Change-Id: Idaf80ea7e6ae9ffa165a8638af886bf6ab21a7f0
 2018-03-20 19:46:36 +00:00
jenkins-bot cea546b502 Merge "MediaContext: Link filename to file page" 2018-03-20 18:41:09 +00:00
jenkins-bot bb34d650c0 Merge "Improve media context item to show Image/Video/Audio instead of 'Media'" 2018-03-20 18:38:53 +00:00
Ed Sanders 10792e179f MediaContext: Link filename to file page 
Change-Id: Ice3fdd40cd1f7b8ba2841ac326babc7f24a2635e
 2018-03-20 17:45:50 +00:00
Ed Sanders c245dd9ca0 Improve media context item to show Image/Video/Audio instead of 'Media' 
Change-Id: Ie3b7ec62483e725d3ce073095a2a958c1db930d5
 2018-03-20 17:45:48 +00:00
Ed Sanders 78ba8bbe3c Use OOUI 'markup' icon instead of local 'alienextension' 
Change-Id: Id15596ab0013cb2078480bdb4dde25ef8e7ae50b
 2018-03-20 17:27:54 +00:00
jenkins-bot c20a610750 Merge "Factor out isSaveable method from updateToolbarSaveButtonState" 2018-03-20 17:26:39 +00:00
jenkins-bot ff21c17c37 Merge "Remove unnecessary attachToolbarSaveButton override" 2018-03-20 17:25:11 +00:00
Bartosz Dziewoński c99b4a0ad5 ve.ui.Icons: Add missing global "invert" variant 
Bug: T190166
Change-Id: I28cc22d49881a25973b31e5e112130fb21cf4a37
 2018-03-20 16:36:18 +01:00
David Lynch a228991181 MWTransclusionNode: describe parameter changes for Visual Diffs 
Currently limited to single-template transclusions.

Bug: T188389
Depends-On: Id03d6a9866b56c00e11a030ed60b3c6fb7ead3d1
Change-Id: I332b5f5aa789fdc00510e9f03ea96e4058a28961
 2018-03-20 10:35:03 -05:00
jenkins-bot 39a8c9e14b Merge "Restrict width of diff feedback button mobile" 2018-03-20 02:09:11 +00:00
jenkins-bot e23dd5fb6d Merge "Make gallery dialog work with native gallery implementation" 2018-03-19 23:39:00 +00:00
jenkins-bot 5b82bb180d Merge "Fix title preview when not overridden" 2018-03-19 23:24:21 +00:00
Thalia 12cc56400b Make gallery dialog work with native gallery implementation 
Updates the model and re-renders the gallery.

Bug: T150621
Bug: T149602
Bug: T149596
Change-Id: I1e93c3af02eeeff1fcdaa5549cccc61ea755ee04
 2018-03-19 23:55:17 +01:00
Ed Sanders 5e1c024d33 Parse title in show preview using hack 
Really Parsoid should do this for us.

Bug: T189540
Change-Id: Ie3b5d458e7e6611565e5852f351d715a48be521a
 2018-03-19 21:58:33 +00:00
Ed Sanders 81f3c2df38 Fix title preview when not overridden 
Change-Id: I555b057d8f20704c0676646afd03c78ad3353f23
 2018-03-19 21:56:54 +00:00
jenkins-bot 48028e84b9 Merge "Allow ve.ui.MWCategoryInputWidget to use different API" 2018-03-19 21:29:58 +00:00
jenkins-bot 98c9a395ac Merge "Show page title in preview" 2018-03-19 17:09:53 +00:00
petarpetkovic fe8b510232 Allow ve.ui.MWCategoryInputWidget to use different API 
* Provide config option to specify which API
ve.ui.MWCategoryInputWidget will use.
* To be used in Iec79e687eff8c63434054282650c97cc882f348d

Change-Id: Ib8869d4facf8b3210b309200d944fad4508d7eee
 2018-03-19 16:50:27 +01:00
Ed Sanders b80075a5e4 Avoid jQuery.parseHTML 
Change-Id: Iaf5cbe27b8883d6e4c468a3b4dae11438d264894
 2018-03-16 15:43:03 +00:00
Ed Sanders a1dffa2dd7 Only use pre-computed measurements for position loading bar 
Change-Id: I5fc17a432de8030a6154c4e961ac10c73f391a79
 2018-03-16 15:39:21 +00:00
Bartosz Dziewoński 13d77ba557 Remember 'checkboxesMessages' when storing document state 
Bug: T188796
Change-Id: I4785fe2fb7df774735c1bd48c222540a0286dd44
 2018-03-16 01:14:29 +01:00
jenkins-bot 1d227935d9 Merge "Autosave: only try to remove autosave on teardown if the surface exists" 2018-03-14 19:17:30 +00:00
jenkins-bot 79f27a5447 Merge "Clear VE autosave whenever WikiEditor is loaded" 2018-03-14 18:25:48 +00:00
jenkins-bot 3c861d7ed1 Merge "Clear auto-save when switching to fallback wikitext editor" 2018-03-14 17:55:44 +00:00
David Lynch 9762b096c8 Autosave: only try to remove autosave on teardown if the surface exists 
It's possible for some load failure states to cause this teardown at a point
without a surface. I observed it in MobileFrontend, when restbase can't be
contacted.

Change-Id: I13489640759c73dad5730d0bbadbfb2a38cb8e53
 2018-03-14 11:53:10 -05:00
Ed Sanders d0eafd6b8d Restrict width of diff feedback button mobile 
Change-Id: Ia4ceb73efb76d7714102619fce9cd87cf34216f9
 2018-03-14 14:32:37 +00:00
jenkins-bot e4a8c0b61b Merge "Attach deactivate code to namespace tab ('Main'/'Article')" 2018-03-14 09:19:16 +00:00
Ed Sanders c6653b6a2d Show page title in preview 
Bug: T189540
Change-Id: Idc203f7fcafcf944108938168b492e90091e3255
 2018-03-13 10:15:16 +00:00
jenkins-bot 540cb864ca Merge "ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image" 2018-03-12 12:28:10 +00:00
Ed Sanders e0419f8388 Autosave section title when adding new section in source mode 
Change-Id: Idcbe2f12e3eb0bb85e2c986885bd8084b16dbe5b
 2018-03-12 12:25:12 +00:00
Ed Sanders 4fc2b32b17 Disable visual diffs on source mode section edits 
Bug: T183938
Change-Id: I0d03c47e9b4c30760b7d3bd7bf90d91e79eb8569
 2018-03-10 22:54:54 +00:00
Ed Sanders e78379a395 Attach deactivate code to namespace tab ('Main'/'Article') 
Bug: T189380
Change-Id: I9f05722b9a1c740f9f982d9c5690d48046f19fdd
 2018-03-10 19:07:11 +00:00
Ed Sanders c3c3c60f1f Clear VE autosave whenever WikiEditor is loaded 
Bug: T189381
Change-Id: I21a76dc32327d6c6e72a793d9b579cb7b6a5e32e
 2018-03-10 18:34:17 +00:00
Ed Sanders ec6d9b235a Clear auto-save when switching to fallback wikitext editor 
Bug: T189381
Change-Id: Id89fa2a673ad8aef3826c0ef862770bf522bbdcf
 2018-03-10 18:04:44 +00:00
jenkins-bot 2ae3f5f1c2 Merge "ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption" 2018-03-10 17:28:34 +00:00
Bartosz Dziewoński 3c676013f8 ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image 
Currently this only handles the caption, but there will be more.

Change-Id: Ia8a25de89375d0ba873f4891b053c7aceab15534
 2018-03-10 17:16:16 +00:00
Bartosz Dziewoński 26e7728272 ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption 
Overriding ve.ce.BranchNode#onSplice seems pretty scary, some bug
could cause two captions to be inserted and it wouldn't even be
visible in the editor.

Instead, allow normal splice handling to happen when the caption is
added/removed, and only override the position where it is inserted
(to account for the image node this.$a).

The caption node is already removed from DM/CE if the image type is
changed to one that doesn't have captions, and even if that failed it
is also hidden in CSS, so we don't need to handle this.

Change-Id: I54f52b288118d692708311512dd674cc85d5d9e3
 2018-03-10 17:16:16 +00:00
Ed Sanders 9678cdc7c8 Factor out isSaveable method from updateToolbarSaveButtonState 
Change-Id: Ic1922ed26bae26a76e8149d48f3fb27fa9ba4330
 2018-03-10 16:20:30 +00:00
Ed Sanders 8b208c80d5 Remove unnecessary attachToolbarSaveButton override 
It's identical to the code inherited form ArticleTarget.

Change-Id: I7fe7a48b0614f2ac2665ece042bb95a6f77303ad
 2018-03-10 16:20:30 +00:00
jenkins-bot 00eb598352 Merge "Update rel attribute checks to be aware of multiple rel values" 2018-03-09 21:44:53 +00:00
jenkins-bot 04e5f6f208 Merge "LinkCache: styleParsoidElements find mw:WikiLink with ~=" 2018-03-09 21:44:52 +00:00
David Lynch b6c6d10d1e ce.MWTransclusionNode: increase invisible selector specificity 
5f6664e2 in VE core changed the specificity for some of the rules this
expected to override.

Bug: T189267
Change-Id: I510e151cc431c321d1d45fde9030d56f059d84ab
 2018-03-08 19:27:52 -06:00
David Lynch 4e10d5b975 Update rel attribute checks to be aware of multiple rel values 
Various checks didn't think a rel attribute could contain multiple values.
Mostly they don't, but to play it safe let's adjust the checks.

Change-Id: I29823b7c8c65ef6b2ff41ce9a801840000972e9c
Depends-On: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
 2018-03-08 14:34:56 -06:00
jenkins-bot 8e79d85583 Merge "Blacklist Web of Trust junk from being added to pages" 2018-03-08 00:33:48 +00:00
David Lynch f8c5608caf LinkCache: styleParsoidElements find mw:WikiLink with ~= 
`noopener` being added to the rel caused issues.

Bug: T189175
Change-Id: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
 2018-03-08 00:14:16 +00:00
Bartosz Dziewoński b05ac142c6 Blacklist Web of Trust junk from being added to pages 
Bug: T189148
Change-Id: Icc4b2d0ddf5104e26a3f563816f6f971d71e2531
 2018-03-07 22:12:43 +01:00
Ed Sanders 045f3b7640 Follow-up I5357a909: Fix logic for autosave from edited state 
Bug: T189071
Change-Id: I5439a73ffcf26795f58625720b1f1667ee3965cc
 2018-03-07 18:43:28 +00:00
Jforrester 16437646fe Merge "Update VE core submodule to master (ca771b8bc)" 2018-03-06 13:14:21 +00:00
James D. Forrester d144599cea Update VE core submodule to master (ca771b8bc) 
New changes:
7551f6c66 [BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore

Local changes:
Follow-through rename of IndexValueStore->HashValueStore

Bug: T188900
Change-Id: If60d0c637fe92f0e7afe916c064fafb17980d063
 2018-03-06 12:55:30 +00:00
jenkins-bot eb125877e2 Merge "Revert "For empty / whitespace-only headings, output <p> instead of <h#>"" 2018-03-06 12:22:31 +00:00
Ed Sanders a274bdb8f7 Revert "For empty / whitespace-only headings, output <p> instead of <h#>" 
Parsoid now handles empty headings for us in
scrub_wikitext mode (which we use).

This reverts commit 884f301aa0.

Bug: T187913
Change-Id: I8690bbced64be76622929f78f9c9e0d8f85d4be8
 2018-03-05 23:27:52 +00:00
David Lynch 09237b71ef mwExample: add test case for cross-document numberedlink paste 
Bug: T188429
Change-Id: I722f30f07abd65dba93e9ba297b6933ef8ca79c2
 2018-03-05 13:35:25 -06:00
David Lynch 795b428477 MWNumberedExternalLinkNode: set an explicit type 
This lets copy-paste between documents retain the numbered status rather than
falling back on pasting "<a>[3]</a>".

Update the part of LinkCache which selects on mw:ExtLink, so it will handle
possible multiple values in the link rel.

Bug: T188429
Change-Id: Ia5e4c9fa45e94da9cbfcd2a42d017d0fda1c511f
 2018-03-05 11:59:41 -06:00