Commit graph

17187 commits

Author SHA1 Message Date
James D. Forrester 21f2b131f9 Update VE core submodule to master (4cb1a3258)
New changes:
40906ce3d Localisation updates from https://translatewiki.net.
bb7fd8081 ve.ui.ContentAction: Fix a documentation comment
4cb1a3258 ve.ce.GeneratedContentNode: Fix a typo in documentation comment

Change-Id: I9dd04b97c3e287466aa6de0ddcf09a851234f2b6
2021-02-15 16:53:22 -08:00
Translation updater bot 84da14f22f Localisation updates from https://translatewiki.net.
Change-Id: I7cf79e7641e90ec3bb670b8d7d823920492bedab
2021-02-15 10:06:57 +01:00
jenkins-bot 76f5f69663 Merge "Only show "Editing mode" preference when VE enabled (on SET beta-feature wikis)" 2021-02-12 17:28:25 +00:00
jenkins-bot de284c21e8 Merge "Stop showing the "Editing tabs" popup some time after SET switch" 2021-02-12 17:12:20 +00:00
Bartosz Dziewoński c2b3694f8a Update VE core submodule to master (a248cdbac)
New changes:
4f7bf062b Rebuild language lists
289073126 Update of 'Live Demo' URL in README
a248cdbac Localisation updates from https://translatewiki.net.

Bug: T274222
Change-Id: I6f22ad177521ad286d59dfdeb6d632b891b62470
2021-02-12 17:09:56 +01:00
jenkins-bot 5b4971ded9 Merge "Update VE core submodule to master (c5b65e31d)" 2021-02-12 15:50:33 +00:00
Translation updater bot af8d4afc7b Localisation updates from https://translatewiki.net.
Change-Id: If0a21f4dd88f3185b6d3a4902dce9609597e321e
2021-02-12 08:52:52 +01:00
Translation updater bot 4dffd99bc7 Localisation updates from https://translatewiki.net.
Change-Id: I0857022e8dc470853cf2078dad76788929e1f9ae
2021-02-11 08:40:50 +01:00
jenkins-bot 6392fda0f0 Merge "Ignore user prefs for enabling/disabling VE which are not settable" 2021-02-11 00:31:26 +00:00
jenkins-bot 776f78d9c2 Merge "Do not define contradictory user preferences for enabling/disabling VE" 2021-02-11 00:30:36 +00:00
jenkins-bot bf3cd04f0f Merge "Remove two unused configuration options" 2021-02-11 00:19:32 +00:00
Translation updater bot 53a55d2542 Localisation updates from https://translatewiki.net.
Change-Id: I3979d83a0f6614376a0cb83caf08ecd08ed99b12
2021-02-10 08:39:22 +01:00
James D. Forrester 1f00c1d89d Update VE core submodule to master (c5b65e31d)
New changes:
248513f69 build: Updating eslint-config-wikimedia to 0.18.1
5e1fb5c18 Localisation updates from https://translatewiki.net.
c5b65e31d Localisation updates from https://translatewiki.net.

Change-Id: I7ab5adba7a931226d324eb3c2ad280c6424b9663
2021-02-08 12:52:54 -08:00
jenkins-bot 4cc121a3ac Merge "tests: Remove legacy setup/teardown function naming from QUnit 1.x" 2021-02-08 19:36:10 +00:00
jenkins-bot db3738e47f Merge "tests: Align setup/teardown function naming with QUnit 2.x" 2021-02-08 19:24:46 +00:00
Translation updater bot 8a6616629e Localisation updates from https://translatewiki.net.
Change-Id: I6988a87ef5f30303a5f1c53a3f690c0e902e6f0a
2021-02-08 08:46:27 +01:00
James D. Forrester 34b8267c82 tests: Remove legacy setup/teardown function naming from QUnit 1.x
Bug: T170872
Depends-On: I992e16fae6fcf4d5e7f2d5109ff16a30b6e73882
Change-Id: I05c10178694bbd5f87e070beea6cad2e3cf5fa67
2021-02-05 11:35:04 -08:00
James D. Forrester d315a3af88 tests: Align setup/teardown function naming with QUnit 2.x
In QUnit 2, QUnit.setup()/QUnit.teardown() were renamed, to be called
QUnit.beforeEach()/QUnit.afterEach(). Though we are insulated by this
through MediaWiki's wrapper for backwards compatibility, changing the
names of the functions we pass to the new names allows us to drop the
old ones.

Bug: T170872
Change-Id: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
2021-02-05 11:34:05 -08:00
Bartosz Dziewoński 263a4d1af7 Only show "Editing mode" preference when VE enabled (on SET beta-feature wikis)
Also, show the editing tabs dialog when appropriate.

Bug: T273189
Change-Id: I1293e0d69580372b23142493ee8905c18df40d23
2021-02-05 12:41:10 +00:00
Bartosz Dziewoński ef8e7945cc Stop showing the "Editing tabs" popup some time after SET switch
If someone has edited before the switch (2016-ish), never edited since
then, and try to edit again now, it's probably no longer helpful to
show them a popup dialog about a change that happened 5 years ago.

The immediate motivation for this, though, is T273189. We discovered a
bug with the preferences that, among other issues, caused this dialog
to not be shown in some cases where it should have been, and fixing
the bug now would cause it to be shown the on the next edit attempt.
If someone has edited before the switch (2016-ish), *and* edited since
then, and try to edit again now, it's definitely not helpful at all to
show them a popup dialog about a change that happened 5 years ago.

Bug: T273189
Change-Id: I4b5a3d8dbdf1c853eb39fcfc85a9fe87a4db0f21
2021-02-05 12:41:01 +00:00
Bartosz Dziewoński b91c8647fe Ignore user prefs for enabling/disabling VE which are not settable
We have two preferences used for enabling/disabling VE:
'visualeditor-enable' and 'visualeditor-betatempdisable'.
(And 'visualeditor-autodisable', which sometimes overrides
them both, but it's not relevant here.)

The user can only set 'visualeditor-enable' when VE is Beta Feature,
and they can only set 'visualeditor-betatempdisable' when it is not.

However, when deciding if VE should be loaded, we always checked both
of the preferences. This gives incorrect results when the preference
that is not supposed to be settable actually exists, due to being set
in GlobalPreferences on another wiki where it's settable.

A similar issue could occur if VE configuration is changed from Beta
Feature to a normal preference (or the other way around), and the
preference values for the previous configuration still persist.

Bug: T271434
Change-Id: I7399b3c516f762429050a662ac85d1d392392323
2021-02-05 12:40:51 +00:00
Bartosz Dziewoński 4b1f141511 Do not define contradictory user preferences for enabling/disabling VE
Depending on the config, we would sometimes define both the
'visualeditor-enable' and the 'visualeditor-betatempdisable'
preferences, even though they contradict each other.

Bug: T273188
Change-Id: I6ac7e4580bf232a5198ad8842f814bc381131e00
2021-02-05 12:40:38 +00:00
Bartosz Dziewoński b1fa5839c4 Remove two unused configuration options
* VisualEditorNewAccountEnableProportion
* VisualEditorAutoAccountEnable

Seemingly never used on Wikimedia wikis, and untested since 2016.

Bug: T273177
Change-Id: Ic132ef2091399fd223626ae307830f278e72ec01
2021-02-05 12:40:28 +00:00
Translation updater bot d8ee3f7c2f Localisation updates from https://translatewiki.net.
Change-Id: Ie991bfb16232022586368e2a9299a7bc07abb740
2021-02-05 08:47:56 +01:00
jenkins-bot 2d6214b186 Merge "Rename magic header to be consistent with WMF CDN infrastructure" 2021-02-04 23:38:23 +00:00
C. Scott Ananian fce9192e82 Rename magic header to be consistent with WMF CDN infrastructure
This name is consistent with T91820.

Bug: T91820
Bug: T259685
Depends-On: I0c4ec63bb26641b237c92dbd3bc5367811ca0675
Followup-to: 3561167493
Change-Id: I4c4c5f83ad56a198d08095d629a6ba86ce9dc1a4
2021-02-04 12:54:21 -05:00
jenkins-bot f284c350bd Merge "Fix sqlite compatibility by opting out of obligatory write lock" 2021-02-03 21:38:46 +00:00
Translation updater bot b944c321ab Localisation updates from https://translatewiki.net.
Change-Id: If06ab07f562192a8ce0dedeab5515d5e828c4bcb
2021-02-03 08:40:09 +01:00
C. Scott Ananian 3561167493 Fix sqlite compatibility by opting out of obligatory write lock
Bug: T259685
Depends-On: If37dc890a24a45c3a914e310b5b5bf625965e9e6
Change-Id: Ib203145f4c9ddfdc6701a916cbbbe17dae85efb9
2021-02-02 18:05:21 -05:00
Adam Wight d5ba11d3b2 Track whether an event was oversampled
This is needed to reconstruct population estimates from a sample.

Depends-On: Ie5cf24e84a2ed041bf7c4f0b891387c45667467b
Bug: T273454
Change-Id: I3a40e74f8ccb80aa6ed7d3313a5394aa31baf572
2021-02-02 13:02:01 +01:00
Translation updater bot 3107705c39 Localisation updates from https://translatewiki.net.
Change-Id: I3ee469f220d9381905a10cd268aefcef98c5c715
2021-02-02 08:40:10 +01:00
jenkins-bot 54f61eb54c Merge "Update save failure logging for EditAttemptStep schema, simplify code" 2021-02-01 18:28:10 +00:00
jenkins-bot f9aa74563a Merge "Logging init mechanism consistency" 2021-02-01 17:08:48 +00:00
jenkins-bot de4c11270c Merge "Log the DiscussionTools a/b test bucket for relevant schemas" 2021-02-01 17:08:43 +00:00
jenkins-bot b6033895f5 Merge "Add edit count bucket to VisualEditorTemplateDialogUse events" 2021-02-01 10:22:38 +00:00
Translation updater bot 796ff55473 Localisation updates from https://translatewiki.net.
Change-Id: Ibf083734bfd963bf01249997e7ce12b5f4c40fd1
2021-02-01 08:49:13 +01:00
David Lynch 2ee500ed70 Logging init mechanism consistency
Support the `url-new` mechanism so we can distinguish between
new/existing sections in direct navigation.

Also, mechanism will now correctly be `new` when clicking the "create"
tab on a previously empty page.

Bug: T272544
Change-Id: I667a1c45c3948ec6dfed8f348a1327bffaba58a5
Depends-On: I3cee7a3a4c4b646692dce4a1180c4ba18a61f4bc
2021-01-29 20:28:11 -06:00
David Lynch 284d43de93 Log the DiscussionTools a/b test bucket for relevant schemas
If someone is enrolled the DT a/b test, we want to know about their
editing here as well.

Bug: T273096
Change-Id: I235f4ccbcbfbf95c6aa0df327a9a5a7d5ddb1038
2021-01-29 20:28:11 -06:00
Bartosz Dziewoński 185db3a157 Remove tabindex="-1" from "Add more information" button in template dialog
This makes it button keyboard-accessible, like the other buttons.

Bug: T179136
Change-Id: Ib2824176fe861e0ad8511f755521bee941119b29
2021-01-29 21:06:12 +01:00
Translation updater bot 7fd9a6e9b0 Localisation updates from https://translatewiki.net.
Change-Id: I41eb682a5fb5e59f1c14f785412f64683abeaaef
2021-01-29 08:39:06 +01:00
libraryupgrader 56724d13db build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 34.0.0 → 35.0.0
* mediawiki/minus-x: 1.1.0 → 1.1.1

npm:
* eslint-config-wikimedia: 0.18.0 → 0.18.1

Additional changes:
* Added the "composer phan" command to conveniently run phan.

Change-Id: I2f9210c6a02e34a59c8ebc9284e0711612c4098e
2021-01-28 21:37:51 +00:00
jenkins-bot 096f2ba8ba Merge "Implement mwPlatform#decodeEntities" 2021-01-28 20:57:40 +00:00
jenkins-bot 750d08c642 Merge "Update VE core submodule to master (fe9082b21)" 2021-01-28 20:51:25 +00:00
jenkins-bot 30cc9f43cd Merge "SpecialCharacter: Small refactor of list building" 2021-01-28 20:11:20 +00:00
Ed Sanders cab608057d Implement mwPlatform#decodeEntities
Logically depends on I3c1e3aa3cee but can be merged before it.

Bug: T70429
Change-Id: I4ded7f1563b9de4cc81e05d890a24392f88de4f2
2021-01-28 19:57:58 +00:00
James D. Forrester d4044d6161 Update VE core submodule to master (fe9082b21)
New changes:
0b5cf3e43 Fix typo in comment
6f79dab51 Localisation updates from https://translatewiki.net.
c24bc7824 Update OOUI to v0.41.1
613f3c405 Move entity decoding into a utility function
4161f4338 Allow HTML entities in the special character list

Bug: T70429
Change-Id: I15eca7813598b76ebb5e7cb07fed6d377bde0fc2
2021-01-28 11:55:29 -08:00
jenkins-bot b193cd95a5 Merge "Show non-breaking spaces in the editor" 2021-01-28 19:38:28 +00:00
Ed Sanders 0edaf11ef4 SpecialCharacter: Small refactor of list building
Change-Id: I720cccbaa1d27771336a9969c4b6c776a696cde9
2021-01-28 19:14:07 +00:00
Bartosz Dziewoński d65fe812f5 Show non-breaking spaces in the editor
MWEntityNode representing   is now displayed with a light
grey background and has a tooltip explaining that this is a
non-breaking space and not a random grey blotch.

This is not done for TextNode (in core VisualEditor), as that doesn't
actually work: Parsoid converts all   in input to regular spaces.

It's still not easily possible to insert a non-breaking space.

Bug: T96666
Change-Id: Icbdf7cc3e5d675b199d08777a3439dc5dedceac1
2021-01-28 19:09:29 +00:00
Translation updater bot 923f1e8e6d Localisation updates from https://translatewiki.net.
Change-Id: I337559487f8312db4b6f45596eb7c623b1de26a0
2021-01-28 08:37:35 +01:00