Commit graph

16584 commits

Author SHA1 Message Date
Bartosz Dziewoński 1fc11e0146 Handle <noinclude> etc. as nodes rather than metaitems
The difference is that metaitems are not visible on the editing
surface, and their exact position is not preserved when the paragraph
containing them is edited.

This behavior is desirable for e.g. categories, but not for
<noinclude> and related tags, which are intentionally placed in
specific places in the text.

Note that we don't really have any editing interface for these nodes
yet. But you can see them (and they come with descriptions and links
to documentation pages), and delete or copy-paste them.

Bug: T250937
Change-Id: I104e7abbd650567df0e59813653c46a66d955d58
2020-06-01 18:47:14 +02:00
Bartosz Dziewoński a6647a258a ve.dm.MWAlienMetaItem: Never match mw:Extension nodes
Bug: T247001
Change-Id: I11771fc2537585622852e6756e800c3d5e530ac8
2020-05-25 19:14:46 +00:00
Translation updater bot 0f4a8b5179 Localisation updates from https://translatewiki.net.
Change-Id: Icffa63b454d845df61fa995b7a32be7c0af0ccbe
2020-05-25 08:41:28 +02:00
James D. Forrester 414bbac1b4 Update VE core submodule to master (3af5d5964)
New changes:
1c7d30c5c Update OOjs to v5.0.0
efe39c405 Update OOUI to v0.39.0

Change-Id: I341ec6a57ddd31929a2dfee4ed0269bea69096bd
2020-05-22 09:07:41 -07:00
Translation updater bot b80978e9cc Localisation updates from https://translatewiki.net.
Change-Id: I2f0d83efb4b3f03f01a34b8b93f77cbb538bc680
2020-05-22 08:36:43 +02:00
jenkins-bot 8ac4b48e96 Merge "Use HttpRequestFactory::createMultiClient()" 2020-05-21 20:38:03 +00:00
Translation updater bot 436532e977 Localisation updates from https://translatewiki.net.
Change-Id: Id8c757c91b9e6370e066a81471685f98042b0803
2020-05-21 08:20:20 +02:00
Tim Starling 92ab300859 Use HttpRequestFactory::createMultiClient()
This allows it to respect the proposed limit on HTTP request timeout.

Bug: T245170
Depends-On: I8252f6c854b98059f4916d5460ea71cf4b580149
Change-Id: I1c3d96720709253ad15bb8528cdd132571de2e4e
2020-05-21 14:56:22 +10:00
jenkins-bot dc90695d8c Merge "Refactor getPreferredEditor and expose reusable parts" 2020-05-20 18:48:21 +00:00
Ed Sanders d6823dbdb4 Use fake server for link inspector tests
Also remove fake server constants in other fake server tests

Bug: T247278
Change-Id: If091c73ad411ac7b16900448bc96745dc84997ba
2020-05-20 15:54:04 +01:00
Translation updater bot 70a7f8775b Localisation updates from https://translatewiki.net.
Change-Id: Ib93923f85bb1191b8f46f1655baccfd63928829e
2020-05-20 08:36:08 +02:00
jenkins-bot 97b2547daf Merge "Replace use of old global with MW_VERSION constant" 2020-05-18 23:51:11 +00:00
jenkins-bot 4233f931fd Merge "Extract Parsoid/RESTBase stuff out of our API code" 2020-05-18 23:49:14 +00:00
jenkins-bot 29940cc99d Merge "Improve deactivating tabs when switching/exiting on MonoBook etc." 2020-05-18 23:39:10 +00:00
jenkins-bot 0410ed44ba Merge "DesktopArticleTarget.init: Set veEditSourceUri in SET mode too" 2020-05-18 23:08:32 +00:00
jenkins-bot 88732d7765 Merge "Update VE core submodule to master (d4085dd7d)" 2020-05-18 22:04:06 +00:00
jenkins-bot d2dd31b805 Merge "Fix #unwrapParsoidSections for pseudo-sections (generated by templates)" 2020-05-18 20:32:28 +00:00
Bartosz Dziewoński 4f70ead440 Fix #unwrapParsoidSections for pseudo-sections (generated by templates)
In 92c3055628 I changed `sectionId > 0`
to `sectionId !== '0'`. That was actually a mistake, as Parsoid's
section IDs can be negative, which indicates pseudo-sections, which
may not have headings.

https://www.mediawiki.org/wiki/Specs/HTML/2.1.0#Headings_and_Sections

Bug: T252238
Change-Id: I9133d4365a71d6db1fa58b69ae3b970166d15c1e
2020-05-18 21:41:13 +02:00
jenkins-bot 5b21c5b67a Merge "Don't log VEFeatureUse from DiscussionTools" 2020-05-18 17:54:13 +00:00
jenkins-bot b9e793d3b7 Merge "Update extension.json authors to match AUTHORS.txt" 2020-05-18 17:49:26 +00:00
David Lynch 92f4e5432e Don't log VEFeatureUse from DiscussionTools
Change-Id: Ie02381e1e65175871c5b43c8089688f632a5066c
2020-05-18 10:25:27 -05:00
Translation updater bot 4492c81cb9 Localisation updates from https://translatewiki.net.
Change-Id: Ic5744a1c85f0923de73d35a3a13f6b90ea53c7a2
2020-05-18 08:31:44 +02:00
Ed Sanders 07867cf349 Update extension.json authors to match AUTHORS.txt
Change-Id: I8ad57c1038b4fd24c2be7c510149d6903910a27b
2020-05-15 22:32:42 +01:00
James D. Forrester 8ccd7cc95a Update VE core submodule to master (d4085dd7d)
New changes:
e946a30cf Localisation updates from https://translatewiki.net.
15f596aa8 Localisation updates from https://translatewiki.net.
d4085dd7d Update principal authors

Change-Id: I5dce4f259ffe28438582f799c41aee7e48db5be4
2020-05-15 12:40:15 -07:00
Ed Sanders 38114d5da8 Update principal authors
Change-Id: If54432471883faaf55b4ed0ae1a664f11828aa0d
2020-05-15 20:25:36 +01:00
Ed Sanders d1f653f58b Update Authors.txt based on lib/ve
* Drops Base64.js

Mentions some depedencies of lib/ve as this is the place we
acknowlege them on wiki (Special:Version/Credits/VisualEditor).

Change-Id: Ic54b8a9de9c07ce799e270a5445c58bb4797409e
2020-05-15 20:16:48 +01:00
James D. Forrester 969b1f266b Replace use of old global with MW_VERSION constant
This repo already requires MW 1.35+ so compatibility isn't a concern.

Change-Id: I3be0e1afe7f9acb56e7070d9d81424b7461a1603
2020-05-15 12:09:26 -07:00
jenkins-bot 38034b1051 Merge "Treat links to diffs and history pages as external links" 2020-05-14 18:54:04 +00:00
Bartosz Dziewoński 61de7530c7 Improve deactivating tabs when switching/exiting on MonoBook etc.
Previously we didn't deactivate them, so if you opened VE, then
switched to NWE, then exited the editor, all three tabs would appear
active.

Change-Id: I904d6daf2896ceadf004f5e57a88c2359f33fd44
2020-05-14 20:24:57 +02:00
Translation updater bot e31c60c63c Localisation updates from https://translatewiki.net.
Change-Id: I9f464fccd0455f615f42a812d1ea700ecd09b7d3
2020-05-13 08:43:45 +02:00
jenkins-bot 734b27b9ca Merge "ApiVisualEditorEdit: Use existing action=compare parameters for PST" 2020-05-12 21:18:00 +00:00
jenkins-bot c5b030d1c7 Merge "Simplify API modules setup" 2020-05-12 21:10:32 +00:00
Bartosz Dziewoński 0528f806fa Extract Parsoid/RESTBase stuff out of our API code
Goals:
* Allow other extensions to reuse these methods (maybe upstream them
  to MediaWiki core later)
* Allow ApiVisualEditorEdit to extend ApiEditPage. We'll be able to
  reuse its definitions for API parameters instead of duplicating
  them, and we won't have to pass around unrecognized parameters.

Bug: T252573
Change-Id: If5c8d95560cbb078ae4980f4a912cbaeafe53d3e
2020-05-12 21:17:29 +02:00
Bartosz Dziewoński 91d40cdfc4 ApiVisualEditorEdit: Use existing action=compare parameters for PST
Change-Id: I436218871e0fae07b39b0c3aa75a0d00bc5fc6b2
2020-05-12 20:56:23 +02:00
Reedy f78b069f48 Remove _merge_strategy from value
Change-Id: If82bb699a65dd6205cda372091d799f94e802322
2020-05-12 19:02:15 +01:00
Bartosz Dziewoński d92e600d58 Simplify API modules setup
We go through all this trouble to pass the config to the API modules,
and then we don't use it at all (we removed the uses recently in
ce094c72d and d85d30f9b).

If we end up needing the config there again, we can just get it by using
MediaWikiServices::getInstance()->getConfigFactory()->makeConfig( 'visualeditor' )
anywhere we want, like we do all over the place in VisualEditorHooks.

Change-Id: I9d254a9946f0d24783baf68c409b10291a8fd1b3
2020-05-12 18:53:31 +02:00
Translation updater bot 1030e78012 Localisation updates from https://translatewiki.net.
Change-Id: Ifcd5d28ea950aff48f40330e84d9e0cc42df4d9e
2020-05-12 08:22:04 +02:00
jenkins-bot d4c4324042 Merge "Convert to manifest_version 2" 2020-05-12 01:47:26 +00:00
Reedy 3b64e6a6a7 Convert to manifest_version 2
Bug: T252470
Change-Id: I4d3b0dc23182da6514f85b8812a10383c96a0626
2020-05-12 02:12:25 +01:00
Bartosz Dziewoński 21b25bd77d Fix deleting signature nodes
Code in ve.dm.MWTransclusionNode (which ve.dm.MWSignatureNode extends)
expects the node data to have an 'attributes' property.

We could override a bunch of methods to fix this, or add checks in the
original code, but it seems more future-proof to instead ensure that
the property exists.

Bug: T248585
Change-Id: I5bd721ca73605a396509669145b740db7283afd3
2020-05-12 01:01:18 +02:00
Translation updater bot a5b0eaaaec Localisation updates from https://translatewiki.net.
Change-Id: I5109f6fe7ec20ea87291f337efb7fc6b5b498a31
2020-05-11 08:39:18 +02:00
jenkins-bot 9e33d28050 Merge "Update toolbar styles for Vector changes" 2020-05-08 20:13:14 +00:00
Bartosz Dziewoński 3866ad7f77 Update toolbar styles for Vector changes
Depends-On: I52938689fc7d99a710510349aaa573a87864a367
Bug: T251648
Change-Id: Ica07cf1dab2cf522532a08fadec599bd2fcade5c
2020-05-08 16:23:57 +02:00
Translation updater bot f2f88771fd Localisation updates from https://translatewiki.net.
Change-Id: I8adfbcb282f8f13bba01901162d25338134ca430
2020-05-08 09:29:06 +02:00
jenkins-bot 20d2ea0767 Merge "Update VE core submodule to master (1cce47f5c)" 2020-05-07 20:09:07 +00:00
jenkins-bot 80038e727e Merge "DesktopArticleTarget.init: Identify our events on multi section edit links" 2020-05-07 20:05:03 +00:00
Bartosz Dziewoński 91f3a971f4 DesktopArticleTarget.init: Identify our events on multi section edit links
This is now consistent with all other events.

Needed for I9904e8af4a60b0f5e9a6e263cd4fd8e1e3fd1f98.

Change-Id: If52aa9d619eac08456874fc75c0f6e1adff01246
2020-05-07 21:42:56 +02:00
Ed Sanders 50db102c4d Refactor getPreferredEditor and expose reusable parts
Separate out logic specific to edit pages

Change-Id: I5b3b47feeeca2085fcd283d55d7e9ceafa73be70
2020-05-07 14:33:21 +01:00
Translation updater bot 81d6810c0a Localisation updates from https://translatewiki.net.
Change-Id: I259e95dc6446d3883f5c781437d62e48166552b1
2020-05-07 08:36:04 +02:00
Bartosz Dziewoński f98ab8c08f Update VE core submodule to master (1cce47f5c)
New changes:
42b098042 TargetWidget: Re throw 'submit' event from the surface
163b0b673 TargetWidget: Don't assume surface exists in setReadOnly

Change-Id: I56db786fac487dd282c8bf22a5f29181a74518e4
2020-05-06 22:25:16 +02:00