Rather than make a new function to determine whether it should be apply-able or
not (and run some checks again), move the enable/disable call into a new
function to do these checks and set the result.
Bug: 72191
Change-Id: I133afa1784e1afd44054f93ed84018894f7c6400
(Followup on If17b50cc4a39993)
Make sure initialHash is set before checking and changing its value
in the MWImageModel method. If a user chooses a brand new image to
insert into the document (an insertion rather than update) then the
initial hash is empty, and changing its values will fail with an
error message.
Bug: 72492
Change-Id: I3f9ea74891cc0ab77a07fa5d4e9cbc591f5b93e6
New changes:
016642e Remove crazy space exception from link validity regex
b538834 Remove insertion inspector class
50839f5 Work around *another* browser bug in getBoundingClientRect
e2e916a Increase inspector height by 1 to deal with Chrome opacity bug
9e387da Update OOjs UI to v0.1.0-pre (40de4dabe6)
27de0c4 Follow-up I2f34448: ve.ui.InsertionInspector.js was deleted, so remove from manifest
Change-Id: If979beb12fe865c0e217b93381769264e2efdc20
The autoValue was displayed in the UI but was never
actually written into the template model, unless you
changed the text input and then undid your change.
Bug: 71157
Change-Id: I08e2ba88c24fdee030104c6fb9baafb558ce8a80
* Introduced MWLinkAction which opens the right link inspector
based on what is selected.
* Added MWLinkInspectorTool overriding core's 'link' tool that
executes MWLinkAction
* Removed MWLinkNodeInspectorTool and linkNode command,
they're unneeded now
Bug: 72150
Change-Id: I03bd6ab1f67f31a6e6cb717cf4298e80e64637b7
New changes:
a554ea6 Add button to debug bar to enable input debugging
8480f41 Add 'valid' event to MediaSizeWidget
a1c42b5 Update OOjs UI to v0.1.0-pre (531d497d3b)
3910521 Prevent JS error in getNativeRange()
Change-Id: I5f13b5d5d0a15579ed2027a09e3fc3933346b2f7
The correct parameter is &redirects=. Which we really don't want
to use anyway, because if Foo->Bar, using &redirects=1 would
cause a search for "Fo" to return "Bar" as a search suggestion
with no explanation why (and "Foo" wouldn't be visible).
This isn't unsurmountable, we could put in handling similar to
how the category widget handles redirects, but what this code
is trying to do by passing this parameter is definitely wrong.
Change-Id: Idd12c03aaef897d7c1dc70b2a7692e7d71980efe
This was broken when requiresRange was renamed to requiresSelection
and MWUseExistingReferenceDialogTool wasn't updated.
Change-Id: Ia1018520fc253e2f09755d5e85a94a325df80005
On initialization, the image model has an initial scalable that has
the given currentDimensions from Parsoid; these are usually correct.
However, in cases where the wiki settings do not fit the user settings
and the images appear smaller or bigger in practice than the values
of the wiki-defaults, the initial hash will store the wrong values.
We will only know what the real values for the comparison will be
after we get them from the API and the calculation; only at that
point we can update the image model initial hash.
This is important so that later the dialog can properly understand
whether to enable the "apply" button if a user changed an image
to custom size and then back to default.
Change-Id: If17b50cc4a39993f98a20a3fec3ddf5d8cb400b3
OOjs UI killed the 'hide' event that was running this code in the dialog refactor
back in July (Id121fc3a), but left it documented (along with 'show').
Just use the 'toggle' event instead.
Bug: 72168
Change-Id: I172fac81c4cbb89505522011aed57db57ccbc52f
New changes:
6b5a276 ve.ui.FormatTool: Update heading size CSS for new OOUI version
2dd5e9c Fix getAnnotationsFromRange when starting with an element
d7db9af Localisation updates from https://translatewiki.net.
3aa1c88 Update OOjs UI to v0.1.0-pre (44db8292bf)
Change-Id: Id5a465af1f14f9e0371d7672d04a7430bcea98d6
Moved the spinner code from ViewPageTarget to ViewPageTarget.init to make it appear immediately on clicking edit.
Bonus: also fixes the URL to add the parameter vesection when clicking a section edit link.
Bug: 65453
Change-Id: Ica33de675203cc0f0594b8362731c4e98a644313
We can make this more sophisticated later, but right now it
accurately checks that upon clicking Basic citation, the user
sees a true VisualEditor UI
Change-Id: Icea910e2bc1bbd4277a7e8eee08f2b0e49661062
Because we also need MobileContext in order to be able to extend it.
I hate our disorganized set of modules. Yes, I said that yesterday too.
Bug: 72282
Change-Id: I7276fc6ee82805f39c47864101ce495a561caa66
This is needed because ve.ui.js is in .core, not in .base.
At some point we should clean up this horrible mess of RL modules.
Bug: 72282
Change-Id: Ief534e1ef4a8154f00a336aa974c14fe91633e90
New changes:
69ecc8e Remove MW-specific mobile hack from core
e556440 doc: Use wildcards for Desktop/Mobile …Context and …Surface for simplicity of extension
Local change:
Bring in MobileContext hack to filter out all tools except links and citations from core where
it didn't belong.
Change-Id: Ica837abd45f0ff02b49a44da617bc1fd8e9872d4
New changes:
e251898 [BREAKING CHANGE] Allow tools to specify which selection types they support
Local changes:
New requiresSelection api for tools
Change-Id: Idc3f62d60bfb5710f786734c342f71b1c73fd4c0
New changes:
618a773 Update OOjs UI to v0.1.0-pre (99ec31d9b9)
e651bd9 Update OOjs UI to v0.1.0-pre (0d358b167a)
0918a82 Use better unicorn image data
1eea699 Stage an empty comment node when inserting
e49a185 Fix height calculation in fragment inspector
26c8566 Stage a space when inserting a special character
480472c Localisation updates from https://translatewiki.net.
990e807 Update OOjs UI to v0.1.0-pre (db065e5a9f)
279031d Fix scroll jumping in Firefox when pasting at end of line
5519914 Handle paste events on the paste target
Change-Id: I760e0f31cbd20dc704a4131384d84d671520f339
* Use .oo-ui-tool-title-text selector rather than .oo-ui-tool-title
to avoid styling accelerator keys.
* Divide all sizes by 0.8, as we no longer need to match the font-size
rule on .oo-ui-tool-title.
* Add CSS for heading1 (which differs between Vector and core VE)
and heading2 (because it looks silly if it's missing).
Change-Id: I12226f0a674037f904149cc10893f5c154767bfc
New changes:
a7e4b2f Update OOjs UI to v0.1.0-pre (98cecf304d)
fa38ad1 Update OOjs UI to v0.1.0-pre (1829141230)
0190d46 Prevent observeration during copy and paste
8e300bf Factor out selection of entire pasteTarget
0bdd637 Fix clipboardData API path on copy
0654b4c Localisation updates from https://translatewiki.net.
9a22fe6 Replace calls to ve.bind( fn, ... ) with fn.bind( ... )
447e8de Use local var instead of bind() for inline functions
13f7c0b Get rid of toHashObject from ranges/selection
74fc34a Fix contextChange events from annotations
c750849 Fix broken node change detection
fdbda64 Close inspector on model select
dd8d23f Fix shift-click select on links in Chrome
Change-Id: I163bd8f04cf945bbec41b06b0a631e0a1e1e5eeb
