Commit graph

21092 commits

Author SHA1 Message Date
David Lynch 54b3202fcd findAddedContentNeedingReference was removed accidentally
Replace it with a hasAddedContentNeedingReference that'll need to be
kept in-sync with the internal logic in AddReferenceEditCheck while
we're tagging this.

Follow-up to d69d366469.

Bug: T367920
Change-Id: I9f4f96bf5c6c4b7b3131b1435426b2e283c9833a
(cherry picked from commit 955bfc4b68)
2024-06-18 22:30:27 +00:00
jenkins-bot b97d66d149 Merge "EditCheck: Use sourceType:commonjs in ESLint" 2024-06-17 17:53:50 +00:00
jenkins-bot 66694cc5f8 Merge "Edit check API" 2024-06-17 15:16:00 +00:00
jenkins-bot aaf9af2ed1 Merge "build: Updating npm dependencies" 2024-06-17 13:54:15 +00:00
Translation updater bot a054bf8fff
Localisation updates from https://translatewiki.net.
Change-Id: I7721a4e934d953242709d3d33e10a9ec15f43624
2024-06-17 09:33:29 +02:00
jenkins-bot dc3128fe4e Merge "Add code to support showing multiple checks in pre-save workflow" 2024-06-16 15:30:27 +00:00
libraryupgrader 9e9ee59272 build: Updating npm dependencies
* eslint-config-wikimedia: 0.28.0 → 0.28.2
  The following rules are failing and were disabled:
  * modules:
    * no-jquery/no-append-html
  * modules/ve-mw/dm:
    * no-jquery/no-append-html

* grunt-stylelint: 0.20.0 → 0.20.1
* stylelint-config-wikimedia: 0.17.1 → 0.17.2
* braces: 3.0.2 → 3.0.3
  * https://github.com/advisories/GHSA-grv7-fg5c-xmjg

Change-Id: If171a41f93d4e96606df99fb394a9f961dc36ebd
2024-06-16 15:25:54 +00:00
Ed Sanders 9a87e1157f EditCheck: Use sourceType:commonjs in ESLint
Change-Id: I0dd72a0129d6f991966a34a502f5a41aab5a154d
2024-06-14 16:25:51 +01:00
Translation updater bot 16f287aed7
Localisation updates from https://translatewiki.net.
Change-Id: Id5fba2c370adaf5dacd478d130c45ded70486b02
2024-06-14 09:50:13 +02:00
Wandji69 3bfb7fcca1 Use ObjectCacheFactory methods
Bug: T363770
Change-Id: I5b53d72a35e2faf034e31fa560d11829337244a6
2024-06-13 09:22:12 -04:00
jenkins-bot 35656833c0 Merge "Use full external link for link to mw.org help page" 2024-06-13 10:36:50 +00:00
Translation updater bot 2c90c5ff1d
Localisation updates from https://translatewiki.net.
Change-Id: Ib0d88db9fb96acb68d4f0bf0c20b9d5d508a5f86
2024-06-13 09:29:34 +02:00
David Lynch d69d366469 Edit check API
Change-Id: Ic5504eb2fe8d1d3f22e88abe1dd88790bdfd8b9c
2024-06-12 11:01:04 +01:00
David Lynch d0a57f5197 Add code to support showing multiple checks in pre-save workflow
Leave the feature disabled for now.

Change-Id: Id70762a887c57d9255df22d50bf7badad89040de
2024-06-12 11:01:04 +01:00
Ed Sanders 2a3f06676d Use full external link for link to mw.org help page
Bug: T367267
Change-Id: I472cfa7007b6468c88b5502162fbef2e9874712d
2024-06-12 10:14:40 +01:00
jenkins-bot f41dd6bb3f Merge "Update VE core submodule to master (6d3f534d7)" 2024-06-12 09:01:13 +00:00
Translation updater bot 527c67af37
Localisation updates from https://translatewiki.net.
Change-Id: I8c345b6dfb3d5d7bd8212b3c2e6a448289299c5d
2024-06-12 09:23:12 +02:00
jenkins-bot 053ef03c8c Merge "SurfaceFragment tests: Put isolateAndUnwrap tests in a loop" 2024-06-11 19:09:15 +00:00
Ed Sanders 841f3182ed Update VE core submodule to master (6d3f534d7)
New changes:
7c075f0c0 Localisation updates from https://translatewiki.net.
d78377076 Track how refs are pasted

Bug: T362358
Change-Id: Ib6bee6698d1a0cf6df3fcebf35a453f6565759cf
2024-06-11 16:08:00 +01:00
Translation updater bot ac6378e78e
Localisation updates from https://translatewiki.net.
Change-Id: Ib37e5133b2f6012a4c9b46b09cd35c9b9fff0df0
2024-06-11 09:56:05 +02:00
Ed Sanders 24ac11d85b Update VE core submodule to master (f7805878d)
New changes:
668eb6408 Localisation updates from https://translatewiki.net.
179c007bd Tests: Fix actual/expected in TransactionBuilder tests
4031b35b1 Tests: Fix typo in TransactionBuilder tests
c9b374cca build: Update linters
6a783c7a6 build: Fix stylelint config and downgrade
e123d688d Localisation updates from https://translatewiki.net.
d1f1df426 build: Upgrade stylelint-config-wikimedia to v0.17.1 and make pass
5fcd06482 eslint: Remove no-op config
b2b1aaf0c Localisation updates from https://translatewiki.net.
f7805878d TransactionBuilder: Handle preserved metaitems correctly

Bug: T366214
Change-Id: I182d0ddf8befe5d951099926339bdce0c63e23df
2024-06-10 23:18:39 +01:00
Umherirrender b985813c56 Use namespaced classes
Changes to the use statements done automatically via script
Addition of missing use statement done manually

Change-Id: Ia08d43b3973a12b8e0628c8552bee1c4b702f249
2024-06-10 22:36:31 +02:00
jenkins-bot c90200d24b Merge "Use reliability API to detect blocked external links" 2024-06-10 18:10:08 +00:00
jenkins-bot 9690972d22 Merge "Phan wasn't checking the editcheck includes" 2024-06-10 15:34:06 +00:00
Translation updater bot b919849e8d Localisation updates from https://translatewiki.net.
Change-Id: I1f6ab8c782525f706a41484fff6167929fa7d84b
2024-06-10 09:56:28 +02:00
David Lynch e6e104dda5 Use reliability API to detect blocked external links
Bug: T366751
Change-Id: If3813cb662155f674688d0ca0733fabdbb338a50
2024-06-08 13:55:43 -05:00
David Lynch d2899153ea Phan wasn't checking the editcheck includes
Have to ignore some calls to AbuseFilter/SpamBlacklist rather than
adding those extensions to directory_list because those extensions don't
pass checks themselves.

Change-Id: If3db9df8a49d8319b08695410a056e1d8e068c15
2024-06-08 13:55:43 -05:00
jenkins-bot 4b1622f68b Merge "getTargetDataFromHref: catch error if passed invalid URL" 2024-06-07 10:21:18 +00:00
Translation updater bot d0b99c7144 Localisation updates from https://translatewiki.net.
Change-Id: Ie70043ca98d1656cbc2f2752102841299fd7d7ab
2024-06-07 09:47:01 +02:00
David Lynch b10fb53f8c getTargetDataFromHref: catch error if passed invalid URL
Could trigger this by typing `https://` into the internal link
annotation inspector.

Bug: T366822
Change-Id: Ie58ded247dbfb6c001d8177953ea148cd82ec03d
2024-06-06 10:57:35 -05:00
Ed Sanders 0378be0f27 eslint: Remove no-op config
Change-Id: Ibacf810f0d31c0aada34d3c6ca84007db506017d
2024-06-06 16:36:51 +01:00
Ed Sanders 0a23f31227 SurfaceFragment tests: Put isolateAndUnwrap tests in a loop
Change-Id: I8791da02a91f5ddc801290121031dde290883d6c
2024-06-05 17:50:29 +00:00
Ed Sanders 291844dbee build: Update stylelint-config-wikimedia to 0.17.1
Change-Id: I8e0f087ae3d2644df85a85791b9c49c09567c0f4
2024-06-05 18:47:49 +01:00
Ed Sanders a3d4388bc1 Follow-up Ic9fad12fe: Move .css file to .less
MWCategoryWidget was converted to LESS syntax but wasn't
moved in the previous commit.

Change-Id: Ifd3e6228b96872ba40fa6d8db1617fb65b781dc0
2024-06-05 18:40:36 +01:00
Translation updater bot 3bc0b9b1b8 Localisation updates from https://translatewiki.net.
Change-Id: I7ab69d3c6dfb1f3e2ffa275066617e8cdbd239b9
2024-06-05 09:24:19 +02:00
jenkins-bot 9a73262215 Merge "Turn property into const in ResourceLoaderData class" 2024-06-04 18:48:04 +00:00
jenkins-bot 2c7607ce94 Merge "Fix type hint in ApiVisualEditorEdit" 2024-06-04 18:44:00 +00:00
jenkins-bot 932df6759e Merge "Add type declarations and remove redundant PHPDoc tags" 2024-06-04 18:24:54 +00:00
Bartosz Dziewoński cc096f1bb8 Fix "implicit-arrow-linebreak" ESLint violation
Change-Id: I61bbfb0762438927c0f7bd5b8e8bf1365861d909
2024-06-04 18:58:25 +02:00
thiemowmde 1d449787ef Add type declarations and remove redundant PHPDoc tags
Most of this code was already typed, but not everything. Using
language-level type declarations allows us to remove extra PHPDoc
blocks that just repeat the same information.

I'm also using the more narrow UserIdentity instead of User in a
few places where this is possible.

Change-Id: I7661824fcb34180af1a4fd3030fcd6c0b7d34089
2024-06-04 16:55:00 +00:00
jenkins-bot 81a1c990e0 Merge "build: Updating eslint-config-wikimedia to 0.28.0" 2024-06-04 13:53:03 +00:00
jenkins-bot 595db906cc Merge "MWExtensionDialog: Fix documentation of confirmAbandon" 2024-06-04 10:57:59 +00:00
jenkins-bot 132606f01d Merge "Localisation updates from https://translatewiki.net." 2024-06-04 07:34:06 +00:00
Translation updater bot f81e2335de Localisation updates from https://translatewiki.net.
Change-Id: I7d60f54f2794777308632eea5afa39c16fd52bf8
2024-06-04 09:32:58 +02:00
jenkins-bot 0e5882b4d5 Merge "MWTemplateTitleInputWidget: Fix unstable sort affecting Firefox" 2024-06-04 07:31:38 +00:00
libraryupgrader 702677220d build: Updating eslint-config-wikimedia to 0.28.0
The following rules are failing and were disabled:
* modules/ve-mw/tests:
  * implicit-arrow-linebreak

Change-Id: If857233c0de24c8cf619dbb1347ebb375f3ab1ba
2024-06-04 03:40:00 +00:00
James D. Forrester 7789b55666 build: Upgrade stylelint-config-wikimedia and grunt-stylelint for stylelint 16
Change-Id: I19ee70def0180bb8504d47b4a65e1e817d9cffcd
2024-06-03 13:07:16 -04:00
Translation updater bot d6a487113d Localisation updates from https://translatewiki.net.
Change-Id: I2e28790004ebaca53f066f7bde83e684ad97cc42
2024-06-03 09:33:32 +02:00
Ed Sanders 1274d03c5d Update VE core submodule to master (4e956f400)
New changes:
c82195c52 JSDoc: convert @cfg to @param
204f48a3e ve.ui.FindAndReplaceDialog: Use flexbox instead of tables
9205fbc97 Tests: Use spread syntax on string literals
84be2efbd Avoid Array.concat
4e956f400 Localisation updates from https://translatewiki.net.

Bug: T250843
Change-Id: Ic68fd49b00d87306a264f4a2d31cbe8955b03f16
2024-05-31 18:42:08 +01:00
Timo Tijhof ad6e0e332e MWTemplateTitleInputWidget: Fix unstable sort affecting Firefox
I'm going to assume the order in production with Chrome, as asserted
by the unit test, is the preferred order whereby negative numbers are
intended to be prepended before the positive numbers.

This came up in I6ecbd5743f3e, where this was the only unit test across
MediaWiki core and WMF gated extensions, that fails in Firefox.

It is reproducible locally with plain MW core + VisualEditor as well.

Bug: T366299
Change-Id: I6f8546e6e604cbb41e11bd2b59f8b5f19350c676
2024-05-31 17:12:29 +01:00